117 Commits

• Apply safeties for AudioFilter usage around drawables which go non-present
  Dean Herbert · 2024-02-26 21:22:25 +08:00
  c686dfd361
• Use new LINQ Order() instead of OrderBy() when possible
  Berkan Diler · 2024-02-08 18:01:00 +01:00
  6adf0ac01e
• Fix collection dropdown crashing when all collections are deleted at once
  Dean Herbert · 2024-01-15 17:10:30 +09:00
  0a522d260b
• Merge pull request #25821 from bdach/fix-collection-dropdown-crash

  Fix collections dropdown crashing during storage migration

  Dean Herbert · 2023-12-19 01:01:23 +09:00
  c466775f78
• Fix crash when creating collections named "All beatmaps" or "Manage collections..."

  Closes https://github.com/ppy/osu/issues/25834
  
  The name fallback that was there previously since
  https://github.com/ppy/osu/pull/11892 was half broken. This way should
  be a lot less prone to failure.

  Bartłomiej Dach · 2023-12-18 12:52:39 +01:00
  eeeb5aa3d4
• Fix collections dropdown crashing during storage migration

  Closes https://github.com/ppy/osu/issues/25815.
  
  `CollectionDropdown.collectionsChanged()` was assuming that if it
  received `null` changes, then it must mean that the change subscription
  is being initialised and the `filters` list will not contain any items.
  
  However, that is not the only circumstance wherein a realm subscription
  can fire with `null` changes; that can also happen after the main realm
  instance gets recycled via the notification registration flow:
  
  	https://github.com/ppy/osu/blob/2f28a92f0a03c8aed6fac2ec7fb41f7ed865f798/osu.Game/Database/RealmAccess.cs#L545-L549
  
  	https://github.com/ppy/osu/blob/2f28a92f0a03c8aed6fac2ec7fb41f7ed865f798/osu.Game/Database/RealmAccess.cs#L1228-L1251
  
  Therefore, to fix the crash, just ensure that the list is cleared every
  time.

  Bartłomiej Dach · 2023-12-18 09:11:00 +01:00
  ef230884a8
• Merge branch 'master' into more-dropdown-search
  Dean Herbert · 2023-12-14 18:44:57 +09:00
  c3d881caee
• Show search bar by default in language and collection dropdowns
  Dean Herbert · 2023-12-14 18:26:13 +09:00
  d77972a39b
• Improve handling of beatmap collection changes in CollectionDropdown

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Salman Ahmed · 2023-11-25 02:40:32 +03:00
  68fca00757
• Remove drag handles from manage collections dialog for now

  The realm implementation doesn't support this.

  Dean Herbert · 2023-10-16 15:51:18 +09:00
  36112302d6
• Add pop-in/pop-out sfx to more overlays
  Jamie Taylor · 2023-08-17 18:36:37 +09:00
  3d7ba0e18c
• Bring realm library up-to-date
  Dean Herbert · 2023-07-06 13:37:43 +09:00
  a98a36872e
• Increase the minimum size of the scroll bar

  Allows easier targetting when there is a lot of content in the scroll view
  
  As discussed in https://github.com/ppy/osu/discussions/24095#discussioncomment-6332398.

  Dean Herbert · 2023-07-02 00:04:56 +09:00
  5f880397a9
• Apply osu! side changes in line with FocusedOverlayContainer.PopIn abstract change

  See https://github.com/ppy/osu-framework/pull/5834

  Dean Herbert · 2023-06-18 20:57:32 +09:00
  eb31fdecee
• Ensure collection edit textbox commits on focus loss

  As discussed in https://github.com/ppy/osu/discussions/23739

  Dean Herbert · 2023-06-04 12:51:03 +09:00
  eb7586b517
• make ResetConfirmDialog properly utilise its parent's logic

  Adjust name of `DeleteAction` to `DangerousAction`

  mk56-spn · 2023-03-05 20:57:26 +01:00
  908651cc11
• Rename DeleteConfirmationDialog.cs into DangerousActionDialog.cs
  mk56-spn · 2023-02-27 21:57:59 +01:00
  90227a6496
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Apply changes in line with framework NRT updates
  Dean Herbert · 2022-11-18 18:13:15 +09:00
  06ce8130c2
• Fix collection dropdown potentially overwriting value change with schedule hotfix
  Dean Herbert · 2022-08-23 17:33:53 +09:00
  db004c9d9f
• Extract common implementation of delete dialog
  Bartłomiej Dach · 2022-08-06 21:04:12 +02:00
  a0d093be5c
• Force alphabetical ordering for now
  Dean Herbert · 2022-07-28 14:07:42 +09:00
  392cb352cc
• Add missing realm subscription cleanup
  Dean Herbert · 2022-07-28 13:57:21 +09:00
  da06467891
• Tidy up naming of collection dropdowns
  Dean Herbert · 2022-07-28 13:57:21 +09:00
  ad482b8afc
• Add note about hash storage
  Dean Herbert · 2022-07-28 13:57:21 +09:00
  226eefcc5c
• Fix ManageCollectionsDialog and remove weird placeholder logic
  Dean Herbert · 2022-07-28 13:57:21 +09:00
  34a2d1a6e1
• Simplify CollectionFilterDropdown filter flow weirdness
  Dean Herbert · 2022-07-28 13:57:21 +09:00
  67c7f324ee
• Hook up remaining data flows
  Dean Herbert · 2022-07-27 19:35:09 +09:00
  804bb33aed
• Convert realm data propagation to more correctly use Live<T>

  wip

  Dean Herbert · 2022-07-27 19:35:09 +09:00
  438067a18b
• Replace BeatmapCollection with RealmBeatmapCollection
  Dean Herbert · 2022-07-27 19:35:09 +09:00
  41393616d8
• Remove CollectionManager
  Dean Herbert · 2022-07-27 18:45:33 +09:00
  9c543fef48
• Split out legacy import path from realm manager
  Dean Herbert · 2022-07-27 15:04:09 +09:00
  6b73f7c7ec
• Use proper variable name
  Salman Ahmed · 2022-07-15 07:44:56 +03:00
  254d22de1c
• Add missing license header
  Salman Ahmed · 2022-07-08 01:59:27 +03:00
  63a06afab2
• Split collection toggle menu item to own class
  Salman Ahmed · 2022-07-08 01:39:45 +03:00
  a94fb62be3
• Update parameter discards
  Dean Herbert · 2022-06-24 21:26:19 +09:00
  31a447fda0
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Rename Beatmaps to BeatmapHashes for clarity
  Dean Herbert · 2022-06-10 14:03:51 +09:00
  4a5e86e451
• Change CollectionManager to only store MD5 hashes instead of full BeatmapInfo
  Dean Herbert · 2022-06-08 18:23:09 +09:00
  42cd7d9e6e
• Allow retrieving count of available stable imports
  Dean Herbert · 2022-05-17 15:55:53 +09:00
  6448c97929
• Split out IDialogOverlay to allow for easier testing
  Dean Herbert · 2022-04-18 18:36:26 +09:00
  e315313266
• Block collection loading until realm migration has completed
  Dean Herbert · 2022-01-27 00:34:51 +09:00
  f21e3d0d86
• Change PlaylistOverlay to use ILive
  Dean Herbert · 2022-01-26 12:19:59 +09:00
  dda513dd08
• Remove unnecessary detach operation
  Dean Herbert · 2022-01-20 17:35:32 +09:00
  4235fb317d
• Merge branch 'master' into realm-integration/score-and-beatmaps
  Bartłomiej Dach · 2022-01-15 14:45:42 +01:00
  03e4ec4214
• Remove unused params from BDL methods
  Susko3 · 2022-01-15 01:06:39 +01:00
  19467e58c1
• BeatmapSetInfo detach support
  Dean Herbert · 2022-01-12 17:00:16 +09:00
  8461eaab46
• Fix most open compound words in identifiers being closed
  Joseph Madamba · 2021-12-27 20:26:28 -08:00
  7de43e3aba
• Fix potential crash from cross-thread drawable mutation in collection management

  As seen at https://github.com/peppy/osu/runs/4613800663?check_suite_focus=true.

  Dean Herbert · 2021-12-23 13:21:17 +09:00
  d69552fbcf
• Clean up unused resolved properties
  Dean Herbert · 2021-12-03 18:49:49 +09:00
  1eed2436e6