321 Commits

• Merge pull request #18795 from smoogipoo/full-size-follow-circle

  Track the full size of the follow circle at all times

  Dean Herbert · 2022-06-28 19:20:34 +09:00
  8cda55e224
• Update parameter discards
  Dean Herbert · 2022-06-24 21:26:19 +09:00
  31a447fda0
• Always track final follow circle size
  Dan Balasescu · 2022-06-21 18:10:11 +09:00
  ede5ca31a1
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Update spinner approach circle to handle LegacySkinTransformer
  Salman Ahmed · 2022-06-04 01:15:39 +03:00
  fe96e15b1b
• Make dependency nullable to allow for safer disposal unbinding
  Dean Herbert · 2022-05-19 13:49:52 +09:00
  a443200d0d
• Fix slider ball rotation becoming undefined when time is not flowing smoothly
  Dean Herbert · 2022-05-12 17:55:12 +09:00
  c4854d4004
• Handle all skin component types explicitly
  Salman Ahmed · 2022-04-23 03:34:05 +03:00
  61078910a6
• Change circle/overlay sprite fields to protected for better test assertion
  Salman Ahmed · 2022-04-20 00:24:28 +03:00
  fd20c2bdcd
• Fix nullability preprocessor placed over the copyright header
  Salman Ahmed · 2022-04-19 19:48:44 +03:00
  a96664295b
• Simplify texture lookup further
  Salman Ahmed · 2022-04-19 19:44:35 +03:00
  033b556be5
• Convert to use nullable and rearrange fields
  Dean Herbert · 2022-04-19 18:10:10 +09:00
  75a6e9fd7f
• Avoid applying state transforms when no object is present
  Salman Ahmed · 2022-04-19 08:08:02 +03:00
  b067924ada
• Rename prioritiyLookup and add xmldoc
  Salman Ahmed · 2022-04-19 08:06:39 +03:00
  fd113953ac
• Improve legacy circle texture lookup to match 1:1 with stable
  Salman Ahmed · 2022-04-19 07:12:07 +03:00
  ec7bb876b5
• Add failing test cases
  Salman Ahmed · 2022-04-19 07:12:07 +03:00
  8d0dd3961e
• Fix follow point animations not looping

  Because they do in stable. I don't know why but let's go with it.
  
  Resolves issue reported in https://github.com/ppy/osu/discussions/17072.

  Dean Herbert · 2022-03-21 18:29:13 +09:00
  e4b2242719
• Use a minimum fade length for clamping rather than zero

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2022-03-10 16:47:02 +09:00
  a1b7bf3986
• Fix crash on super high bpm kiai sections
  Siim Pender · 2022-03-07 20:36:09 +02:00
  a02adfdbd4
• Remove unused params from BDL methods
  Susko3 · 2022-01-15 01:06:39 +01:00
  19467e58c1
• Merge remote-tracking branch 'upstream/master' into fix-remaining-identifier-names
  Joseph Madamba · 2022-01-12 15:05:07 -08:00
  b245ffefc1
• Fix null reference causing crash in KiaiFlashingDrawable

  Can occur if there is no fallback graphics available. Previously would
  work as it was only setting the `Texture`.
  
  As reported in https://github.com/ppy/osu/discussions/16281.

  Dean Herbert · 2021-12-30 22:21:39 +09:00
  408e8d5710
• Bump identifier typo inspection and fix remaining identifier names
  Joseph Madamba · 2021-12-28 11:26:42 -08:00
  c22a07d9fc
• Add support for animated legacy hit circle overlay
  Bartłomiej Dach · 2021-12-28 15:58:34 +01:00
  eea0fea69f
• Generalise KiaiFlashingSprite for arbitrary drawables
  Bartłomiej Dach · 2021-12-28 15:58:34 +01:00
  448c6ed515
• Merge branch 'master' into fix-skin-layout-editor-crash
  Dean Herbert · 2021-10-28 06:24:24 +09:00
  add39fbd4f
• Apply batch fixing of built-in types using var
  Dean Herbert · 2021-10-27 13:04:41 +09:00
  6944151486
• Remove SkinConfiguration subclasses and allow configuration parsing for all skin types
  Dean Herbert · 2021-10-22 14:42:23 +09:00
  93482414d6
• Merge pull request #14929 from peppy/gameplay-state

  Replace `GameplayBeatmap` with `GameplayState`

  Dan Balasescu · 2021-10-04 15:56:44 +09:00
  aa1bfc16d2
• Privatise setter

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Bartłomiej Dach · 2021-10-03 19:14:01 +02:00
  5e5cdaab5e
• Proxy slider head circle number along with overlay
  Bartłomiej Dach · 2021-10-03 15:53:49 +02:00
  abe0ced48c
• Replace all basic usages
  Dean Herbert · 2021-10-02 02:22:23 +09:00
  32afd3f426
• Rename inner lambda parameter
  Bartłomiej Dach · 2021-09-27 22:21:14 +02:00
  5bd09a4a30
• Fix repeat arrow texture not falling back to default legacy skin
  Bartłomiej Dach · 2021-09-27 21:45:26 +02:00
  7a0499ad07
• Remove GameplayClock dependency
  smoogipoo · 2021-09-21 14:48:46 +09:00
  6c91d39c15
• Fix kiai spawner using wrong current time
  smoogipoo · 2021-09-21 14:40:33 +09:00
  f0971cb90c
• Merge branch 'master' into correct-reverse-arrow-depth
  Bartłomiej Dach · 2021-09-20 22:32:28 +02:00
  c911332540
• Avoid AliveObject enumeration when not in kiai section
  Dean Herbert · 2021-09-20 18:49:36 +09:00
  20eeb36567
• Revert af4c3727d77a16e2534df9bbf452336b5c544342
  Opelkuh · 2021-09-19 14:00:56 +02:00
  761da45f6a
• Fix build errors
  Opelkuh · 2021-09-19 04:39:35 +02:00
  af4c3727d7
• Merge branch 'master' into add-legacy-star-particles
  Opelkuh · 2021-09-19 04:34:35 +02:00
  1d7d779f66
• Remove abstract from ParticleSpewer
  Opelkuh · 2021-09-19 03:19:16 +02:00
  3f8454cb76
• Remove accidental leftover nullable BDL spec
  Bartłomiej Dach · 2021-09-18 18:24:36 +02:00
  36237398fa
• Remove unused setter
  Bartłomiej Dach · 2021-09-18 16:28:44 +02:00
  c23354bb67
• Remove redundant qualifier
  Bartłomiej Dach · 2021-09-18 16:28:25 +02:00
  59657aca9a
• Fix slider parts not reproxying after first hitobject freed
  Bartłomiej Dach · 2021-09-18 16:27:30 +02:00
  79438c19a4
• Revert ctor param
  smoogipoo · 2021-09-16 20:06:20 +09:00
  bcbd0e0961
• Fix legacy approach circles accepting alpha
  smoogipoo · 2021-09-16 19:35:15 +09:00
  d8f27633a4
• SpawnParticle -> CreateParticle (and set time outside of virtual call)

  Allows easier overriding (no need to call the `base.CreateParticle` call
  and worry about overwriting the time value.

  Dean Herbert · 2021-09-16 16:52:46 +09:00
  2df4073946
• Remove implied defaults
  Dean Herbert · 2021-09-16 16:44:46 +09:00
  29ce2f05bd