96 Commits

• Update parameter discards
  Dean Herbert · 2022-06-24 21:26:19 +09:00
  31a447fda0
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Merge pull request #18236 from peppy/snap-unification

  Add `enum` to snap method as alternative to multiple nested invocations

  Dan Balasescu · 2022-05-20 11:35:05 +09:00
  64a371638e
• Add enum to snap method as alternative to mutliple nested invocations
  Dean Herbert · 2022-05-12 16:19:07 +09:00
  c0abce918f
• Merge branch 'master' into catch-editor-per-object-sv
  Dean Herbert · 2022-05-09 19:18:01 +09:00
  c7e9bd7751
• Merge pull request #18158 from ekrctb/fix-banana-shower-placement-negative-duration

  Fix duration is negative while placing banana shower in catch editor

  Dan Balasescu · 2022-05-09 11:26:06 +09:00
  45c6f5edef
• Fix duration is negative while placing banana shower in catch editor.

  Timeline blueprint is glitched when the hit object has negative duration.
  Negative duration is unwanted anyways so placement implementation is fixed instead of supporting it in timline blueprint.

  ekrctb · 2022-05-09 00:01:05 +09:00
  158f134260
• Fix BeginPlacement location.
  ekrctb · 2022-05-08 23:10:51 +09:00
  483a611c41
• Remove now-redundant velocity calculation

  Velocity is computed from the up-to-date SV now.

  ekrctb · 2022-05-08 22:36:33 +09:00
  7daa3d8eb7
• Make ScrollingPath use time instead of distance.

  This is consistent as other components now use time instead of distance.

  ekrctb · 2022-05-08 22:36:33 +09:00
  37c9aac49f
• Fix wrong resampling times are used for juice stream path
  ekrctb · 2022-05-08 22:36:33 +09:00
  0e98bb28bd
• Automatically set slider velocity from juice stream path
  ekrctb · 2022-05-08 22:36:33 +09:00
  9ffa90602b
• Make JuiceStreamPath time based instead of distance based.

  And remove the "slope limit" feature.
  TODO: for a juice stream with a large slope, the slider velocity of the hit object should be changed.

  ekrctb · 2022-05-08 22:36:33 +09:00
  4e0155fa4b
• Fix hit object not shown in timline while placement is waiting
  ekrctb · 2022-05-08 15:52:14 +09:00
  125628dd20
• Add xmldoc and rename methods in IPositionSnapProvider for legibility
  Dean Herbert · 2022-05-05 15:58:21 +09:00
  f6fc926f1a
• Clarify TODO comment
  Salman Ahmed · 2022-04-28 10:57:14 +03:00
  b6d2ca7709
• Let CatchHitObjectComposer inherit from DistancedHitObjectComposer and hide control
  Salman Ahmed · 2022-04-28 06:44:50 +03:00
  bfc6bfc91b
• Encapsulate distance spacing control handling to a "distance toolbox composite"

  Encapsulated in a way which can allow further extensibility for the
  right-side area of toolboxes.

  Salman Ahmed · 2022-04-24 08:33:03 +03:00
  8ed39009fd
• Add "distance spacing" multiplier for osu! ruleset

  While osu!catch also implements a distance snap grid, it doesn't rely on
  `GetBeatSnapDistanceAt` (unlike osu!), therefore it can't have the
  "distance spacing" multiplier yet.

  Salman Ahmed · 2022-02-15 02:21:53 +03:00
  19ee05c232
• Remove unnecessary precondition check and disallow vertical catch flips for now
  Dean Herbert · 2022-01-06 14:39:29 +09:00
  5c0494f3ba
• Refactor logic to avoid TimelineSelectionHandler having to block base calls
  Dean Herbert · 2022-01-05 16:56:54 +09:00
  6779503e57
• Add global flip hotkeys
  Dean Herbert · 2022-01-05 16:48:07 +09:00
  866ae3472b
• Changed finding the spinner gaps via a dictionary instead of getting the thresholds via an array
  Darius Wattimena · 2021-11-10 19:58:36 +01:00
  d370f64ac3
• Fixed typo in banana shower gap check message
  Darius Wattimena · 2021-11-10 00:23:14 +01:00
  bd5caceeb1
• Code cleanup and added tests for the spinner check
  Darius Wattimena · 2021-11-10 00:16:29 +01:00
  5d8f35f3c9
• Started on implementing a spinner gap check for catch
  Darius Wattimena · 2021-11-09 23:05:25 +01:00
  fbfed16756
• Fix compilation failure overlooked in merge
  ekrctb · 2021-10-26 20:20:43 +09:00
  393d118eef
• Don't assume catcher dash speed is 2x the walk speed
  ekrctb · 2021-10-26 20:09:48 +09:00
  e5050b90a5
• Cut distance snap lines at playfield border in catch editor
  ekrctb · 2021-10-26 14:51:52 +09:00
  de7a908be2
• Don't compute source object for distance snap grid when it is not enabled
  ekrctb · 2021-10-26 11:17:04 +09:00
  c5d765029c
• Rename method
  ekrctb · 2021-10-26 11:14:12 +09:00
  b7a719de71
• Add doc comment on catch distance snap grid
  ekrctb · 2021-10-26 11:12:10 +09:00
  068217557e
• Handle the case of cursor below the start time of distance snap
  ekrctb · 2021-10-26 11:00:55 +09:00
  9f49a1df8b
• Fix distance snap grid rendering inverted when out of bounds
  ekrctb · 2021-10-26 11:00:44 +09:00
  865be5a10b
• Use array for fixed-size list
  ekrctb · 2021-10-26 10:41:17 +09:00
  2c92f1a0b7
• Add distance snapping to catch editor
  ekrctb · 2021-10-25 16:37:44 +09:00
  6d1cd0a3a1
• Add very basic distance snap grid for catch editor
  ekrctb · 2021-10-25 15:25:59 +09:00
  60df0151c0
• Copy BaseDifficulty to Beatmap<T> and move all write operations across
  Dean Herbert · 2021-10-06 15:10:45 +09:00
  b339c149d8
• Convert usages of BeatmapDifficulty to IBeatmapDifficultyInfo
  Dean Herbert · 2021-10-01 16:55:50 +09:00
  a92d499d7a
• Remove bindable usage in PathControlPoint

  This is quite a breaking change, but I think it is beneficial due to the large amount of usage of this class.
  
  I originally intended just to remove the allocations of the two delegates handling the `Changed` flow internally, but as nothing was really using the bindables for anything more than a general "point has changed" case, this felt like a better direction.

  Dean Herbert · 2021-08-26 12:33:53 +09:00
  6dcd9427ac
• Merge pull request #13983 from ekrctb/juice-stream-placement

  Add initial implementation of juice stream placement

  Dean Herbert · 2021-07-23 13:52:25 +09:00
  a7d6c682de
• Fix previously placed vertices in juice stream placement

  A different UX than not fixing vertices.

  ekrctb · 2021-07-23 10:18:37 +09:00
  bd3386e770
• Use the more consistent lastVertex, with a comment
  ekrctb · 2021-07-23 10:13:55 +09:00
  4509c8bcfb
• Call GetContainingInputManager at LoadComplete
  ekrctb · 2021-07-23 10:10:55 +09:00
  d49d303bae
• Implement reversing of selected pattern in catch editor
  ekrctb · 2021-07-22 17:00:08 +09:00
  9fff304554
• EditorBeatmap.SelectedHitObjects -> SelectedItems (same thing)
  ekrctb · 2021-07-22 16:52:47 +09:00
  dc90e4d24c
• Add initial implementation of juice stream placement
  ekrctb · 2021-07-22 15:47:23 +09:00
  64102d2972
• Add empty juice stream placement blueprint (no implementation)
  ekrctb · 2021-07-22 15:47:23 +09:00
  2beef89c23
• Merge pull request #13961 from ekrctb/catch-editor-flip

  Implement horizontal flipping of hit objects in catch editor

  Dean Herbert · 2021-07-22 15:27:59 +09:00
  e8aaf4df16
• Merge pull request #13937 from ekrctb/selection-editable-path

  Add initial implementation of juice stream path editing

  Dean Herbert · 2021-07-22 14:48:02 +09:00
  1d2fdd9841