66807 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Dean Herbert	aa4d16bdb8	Fix beatmap listing cards being far too large	2024-05-03 12:13:52 +08:00
Dean Herbert	2d0240437a	Merge pull request #28066 from bdach/distance-snap-grid-spacing-change-hides-it ... Fix changing distance spacing multiplier hiding the distance snap grid when it's already shown	2024-05-02 22:35:02 +08:00
Bartłomiej Dach	0e11ce7f85	Merge pull request #28062 from peppy/dont-hide-playfield ... Don't hide playfield layer with HUD	2024-05-02 15:06:25 +02:00
Bartłomiej Dach	6000ffed2a	Add extended test coverage for intended behaviour	2024-05-02 14:15:46 +02:00
Bartłomiej Dach	14658824e7	Adjust distance snap grid momentary toggle logic to not hide it on spacing adjust	2024-05-02 14:11:44 +02:00
Bartłomiej Dach	093c25539c	Add failing test case	2024-05-02 13:59:40 +02:00
Dean Herbert	f9ef689492	Don't hide playfield layer with HUD	2024-05-02 15:36:40 +08:00
Bartłomiej Dach	555305bf7f	Merge pull request #28058 from frenzibyte/export-score-rank ... Preserve score rank on lazer scores during encode/decode	2024-05-02 08:44:10 +02:00
Bartłomiej Dach	1eac34667d	Fix test failure	2024-05-02 08:02:55 +02:00
Dean Herbert	fb4a304ad1	Merge pull request #28051 from frenzibyte/fix-naming-inspections ... Handle new naming inspections on certain enums	2024-05-02 09:33:39 +08:00
Salman Ahmed	0106f1fe3e	Preserve score rank on encode/decode	2024-05-01 23:31:23 +03:00
Salman Ahmed	eb45a406e1	Add failing test case	2024-05-01 23:00:24 +03:00
Salman Ahmed	30fd40efd1	Avoid disable/restore pairs	2024-05-01 21:18:56 +03:00
Salman Ahmed	9dc1a58ce7	Add few abbreviations from existing enums to appease naming inspection	2024-05-01 17:27:21 +03:00
Salman Ahmed	e8a6381395	Update naming of enum fields in ObjType	2024-05-01 17:24:53 +03:00
Salman Ahmed	16bae4f004	Update naming of enum fields in StartMode	2024-05-01 17:22:42 +03:00
Salman Ahmed	97fc2a5473	Disable inconsistent naming in some fields of ScoreRank	2024-05-01 17:22:10 +03:00
Salman Ahmed	2fd8950b21	Disable inconsistent naming in some fields of LegacyManiaSkinConfigurationLookup	2024-05-01 17:22:10 +03:00
Salman Ahmed	02be275554	Disable naming inspections in country/language enums	2024-05-01 17:20:20 +03:00
Salman Ahmed	981a19f6a5	Disable naming inspections in p/invoke code	2024-05-01 17:20:08 +03:00
Bartłomiej Dach	fe9e6168fe	Merge pull request #28050 from peppy/delay-resume-visibility ... Tweak resume overlay to allow better visibility of hit objects underneath	2024-05-01 15:49:31 +02:00
Bartłomiej Dach	d443a9bc96	Merge pull request #28033 from peppy/preserve-storyboard ... Preserve storyboard events when saving a beatmap in the editor	2024-05-01 15:48:21 +02:00
Bartłomiej Dach	72b59c01f7	Merge branch 'master' into preserve-storyboard	2024-05-01 15:21:45 +02:00
Bartłomiej Dach	f0eef32913	Fix code quality inspection	2024-05-01 15:21:39 +02:00
Dean Herbert	b8209b92f6	Add delay before delayed resume starts ... It was previously a bit sudden after dismissing the pause screen. Now there's a short delay before the actual countdown begins.	2024-05-01 20:30:48 +08:00
Dean Herbert	87e814e201	Fix incorrect xmldoc and adjust colour provider to match Player	2024-05-01 20:30:36 +08:00
Dean Herbert	67c0d7590a	Decrease alpha of delayed resume overlay as count approaches zero ... Allows better visibility of playfield underneath it.	2024-05-01 20:29:28 +08:00
Dean Herbert	44091b1f35	Fix some lines still getting forgotten about	2024-05-01 17:33:03 +08:00
Dan Balasescu	61350ebf6e	Merge pull request #28031 from peppy/reduce-volume ... Reduce startup volume	2024-05-01 04:44:00 +09:00
Dan Balasescu	ff91284be2	Merge pull request #28040 from peppy/fix-background-load-order ... Fix incorrect background being loaded due to async race	2024-05-01 04:23:27 +09:00
Dean Herbert	ff108416d8	Fix incorrect background being loaded due to async race ... If the API login (and thus user set) completed between `load` and `LoadComplete`, the re-fetch on user change would not yet be hooked up, causing an incorrect default background to be used instead. Of note, moving this out of async load doesn't really affect load performance as the bulk of the load operation is already scheduled and `LoadComponentAsync`ed anyway	2024-05-01 00:05:14 +08:00
Bartłomiej Dach	93be4b314b	Merge pull request #28034 from peppy/fix-zip-encoding ... Fix filenames containing japanese not being read correctly	2024-04-30 16:53:48 +02:00
Bartłomiej Dach	82d1ebbd20	Merge branch 'master' into fix-zip-encoding	2024-04-30 16:30:15 +02:00
Bartłomiej Dach	38e239a435	Expand test to cover both legacy and non-legacy export paths	2024-04-30 16:07:41 +02:00
Dean Herbert	6a7e2dc258	Fix formatting	2024-04-30 21:47:03 +08:00
Dean Herbert	a3213fc36d	Change .olz to use UTF-8 encoding	2024-04-30 21:40:04 +08:00
Bartłomiej Dach	5e2e2a8d39	Merge pull request #28019 from peppy/realm-file-perm-check ... Check realm file can be written to before attempting further initialisation	2024-04-30 13:46:43 +02:00
Dean Herbert	ba9f4e4baf	Don't skip lines in beatmap decoding ... Was added in cc76c58f5f without any specific reasoning. Likely not required (and will fix some storyboard elements inside `.osu` files from not being correctly saved).	2024-04-30 16:42:15 +08:00
Dean Herbert	0bfad74907	Move realm error handling to avoid triggering in test scenarios	2024-04-30 14:09:29 +08:00
Dean Herbert	a8416f3572	Move exists check inside retry operation ... Might help?	2024-04-30 12:39:18 +08:00
Dean Herbert	c8f7f2215b	Force encoding to Shift-JIS for archive filenames ... After way too much time investigating this, the encoding situation is not great right now. - Stable sets the "default code page" to be used for encoding filenames to Shift-JIS (932): c29ebd7fc5/osu!/GameBase.cs#L3099 - Lazer does nothing (therefore using UTF-8). When importing to lazer, stable files are assumed to be UTF-8. This means that the linked beatmaps don't work correctly. Forcing lazer to decompress *and* compress using Shift-JIS will fix this. Here's a rough idea of how things look for japanese character filenames in current `master`: | | stable | lazer | |--------|--------|--------| | export encoding | shift-jis | utf8 | | utf8 [bit flag](https://superuser.com/a/1507988) set | ❌ | ❌ | | import stable export osz | ✅ | ❌ | | import lazer export osz | ❌ | ✅ | | windows unzip | ❌ | ❌ | | macos unzip | ✅ | ✅ | and after this change | | stable | lazer | |--------|--------|--------| | export encoding | shift-jis | shift-jis | | utf8 [bit flag](https://superuser.com/a/1507988) set | ❌ | ❌ | | import stable export osz | ✅ | ✅ | | import lazer export osz | ✅ | ✅ | | windows unzip | ❌ | ❌ | | macos unzip | ✅ | ✅ | A future endeavour to improve compatibility would be to look at setting the utf8 flag in lazer, switching the default to utf8, and ensuring the stable supports this flag (I don't believe it does right now).	2024-04-30 01:27:47 +08:00
Dean Herbert	97da47f69c	Add test coverage of reading japanese filename after exporting	2024-04-30 01:27:47 +08:00
Dean Herbert	b455e793dd	Add test coverage of reading japanese file from stable export	2024-04-30 01:15:02 +08:00
Dean Herbert	19897c4c07	Add testing for actual presence of video after encode-decode	2024-04-30 00:50:40 +08:00
Dean Herbert	fd3f4a9e7b	Preserve storyboard events when saving a beatmap in the editor ... Until we have full encoding support for storyboards, this stop-gap measure ensures that storyboards don't just disappear from existence.	2024-04-30 00:01:56 +08:00
Dean Herbert	85c085e587	Reduce startup volume ... Constant complaints about startup volume mean we should reduce it further and let users adjust as they see fit.	2024-04-29 23:28:19 +08:00
Dean Herbert	0c45a482eb	Merge pull request #28030 from bdach/save-skin-on-change ... Autosave edited skin on change	2024-04-29 21:47:50 +08:00
Bartłomiej Dach	f78abf801c	Autosave edited skin on change	2024-04-29 14:38:53 +02:00
Bartłomiej Dach	fa3aeca09d	Add failing test for skins not saving on change	2024-04-29 14:38:49 +02:00
Dean Herbert	a3d239c11a	Remove unused method	2024-04-29 18:48:07 +08:00