smoogipoo
6730c4c58b
Apply review comments (user explanations + property names)
2021-02-10 18:41:28 +09:00
smoogipoo
cf06684ad1
Judge heads as slider ticks instead
2021-02-10 18:38:31 +09:00
Dean Herbert
1cb51fa8d2
Merge branch 'master' into autoplay-rate-independence
2021-02-09 16:05:34 +09:00
Dean Herbert
695e46a358
Fix AutoPilot mod failing to block touch input
2021-02-09 15:31:55 +09:00
Dean Herbert
b96a594546
Remove unnecessary initial call to HitObjectApplied bound method
...
Was causing test failures. Looks to be unnecessary on a check of when
HitObjectApplied is invoked.
2021-02-09 15:11:59 +09:00
smoogipoo
7021d1dfdc
Merge branch 'hit-policy-refactor' into classic-mode-flags
2021-02-08 20:12:33 +09:00
smoogipoo
f4a31287bf
Add/use IHitObjectContainer interface instead of IEnumerables
2021-02-08 20:11:06 +09:00
smoogipoo
d955200e07
Prevent invalid hit results for ignored slider heads
2021-02-08 11:10:14 +09:00
smoogipoo
2218247b21
Override mod type
2021-02-08 11:07:50 +09:00
Bartłomiej Dach
0e1ec703d3
Use IApplicableToRate in osu! auto generator
2021-02-07 18:49:31 +01:00
Bartłomiej Dach
3fabe247b0
Allow OsuModGenerator to accept a mod list
2021-02-07 18:35:34 +01:00
Bartłomiej Dach
68c20a2a37
Allow autoplay score generation to access mod list
2021-02-07 18:35:34 +01:00
smoogipoo
a5855f5d28
Move follow circle tracking to DrawableSliderHead
2021-02-05 17:33:48 +09:00
smoogipoo
ee3367d7c5
Add classic slider ball tracking
2021-02-05 17:14:23 +09:00
smoogipoo
3aa3692ed4
Disable snaking out when tracking is disabled
2021-02-05 15:56:13 +09:00
smoogipoo
6aece18f8d
Add OOHP tests
2021-02-05 15:36:47 +09:00
smoogipoo
a4551dc1ee
Add object-ordered hit policy
2021-02-05 15:36:47 +09:00
smoogipoo
6c78d308a4
Merge branch 'hit-policy-refactor' into classic-mode-flags
2021-02-05 15:36:43 +09:00
smoogipoo
8adf37d958
Add SetHitObjects() to IHitPolicy instead of using ctor
2021-02-05 15:25:03 +09:00
smoogipoo
08aae011c1
Add IHitPolicy interface
2021-02-05 15:25:03 +09:00
smoogipoo
df1df81847
Better indicate ordering
2021-02-05 15:25:03 +09:00
smoogipoo
0528469b44
Rename OrderedHitPolicy -> StartTimeOrderedHitPolicy
2021-02-05 15:25:03 +09:00
smoogipoo
3b5c67a063
Add OsuModClassic
2021-02-03 23:08:59 +09:00
smoogipoo
2f22dbe06b
Make sliders display judgements when not ignored
2021-02-03 22:42:50 +09:00
smoogipoo
03b7817887
Add flags to return to classic slider scoring
2021-02-03 22:12:20 +09:00
smoogipoo
623b47f9af
Add flag to toggle follow circle tracking for slider heads
2021-02-03 21:55:19 +09:00
Bartłomiej Dach
ae08ef2543
Reset SPM counter state on DHO application
2021-01-29 20:32:45 +01:00
Dean Herbert
d521bfc251
Don't directly update HandleUserInput (as it is used by mods)
2021-01-30 02:35:11 +09:00
Dean Herbert
5a306dfc2b
Fix unused using
2021-01-29 20:22:25 +09:00
Dean Herbert
f25809d35f
Ensure spinners only handle input during their hittable time
...
While this was already being enforced inside of `CheckForResult`, the
internal tracking values of rotation were still being incremented as
long as the `DrawableSpinner` was present. This resulted in incorrect
SPM values being displayed if a user was to start spinning before the
object's `StartTime`.
Kind of annoying to write a test for (there's no setup for spinners yet)
but am willing to do so if that is deemed necessary.
Closes https://github.com/ppy/osu/issues/11600 .
2021-01-29 19:55:55 +09:00
smoogipoo
de9d075f94
Initial sample + samplechannel rework
2021-01-19 17:11:40 +09:00
Dean Herbert
000c7dd07b
Merge pull request #11502 from peppy/fix-spinner-spinning-weirdness
...
Fix some issues with spinner spin sound
2021-01-18 22:50:32 +09:00
Dan Balasescu
95963f2fa2
Merge pull request #11526 from peppy/fix-editor-repeat-slider-adjustment
...
Fix sliders with an even number of repeats not allowing rotation/scale transforms
2021-01-18 18:56:25 +09:00
Dean Herbert
707d5346c9
Merge branch 'master' into fix-spinner-spinning-weirdness
2021-01-18 18:26:44 +09:00
Dean Herbert
2f1d4bf51b
Add missing braces
2021-01-18 17:13:47 +09:00
Dean Herbert
c79ab63743
Fix sliders with an even number of repeats not allowing rotation/scale transforms
2021-01-18 16:59:16 +09:00
Dean Herbert
02d2b2742b
Fix selection box not updating with hitcircles/sliders far in the future or past
2021-01-18 16:57:36 +09:00
smoogipoo
1b166d809e
Adjust package titles
2021-01-18 11:08:03 +09:00
smoogipoo
ec00aaef90
Add nuget deploys for all rulesets
2021-01-18 10:53:31 +09:00
Dean Herbert
14b3323682
Use OnComplete instead of Finally to avoid potentially stopping on aborted transforms
2021-01-15 17:18:15 +09:00
Dean Herbert
311f8b7017
Only restart spinning sample if it was not already playing
2021-01-15 17:17:51 +09:00
Dean Herbert
767c76921f
Adjust transition time of spinner sound
2021-01-15 17:17:28 +09:00
Bartłomiej Dach
1ba586a683
Revert overlooked AR<8 speed buff
...
Pull request #11107 introduced changes in osu! performance calculation,
related to a scaling coefficient applied to the speed and aim skills.
The coefficient in question was dependent on the approach rate of
a map. During a post-merge review of that PR, it was spotted that
the scaling coefficient for speed also had a 10x buff applied for AR<8,
which could reach magnitudes as large as 80% on AR0, which seems quite
exorbitant. This change was not discussed or mentioned anywhere in the
review process.
Revert back to the old multiplier of 0.01 rather than 0.1 for AR<8. The
negative slope through AR0 to 8 is retained in its previous form.
2021-01-13 17:59:29 +01:00
Bartłomiej Dach
303cc62ee7
Transfer flags indicating if settings were changed
2021-01-06 22:46:46 +01:00
TheOmyNomy
355ecc4499
Change cursor trail blending mode to match stable
2020-12-29 12:37:57 +11:00
Dean Herbert
a411b26a09
Remove unnecessary clamp
...
Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com>
2020-12-24 10:51:24 +09:00
Dean Herbert
dec997c0f4
Fix flashlight not updating its position during replay rewinding
...
Closes #11260
2020-12-23 14:44:38 +09:00
Dean Herbert
87176edca1
Fix crash when attempting to scale two hitobjects on the same axis
2020-12-22 12:52:57 +09:00
Bartłomiej Dach
569caa9500
Merge branch 'master' into add-bundle-header
2020-12-17 20:55:24 +01:00
Dean Herbert
76ffe31855
Merge pull request #11138 from smoogipoo/stanr-nf-multiplier
...
Port StanR's NF multiplier changes
2020-12-17 18:59:46 +09:00
Dean Herbert
88b3bf06e8
Merge branch 'master' into add-bundle-header
2020-12-16 13:40:15 +09:00
Dan Balasescu
8bdef0ff55
Code quality fix
...
Co-authored-by: Dean Herbert <pe@ppy.sh>
2020-12-15 13:18:41 +09:00
Xexxar
54827d4e96
fixed low 50s count still penalizing high obj count maps
2020-12-14 12:41:24 -06:00
Dean Herbert
1793385e96
Pass a score to the replay recorder to allow reading more general scoring data
2020-12-14 16:52:14 +09:00
Dan Balasescu
66f43e523b
Merge pull request #11147 from Xexxar/miss-penalty-curve
...
Change miss penalty curve for speed and aim pp awarded in the osu! ruleset
2020-12-14 14:25:26 +09:00
Xexxar
1dce446c52
Merge branch 'miss-penalty-curve'
2020-12-11 10:49:31 -06:00
Xexxar
b7872a54b8
small factor rebalance
2020-12-11 10:48:53 -06:00
Xexxar
a5a66e71f9
Merge branch 'miss-penalty-curve'
2020-12-11 10:22:04 -06:00
Xexxar
abc8a2982c
swapped ^.75 buff onto speed instead of aim
2020-12-11 08:20:56 -06:00
Xexxar
c20117f0fb
Merge branch 'miss-penalty-curve'
2020-12-11 08:02:39 -06:00
Xexxar
544160798b
cleaned up mistakes and made quality changes
2020-12-11 08:01:45 -06:00
Xexxar
fd0d793c69
changed the comment to reflect the change
2020-12-10 18:51:54 -06:00
Xexxar
e45417d4fe
Merge branch 'lowacc-nerf'
2020-12-10 14:24:42 -06:00
Xexxar
1f2946d64c
changed miss penalty curve to scale with totalhits
2020-12-10 14:21:06 -06:00
Xexxar
cc5639d2b4
added unneeded whitespace
2020-12-10 09:48:40 -06:00
smoogipoo
7c2f506b79
Port StanR's NF multiplier changes
2020-12-10 17:10:29 +09:00
Xexxar
54abc3bd4d
revert aim curve and add new 50s nerf
2020-12-09 20:07:52 -06:00
Xexxar
149651dec1
Merge branch 'lowacc-nerf' of https://github.com/Xexxar/osu into lowacc-nerf
2020-12-09 13:05:11 -06:00
Xexxar
d604c51cbd
capped scaling at OD 8 to prevent overscaling
2020-12-09 13:04:14 -06:00
Xexxar
a2bd8ece10
Merge branch 'master' into lowacc-nerf
2020-12-09 12:06:33 -06:00
Xexxar
05ad9aae8d
changed curve to linear OD + acc based curve
2020-12-09 11:57:01 -06:00
Xexxar
cfc34a63bd
realized i accidently deleted the OD scaling
2020-12-09 11:21:03 -06:00
Xexxar
7e3fcfe437
fixed issue with comment
2020-12-09 10:35:48 -06:00
smoogipoo
47a93d8614
Adjust osu! hitobject fade-ins to support AR>10
2020-12-10 00:37:19 +09:00
smoogipoo
ac91f0e270
Add extended limits to difficulty adjustment mod
2020-12-10 00:37:19 +09:00
Xexxar
748035e80a
changes to acc scaling curve for speed and aim pp
2020-12-08 16:53:52 -06:00
smoogipoo
168ba62500
Port StanR's dynamic SO pp changes
2020-12-08 22:09:48 +09:00
Dan Balasescu
c3cb82489b
Merge pull request #11107 from Xexxar/ar11-nerf
...
osu! PerformanceCalc Short Map AR11 Nerf
2020-12-08 12:51:26 +09:00
smoogipoo
57b7ef88e2
Fix spacing
2020-12-08 12:12:53 +09:00
ekrctb
0d88ff3404
Adjust namespace
2020-12-07 12:27:12 +09:00
ekrctb
c905df8a77
Move LegacySkinTransformer
2020-12-07 12:26:58 +09:00
Xexxar
cf3fbe0b0b
osuDifficulty ar11 nerf
2020-12-06 18:06:36 -06:00
ekrctb
0ed9989a82
Adjust namespace
2020-12-04 20:25:49 +09:00
ekrctb
626956febd
Move some files from Drawables to Skinning.Default namespace
2020-12-04 20:25:12 +09:00
ekrctb
245be2c5ed
Adjust namespace
2020-12-04 20:21:53 +09:00
ekrctb
a12b049154
Move piece files in Osu ruleset
2020-12-04 20:11:35 +09:00
Dean Herbert
2f4b3a2d4c
Merge branch 'master' into fix-hidden-increased-visibility-state-2
2020-12-04 13:38:01 +09:00
Dean Herbert
5db15a6b26
Merge branch 'master' into fix-hidden-mod-crash
2020-12-04 12:50:02 +09:00
Dean Herbert
5ded4b9faa
Merge branch 'master' into dho-remove-onparentreceived
2020-12-04 11:04:56 +09:00
Bartłomiej Dach
4d739f11a8
Fix spinner ticks getting increased visibility state
...
Regressed in #10696 . The old `IsFirstHideableObject()` method did not
consider nested hitobjects, while its replacement -
`IsFirstAdjustableObject()` - did. Therefore, spinner ticks could be
considered first adjustable objects, breaking the old logic.
There is no need to match over `SpinnerBonusTick`, as it inherits from
`SpinnerTick`.
2020-12-03 22:51:59 +01:00
smoogipoo
09af4bbd57
Merge branch 'dho-remove-onparentreceived' into fix-hidden-mod-crash
2020-12-03 20:10:16 +09:00
smoogipoo
0bdf99b97a
Remove OnParentReceived()
2020-12-03 20:08:42 +09:00
smoogipoo
73e99718bc
Change order of OnParentReceived()
2020-12-03 20:06:26 +09:00
smoogipoo
e3bbc2b128
Rework osu! hidden mod to avoid storing hitobjects
2020-12-03 14:45:56 +09:00
smoogipoo
e831c797f3
Merge branch 'master' into hit-sample-pooling
2020-12-02 14:45:24 +09:00
Dean Herbert
71a121389b
Merge pull request #11033 from smoogipoo/immutable-hit-samples
...
Make HitSampleInfo immutable
2020-12-02 14:44:26 +09:00
Dean Herbert
d344268df7
Merge pull request #11028 from peppy/osu-fade-slider-body-on-hit
...
Hide slider body immediately on successful hit when snaking is enabled
2020-12-02 12:59:26 +09:00
Dan Balasescu
be3fed3072
Merge pull request #11024 from peppy/fix-slider-point-drag-offset
...
Fix slider control point dragging not correctly accounting for drag deadzone
2020-12-02 11:10:06 +09:00
Dan Balasescu
8dfe3a21cc
Merge pull request #11025 from peppy/editor-slider-control-point-scaling
...
Scale slider control point display in line with circle size
2020-12-02 11:06:00 +09:00
Dan Balasescu
46a57921e2
Merge branch 'master' into osu-fade-slider-body-on-hit
2020-12-02 11:03:04 +09:00
