52 Commits

• Remove ScrollableContent container from carousel

  This was causing multiple issues with masking and sizing and really
  didn't need to exist in the first place. Also not sure why the pool was
  nested inside the scroll container, but it isn't any more. Probably for
  the best.

  Dean Herbert · 2020-11-26 18:28:54 +09:00
  f8db7a9902
• Merge branch 'master' into beatmap-carousel-refactor
  Dean Herbert · 2020-10-19 13:17:11 +09:00
  467bb9b96f
• Update EndsWith usages
  Dean Herbert · 2020-10-16 12:58:34 +09:00
  88ffcb9234
• Locallise ChildItems to DrawableCarouselBeatmapSet for clarity
  Dean Herbert · 2020-10-13 19:31:29 +09:00
  5d11db7753
• Add test specifically for many panels visible
  Dean Herbert · 2020-10-13 17:37:33 +09:00
  4160feb3da
• Fix failing tests
  Dean Herbert · 2020-10-13 17:37:33 +09:00
  1f0aa974dd
• Update test scene to fix crash
  Dean Herbert · 2020-10-13 17:37:33 +09:00
  dd8943eb7f
• Temporarily increase test beatmap count for perf testing
  Dean Herbert · 2020-10-13 17:37:33 +09:00
  580ea62710
• Refactor how drawable carousel items are constructed
  Dean Herbert · 2020-10-13 17:37:33 +09:00
  3143224e5b
• Remove beatmap paths from tests where they would result in exceptions
  Dean Herbert · 2020-09-15 22:50:44 +09:00
  dbfaa4a0df
• Adjust step name
  Dan Balasescu · 2020-07-13 20:03:07 +09:00
  69548447a7
• Fix carousel tests relying on initial selection being null
  Dean Herbert · 2020-07-13 17:05:29 +09:00
  cd3500510e
• Add test coverage
  Dean Herbert · 2020-06-25 20:01:29 +09:00
  c36d9d4fc3
• Remove all RequiredTypes usages
  smoogipoo · 2020-05-16 18:17:12 +09:00
  648999a2de
• Add test coverage
  Dean Herbert · 2020-04-11 17:17:18 +09:00
  c0c1f2c023
• Style changes
  Endrik Tombak · 2020-04-09 18:59:18 +03:00
  35f97dfc75
• Remove test for now
  Endrik Tombak · 2020-04-09 18:48:13 +03:00
  caa404f8fa
• Merge branch 'master' into select-recommended
  Dean Herbert · 2020-04-09 15:30:35 +09:00
  260de77304
• Fix copy paste oversight
  Endrik · 2020-03-29 18:55:47 +03:00
  f4c8b6d219
• Refactor tests for readability
  Dean Herbert · 2020-03-30 00:05:07 +09:00
  a72f0f57f6
• Change int div comments
  Dean Herbert · 2020-03-29 23:46:28 +09:00
  07c7233b3d
• Cover skipDifficulties = false in tests
  Endrik Tombak · 2020-03-28 21:02:55 +02:00
  8cab303611
• Test both ways
  Endrik Tombak · 2020-03-28 13:10:20 +02:00
  63f6269eb0
• Use understandable set id
  Endrik Tombak · 2020-03-28 13:08:06 +02:00
  659865b457
• Increase amount of test sets
  Endrik Tombak · 2020-03-26 21:16:10 +02:00
  e707adb773
• Add failing test
  Endrik Tombak · 2020-03-26 20:32:43 +02:00
  902734b75e
• Write tests
  Endrik Tombak · 2020-03-26 19:18:16 +02:00
  bbbaaae3ee
• Merge branch 'master' into fix-carousel-root-selects-from-nothing
  Dan Balasescu · 2020-03-23 11:34:04 +09:00
  d0c7b49376
• Fix test re-using the same beatmap sets
  smoogipoo · 2020-03-23 11:12:36 +09:00
  bf70276496
• Fix a couple of broken tests
  Dean Herbert · 2020-03-20 15:02:13 +09:00
  8136ea561e
• Fix selection not occurring when switching from empty ruleset on first load
  Dean Herbert · 2020-03-20 15:01:26 +09:00
  9b60b535e5
• Update tests
  Dean Herbert · 2020-03-19 18:58:22 +09:00
  3a50c4bb51
• Merge branch 'master' into carousel-selection-fallback-improvement
  Dan Balasescu · 2020-03-16 10:53:10 +09:00
  bd05462a7f
• Update carousel test logic to match new carousel selection behaviour
  Dean Herbert · 2020-03-12 19:55:25 +09:00
  bab197553e
• Fix beatmap carousel tests loading beatmap manager beatmaps in test browser
  Dean Herbert · 2020-03-12 16:53:23 +09:00
  28ac5af91c
• Add test
  smoogipoo · 2020-01-24 19:40:20 +09:00
  bb390b4470
• Fix remaining cases of pollution
  Dean Herbert · 2019-11-15 11:46:32 +09:00
  e81dfcad4c
• Clear count variables on carousel creation
  Dean Herbert · 2019-11-15 11:26:01 +09:00
  22c3be2c6f
• Fix unnecessary string interpolation
  Dean Herbert · 2019-11-13 19:42:33 +09:00
  2fe068174a
• Clean up carousel tests
  Dean Herbert · 2019-11-13 19:09:03 +09:00
  2cd156f3d4
• Apply brace style.
  Huo Yaoyuan · 2019-11-11 20:13:13 +08:00
  ccc8aa6fa4
• Add beatmap carousel item sorting stability test

  Add visual test to ensure sorting stability when sorting criteria are
  applied in the beatmap carousel.

  Bartłomiej Dach · 2019-10-27 22:55:46 +01:00
  022cc13952
• Add failing test
  Dean Herbert · 2019-10-07 15:17:03 +09:00
  46d6c5ec3b
• Move private functions to bottom
  Dean Herbert · 2019-10-07 15:17:03 +09:00
  62c4c1266e
• Fix random failures on BeatmapCarousel filter test

  The "un-filter" step causes a `SelectNextRandom` invocation. If this happens to select a difficulty in set 3 other than the previously buffered difficulty #2, the subsequent test would fail.
  
  I've split this test out to remove the random element, but added a new assert to ensure buffered (previously visited?) difficulty is re-selected on return to the same set.

  Dean Herbert · 2019-10-03 16:21:14 +08:00
  e9c73ce30f
• Rename method to match new behaviour
  Dean Herbert · 2019-09-29 12:23:18 +08:00
  539f3329ce
• Migrate beatmap carousel test to AddUntilStep

  Due to non-deterministic test failures in TestSceneBeatmapCarousel,
  migrate the checkSelected helper step from AddAssert to AddUntilStep.
  This adds more leniency for performance-related issues while still
  checking the desired behaviour.

  Bartłomiej Dach · 2019-09-28 11:58:27 +02:00
  2487d4f0f2
• Fix potential test fail case
  Dean Herbert · 2019-09-25 14:28:35 +09:00
  2089f6fc42
• Update beatmap carousel tests code style

  Also fixes one issue I spotted in BeatmapCarousel related to incorrectly holding a selection after new sets are loaded.

  Dean Herbert · 2019-09-25 02:42:12 +09:00
  4a59e3351e
• Add filter steps to carousel visual test

  Just a couple of steps for added coverage in visual tests. Very
  on-the-surface, the unit tests are supposed to cover the gory details.

  Bartłomiej Dach · 2019-09-22 00:20:54 +02:00
  51509f6be0