62169 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Bartłomiej Dach	a7a053102d	Merge pull request #24563 from peppy/disable-tournament-client-ipc ... Disable IPC binding in tournament client to allow running concurrently	2023-08-16 12:14:26 +02:00
Bartłomiej Dach	90ab3fc953	Merge pull request #24451 from peppy/multi-spectator-fix-startup-delay ... Fix multiplayer spectator potentially taking too long to start	2023-08-16 12:12:59 +02:00
Bartłomiej Dach	5219b8a13b	Add test coverage for precise rotation control	2023-08-16 11:37:52 +02:00
Bartłomiej Dach	19f892687a	Add precise rotation control to osu! editor	2023-08-16 11:37:52 +02:00
Dean Herbert	eed9f83a91	Merge pull request #24537 from OliBomby/remove-sv ... Remove slider velocity from `DrumRoll`	2023-08-16 18:28:09 +09:00
Bartłomiej Dach	bdf87e43db	Merge branch 'master' into slider-with-textbox-instantaneous	2023-08-16 10:48:45 +02:00
Bartłomiej Dach	35af15f491	Merge branch 'master' into multi-spectator-fix-startup-delay	2023-08-16 10:34:20 +02:00
Bartłomiej Dach	e624f603b3	Merge pull request #24562 from peppy/fix-unsafe-realm-access ... Fix incorrect access to realm object in beatmap editor	2023-08-16 10:31:35 +02:00
Dean Herbert	d309865b0d	Update TournamentMatchScoreDisplay to share base implementation	2023-08-16 17:26:10 +09:00
Dean Herbert	8b9759c569	Apply nullability to MatchScoreDisplay	2023-08-16 17:26:10 +09:00
Dean Herbert	ab826c35b7	Add score diff display to multiplayer spectator ... Basically pulling changes over from the tournament client implementation	2023-08-16 17:26:10 +09:00
Dean Herbert	f02416f877	Improve visuals of tournament song bar ... This is a stop-gap until we add new versions (and share between game and tournament client).	2023-08-16 17:16:36 +09:00
Dean Herbert	26d05afadc	Add more test coverage to multi spectator screen	2023-08-16 17:14:42 +09:00
Dean Herbert	56eb44d15b	Change TestSpectatorClient to provide some better fake data for score / acc	2023-08-16 17:14:42 +09:00
Dean Herbert	965da343a4	Fix tournament song bar tests not showing anything by default	2023-08-16 17:14:34 +09:00
Bartłomiej Dach	add1ef77d0	Fix typo in comment	2023-08-16 10:07:12 +02:00
Bartłomiej Dach	4f47b196c1	Merge branch 'master' into fix-unsafe-realm-access	2023-08-16 09:59:17 +02:00
Dean Herbert	7f8455eb06	Merge pull request #24402 from QuantumSno/leaderboard-toggle ... Add ability to toggle gameplay leaderboards with tab key	2023-08-16 16:57:07 +09:00
Dean Herbert	56a4989f71	Disable IPC binding in tournament client to allow running concurrently	2023-08-16 16:55:48 +09:00
Bartłomiej Dach	d70a9a5bc4	Fill out xmldoc and adjust inline commentary	2023-08-16 09:40:46 +02:00
Dean Herbert	bb98f10ff6	Use CurrentTime instead of StartTime for hotfix seek (and update comment)	2023-08-16 16:38:49 +09:00
Dean Herbert	184eabb902	Merge branch 'master' into multi-spectator-fix-startup-delay	2023-08-16 16:27:49 +09:00
Dean Herbert	caf0fd0742	Refactor migration to read the same as previous one	2023-08-16 16:21:42 +09:00
Dean Herbert	68db112882	Re-date migration	2023-08-16 16:20:17 +09:00
Dean Herbert	c885b71f3a	Add leaderboard toggle as tracked setting to give better use visibility	2023-08-16 16:17:56 +09:00
Dean Herbert	31c2b7f925	Merge branch 'master' into leaderboard-toggle	2023-08-16 15:49:55 +09:00
Dean Herbert	6e11162ab1	Add helper method for safer realm Find<T>	2023-08-16 15:37:09 +09:00
Bartłomiej Dach	88295a49aa	Fix invalid reference in xmldoc	2023-08-16 07:38:31 +02:00
Bartłomiej Dach	6c4c76350f	Remove unused using directive	2023-08-16 07:36:56 +02:00
Bartłomiej Dach	34a519f803	Merge pull request #24561 from peppy/rename-dummy-local-user ... Rename "dummy" local user to something more descriptive	2023-08-16 07:34:25 +02:00
Dean Herbert	a8824c8c8a	Remove flaky test documentation for fixed test	2023-08-16 14:30:10 +09:00
Dean Herbert	531794b26b	Fix ModelManager not correctly re-retrieving realm objects before performing operations ... Falls into the age-old trap of attempting to retrieve an item from realm without first ensuring that realm is in an up-to-date state. Consider this scenario: - Editor is entered from main menu, causing it to create a new beatmap from its async `load()` method. - Editor opens correctly, then main thread performs a file operations on the same beatmap. - Main thread is potentially not refreshed yet, and will result in `null` instance when performing the re-fetch in `performFileOperation`. I've fixed this by using the safe implementation inside `RealmLive<T>`. Feels like we want this is one place which is always used as the correct method. On a quick search, there are 10-20 other usages of `Realm.Find<T>` which could also have similar issues, but it'll be a bit of a pain to go through and fix each of these. In 99.9% of cases, the accesses are on instances which couldn't have just been created (or the usage of recently-imported/created is blocked by realm subscription flows, ie. baetmap import) so I'm not touching them for now. Something to keep in mind when working with realm going forward though.	2023-08-16 14:23:32 +09:00
Dean Herbert	5bd7370439	Add log output when editor is creating a fresh beatmap	2023-08-16 14:23:17 +09:00
Dean Herbert	502844a858	Add ability to construct RealmLive from ID	2023-08-16 14:23:01 +09:00
Dean Herbert	6001f7e5c7	Rename "dummy" local user to something more descriptive ... This created weird cases in logs which are very hard to understand. The one which really got me was this: ``` [runtime] 2023-08-13 07:48:27 [verbose]: Invalidating working beatmap cache for unknown artist - unknown title (Dummy) ``` Which looks like a dummy working beatmap was invalidated, but it turns out that's just the local user which was populated when creating a new local beatmap.	2023-08-16 13:52:27 +09:00
Dean Herbert	2a3f7e7362	Merge pull request #24552 from smoogipoo/hold-off-no-end-notes ... Disable hold end conversion for mania HoldOff mod	2023-08-16 13:26:28 +09:00
Pasi4K5	58bffa13cd	Fix possible IndexOutOfRangeException	2023-08-16 01:19:41 +02:00
Pasi4K5	e7e0c49f42	Replace .Distinct() with truncateEndingDuplicates()	2023-08-16 01:14:25 +02:00
Pasi4K5	6346872c39	Improve code readability and add assertion to test scene	2023-08-15 23:27:12 +02:00
Dan Balasescu	7d8cef83e6	Merge branch 'master' into LNFixHotfix	2023-08-15 13:45:06 +02:00
Dan Balasescu	5678db4e70	Fix test + cleanup	2023-08-15 19:42:32 +09:00
Dan Balasescu	e34a9a0001	Disable hold end conversion for mania HoldOff mod	2023-08-15 19:30:40 +09:00
Bartłomiej Dach	4e96853c75	Merge pull request #24548 from peppy/fix-score-copy-instability ... Fix score being cloned in async method causing random crashes	2023-08-15 09:38:38 +02:00
Dean Herbert	e8bde6504a	Fix score being cloned in async method causing random crashes ... Closes https://github.com/ppy/osu/issues/24445.	2023-08-15 16:08:13 +09:00
Dean Herbert	526a145b93	Merge pull request #24546 from peppy/update-framework ... Update framework	2023-08-15 15:34:56 +09:00
Dean Herbert	3526032c9a	Merge pull request #24544 from smoogipoo/pool-mania-barlines ... Add pooling for mania barlines	2023-08-15 15:21:59 +09:00
Dean Herbert	57e49495bc	Merge pull request #24547 from bdach/slider-kiai-stars-broke ... Fix kiai stars flickering on and off during gameplay	2023-08-15 15:21:46 +09:00
Bartłomiej Dach	ab1d523528	Fix kiai stars flickering on and off during gameplay ... Closes #24503. The problematic reset of `lastParticleAdded` has been moved to a place that should hopefully (a) not cause such problems and (b) be much more explicit about what's happening.	2023-08-15 07:44:05 +02:00
Dean Herbert	8c14ff674e	Update framework	2023-08-15 14:33:21 +09:00
Dean Herbert	31c31a9359	Merge pull request #24528 from bdach/fix-dual-stages-skinnable-layer ... Fix playfield skinnable layer bounds being incorrectly calculated with multiple stages	2023-08-15 14:29:18 +09:00