58459 Commits

This Branch

This Branch

All Branches

• Inline StopSample() into StopSampleAndRemoveFilters()

  The first method no longer has any callers except for the second one.

  Bartłomiej Dach · 2023-01-22 09:26:01 +01:00
  9e4e85e3e3
• Remove unnecessary sample stop in Restart()

  It is unnecessary, as a successful restart will exit the current player
  screen, and `OnExiting()` has another `StopSampleAndRemoveFilters()`
  call, which means that in the restart flow the sample was actually
  getting stopped twice.
  
  Standard exit flow is fine, it only stopped the sample once.

  Bartłomiej Dach · 2023-01-22 09:24:12 +01:00
  0edfd24410
• Merge branch 'master' into fix-fail-sample-playing-after-leaving-dialog
  Matheus Filipe dos Santos Reinert · 2023-01-22 02:12:07 -03:00
  db0b69db6b
• Merge pull request #22330 from bdach/segmented-graph-bad-accesses

  Fix `SegmentedGraph` draw node calculating segment colours in unsafe manner

  Dean Herbert · 2023-01-22 13:55:48 +09:00
  27f1afdae1
• Replace RemoveFilters call with StopSampleAndRemoveFilters
  Matheus Filipe dos Santos Reinert · 2023-01-22 01:44:16 -03:00
  5b1a23c697
• Create StopSampleAndRemoveFilters method and change RemoveFilters to private
  Matheus Filipe dos Santos Reinert · 2023-01-22 01:43:40 -03:00
  2e1ba6ef49
• Fix failSample still playing after player left FailOverlay
  Matheus Filipe dos Santos Reinert · 2023-01-22 01:14:33 -03:00
  a746cbc6ed
• Fix SegmentedGraph draw node calculating segment colours in unsafe manner

  The `SegmentedGraph`'s draw node would call `getSegmentColour()`
  on the drawable, which would query the `DrawColourInfo` and
  `tierColours` properties of the drawable. This is a cross-thread access
  and as such completely unsafe, as due to being cross-thread it can die
  on invalidations or out-of-bounds accesses.
  
  Fix by transferring everything to the draw node first before attempting
  to draw. `SegmentedGraph.TierColours` setter already correctly
  invalidates the draw node via `graphNeedsUpdate`, so no further
  intervention was required there.
  
  Closes #22326.

  Bartłomiej Dach · 2023-01-21 23:19:34 +01:00
  718cbf9382
• Merge pull request #22302 from ekrctb/fix-infinity-spm

  Fix spinners potentially displaying incorrect SPM numbers

  Salman Ahmed · 2023-01-21 16:56:34 +03:00
  292fd345bc
• Merge branch 'master' into fix-infinity-spm
  Salman Ahmed · 2023-01-21 15:42:48 +03:00
  ce64ba471a
• Merge pull request #22315 from frenzibyte/fix-test-browser-broken

  Fix test browsers on longer working after framework update

  Dean Herbert · 2023-01-21 21:34:08 +09:00
  c2e1c91b58
• Fix test browsers on longer working after framework update
  Salman Ahmed · 2023-01-21 14:49:47 +03:00
  c48af79588
• Merge pull request #22310 from peppy/fix-threading-tournament-save

  Fix incorrect async continuation causing tournament client to not enable save button

  Dean Herbert · 2023-01-21 15:31:56 +09:00
  2023.121.0 2a9b1ea9fc
• Fix incorrect async continuation causing tournament client to not enable save button
  Dean Herbert · 2023-01-21 11:28:56 +09:00
  0fb12508f0
• Merge pull request #22303 from peppy/update-framework

  Update framework

  Dean Herbert · 2023-01-21 00:30:59 +09:00
  2075583313
• Fix TournamentGameBase calling AddInternal
  Dean Herbert · 2023-01-20 23:53:30 +09:00
  154c258248
• Update framework
  Dean Herbert · 2023-01-20 23:23:25 +09:00
  19450bfe12
• Fix SPM calculation division by zero
  ekrctb · 2023-01-20 21:00:01 +09:00
  7e466e1eba
• Merge pull request #22296 from frenzibyte/actually-fix-beatmap-options
  Dean Herbert · 2023-01-20 10:21:55 +09:00
  e86748626a
• Merge pull request #22297 from frenzibyte/fix-playlists-match-test-failure
  Dean Herbert · 2023-01-20 10:19:45 +09:00
  684d05e9aa
• Fix intermittent failure in playlists match loading test
  Salman Ahmed · 2023-01-20 01:18:41 +03:00
  8174ef06c3
• Actually fix intermittent failure in beatmap options state test
  Salman Ahmed · 2023-01-19 22:47:35 +03:00
  f0464b0340
• Merge pull request #22290 from mk56-spn/judgement_fix

  Fix JudgementCounterDisplay.cs max judgement not hiding upon display mode change

  Dean Herbert · 2023-01-19 20:00:44 +09:00
  5a1940facf
• Refactor update logic to be easier to follow
  Dean Herbert · 2023-01-19 19:27:05 +09:00
  2ce32e3209
• Fix JudgementCounterDisplay.cs max judgement always showing upon changing display mode
  mk56-spn · 2023-01-19 10:31:02 +01:00
  b22363ed8c
• Merge pull request #22283 from Feodor0090/comment-reply

  Add ability to leave replies to comments

  Dean Herbert · 2023-01-19 16:41:05 +09:00
  c6dfbab702
• Immediately focus the textbox when clicking to reply to a comment
  Dean Herbert · 2023-01-19 16:08:27 +09:00
  4916a742d5
• Remove unused method
  Dean Herbert · 2023-01-19 16:03:46 +09:00
  81e6c3792c
• Merge branch 'master' into comment-reply
  Dean Herbert · 2023-01-19 16:01:47 +09:00
  56ce8504ae
• Remove ReplyCommentEditor into its own class
  Dean Herbert · 2023-01-19 16:01:37 +09:00
  07af18b8a7
• Merge pull request #22285 from bdach/segmented-graph-tint

  Apply draw colour to segmented graph

  Dean Herbert · 2023-01-19 13:36:19 +09:00
  db8084570d
• Merge pull request #22284 from bdach/judgement-counter-broken

  Fix "show max judgement" setting not applying initially on judgement counter display

  Dean Herbert · 2023-01-19 09:09:06 +09:00
  e58abf7d1a
• Merge pull request #22233 from peppy/osu-ruleset-multi-touch-basic

  Add basic multi-touch support for osu! ruleset

  Bartłomiej Dach · 2023-01-19 00:59:45 +01:00
  83c38a8960
• Merge branch 'master' into osu-ruleset-multi-touch-basic
  Bartłomiej Dach · 2023-01-19 00:26:57 +01:00
  2fba80dfd3
• Merge pull request #22144 from ItsShamed/skin/argon-song-progress-cleaner

  Add "argon" variant of song progress display

  Bartłomiej Dach · 2023-01-19 00:25:39 +01:00
  593f5f6d56
• Use alternative segment colour computation method
  Bartłomiej Dach · 2023-01-19 00:08:32 +01:00
  a0fe71c706
• Merge branch 'master' into skin/argon-song-progress-cleaner
  Bartłomiej Dach · 2023-01-18 23:52:12 +01:00
  b62ff8d644
• Make SongProgressInfo.ShowProgress init-only (and remove duplicate init)
  Bartłomiej Dach · 2023-01-18 23:35:40 +01:00
  b8b7442eb8
• Apply draw colour to segmented graph segments
  Bartłomiej Dach · 2023-01-18 23:17:57 +01:00
  903c37bf32
• Add test steps demonstrating failure
  Bartłomiej Dach · 2023-01-18 23:07:40 +01:00
  e09b768a99
• Fix ShowMaxJudgement callback conflicting with JudgementCounter.Pop{In,Out}

  Both `JudgementCounterDisplay` (via the `ShowMaxJudgement` callback)
  and the `JudgementCounter.Pop{In,Out}` methods were operating on the
  alpha of the `JudgementCounter`. This meant that if the counter display
  was created with max judgement initially hidden, it would be hidden
  by the `ShowMaxJudgement` callback first, but then _unhidden_
  by `PopIn()`.

  Bartłomiej Dach · 2023-01-18 21:46:28 +01:00
  769f8c6190
• Add failing test case
  Bartłomiej Dach · 2023-01-18 21:42:22 +01:00
  7299d227d1
• Restructure test scene to demonstrate failure
  Bartłomiej Dach · 2023-01-18 21:41:00 +01:00
  06212bca51
• Add test
  ansel · 2023-01-18 21:27:42 +03:00
  7f4d8bdcaa
• Integrate editor into comment
  ansel · 2023-01-18 20:50:07 +03:00
  77bc4fbf70
• Add ability to change number on replies button
  ansel · 2023-01-18 20:49:30 +03:00
  0d91277ea5
• Add reply editor
  ansel · 2023-01-18 20:49:07 +03:00
  c74500b4b4
• Merge pull request #22275 from peppy/fix-legacy-old-judgement-animation

  Fix legacy judgement animation not matching perfectly

  Bartłomiej Dach · 2023-01-18 18:27:13 +01:00
  761298cd8e
• Merge pull request #22248 from peppy/fix-carousel-sort-change-after-play

  Fix beatmap sorting at song select sometimes changing after setting a score

  Bartłomiej Dach · 2023-01-18 17:57:08 +01:00
  c7249383ba
• Merge branch 'master' into fix-carousel-sort-change-after-play
  Bartłomiej Dach · 2023-01-18 17:15:20 +01:00
  4a6f6300c5