Dean Herbert
c61d0ff80a
Merge pull request #18215 from bdach/mod-overlay/rename-new
...
Rename new mod select classes to "mod overlay" nomenclature
2022-05-11 10:27:57 +09:00
Dean Herbert
53259251af
Merge branch 'master' into mod-overlay/rename-new
2022-05-11 10:15:59 +09:00
Dean Herbert
dd316befb4
Merge pull request #18214 from bdach/mod-overlay/delete-old
...
Remove old mod overlay code
2022-05-11 10:09:42 +09:00
Dan Balasescu
7473ff49cb
Merge pull request #18210 from peppy/realm-asycn-import-woes
...
Fix realm refetch operations potentially being unsafe
2022-05-11 09:53:46 +09:00
Bartłomiej Dach
76c63f1d0a
Rename ModSelect{Screen -> Overlay} in place of removed old design
2022-05-10 22:56:50 +02:00
Bartłomiej Dach
c4c7556fb2
Make remains of TestSceneModSettings non-visual
...
As they're not really testing anything visual.
2022-05-10 22:07:26 +02:00
Bartłomiej Dach
33634cba1e
Remove old mod buttons
2022-05-10 21:58:22 +02:00
Bartłomiej Dach
8b0ece1c09
Remove old mod section
2022-05-10 21:55:54 +02:00
Bartłomiej Dach
dfd97701d7
Remove old mod settings container & related controls
2022-05-10 21:53:42 +02:00
Bartłomiej Dach
128468e13d
Remove old base mod select overlay
2022-05-10 21:52:30 +02:00
Bartłomiej Dach
24c59e2f2f
Remove old user mod select overlay
2022-05-10 21:52:17 +02:00
Bartłomiej Dach
4a3447f59f
Remove old free mod select overlay
2022-05-10 21:45:57 +02:00
Bartłomiej Dach
9cfe2cc310
Move TestCustomisableModRuleset out of TestSceneModSettings
2022-05-10 21:43:57 +02:00
Salman Ahmed
9446be2511
Remove unnecessary UnbindAdjustments call
...
It is not necessary given that `CurrentTrack` already removes all adjustments first.
2022-05-10 20:49:44 +03:00
Salman Ahmed
36a7644164
Reinstantiate mod adjustments layer for safety against previous mods
2022-05-10 20:46:33 +03:00
Salman Ahmed
a0f1c48e80
Fix ModTimeRampTest failing due to changes in Update method
2022-05-10 19:24:36 +03:00
Dean Herbert
ec231e0f31
Use more local realm reference
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2022-05-11 00:45:17 +09:00
Salman Ahmed
725ff93f34
Define local adjustments component for mods in MusicController
...
Isolates `CurrentTrack` from being directly adjusted by the mod, which could lead to issues depending on how the mod adds adjustments (i.e. `ModTimeRamp`, which adds adjustments based on changes to a setting bindable).
2022-05-10 18:24:29 +03:00
Salman Ahmed
82b784ce5a
Change IApplicableToSample to receive adjustable component instead
...
Done for consistency with `IApplicableToTrack`.
2022-05-10 18:06:03 +03:00
Salman Ahmed
4f5001704e
Change IApplicableToTrack to receive adjustable component instead
2022-05-10 18:06:03 +03:00
Salman Ahmed
bbbecbb6b7
Apply time-ramping adjustment using clock instead of track
2022-05-10 18:06:03 +03:00
Dean Herbert
0eb29d56f2
Rename new test method to be english
2022-05-10 18:06:03 +03:00
Dean Herbert
587cc8cdb3
Merge pull request #18204 from frenzibyte/move-soft-handle-exception
2022-05-10 21:57:15 +09:00
Dean Herbert
33f024212f
Fix realm refetch operations potentially being unsafe
...
As seen in test failure https://github.com/ppy/osu/runs/6357384721?check_suite_focus=true .
2022-05-10 21:04:30 +09:00
Dean Herbert
87f6f74795
Add failing test coverage of adding a file to a detached beatmap across threads
2022-05-10 21:04:30 +09:00
Dan Balasescu
2e774fbc2b
Merge pull request #18207 from peppy/first-run-finalise
...
Improve first run overlay layout (and switch on)
2022-05-10 20:31:33 +09:00
Dan Balasescu
42fe708225
Fix inspection
2022-05-10 19:56:21 +09:00
Dean Herbert
b2a57c34bb
Move implementation to base
2022-05-10 19:10:34 +09:00
Dean Herbert
4d22f26266
Rename property and improve xmldoc
2022-05-10 19:07:07 +09:00
Dean Herbert
cac6d5569c
Fix incorrect variable reference in log output
2022-05-10 19:07:00 +09:00
Dean Herbert
a578f7a406
Force nested screens to load synchronously
2022-05-10 18:21:35 +09:00
Dean Herbert
a93c63b2b5
Add loading spinner when loading first run screens
2022-05-10 18:21:35 +09:00
Dean Herbert
25c6226ca9
Adjust transition length for a more seamless screen change
2022-05-10 18:21:35 +09:00
Dean Herbert
493798ae5e
Fix nested ui scale example screens no longer fitting
2022-05-10 18:21:35 +09:00
Dean Herbert
63b9e01d38
Fix behaviour screen using old style buttons
2022-05-10 18:21:35 +09:00
Dean Herbert
61313b69ec
Standardise font sizes in first run overlay screens
2022-05-10 18:21:35 +09:00
Dean Herbert
e5204e565d
Move horizontal padding to content level to better align scrollbar
2022-05-10 18:21:35 +09:00
Dean Herbert
bcce9c5e67
Limit the width of first run overlay content
2022-05-10 18:21:35 +09:00
Dean Herbert
9aadc274bf
Show first run dialog on first run of the game
2022-05-10 18:21:35 +09:00
Dean Herbert
09613c9e18
Merge pull request #18206 from frenzibyte/fix-first-run-hot-reload
...
Workaround interface mocks in `TestSceneFirstRunSetupOverlay` breaking with hot reload
2022-05-10 18:12:50 +09:00
Salman Ahmed
14a21e9224
Workaround interface mocks in TestSceneFirstRunSetupOverlay breaking with hot reload
2022-05-10 11:41:41 +03:00
Dan Balasescu
a6674d8c1a
Merge pull request #18205 from peppy/sentry-setup
...
Bring sentry usage up-to-date
2022-05-10 17:11:36 +09:00
Dean Herbert
5af18f9574
Merge pull request #18202 from smoogipoo/workaround-freemod-performance
...
Workaround bad performance when selecting all freemods
2022-05-10 16:26:57 +09:00
Dean Herbert
6a49eb6875
Add breadcrumb level mappings
2022-05-10 16:14:04 +09:00
Dean Herbert
216c68e6d0
Add unobserved exception hinting
2022-05-10 16:09:16 +09:00
Dean Herbert
363643a16d
Remove sentry logger debounce
...
This is probably going to result in a high quantity of exceptions, but I
think this is fine. We can add rules as we go to not log certain
exception types.
2022-05-10 16:09:16 +09:00
Dean Herbert
c6112b3ae7
Add unhandled exception marking
2022-05-10 16:09:16 +09:00
Dean Herbert
99e6d56508
Add finalizer to sentry logger for safety
2022-05-10 16:09:16 +09:00
Dean Herbert
9734d778f4
Update sentry SDK usage in line with more recent specifications
2022-05-10 16:09:16 +09:00
Dean Herbert
3338bffce3
Attach user to sentry later in startup flow
2022-05-10 16:09:16 +09:00
