Bartłomiej Dach
9997271a6a
Fix more code quality inspections
2024-08-22 10:49:24 +02:00
Bartłomiej Dach
9020739f36
Remove unused using directives
2024-08-22 10:05:45 +02:00
Dean Herbert
b3be04aff1
Remove "leftover files" notification when migration partly fails
...
People were deleting files they shouldn't, causing osu! to lose track of
where the real user files are.
For now let's just keep things simple and not let the users know that
some files got left behind. Usually the files which are left behind are
minimal and it should be fine to leave this up to the user.
Closes https://github.com/ppy/osu/issues/29505 .
2024-08-22 16:09:11 +09:00
Bartłomiej Dach
df94c22a29
Merge pull request #29545 from peppy/timeline-redesign-in-circles
...
Further timeline usability tweaks
2024-08-22 08:39:34 +02:00
Dean Herbert
7e483bbee3
Merge pull request #29541 from frenzibyte/fix-mod-customisation-dragging-outside
...
Keep mod customisation panel open when dragging outside
2024-08-22 15:28:32 +09:00
Bartłomiej Dach
d33f4837fa
Merge pull request #29532 from bdach/redesign-timing-table-tracking
...
Redesign timing table tracking
2024-08-22 08:21:39 +02:00
Dean Herbert
066c34e950
Merge pull request #29553 from bdach/local-cache-updates
...
Add support for retrieving submit/rank date from local metadata cache in version 2
2024-08-22 14:55:43 +09:00
Dean Herbert
dfb4a76e29
Fix test being repeat step
2024-08-22 14:45:40 +09:00
Dean Herbert
9df12e3d87
Move seek button to left to differentiate mutating operations
2024-08-22 14:15:36 +09:00
Dean Herbert
54e5f1c9f0
Merge pull request #29556 from frenzibyte/kiai-star-bursts
...
Add star fountains/bursts when entering kiai mode in gameplay
2024-08-22 14:14:25 +09:00
Dean Herbert
502192ff6f
Merge pull request #29529 from frenzibyte/fix-mania-stuff
...
Fix mania combo counter positioning break on centre anchor
2024-08-22 11:08:18 +09:00
Salman Ahmed
1efa6b7221
Merge if branches
2024-08-22 05:40:43 +09:00
Salman Ahmed
fc02b4b942
Alter NRT usage
2024-08-22 05:39:57 +09:00
Dean Herbert
a943000579
Merge pull request #29435 from OliBomby/improve-snaps
...
Fix timeline snapping ignoring nearby timing points
2024-08-22 01:36:30 +09:00
Dean Herbert
fb5fb78fd3
Move zero marker below control points to avoid common overlap scenario
2024-08-22 01:09:22 +09:00
Dean Herbert
843b10ef34
Add back incorrectly removed control point display toggle
2024-08-22 01:05:47 +09:00
Dean Herbert
2876cb73bd
Merge pull request #28991 from Layendan/master
...
Add collection and favourite buttons to results screen
2024-08-21 23:59:26 +09:00
Bartłomiej Dach
5f88435d96
Add support for retrieving submit/rank date from local metadata cache in version 2
...
Closes https://github.com/ppy/osu/issues/22416 .
2024-08-21 15:42:22 +02:00
Bartłomiej Dach
28d0a24555
Fix the fix
...
The more proper way to do this would be to address the underlying issue,
which is https://github.com/ppy/osu/issues/29546 , but let's do this
locally for now.
2024-08-21 12:27:56 +02:00
Salman Ahmed
c92af71029
Add in-gameplay version of kiai star fountains/burst
2024-08-21 17:34:38 +09:00
Dean Herbert
fef56cc29e
Remove expanding behaviour of timeline completely
2024-08-21 16:57:52 +09:00
Dean Herbert
7e6490133d
Adjust visuals of tick display (and fine tune some other timeline elements)
2024-08-21 16:46:14 +09:00
Dean Herbert
1a48a6f654
Reduce size of hit objects on timeline
2024-08-21 16:46:13 +09:00
Dean Herbert
3065f808a7
Simplify timing point display on timeline
2024-08-21 16:46:13 +09:00
Dean Herbert
a0002943a1
Adjust centre marker visuals a bit
2024-08-21 16:46:12 +09:00
Bartłomiej Dach
c4f08b42ab
Use colours to distinguish buttons better
2024-08-21 09:05:33 +02:00
Dan Balasescu
4ee5a1225e
Merge pull request #29540 from frenzibyte/fix-resume-overlay
...
Fix resume overlay appearing behind HUD/skip overlays
2024-08-21 08:56:01 +09:00
OliBomby
8d72ec8bd6
move timing point binary search back inline
2024-08-21 01:50:52 +02:00
Salman Ahmed
b7599dd1f8
Keep mod customisation panel open when dragging a drawable
2024-08-21 03:23:23 +09:00
Salman Ahmed
ae4fefeba1
Add failing test case
2024-08-21 03:22:03 +09:00
Salman Ahmed
0d358a1dae
Fix resume overlay appearing behind HUD/skip overlays
2024-08-21 02:53:11 +09:00
Dan Balasescu
f4b8fc6165
Merge pull request #29536 from frenzibyte/fix-legacy-key-counter-position
...
Fix legacy key counter position not matching stable
2024-08-21 01:05:46 +09:00
Salman Ahmed
20658ef4ee
Fix legacy key counter position not matching stable
2024-08-21 00:10:16 +09:00
Dan Balasescu
2011d5525f
Add flaky test attribute to some tests
...
See occurences like https://github.com/ppy/osu/actions/runs/10471058714 .
2024-08-20 22:21:10 +09:00
Dan Balasescu
5bb94000d3
Merge pull request #29534 from bdach/fix-divisor-crash
...
Fix crash on attempting to edit particular beatmaps
2024-08-20 22:06:32 +09:00
Dan Balasescu
44213a34ae
Merge pull request #29508 from peppy/hold-for-menu-sometimes
...
Change "hold for menu" button to only show for touch by default
2024-08-20 21:45:50 +09:00
Bartłomiej Dach
c2dd2ad978
Clamp beat divisor to sane range when decoding
...
In my view this is a nice change, but do note that on its own it does
nothing to fix https://github.com/ppy/osu/issues/29492 , because of
`BeatmapInfo` reference management foibles when opening the editor. See
also: https://github.com/ppy/osu/issues/20883#issuecomment-1288149271 ,
https://github.com/ppy/osu/pull/28473 .
2024-08-20 13:52:29 +02:00
Bartłomiej Dach
bb964e32fa
Fix crash on attempting to edit particular beatmaps
...
Closes https://github.com/ppy/osu/issues/29492 .
I'm not immediately sure why this happened, but some old locally
modified beatmaps in my local realm database have a `BeatDivisor` of 0
stored, which is then passed to
`BindableBeatDivisor.SetArbitraryDivisor()`, which then blows up.
To stop this from happening, just refuse to use values outside of a sane
range.
2024-08-20 13:51:58 +02:00
Dean Herbert
ebff2ebf01
Merge pull request #29528 from smoogipoo/invert-snapping-binds
...
Make grid/distance snap binds T/Y respectively
2024-08-20 19:23:42 +09:00
Dean Herbert
a633fcdb49
Merge branch 'master' into redesign-timing-table-tracking
2024-08-20 19:16:03 +09:00
Bartłomiej Dach
f0ddb6daa4
Merge pull request #29445 from OliBomby/transparent-break
...
Make break periods in bottom timeline transparent
2024-08-20 11:46:02 +02:00
Bartłomiej Dach
2a22049fec
Merge branch 'master' into redesign-timing-table-tracking
2024-08-20 11:38:12 +02:00
Dean Herbert
28f1ea9911
Merge pull request #29531 from bdach/remove-dead-classes
...
Remove dead row attribute classes
2024-08-20 18:36:14 +09:00
Bartłomiej Dach
333e5b8cac
Remove outdated tests
2024-08-20 11:23:39 +02:00
Bartłomiej Dach
a33294ac42
Redesign timing table tracking
...
- On entering the screen, the timing point active at the current instant
of the map is selected. This is the *only* time where the selected
point is changed automatically for the user.
- The ongoing automatic tracking of the relevant point after the initial
selection is *gone*. Even knowing the fact that it was supposed to
track the supposedly relevant "last selected type" of control point,
I always found the tracking to be fairly arbitrary in how it works.
Removing this behaviour also incidentally fixes
https://github.com/ppy/osu/issues/23147 .
In its stead, to indicate which timing groups are having an effect,
they receive an indicator line on the left (coloured using the
relevant control points' representing colours), as well as a slight
highlight effect.
- If there is no control point selected, the table will autoscroll to
the latest timing group, unless the user manually scrolled the table
before.
- If the selected control point changes, the table will autoscroll to
the newly selected point, *regardless* of whether the user manually
scrolled the table before.
- A new button is added which permits the user to select the latest
timing group. As per the point above, this will autoscroll the user
to that group at the same time.
2024-08-20 11:14:42 +02:00
Dean Herbert
73f2f5cb12
Fix more tests
2024-08-20 17:59:55 +09:00
Dean Herbert
bccc797bcb
Move break display to background of summary timeline
2024-08-20 17:45:44 +09:00
Dean Herbert
c85b04bca5
Add more test coverage to better show overlapping break / kiai sections
2024-08-20 17:45:44 +09:00
Bartłomiej Dach
373ff47a94
Remove dead row attribute classes
...
These aren't shown on the control point table since difficulty and
sample control points were moved into objects.
2024-08-20 09:53:40 +02:00
Dan Balasescu
95a3dcfdae
Merge pull request #29515 from TheOmyNomy/add-cursor-trail-expanding-behaviour
...
Apply current cursor expansion scale to trail parts
2024-08-20 16:14:58 +09:00
