47998 Commits

This Branch

This Branch

All Branches

• Remove outdated comment
  Dean Herbert · 2022-01-14 21:40:35 +09:00
  9900a3f408
• Update one more mismatched test implementation
  Dean Herbert · 2022-01-14 21:39:42 +09:00
  289ae7c72f
• Add local ContextFactory caching to all remaining test scenes that create local managers
  Dean Herbert · 2022-01-14 19:59:21 +09:00
  a59dcccab7
• Remove left-over methods in MusicController
  Dean Herbert · 2022-01-14 19:55:49 +09:00
  3a95425a9e
• Remove unnecessary Live conversion in IntroScreen (handled by GetWorkingBeatmap)
  Dean Herbert · 2022-01-14 19:55:09 +09:00
  7acd1b545f
• Only copy across Hash and ID so statistics aren't lost
  Dean Herbert · 2022-01-14 18:22:52 +09:00
  34dbde6023
• Fix watch replay button not working immediately after playing
  Dean Herbert · 2022-01-14 18:03:06 +09:00
  916b591b1b
• Return immediately on failed web request in synchronous BeatmapOnlineLookupQueue flow
  Dean Herbert · 2022-01-14 13:20:51 +09:00
  dea2e1fac0
• Remove unused cancellationToken parameter in synchronous BeatmapOnlineLookupQueue flow
  Dean Herbert · 2022-01-14 13:19:00 +09:00
  8424d86e9a
• Ensure detached when performing model Clone operations on BeatmapInfo/ScoreInfo
  Dean Herbert · 2022-01-14 13:08:20 +09:00
  9b33fbbee5
• Fix delete/clear scores buttons not working
  Dean Herbert · 2022-01-13 18:38:38 +09:00
  54804ebfbd
• Remove one more unnecessary Detach operation
  Dean Herbert · 2022-01-13 18:32:59 +09:00
  c33fe7bcc6
• Uncomment EF deletion lines in migrations
  Dean Herbert · 2022-01-13 18:28:00 +09:00
  2840a71dda
• Merge branch 'master' into realm-integration/score-and-beatmaps
  Dean Herbert · 2022-01-13 18:25:09 +09:00
  4f8d29c1c0
• Add EF to realm beatmap migration
  Dean Herbert · 2022-01-13 18:23:18 +09:00
  b610d2db12
• Add EF to realm score migration
  Dean Herbert · 2022-01-13 18:23:18 +09:00
  45a23e5a43
• Move RulesetStore construction earlier in process so rulesets are available for EF migration
  Dean Herbert · 2022-01-13 18:23:18 +09:00
  ded1d87739
• Remove pointless compatibility parameter BeatmapSetInfoID
  Dean Herbert · 2022-01-13 18:02:10 +09:00
  069d6d2954
• Merge pull request #16273 from Joehuu/fix-remaining-identifier-names

  Normalise more identifier names

  Dean Herbert · 2022-01-13 17:06:57 +09:00
  7147799895
• Fix scores not using correct filename/display strings

  I've updated all cases where we should have been using
  `GetDisplayString()` anyway, but left the `ToString()` implementations
  in place for safety. They should probably be removed in the future.

  Dean Herbert · 2022-01-13 16:56:11 +09:00
  c61419dfe5
• Add synchronous fetch flow to BeatmapOnlineLookupQueue

  The async flow doesn't work great with the realm import process. We
  might be able to improve on this going forward, but for the time being
  adding a synchronous path seems safest.
  
  After all, we are already an an asynchronous (dedicated) thread pool at
  this point.

  Dean Herbert · 2022-01-13 16:36:54 +09:00
  93c78253d6
• Remove async from Populate method
  Dean Herbert · 2022-01-13 16:36:54 +09:00
  bdb2979b2e
• Remove pointless override method in RealmArchiveModelManager
  Dean Herbert · 2022-01-13 16:27:12 +09:00
  70c107b434
• Remove oudated comments
  Dean Herbert · 2022-01-13 15:27:43 +09:00
  88145dedf1
• Fix filter criteria not being applied after carousel loads new beatmap sets
  Dean Herbert · 2022-01-13 15:08:51 +09:00
  6025fe325d
• Fix typo in comment in IntroScreen
  Dean Herbert · 2022-01-13 13:47:23 +09:00
  0a133c7e97
• Fix deleted scores not being cleaned up on next startup
  Dean Herbert · 2022-01-13 13:40:09 +09:00
  dcc354aa7c
• Bump realm schema version to allow upgrades
  Dean Herbert · 2022-01-13 13:28:46 +09:00
  7a81fe19f6
• Use ctor rather than MemberwiseClone to guarantee a safer clone of BeatmapDifficulty
  Dean Herbert · 2022-01-13 13:23:41 +09:00
  b77cb344d5
• Remove unnecessary Ruleset null check in BeatmapDifficultyCache
  Dean Herbert · 2022-01-13 13:19:49 +09:00
  86b2ac3217
• Add back PerformRead return safety by checking IsManaged status of returned data
  Dean Herbert · 2022-01-13 13:14:44 +09:00
  7baff18764
• Fix stray bracket
  Dean Herbert · 2022-01-13 13:03:57 +09:00
  085893c9b4
• Sanitise mods / statistics cache logic in ScoreInfo
  Dean Herbert · 2022-01-13 12:59:16 +09:00
  65dd80e6f6
• Change default value and add comment explaining why skins are never "locally available"
  Dean Herbert · 2022-01-13 12:50:18 +09:00
  1a29098f3b
• Fix unintended change to dotsetting
  Dean Herbert · 2022-01-13 12:47:11 +09:00
  ebe8ba3c3c
• Remove names from user dictionary
  Dean Herbert · 2022-01-13 12:40:19 +09:00
  e1f5acd689
• Merge pull request #16436 from smoogipoo/fix-intermittent-tests
  Dean Herbert · 2022-01-13 09:45:22 +09:00
  24f02cab8a
• Revert identifier typo bump
  Joseph Madamba · 2022-01-12 15:52:33 -08:00
  a18b283626
• Use comments to disable identifier typos instead
  Joseph Madamba · 2022-01-12 15:49:28 -08:00
  66773f6d7d
• Fix missed identifier typos
  Joseph Madamba · 2022-01-12 15:46:20 -08:00
  5185f6010e
• Merge remote-tracking branch 'upstream/master' into fix-remaining-identifier-names
  Joseph Madamba · 2022-01-12 15:05:07 -08:00
  b245ffefc1
• Fix intermitten screen navigation tests
  Dan Balasescu · 2022-01-13 05:52:04 +09:00
  672c1d36dc
• Merge pull request #16434 from peppy/fix-being-playing-test-failures

  Fix test failures due to double `BeginPlaying` calls

  Dan Balasescu · 2022-01-13 02:43:42 +09:00
  6b7896ec69
• Fix test failures due to double BeginPlaying calls
  Dean Herbert · 2022-01-13 01:34:29 +09:00
  2212bea17f
• Fix potential mod nullref in APIUserScoreAggregate's CreateScoreInfo implementation
  Dean Herbert · 2022-01-13 00:28:16 +09:00
  4c79145c11
• Fix further warnings
  Dean Herbert · 2022-01-12 23:42:12 +09:00
  b2d09b7b10
• Add far too many fixes for ruleset non-nullable requirements
  Dean Herbert · 2022-01-12 23:24:11 +09:00
  b5f670cc5b
• Fix CI reported warnings
  Dean Herbert · 2022-01-12 22:39:00 +09:00
  51251e3204
• Merge branch 'master' into realm-integration/score-and-beatmaps
  Dean Herbert · 2022-01-12 19:22:55 +09:00
  08da948afc
• Merge pull request #16430 from smoogipoo/less-harsh-mania-hp

  Fix mania requiring PERFECTs to maintain HP

  Dean Herbert · 2022-01-12 19:07:13 +09:00
  017f5a9b9b