Dean Herbert
f443cfb93e
Move blueprint validity conditions to allow more correct external usage of EndPlacement
...
Until now, these were haphazardly enforce inline in blueprint
implementations. The only thing stopping complete breakage is that
`EndPlacement` wasn't called (too much) from outside the blueprint,
leaving them responsible for their own placement.
By moving this conditional out of the provided paramters to
`EndPlacement`, it allows more flexible usage of that method externally.
Coming in a future PR.
2023-05-12 16:02:22 +09:00
Bartłomiej Dach
7d9327f3e2
Only allow hit placement when left mouse is clicked
2023-04-04 18:40:10 +02:00
Bartłomiej Dach
f42a463479
Remove #nullable disable
...
May as well that we're here...
2023-04-03 20:14:17 +02:00
Bartłomiej Dach
ed07c0640b
Remove unused using directive
2023-04-03 20:13:59 +02:00
Dean Herbert
be79ea1c10
Remove left/right click based placement in taiko editor and respect sample selection
2023-04-03 18:14:58 +09:00
Dan Balasescu
7bc8908ca9
Partial everything
2022-11-27 00:00:27 +09:00
cdwcgt
f14d871f97
let TaikoSpan show in timeline before placed
2022-10-23 01:32:22 +09:00
cdwcgt
a74e873b98
remove useless using
2022-10-23 01:13:29 +09:00
cdwcgt
42bb9dc3e3
revert EndPlacement change
2022-10-20 22:17:26 +09:00
cdwcgt
d6ed561280
make EndPlacement virtual
2022-10-19 00:31:21 +09:00
cdwcgt
344015a6e6
do not move timeline when EndPlacement
2022-09-27 20:12:40 +09:00
cdwcgt
9c4ae768f1
show object in timeline before placed
...
just BeginPlacement()
2022-09-27 20:08:32 +09:00
Dean Herbert
48fac9f8a5
Fix taiko drum rolls with zero length being placeable in editor
...
Addresses https://github.com/ppy/osu/discussions/19808 .
2022-08-18 16:50:36 +09:00
Dan Balasescu
f8830c6850
Automated #nullable processing
2022-06-17 16:37:17 +09:00
Dean Herbert
4c9d72e62a
Ensure EditorBeatmap.Update is called inside PerformOnSelection calls
2021-05-23 21:22:35 +09:00
Dean Herbert
c00e6e29a6
Remove static usage
2021-05-21 14:21:56 +09:00
Dean Herbert
df5970fab4
Create base implementations of the two most common TernaryStateMenuItems
2021-05-20 19:34:53 +09:00
smoogipoo
ffb6135a1b
Rework hitobject blueprints to take in hitobject models
2021-05-13 19:53:32 +09:00
Dean Herbert
4c9e94da2b
Move context menu logic to base class
2021-04-28 13:43:16 +09:00
Dean Herbert
f2e56bd306
Refactor editor selection/blueprint components to be generic
2021-04-27 19:01:29 +09:00
Dean Herbert
119c9b4294
Fix placement blueprints not being correctly removed after a rolled back placement
2021-04-16 14:11:33 +09:00
Dean Herbert
cd1c1bf534
Centralise cases of performing actions on the current selection
...
By moving this to a central location, we can avoid invoking the
EditorChangeHandler when there is no selection made. This helps
alleviate the issue pointed out in
https://github.com/ppy/osu/issues/11901 , but not fix it completely.
2021-02-26 14:15:13 +09:00
Bartłomiej Dach
5af1ac1b53
Rename TaikoStrong{-> able}HitObject
2020-12-14 21:46:02 +01:00
Bartłomiej Dach
f74567e8eb
Introduce base class for hitobjects that can be strong
2020-12-13 12:36:39 +01:00
Dean Herbert
9811c46e35
Rename application method to better describe what it actually does
2020-11-26 19:16:18 +09:00
smoogipoo
4ef2e9548c
Pass HitObjectComposer to BlueprintContainer via ctor
2020-11-13 16:59:37 +09:00
Dean Herbert
681e88af40
Merge branch 'master' into editor-fix-button-states-after-paste
2020-10-09 20:51:09 +09:00
Dan Balasescu
ecfb7e94c5
Merge branch 'master' into fix-editor-batch-handling
2020-10-09 20:06:06 +09:00
Dean Herbert
3838f405dd
Fix missed usages
2020-10-09 18:50:05 +09:00
Dean Herbert
c9f069d7ed
Fix taiko's HitObjectComposer not allowing movement o
...
f selected hitobjects
2020-10-08 18:17:57 +09:00
Dean Herbert
afed832b19
Tidy up EditorBeatmap slightly
2020-10-08 18:06:49 +09:00
Dean Herbert
38babf3de5
Update usages of ChangeHandler to EditorBeatmap where relevant
2020-10-08 18:04:07 +09:00
Dean Herbert
1aa8b400d4
Avoid unnecessary object updates from SelectionHandlers
2020-09-28 15:33:49 +09:00
Dean Herbert
727ab98d22
Update taiko selection handler with new logic
2020-09-25 15:32:45 +09:00
Dean Herbert
487fc2a2c6
Add missing change handler scopings to taiko context menu operations
2020-09-23 16:58:22 +09:00
Dean Herbert
a65f564e45
Add icons for other ruleset editors
2020-09-09 18:40:01 +09:00
Dean Herbert
61f906d9c4
Fix span piece being incorrect in some drag scenarios
2020-06-02 21:02:09 +09:00
Dean Herbert
665530f1c3
Remove excess newline
2020-06-02 17:22:59 +09:00
Dean Herbert
816f721f3d
Move selection blueprint to correct namespace
2020-05-30 15:24:44 +09:00
Dean Herbert
b068992a15
Add missing licence headers
2020-05-29 18:58:34 +09:00
Dean Herbert
e0aae15c0a
Hard type incoming ruleset
2020-05-29 16:45:47 +09:00
Dean Herbert
da289c474e
Split files out
2020-05-29 16:45:47 +09:00
