3288 Commits

• Adjust code again to avoid weird throw mishandling
  Dean Herbert · 2025-01-22 18:24:01 +09:00
  6ceb348cf6
• Adjust code style slightly
  Dean Herbert · 2025-01-22 17:03:01 +09:00
  910c0022e3
• Refetch local metadata cache if corruption is detected

  Addresses one of the points in https://github.com/ppy/osu/issues/31496.
  
  Not going to lie, this is mostly best-effort stuff (while the refetch is
  happening, metadata lookups using the local source *will* fail), but I
  see this as a marginal scenario anyways.

  Bartłomiej Dach · 2025-01-14 11:20:52 +01:00
  b0c0c98c5d
• Constrain range of usable characters in romanised metadata to ASCII only

  Closes https://github.com/ppy/osu/issues/31398.
  
  Rationale given in issue.
  
  Compare stable logic:
  
  - https://github.com/peppy/osu-stable-reference/blob/2280c4c436f80d04f9c79d3c905db00ac2902273/osu!/GameModes/Edit/Forms/SongSetup.cs#L118-L122
  - https://github.com/peppy/osu-stable-reference/blob/2280c4c436f80d04f9c79d3c905db00ac2902273/osu!common/Helpers/GeneralHelper.cs#L410-L423
  
  The control character check is a bit gratuitous (text boxes will already
  not allow insertion of those, see
  https://github.com/ppy/osu-framework/blob/e05cb86ff64abd343de49a143ada9734fd160a0a/osu.Framework/Graphics/UserInterface/TextBox.cs#L92),
  but as it's a general helper I figured might as well.

  Bartłomiej Dach · 2025-01-06 14:04:47 +01:00
  3a4497af32
• Merge pull request #31138 from bdach/mark-as-played

  Implement ability to mark beatmap as played

  Dean Herbert · 2024-12-24 21:43:15 +09:00
  62e536baf6
• Merge pull request #30984 from smoogipoo/fix-mania-spinner-conversion

  Fix "spinner" conversion for mania-specific beatmaps

  Bartłomiej Dach · 2024-12-19 15:30:10 +01:00
  1057aa867f
• Implement ability to mark beatmap as played

  Reported at https://osu.ppy.sh/community/forums/topics/2015478?n=1.
  
  Would you believe it that this button that has been there for literal
  years never did anything?
  
  Implemented at a per-beatmap level. Also additionally added to context
  menu (at @peppy's suggestion), and also copy reworded from "Delete from
  unplayed" to "Mark as played" because double negation hurt my tiny
  brain.

  Bartłomiej Dach · 2024-12-16 10:49:19 +09:00
  a6e00d6eac
• Merge branch 'master' into recommended-diff-beatmap-listing
  Dan Balasescu · 2024-12-13 16:38:07 +09:00
  62a1a5883a
• Update recommended difficulty for osu!taiko
  Joseph Madamba · 2024-12-12 16:17:57 -08:00
  38b3d5fc00
• Add test and null protections
  Joseph Madamba · 2024-12-12 15:23:00 -08:00
  f7364de01a
• Add recommended difficulty numerical value near filter in beatmap listing
  Joseph Madamba · 2024-12-12 15:23:00 -08:00
  92e07b4f99
• Add FormatStarRating() method util
  Joseph Madamba · 2024-12-12 15:23:00 -08:00
  e95dc2b308
• Apply NRT to incoming changed files
  Joseph Madamba · 2024-12-12 15:22:58 -08:00
  3035e8435d
• Merge pull request #30860 from frenzibyte/editor-multiple-background-audio-files

  Allow choosing different background/audio files for individual difficulties

  Bartłomiej Dach · 2024-12-11 14:12:58 +09:00
  89e3c551ff
• Merge pull request #30960 from bdach/bookmarks

  Implement basic bookmark support in editor

  Dean Herbert · 2024-12-09 23:42:04 -08:00
  48bf2fa001
• Adjust bad grammar
  Dean Herbert · 2024-12-10 14:35:09 +09:00
  92dfcae6eb
• Merge pull request #30973 from frenzibyte/copy-effect-points

  Preserve effect point specifications when creating blank difficulties

  Dan Balasescu · 2024-12-09 16:13:52 +09:00
  1b8d9370aa
• Fix reference effect point getting mutated
  Salman Alshamrani · 2024-12-06 05:47:41 -05:00
  5cb6b86b1c
• Always convert mania spinners

  A big part of these changes is refactoring, which is somewhat necessary
  because it was previously implemented as two separate pathways which
  in-fact need to be joined at the hip when handling spinners.
  
  I've chosen to use `IHasLegacyHitObjectType` here because there's no
  other flag that allows us to tell `ConvertHold` apart from
  `ConvertSpinner`.

  Dan Balasescu · 2024-12-06 16:40:28 +09:00
  8b456e1379
• Copy effect points across on blank difficulty creation
  Salman Alshamrani · 2024-12-04 02:32:00 -05:00
  e3abbf1177
• Move bookmarks out of BeatmapInfo

  Not sure why I didn't do that in https://github.com/ppy/osu/pull/28473...

  Bartłomiej Dach · 2024-12-03 14:17:14 +01:00
  808934581f
• Merge pull request #28473 from bdach/beatmap-info-purge

  Move unnecessary properties from `BeatmapInfo` / realm to `IBeatmap`

  Dean Herbert · 2024-12-02 16:19:12 +09:00
  5b2558cec2
• Centralise supported file extensions to one helper class

  As proposed in
  https://github.com/ppy/osu-server-beatmap-submission/pull/5#discussion_r1861680837.

  Bartłomiej Dach · 2024-11-29 08:42:45 +01:00
  110e4fbb30
• Use RealmLive in SaveFailedScoreButton

  This also optimises the manager classes to better support `Live` usage
  where the managed object is already in a good state (ie. doesn't require
  re-fetching).

  Dean Herbert · 2024-11-27 15:25:42 +09:00
  5260a401d4
• Merge pull request #27128 from frenzibyte/user-statistics-provider

  Introduce `UserStatisticsProvider` component and add support for respecting selected ruleset

  Dean Herbert · 2024-11-27 13:13:47 +09:00
  573aaf6637
• Fix Beatmap.Countdown not being copied on conversion
  Bartłomiej Dach · 2024-11-26 11:39:03 +01:00
  46d1f00590
• Merge branch 'master' into beatmap-info-purge
  Bartłomiej Dach · 2024-11-26 10:21:16 +01:00
  cf905d0f5c
• Merge pull request #30748 from stanriders/scale-profile-beatmaps

  Scale down beatmap cards

  Dean Herbert · 2024-11-25 22:53:51 +09:00
  9ca17f9b6b
• Remove legacy default setter for SamplesMatchPlaybackRate now that it's the default
  Dean Herbert · 2024-11-22 19:05:29 +09:00
  c590bef4c3
• Merge branch 'master' into beatmap-info-purge
  Dean Herbert · 2024-11-22 18:47:32 +09:00
  086a34f5c0
• Merge branch 'master' into scale-profile-beatmaps
  Dean Herbert · 2024-11-22 18:33:37 +09:00
  e33e0e16e8
• Change some beatmap default settings to match stable

  - Countdown should [be off by
  default](https://github.com/peppy/osu-stable-reference/blob/9a0748563812b5085a0ef5f8600b997408330eab/osu!/GameplayElements/Beatmaps/Beatmap.cs#L372)
  - Samples match playback rate
  [also](https://github.com/peppy/osu-stable-reference/blob/9a0748563812b5085a0ef5f8600b997408330eab/osu!/GameplayElements/Beatmaps/Beatmap.cs#L210)

  Dean Herbert · 2024-11-22 16:55:37 +09:00
  a76b4418b9
• Merge branch 'master' into multiplayer-remove-cmc-and-composite
  Dean Herbert · 2024-11-20 17:24:55 +09:00
  6fba6de4dc
• Use properties instead of fields
  Dan Balasescu · 2024-11-19 18:48:30 +09:00
  a5327aa562
• Replace bindable with an event
  Salman Alshamrani · 2024-11-18 06:47:22 -05:00
  74daf85e48
• Scale beatmap cards down by ~0.8
  StanR · 2024-11-18 14:48:51 +05:00
  4066186b24
• Fix more test / component breakage
  Salman Alshamrani · 2024-11-17 20:36:12 -05:00
  b106833663
• Fix various test failures
  Salman Alshamrani · 2024-11-17 19:13:29 -05:00
  caf56afba6
• Make DifficultyRecommender rely on the statistics provider
  Salman Alshamrani · 2024-11-17 18:32:17 -05:00
  28f87407f6
• use .ToFormattedDuration
  Shin Morisawa · 2024-11-14 16:59:03 +09:00
  7dff243e6a
• fix issue
  Shin Morisawa · 2024-11-14 16:33:52 +09:00
  64e7e44f28
• Merge branch 'ppy:master' into 1hour-song-multi
  Shin Morisawa · 2024-11-14 16:32:24 +09:00
  53fcb494ff
• Merge pull request #30578 from smoogipoo/beatmap-legacy-object-type

  Simplify convertible hitobject parsing and add `IHasLegacyHitObjectType`

  Dean Herbert · 2024-11-14 16:16:44 +09:00
  7f8eebc510
• Remove redundant null initialisation and apply nullability
  Dean Herbert · 2024-11-14 13:37:58 +09:00
  d37c1bb6d0
• Merge branch 'master' into bat-max-performance
  Dean Herbert · 2024-11-14 13:35:29 +09:00
  7670a81181
• fixed said issue
  Shin Morisawa · 2024-11-14 07:19:18 +09:00
  a3da10ff44
• change stuff. (idk what exactly)
  Shin Morisawa · 2024-11-14 06:58:54 +09:00
  7e96ae6da4
• Make CurrentPlaylistItem not a bindable
  Dan Balasescu · 2024-11-12 18:17:24 +09:00
  72564b5c98
• Add IHasLegacyHitObjectType to ConvertHitObject
  Dan Balasescu · 2024-11-11 16:10:15 +09:00
  7206e97b7b
• Merge implementations of ConvertHitObjectParser

  Having these be separate implementations sounded awesome at the time,
  but it only ever led to confusion. There's no practical difference if,
  for example, catch sees hitobjects with `IHasPosition` instead of
  `IHasXPosition`.

  Dan Balasescu · 2024-11-11 15:09:13 +09:00
  e1d93a7d9c