1217 Commits

• Rename FramedAutoGenerator<T> -> AutoGenerator<T>
  ekrctb · 2021-05-07 00:31:12 +09:00
  207f7f1e56
• Use FramedAutoGenerator in Taiko, Catch, Mania

  OsuAutoGenerator is not included in this change because it uses SortedList-like thing

  ekrctb · 2021-05-06 22:57:07 +09:00
  cf39178099
• Fix code quality issues
  Dean Herbert · 2021-04-24 14:35:49 +09:00
  0ccdfeea57
• Merge branch 'master' into reversed-fruits
  Dean Herbert · 2021-04-23 15:08:18 +09:00
  d4ffd2ef4b
• Remove dead newline
  Dean Herbert · 2021-04-23 15:06:39 +09:00
  bc0e1d8c37
• Merge branch 'master' into legacy-scores-classic-mod
  smoogipoo · 2021-04-22 18:44:20 +09:00
  d4d78f7434
• Expose internal catcher width calculation methods
  Dean Herbert · 2021-04-22 17:27:23 +09:00
  dc2bc462b8
• Update tests to better support stack regeneration cases
  Dean Herbert · 2021-04-22 17:13:19 +09:00
  84a7138223
• Improve osu!catch caught fruit placement algorithm
  Dean Herbert · 2021-04-22 17:06:28 +09:00
  3e1002fbf3
• Implement "classic" mod for all other legacy rulesets

  Currently empty, automatically handled in game to not be selectable (see `Mod.HasImplementation`)

  Salman Ahmed · 2021-04-21 09:14:33 +03:00
  e3398d8f1f
• Remove catcher fade during hyperdash

  Closes https://github.com/ppy/osu/issues/12472.

  Dean Herbert · 2021-04-20 18:18:51 +09:00
  ddf1b560f3
• replace icon
  Fabian · 2021-04-17 23:55:39 +02:00
  eec77b0527
• replace IApplicableToPlayer with IApplicableToDrawableRuleset
  Fabian · 2021-04-17 16:38:28 +02:00
  5d274dbce8
• Add floating fruits mod
  Fabian · 2021-04-17 16:01:23 +02:00
  cf3aaff7bd
• Remove AutoGenerator workaround of now-fixed issue
  ekrctb · 2021-04-16 14:13:41 +09:00
  a965e8a75d
• Introduce StartFrame and EndFrame to simplify the replay interpolation code
  ekrctb · 2021-04-16 14:13:41 +09:00
  91c7d8d26c
• Make FramedReplayInputHandler.CurrentTime non-null
  ekrctb · 2021-04-16 14:13:41 +09:00
  84bc81a6de
• Make sure latest catcher position is used for catching logic

  A replay frame processed in CatchInputManager is applied to catcher in `CatcherArea`.
  The catcher position is then used for the catching logic for each hit object under `HitObjectContainer`.
  Thus, if `HitObjectContainer` came before `CatcherArea`, the replay input is delayed one frame.
  That was one reason why the catch autoplay misses hit objects (especially when fast-forwarded).

  ekrctb · 2021-04-09 16:04:45 +09:00
  6d0dc62502
• Refactor to abstract out strain logic into StrainSkill class

  While it is the case for the existing official Skills, Skill implementations shouldn't be required to conform to a strain based approach.
  There are other valid approaches to calculating skill difficulty that can be supported by abstracting the strain logic into its own StrainSkill class.

  Samuel Cattini-Schultz · 2021-04-03 20:52:39 +11:00
  85d2b1232a
• Refactor to encapsulate strain logic into Skill class

  As strains are an implementation detail of the current Skill calculations, it makes sense that strain related logic should be encapsulated within the Skill class.

  Samuel Cattini-Schultz · 2021-04-03 20:47:43 +11:00
  5b2dcea8a8
• Merge branch 'master' into hide-caught-fruit-in-hidden
  Dan Balasescu · 2021-03-30 15:42:00 +09:00
  b24c695146
• Move bool one level down
  Dean Herbert · 2021-03-30 14:33:55 +09:00
  89bea2868a
• Fix osu!catch fruit showing on plate when hidden mod is enabled

  Closes https://github.com/ppy/osu/issues/12065.

  Dean Herbert · 2021-03-25 17:04:37 +09:00
  013ddc734c
• Update existing usages

  Resolve post-conflict issues

  Salman Ahmed · 2021-03-13 06:09:07 +03:00
  43c1e1d217
• Merge branch 'master' into diffcalc/skill-mods
  Dan Balasescu · 2021-03-04 13:06:26 +09:00
  5b6018295d
• Update HasFlag usages to HasFlagFast
  smoogipoo · 2021-02-25 15:38:56 +09:00
  dff1d80f39
• Add a list of mods to Skill class

  Although this isn't necessary for existing official rulesets and calculators, custom calculators can have use cases for accessing mods in difficulty calculation.
  For example, accounting for the effects of visual mods.

  Samuel Cattini-Schultz · 2021-02-20 20:37:44 +11:00
  66643a97b0
• Merge branch 'master' into autoplay-rate-independence
  Dean Herbert · 2021-02-11 17:39:45 +09:00
  aaa0362b12
• Merge branch 'master' into difficulty-adjustment-extension
  smoogipoo · 2021-02-10 20:42:08 +09:00
  be9b07a4cf
• Allow autoplay score generation to access mod list
  Bartłomiej Dach · 2021-02-07 18:35:34 +01:00
  68c20a2a37
• Fix codefactor style issues
  Joehu · 2021-02-04 13:28:35 -08:00
  9ef130cdcc
• Formatting
  Corentin PALLARD · 2021-01-29 03:03:23 +01:00
  d168de0ae3
• Fix the ctb auto mod speedup in some occasions
  Corentin PALLARD · 2021-01-29 02:53:26 +01:00
  da4c207a73
• Adjust package titles
  smoogipoo · 2021-01-18 11:08:03 +09:00
  1b166d809e
• Add nuget deploys for all rulesets
  smoogipoo · 2021-01-18 10:53:31 +09:00
  ec00aaef90
• Transfer flags indicating if settings were changed
  Bartłomiej Dach · 2021-01-06 22:46:46 +01:00
  303cc62ee7
• Pass a score to the replay recorder to allow reading more general scoring data
  Dean Herbert · 2020-12-14 16:52:14 +09:00
  1793385e96
• Move shared implementation to a named function
  Dean Herbert · 2020-12-14 13:56:46 +09:00
  b81dbfc192
• Remove EffectiveXBindable (setting Value was not handled)

  And use orthogonal `OriginalXBindable` and `XOffsetBindable`.

  ekrctb · 2020-12-14 13:39:07 +09:00
  5b5e883904
• Fix comment
  ekrctb · 2020-12-14 13:18:32 +09:00
  0ad256a762
• Revert "Remove X setter from CatchHitObject"

  This reverts commit 7cbbd74d

  ekrctb · 2020-12-14 13:18:14 +09:00
  d96399ea42
• Remove X setter from CatchHitObject
  ekrctb · 2020-12-14 11:38:07 +09:00
  7cbbd74df2
• Add some more doc comment
  ekrctb · 2020-12-14 11:32:34 +09:00
  f621d977fc
• Use OriginalX for CatchHitObject.X instead of EffectiveX

  And explicitly implement IHasXPosition interface to prevent use of the X property.
  It should be preferred for beatmap conversion purpose.

  ekrctb · 2020-12-14 11:26:05 +09:00
  36529bdd1b
• Add doc comments to catch hit object X properties
  ekrctb · 2020-12-14 11:15:49 +09:00
  089f3bebf5
• XBindable -> EffectiveXBindable in catch DHO
  ekrctb · 2020-12-14 11:05:26 +09:00
  cd2db59900
• Replace CatchHitObject.X usage to EffectiveX and OriginalX
  ekrctb · 2020-12-14 11:03:14 +09:00
  96f3e0dad8
• Obsolete X getter
  ekrctb · 2020-12-14 11:03:10 +09:00
  c1f3f1c231
• Separate asymmetric CatchHitObject.X to EffectiveX and OriginalX
  ekrctb · 2020-12-14 11:03:03 +09:00
  8da502da44
• Add some spacing to interface class
  Dean Herbert · 2020-12-11 16:43:00 +09:00
  c0d20d8ce4