Bartłomiej Dach
659505f711
Adjust calls to GetContainingInputManager()
2024-06-18 07:41:19 +02:00
Bartłomiej Dach
8a4ae5d23d
Null-propagate all calls to GetContainingFocusManager()
2024-06-18 07:30:46 +02:00
Dean Herbert
66ceda1d67
Update focus specifications in line with framework changes
2024-05-22 21:32:49 +08:00
Bartłomiej Dach
9f5a280bc2
Fix key binding row fire-and-forgetting writes
...
Intends to fix test failures as seen in https://github.com/ppy/osu/actions/runs/6692350567/job/18181352642#step:5:129
This is what happens if you carelessly fire and forget.
The working theory (that I'm not sure I have the tools to conclusively
confirm) is that the async write from the key binding changing could
fire _after_ the section is reset.
I briefly considered having the test wait for the change, but given that
the entirety of the surrounding flow is using sync operations, this just
looks like a bug to me. And there's no real sane way to inject async
into that flow due to dependence on `OsuButton.Action`.
2023-10-31 12:25:09 +01:00
Jamie Taylor
fbf8f52f7d
Add audio feedback for when keys are pressed during key binding
2023-10-20 21:01:37 +09:00
Dean Herbert
9b0c4acdef
Split KeyBindingRow
out into partial pieces
2023-10-13 18:29:06 +09:00
Dean Herbert
8e609b6f1d
Switch records to classes for sanity
...
I don't have anything against records except for the capitalisation when
including the paramter names in a constructor.
ie. `new Record(This: 1);`
2023-10-13 18:19:12 +09:00
Bartłomiej Dach
f083309e64
Move type back next to exposing class
2023-10-12 20:26:01 +02:00
Bartłomiej Dach
991e425b9a
Refactor conflict handling flow to be less back-and-forth
2023-10-12 20:25:59 +02:00
Bartłomiej Dach
f5a6781e5a
Integrate key binding conflict popover into keybindings panel
2023-10-12 16:04:46 +02:00
Bartłomiej Dach
aa8dbd742e
Hoist database update to subsection level
...
The end goal here is to be able to better coordinate deconfliction of
bindings at the subsection level rather than try to jam that logic into
individual rows somehow.
The flipside is that this is going to require a flow to update the
individual rows after the subsection's intervention, but that's what the
previous commit was for.
2023-10-12 16:01:51 +02:00
Bartłomiej Dach
5f0b1d69a5
Prepare KeyBindingRow
for accepting external changes
2023-10-12 16:00:20 +02:00
Bartłomiej Dach
c2e92cbb70
Refactor key binding panel leveraging new helper methods
2023-10-12 15:03:29 +02:00
Bartłomiej Dach
797109c05c
Enable NRT in KeyBindingRow
2023-10-11 08:50:00 +02:00
Bartłomiej Dach
0b2b065383
Add xmldoc
2023-10-11 08:50:00 +02:00
Bartłomiej Dach
7ac874d17a
Use init-only properties where applicable
2023-10-11 08:49:58 +02:00
Bartłomiej Dach
1acc02405e
Reorder KeyBindingRow
members
2023-10-11 08:18:59 +02:00
Dean Herbert
1bfe5a18cb
Rename RestoreDefaultValueButton
to RevertToDefaultButton
...
Because I can't find it every time I search.
2023-07-13 13:46:50 +09:00
Bartłomiej Dach
ae2896ba7e
Sprinkle some more null-forgiving operators
2023-07-06 22:08:48 +02:00
Bartłomiej Dach
894ef15e79
Merge branch 'master' into update-framework
2022-11-26 16:19:36 +01:00
Dan Balasescu
7bc8908ca9
Partial everything
2022-11-27 00:00:27 +09:00
Dean Herbert
53b03df93d
Combine TriangleButton
and RoundedButton
classes
2022-11-24 16:26:57 +09:00
Dan Balasescu
e4fc14faee
Merge pull request #21270 from peppy/auto-advance-bindings
...
Auto-advance binding for ruleset key bindings
2022-11-18 16:19:54 +09:00
Dean Herbert
e658efbefa
Fix being able to bind two non-modifier keys to the same binding
2022-11-18 15:34:41 +09:00
Dan Balasescu
551192b413
Refactor a bit for readability
2022-11-18 13:55:37 +09:00
Dean Herbert
d1b2116400
Auto-advance binding for ruleset key bindings
2022-11-17 15:23:20 +09:00
Aki
91358f4a6a
Implement tablet button bindings
2022-10-15 15:16:14 +08:00
Dean Herbert
6f6290a21a
Use async flow for storing key binding changes to realm
2022-10-11 15:37:22 +09:00
Dan Balasescu
f8830c6850
Automated #nullable processing
2022-06-17 16:37:17 +09:00
Dan Balasescu
a633501687
Change FilterTerms to use LocalisableString
2022-05-16 14:09:37 +09:00
Joseph Madamba
5e5c8e78a6
Use existing web localisation for most hardcoded strings
2022-04-20 16:31:11 -07:00
Dean Herbert
e23b10e6a5
Update remaining cases of clashing variable name in realm.Run(realm..
2022-01-25 13:04:05 +09:00
Dean Herbert
6eb2c28e41
Rename RealmContextFactory
to RealmAccess
2022-01-24 20:38:07 +09:00
Dean Herbert
a5d2047f05
Fix various cases of creating realm contexts from update thread when not necessary
2022-01-21 01:44:56 +09:00
Dean Herbert
d94b27a8a2
Switch realm ruleset key bindings to use ruleset's ShortName
as key
2021-11-22 18:52:30 +09:00
Susko3
8a23b648fe
Move HoverClickSounds
to the clickable button
2021-11-08 14:32:00 +01:00
Dean Herbert
49c26a465c
Debounce and schedule updates to key combinations
2021-11-08 18:29:11 +09:00
Dean Herbert
b4225804ed
Add missing null check
2021-11-08 18:26:12 +09:00
Dean Herbert
f5842e7587
Shorten variable names
2021-11-08 18:24:37 +09:00
Dean Herbert
82f24b0502
Revert "Change font to default"
...
This reverts commit cc286f165d
.
2021-11-08 18:16:06 +09:00
Susko3
cc286f165d
Change font to default
...
Non-english letters look tiny with size 10
and don't fit into the look.
2021-11-08 06:56:57 +01:00
Susko3
c3069ad002
Change to use ReadableKeyCombinationProvider
...
Changes all usages of `KeyCombination.ReadableString()` to
`ReadableKeyCombinationProvider.GetReadableString()`.
Subscribing to `KeymapChanged` is only required in `KeyButton`.
All other places query `GetReadableString()` every time.
2021-11-08 06:55:26 +01:00
Bartłomiej Dach
6c3637a62a
Remove grid usage in KeyBindingRow
2021-10-18 22:07:30 +02:00
Bartłomiej Dach
552fc1dc8a
Adjust key binding rows to accommodate new default value indicator
2021-10-17 21:50:04 +02:00
Bartłomiej Dach
b8616bf910
Adjust appearance of keybinding subpanel
2021-10-10 00:34:12 +02:00
Dean Herbert
9fa901f6aa
Refine RealmContext
implementation API
2021-09-30 23:56:38 +09:00
kj415j45
51997fa533
Add localisation for GlobalActions
2021-09-16 16:02:04 +08:00
kj415j45
03013d0d30
Add InputSettingsStrings
...
Existed strings files keep no change
2021-08-12 12:34:06 +08:00
Jamie Taylor
9b7bb37244
Add hover+select sounds to some components that are missing them
2021-07-30 21:35:28 +09:00
Anton Kovalyov
2b0d530075
Eliminate Overlay.KeyBinding namespace and move everything to Settings.Section.Input
2021-07-20 21:18:24 -07:00