127 Commits

Author	SHA1	Message	Date
Dean Herbert	74ab036f3e	Refactor SkinnableSound.Samples to be non-nullable	2023-01-27 19:32:30 +09:00
Dan Balasescu	7bc8908ca9	Partial everything	2022-11-27 00:00:27 +09:00
Dean Herbert	57723107dd	Fix osu!mania hold notes occasionally getting in a visually incorrect hit state ... To correctly end a mania hold note, `endHold()` needs to be called. This was not happening in a very specific scenario: - The hold note's head is not hit - The user pressed the column's key within the hold note's tail's window, but does so to hit the next object (a note in proximity to the hold note's tail). - The hit policy forces a miss on the hold note, but `endHold()` is not called - `CheckForResult` is not called after this point due to `Judged` being `true`. Closes #21311.	2022-11-22 16:15:34 +09:00
Dean Herbert	1aa0e40f2f	Add "Component" prefix to lookup naming	2022-11-09 17:46:43 +09:00
Dean Herbert	c908969d9b	Rename ISkinComponent to ISkinLookup	2022-11-09 17:46:43 +09:00
ekrctb	92ab39f5c2	Fix hold note disappear instantly	2022-10-25 19:16:23 +09:00
Dean Herbert	f060e6a780	Implement hold "sliding" samples in osu!mania	2022-10-11 16:31:37 +09:00
Dan Balasescu	f8830c6850	Automated #nullable processing	2022-06-17 16:37:17 +09:00
smoogipoo	f9d5abff8a	Update with keybinding changes	2021-09-16 18:26:12 +09:00
Dean Herbert	6252b8aa42	Fix hold notes handling all input ever	2021-08-24 19:08:04 +09:00
smoogipoo	f992b59b4f	Fix DrawableHoldNote retaining hit states through applications	2021-05-12 17:07:42 +09:00
smoogipoo	5692cecaa4	Initial implementation of DHO pooling	2021-05-12 16:35:05 +09:00
smoogipoo	4148d473e3	Fix hold note crashing with 0 length	2021-04-22 19:51:33 +09:00
smoogipoo	43e48406ca	Miss all ticks when hold note is hit	2021-03-31 12:21:14 +09:00
ekrctb	e3c035fe9c	Adjust namespace	2020-12-07 12:32:52 +09:00
Bartłomiej Dach	b62bf5798d	Store time of hold note break	2020-11-13 21:14:34 +01:00
Bartłomiej Dach	7a89e58483	Disable pressed/released action logic when rewinding	2020-11-13 20:49:06 +01:00
Dean Herbert	a3dc1d5730	Update existing implementations	2020-11-04 17:14:23 +09:00
Bartłomiej Dach	2b1ef16f89	Replace comparison references to HitResult.Miss with IsHit	2020-10-02 23:31:24 +02:00
smoogipoo	b1877b649b	Use new hit results in mania	2020-09-29 16:33:38 +09:00
smoogipoo	aa151e4cd7	Merge branch 'master' into mania-notelock	2020-08-31 13:31:41 +09:00
smoogipoo	deb172bb6c	Implement basic mania hit order policy	2020-08-27 20:24:21 +09:00
smoogipoo	1db836e9e0	Merge branch 'master' into hold-note-lighting	2020-08-26 20:22:07 +09:00
smoogipoo	9372c6eef6	Implement hold note lighting	2020-08-26 20:21:56 +09:00
smoogipoo	8632c3adf0	Fix hold notes bouncing with SV changes	2020-08-21 23:11:15 +09:00
Dan Balasescu	42ee9b75df	Apply suggestions from code review ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2020-08-21 19:38:59 +09:00
smoogipoo	aead13628b	Rework freezing to use masking	2020-08-21 17:52:42 +09:00
smoogipoo	37cf7999b1	Merge branch 'master' into hold-note-freeze	2020-08-21 14:39:25 +09:00
smoogipoo	1d9d885d27	Mask the tail as the body gets shorter	2020-08-19 01:40:26 +09:00
smoogipoo	4d4d9b7356	Add rewinding support	2020-08-19 01:37:31 +09:00
smoogipoo	99315a4aa7	Fix incorrect anchors for up-scroll	2020-08-19 00:05:36 +09:00
smoogipoo	988ad378a7	Fix body size + freeze head piece	2020-08-19 00:05:05 +09:00
smoogipoo	385f7cf85d	Implement mania hold note body recycling	2020-08-18 17:56:48 +09:00
smoogipoo	548ccc1a50	Initial implementation of hold note freezing	2020-08-18 00:29:00 +09:00
smoogipoo	f044c06d08	Fix hold notes accepting presses during release lenience	2020-07-20 22:26:58 +09:00
Dean Herbert	59bd2b3035	Merge pull request #8823 from smoogipoo/all-ruleset-encoders ... Implement legacy beatmap encoding for all rulesets	2020-04-24 17:49:34 +09:00
smoogipoo	4f0b5a34d3	Fix hold note placement body sized incorrectly	2020-04-23 12:53:23 +09:00
smoogipoo	1f962f5c56	Reword comment	2020-04-22 09:06:04 +09:00
smoogipoo	d957614fc9	Cleanup handling of mania samples	2020-04-22 09:06:04 +09:00
smoogipoo	1f797207f7	Rework lookups to not require total playfield columns	2020-04-03 12:31:05 +09:00
smoogipoo	1952fcc0ce	Implement mania hold note skinning	2020-03-31 16:42:35 +09:00
smoogipoo	7b2f58eb30	Apply OnRelease method signature refactorings	2020-01-22 13:22:34 +09:00
smoogipoo	d6fd1007c4	internal -> public	2019-12-23 18:48:14 +09:00
smoogipoo	7ac6f68de8	Rewrite hold note input handling	2019-12-23 17:48:57 +09:00
smoogipoo	42853b5af6	Separate head/tail notes from hold note class	2019-12-23 17:48:57 +09:00
smoogipoo	bc41eb176e	Clean up head/tail setting in various DHOs	2019-10-17 14:02:23 +09:00
smoogipoo	f429a8f7c2	Add back/obsolete old AddNested() method	2019-10-17 14:02:08 +09:00
smoogipoo	d8f3678c3c	Rename parameter	2019-10-17 12:53:54 +09:00
smoogipoo	8a284bacba	Make mania use the new nested hitobject structure	2019-10-17 12:37:20 +09:00
smoogipoo	8302658186	Fix other potential nullref cases that rider missed	2019-09-02 18:31:33 +09:00