1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-18 07:32:54 +08:00
Commit Graph

7766 Commits

Author SHA1 Message Date
Dean Herbert
7d93778355
Merge pull request #18290 from jai-x/new-chat-remove-selector-item
Use dummy channel to show selector and remove `ChannelListSelector`
2022-05-23 15:49:00 +09:00
Dean Herbert
d84119ac06
Merge pull request #18343 from frenzibyte/waveform-test-beatmap-failure
Fix `WaveformTestBeatmap`s potentially providing disposed track
2022-05-22 21:21:28 +09:00
Jai Sharma
fb06b7658b Merge branch 'master' into new-chat-remove-selector-item 2022-05-21 17:30:06 +01:00
Dean Herbert
4633eed78c Merge branch 'master' into localisable-filter-items 2022-05-20 23:55:16 +09:00
Salman Ahmed
abf9039109 Use == instead of ?? 2022-05-20 16:08:31 +03:00
Salman Ahmed
c78d90ccbd Refactor track transferring logic for ability to override and disallow 2022-05-20 14:43:07 +03:00
Jai Sharma
c37d1e4fae Ensure current channel is set to the ChannelListingChannel when it becomes null 2022-05-19 11:45:39 +01:00
Dean Herbert
136ecb45e2 Rename dummy channel and move to a nested class inside the ChannelListing itself 2022-05-19 19:26:14 +09:00
Dean Herbert
63c9776365 Fix oversight in bindable logic in new overlay class 2022-05-19 19:24:18 +09:00
Dean Herbert
363e7a6f53 Simplify toolbar hiding logic in FirstRunSetupOverlay
Rather than fiddling around with the activation modes, this seems like a
much cleaner way to make things work.

Closes https://github.com/ppy/osu/issues/18277.
2022-05-19 16:42:48 +09:00
Dean Herbert
d187ca2d8c
Merge pull request #18246 from jai-x/new-chat-cache-loaded-channels
Add drawable channel caching to new chat overlay
2022-05-19 15:15:47 +09:00
Dean Herbert
a443200d0d Make dependency nullable to allow for safer disposal unbinding 2022-05-19 13:49:52 +09:00
Salman Ahmed
5d3878a737 Add test coverage for slow-loading channels 2022-05-18 22:58:39 +03:00
Jai Sharma
371738b047 Check against the loaded drawable channel 2022-05-18 20:00:42 +01:00
Dean Herbert
0cee90e156 Add common strings for missing localisable content 2022-05-18 21:32:57 +09:00
Dean Herbert
d54e1503c7 Rename interaction toggle method 2022-05-18 21:32:57 +09:00
Dean Herbert
fa09270e62 Remove left-over todo 2022-05-18 21:32:57 +09:00
Jai Sharma
4015042e36 Ensure close button component is not stored as a Drawable 2022-05-18 01:35:39 +01:00
Bartłomiej Dach
c2555a91c7
Merge branch 'master' into first-run-screen-import-from-stable 2022-05-17 22:52:01 +02:00
Bartłomiej Dach
10b881dbf7
Merge branch 'master' into first-run-screen-button-ux 2022-05-17 22:27:49 +02:00
Jai Sharma
932442e242 Use null for empty grid cells in ChannelListItem 2022-05-17 18:52:19 +01:00
Dean Herbert
062ffe64ac Remove delay on pop in 2022-05-17 18:21:19 +09:00
Dean Herbert
bf00b062ad Add full localisation of import beatmaps screen 2022-05-17 17:58:24 +09:00
Dean Herbert
f4e0ad8c4c Fix drag drop of osu! folder not working as expected 2022-05-17 17:51:28 +09:00
Dean Herbert
c0de1f96ff Tidy up interaction toggling and add progress message 2022-05-17 17:33:54 +09:00
Dean Herbert
03d3900a02 Fix incorrect default state of checkboxes 2022-05-17 17:33:54 +09:00
Dean Herbert
adc7b61240 Switch directory selector to use a semi-shared popover implementation 2022-05-17 17:33:54 +09:00
Dean Herbert
e2ea98693f Tidy up buttons and text 2022-05-17 17:33:54 +09:00
Dean Herbert
4af1a788d1 Add locate stable button / screen 2022-05-17 15:55:53 +09:00
Dean Herbert
1593f05ff3 Tidy up checkbox implementation 2022-05-17 15:55:53 +09:00
Dean Herbert
13e70eab51 Allow cancellation of count operations and bypassing interactive location logic 2022-05-17 15:55:53 +09:00
Dean Herbert
1666d13d26 Add item counts to import screen 2022-05-17 15:55:53 +09:00
Dean Herbert
4412fec41a Add import from stable screen 2022-05-17 15:55:52 +09:00
Dean Herbert
ef5b2233d7 Improve the first run progress button to show loading and completion status 2022-05-17 15:23:13 +09:00
Dan Balasescu
a633501687 Change FilterTerms to use LocalisableString 2022-05-16 14:09:37 +09:00
Jai Sharma
ae5b6c3e10 Use dummy channel to show selector and remove ChannelListSelector
Add dummy channel `DummySelectorChannel` which should be set as the
current channel in the channel manager when the selector in the chat
overlay should be shown.

Refactors the `ChannelListItem` to not show mention pill and close
button when the channel is the dummy selector channel.

Ensure that the `ChannelList` selects the dummy channel on clicking the
selector item.

Removes `ChannelListSelector` as it is no longer needed.

Removes the `setCurrent` parameter from `ChannelManager.JoinChannel`
method as it is no longer needed.
2022-05-15 20:24:49 +01:00
Bartłomiej Dach
170df01b46
Adjust difficulty multiplier scale transition on mod overlay
The previous transition was supposed to be a center-anchored elastic
scale-in, but this didn't work as intended - because the multiplier
ended up inside of an auto-sized right-aligned container, the animation
itself would end up being anchored right.

Attempts to remove the scale transition resulted in a rather
jarring-looking result, so swap out the elastic scale-in for a sweep-in
effect from the top, to match the header and avoid introducing too many
directions of movement.

Delay values tweaked "to taste" - can be adjusted further if there is an
alternative set of values that feels better.
2022-05-15 20:44:50 +02:00
Dean Herbert
328561f5c8
Merge pull request #18263 from frenzibyte/spotlight-beatmap-badge
Add support for "spotlight" label in beatmap overlay/listing
2022-05-15 12:32:20 +09:00
Salman Ahmed
4bb06873d5 Move badge hierarchy declaration to constructor for safer access 2022-05-14 21:54:56 +03:00
Dean Herbert
8a01050168 Refactor mod select button initialisation to allow shared usage of deselect button 2022-05-15 03:16:43 +09:00
Salman Ahmed
1878578196 Move todo comment to subclasses 2022-05-14 21:05:34 +03:00
Salman Ahmed
441957e18e Convert get-only virtual properties to avoid DI order dependency 2022-05-14 21:05:34 +03:00
Salman Ahmed
88ba84ac9c Replace Pill with Badge everywhere 2022-05-14 20:52:38 +03:00
Dean Herbert
a759cf2dab Add key binding to deselect all mods
Defaults to `Backspace`.
2022-05-15 02:51:58 +09:00
Salman Ahmed
2878a6dcbe Integrate spotlight beatmap badge in info overlay 2022-05-14 19:47:10 +03:00
Salman Ahmed
56d6cb5764 Add "spotlight" beatmap badge 2022-05-14 19:46:50 +03:00
Salman Ahmed
c8bea6273b Abstractify beatmap badge logic to own class 2022-05-14 19:46:37 +03:00
Jai Sharma
bd68ffa805 Fix textbox focus test in ChatOverlayV2 2022-05-14 12:16:00 +01:00
Jai Sharma
2163a78b7f Ensure drawable channels removed from the cache are disposed 2022-05-14 00:15:09 +01:00
Jai Sharma
f88e416d1a Ensure the wrong drawable channel isn't shown after load 2022-05-13 23:39:09 +01:00