67584 Commits

This Branch

This Branch

All Branches

• Fix new inspection after framework bump
  Bartłomiej Dach · 2024-06-18 18:32:58 +02:00
  8836b98070
• Merge branch 'master' into navigate-to-timestamp
  Bartłomiej Dach · 2024-06-18 18:32:33 +02:00
  5551bae7ce
• Correct xmldoc
  Bartłomiej Dach · 2024-06-18 18:32:24 +02:00
  f764ec24cd
• Parse plain numbers as millisecond count when parsing timestamp
  Bartłomiej Dach · 2024-06-18 16:48:04 +02:00
  7ee29667db
• Merge pull request #28518 from bdach/update-framework

  Update framework

  Dan Balasescu · 2024-06-18 23:44:42 +09:00
  1933c14bee
• Fix tests
  Bartłomiej Dach · 2024-06-18 16:41:13 +02:00
  623055b60a
• Allow more lenient parsing of incoming timestamps
  Bartłomiej Dach · 2024-06-18 13:13:50 +02:00
  44b9a06639
• Address review feedback
  Bartłomiej Dach · 2024-06-18 13:07:18 +02:00
  e1827ac28d
• Fix nullability insepction
  Dean Herbert · 2024-06-18 15:13:52 +08:00
  e6187ebec0
• Adjust calls to DrawableExtensions.With<T>()
  Bartłomiej Dach · 2024-06-18 07:41:20 +02:00
  366ba26cb6
• Adjust calls to GetContainingInputManager()
  Bartłomiej Dach · 2024-06-18 07:41:19 +02:00
  659505f711
• Null-propagate all calls to GetContainingFocusManager()
  Bartłomiej Dach · 2024-06-18 07:30:46 +02:00
  8a4ae5d23d
• Adjust AudioFilter to framework-side changes

  Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>

  Bartłomiej Dach · 2024-06-18 07:30:46 +02:00
  7f08008059
• Update framework
  Bartłomiej Dach · 2024-06-18 07:26:20 +02:00
  da4160439e
• Merge pull request #23443 from OliBomby/edit-nodesample

  Make NodeSamples editable

  Dean Herbert · 2024-06-18 11:12:02 +09:00
  316125d47a
• Allow to jump to a specific timestamp via bottom bar in editor

  Apparently this is a stable feature and is helpful for modding.

  Bartłomiej Dach · 2024-06-17 17:07:55 +02:00
  5652a558f9
• Merge pull request #28507 from bdach/editor-opacity

  Reduce editor opacity of several editor components when hovering over composer

  Dean Herbert · 2024-06-17 22:16:08 +09:00
  b535f7c519
• Merge pull request #28468 from bdach/daily-challenge/event-feed

  Implement event feed view for daily challenge screen

  Dean Herbert · 2024-06-17 20:16:48 +09:00
  a6f09bc626
• Record on single line
  Dean Herbert · 2024-06-17 19:16:23 +08:00
  d3d325c46c
• Disable collection expression inspections completely
  Dean Herbert · 2024-06-17 19:11:08 +08:00
  05596a391d
• Reduce editor opacity of several editor components when hovering over composer

  Addresses https://github.com/ppy/osu/discussions/24384.

  Bartłomiej Dach · 2024-06-17 12:14:28 +02:00
  7cfe8d8df2
• Merge pull request #28505 from bdach/move-timeline-toggles-elsewhere

  Move timeline toggle controls to "view" menu

  Dean Herbert · 2024-06-17 18:59:38 +09:00
  cc0ef20afd
• Align beat snap control width with right toolbox
  Bartłomiej Dach · 2024-06-17 11:47:37 +02:00
  07f1994a13
• Remove unused delegate for now

  To silence inspections.

  Bartłomiej Dach · 2024-06-17 11:09:07 +02:00
  3884bce239
• Remove redundant type spec
  Bartłomiej Dach · 2024-06-17 10:54:52 +02:00
  f7910f774d
• Merge pull request #28504 from bdach/osu-playfield-border-includes-radius

  Account for osu! circle radius when drawing playfield border

  Dean Herbert · 2024-06-17 17:48:29 +09:00
  291a7f07e6
• Merge pull request #28503 from smoogipoo/partial-aot-trimming

  Annotate `ControlPoint` and `Mod` for AOT trimming support

  Bartłomiej Dach · 2024-06-17 10:36:17 +02:00
  57688c2cfa
• Remove stuff that looks bad after moving timeline toggle controls
  Bartłomiej Dach · 2024-06-17 10:23:00 +02:00
  03049d45bb
• Move timeline toggle controls to "view" menu
  Bartłomiej Dach · 2024-06-17 10:16:40 +02:00
  b42752c9f0
• Also annotate ControlPointInfo

  Same deal with this class. Fully qualifying the type names because this
  has `#nullable disable` and makes use of `NotNull` which is also present
  in the `System.Diagnostics.CodeAnalysis` namespace and AAAAAAARGH
  NAMESPACE CONFLICTS.

  Dan Balasescu · 2024-06-17 17:13:44 +09:00
  f86e9c9a4a
• Fix playfield border size not updating in editor on circle size change
  Bartłomiej Dach · 2024-06-17 09:36:01 +02:00
  1b00d0181a
• Annotate ControlPoint and Mod for AOT trimming support
  Dan Balasescu · 2024-06-17 16:19:33 +09:00
  41446a08b6
• Account for osu! circle radius when drawing playfield border

  Addresses https://github.com/ppy/osu/discussions/13167.

  Bartłomiej Dach · 2024-06-17 09:08:43 +02:00
  97003b3679
• Merge pull request #28472 from bdach/taiko-mod-relax

  Implement relax mod for taiko

  Dan Balasescu · 2024-06-17 13:49:17 +09:00
  030853ed5a
• Merge pull request #28480 from bdach/storyboard-pass-fail-show

  Implement toggling visibility of pass and fail storyboard layers

  Dean Herbert · 2024-06-16 11:08:00 +09:00
  15fbad0097
• Merge pull request #28481 from shiumano/no-offset-change

  Disable the automatic offset adjustment button if the offset of the previous play was 0

  Dan Balasescu · 2024-06-15 19:16:22 +09:00
  294f9bd626
• Merge pull request #28353 from Givikap120/catch_nf_penalty

  Changed Catch NF penalty to match Osu

  Dan Balasescu · 2024-06-15 18:54:02 +09:00
  2ecb9cd79e
• Inline enabled setting
  Dean Herbert · 2024-06-15 17:34:04 +08:00
  ff2d721029
• Apply NRT to test scene
  Dean Herbert · 2024-06-15 17:26:57 +08:00
  6bd633f8ce
• Set to enable or disable at load time
  Shiumano · 2024-06-14 21:43:17 +09:00
  6c82f1de9b
• Implement toggling visibility of pass and fail storyboard layers

  Closes https://github.com/ppy/osu/issues/6842.
  
  This is a rather barebones implementation, just to get this in place
  somehow at least. The logic is simple - 50% health or above shows pass
  layer, anything below shows fail layer.
  
  This does not match stable logic all across the board because I have
  no idea how to package that. Stable defines "passing" in like fifty
  ways:
  
  - in mania it's >80% HP
    (https://github.com/peppy/osu-stable-reference/blob/bb57924c1552adbed11ee3d96cdcde47cf96f2b6/osu!/GameModes/Play/Rulesets/Mania/RulesetMania.cs#L333-L336)
  - in taiko it's >80% *accuracy*
    (https://github.com/peppy/osu-stable-reference/blob/bb57924c1552adbed11ee3d96cdcde47cf96f2b6/osu!/GameModes/Play/Rulesets/Taiko/RulesetTaiko.cs#L486-L492)
  - there's also the part where "geki additions" will unconditionally set
    passing state
    (https://github.com/peppy/osu-stable-reference/blob/bb57924c1552adbed11ee3d96cdcde47cf96f2b6/osu!/GameModes/Play/Player.cs#L3561-L3564)
  - and also the part where at the end of the map, the final passing state
    is determined by checking whether the user passed more sections than
    failed
    (https://github.com/peppy/osu-stable-reference/blob/bb57924c1552adbed11ee3d96cdcde47cf96f2b6/osu!/GameModes/Play/Player.cs#L3320)
  
  The biggest issues of these are probably the first two, and they can
  *probably* be fixed, but would require a new member on `Ruleset` and I'm
  not sure how to make one look, so I'm not doing that at this time
  pending collection of ideas on how to do that.

  Bartłomiej Dach · 2024-06-14 13:59:02 +02:00
  67ca7e4135
• Add failing test
  Shiumano · 2024-06-14 20:07:27 +09:00
  bfca64a98e
• Merge pull request #28475 from Joppe27/scorepanel-applause-balance

  Fix excessive `applause` audio balancing in result screen

  Dean Herbert · 2024-06-14 13:33:23 +09:00
  2d4121b14a
• Clamp X value to avoid excessive balance shift
  Joppe27 · 2024-06-13 18:06:19 +02:00
  47f89b8969
• Implement taiko relax mod
  Bartłomiej Dach · 2024-06-13 15:06:40 +02:00
  d7997cc93c
• Add precautionary test coverage for alternating still being required by default for swells
  Bartłomiej Dach · 2024-06-13 15:06:40 +02:00
  173f195834
• Add test scene for taiko relax mod
  Bartłomiej Dach · 2024-06-13 15:03:43 +02:00
  253b7b046b
• Merge pull request #28466 from smoogipoo/fix-long-hold-length

  Fix missing texture on extremely long hold notes

  Bartłomiej Dach · 2024-06-13 09:13:03 +02:00
  fdb63bd7cd
• Implement event feed view for daily challenge screen
  Bartłomiej Dach · 2024-06-13 09:05:45 +02:00
  8c4aa84037
• Merge pull request #28458 from bdach/mania-editor-hold-note-drag

  Allow modifying hold note start/end time via mania composer playfield

  Dan Balasescu · 2024-06-13 15:42:44 +09:00
  16aebb97a5