Bartłomiej Dach
04c2a9cd59
Display basic statistics on card hover
2021-11-07 21:03:06 +01:00
Bartłomiej Dach
6d30248cef
Merge branch 'master' into use-class-rename
2021-11-07 15:41:00 +01:00
Dean Herbert
0ecf5f201c
Rename User
to APIUser
and move to correct namespace
2021-11-07 11:26:01 +09:00
Bartłomiej Dach
6a1c27d67a
Merge branch 'master' into fix-more-null
2021-11-06 15:36:15 +01:00
Dean Herbert
b8fb22b769
Add missing test coverage of score import process being tracked correctly
2021-11-06 16:45:55 +09:00
Dean Herbert
bc17446055
Merge branch 'master' into user-lookup-by-username-cleanup
2021-11-06 14:38:30 +09:00
Dean Herbert
2881ce0f5a
Merge branch 'master' into remove-stupid-weak-reference-bindable-events
2021-11-06 14:08:39 +09:00
Chinmay Patil
77e853ce25
Optimized UR Counter and removed redundant code
2021-11-05 12:16:58 -06:00
Dean Herbert
9a7c75508e
Merge branch 'master' into user-class-cleanup
2021-11-05 19:56:18 +09:00
Dean Herbert
54f72d68ca
Revert weird event flow in model manager/importers
2021-11-05 19:12:49 +09:00
Dean Herbert
6c385ccd29
Move second generic to abstract
model downloader rather than interface type
2021-11-05 17:37:05 +09:00
Dean Herbert
1fe9bca819
Change ModelDownloader
's requirement to an IModelImporter
rather than IModelManager
2021-11-05 16:47:18 +09:00
Salman Ahmed
b723975767
Replace pragma with add/remove => throw
2021-11-05 09:10:38 +03:00
Dean Herbert
ba74dd93b2
Remove weird fetchOnline
logic
2021-11-05 13:55:34 +09:00
Dean Herbert
1f5ca122b0
Merge branch 'master' into user-class-cleanup
2021-11-05 13:55:22 +09:00
Dean Herbert
ead64282dd
Split out a couple more nested classes
2021-11-05 13:40:44 +09:00
Dan Balasescu
acb06d4a99
Merge branch 'master' into beatmap-refactor/remove-online-info
2021-11-05 12:46:02 +09:00
Salman Ahmed
2764ad90ea
Merge branch 'master' into fix-more-null
2021-11-05 05:14:22 +03:00
Salman Ahmed
6197ef426d
Disable another "code heurstically unreachable" with comment
2021-11-05 03:50:17 +03:00
Salman Ahmed
af6ae1cce5
Remove hacky code with explicit pragma disable
2021-11-05 03:49:35 +03:00
Bartłomiej Dach
9246adc349
Add failing test coverage for labelled drawable description visible
2021-11-04 21:43:20 +01:00
Chinmay Patil
8923561b05
Removed Unnessicary class in the Test file, and optimized UR counter
2021-11-04 14:27:48 -06:00
Dean Herbert
7049d0de66
Merge branch 'master' into beatmap-refactor/remove-online-info
2021-11-05 01:16:11 +09:00
Chinmay Patil
a76878e053
A bit more formatting
2021-11-04 09:52:16 -06:00
Chinmay Patil
c568888500
Edited to remove unessicary blank lines
2021-11-04 09:47:52 -06:00
Chinmay Patil
223efe55d5
Added Tests for UR counter
2021-11-04 09:23:29 -06:00
Dean Herbert
ed07ee8c61
Update all existing usages of AuthorString
/AuthorId
...
Unfortunately the getters need to be left in place else EF breaks.
2021-11-04 18:59:37 +09:00
Dan Balasescu
45dcf187b9
Merge branch 'master' into beatmap-refactor/playlist-use-api-beatmap-extended
2021-11-04 18:59:04 +09:00
Dean Herbert
86540d1fb6
Update existing usages of Author
as string
to access Username
directly
2021-11-04 18:57:54 +09:00
Dean Herbert
b9983add15
Rename User
to APIUser
and move to correct namespace
2021-11-04 18:21:31 +09:00
Dean Herbert
d2831b1152
Merge branch 'beatmap-refactor/remove-online-info' into beatmap-refactor/to-model-removal-2
2021-11-04 17:09:50 +09:00
Dean Herbert
77be610b26
Revert "Clean up DirectDownloadButton
test scene"
...
This reverts commit baabe99f78
.
2021-11-04 17:09:20 +09:00
Dean Herbert
5a078da4d9
Fix APIBeatmapSet.Beatmaps
being IEnumerable
, causing stupid issues
2021-11-04 16:50:14 +09:00
Dean Herbert
c820d445ad
Merge pull request #15461 from peppy/fix-more-computationally-expensive
...
Fix a few more "maybe null" inspections
2021-11-04 16:49:38 +09:00
Dean Herbert
8f459e6ce8
Fix APIBeatmapSet.Beatmaps
being IEnumerable
, causing stupid issues
2021-11-04 16:44:17 +09:00
Dean Herbert
baabe99f78
Clean up DirectDownloadButton
test scene
2021-11-04 16:28:29 +09:00
Dean Herbert
317506d4d7
Fix a few more "maybe null" inspections
2021-11-04 16:11:23 +09:00
Dean Herbert
0f4f1349db
Merge branch 'master' into editor-context-menu-on-select
2021-11-04 15:59:06 +09:00
Dan Balasescu
222c3e552b
Merge pull request #15456 from peppy/beatmap-refactor/beatmap-metadata-nullable-enable
...
Enable nullable support on `BeatmapMetadata`
2021-11-04 15:47:18 +09:00
Dean Herbert
9c926e5514
Remove BeatmapSetInfo.OnlineInfo
and all usages
2021-11-04 15:23:04 +09:00
Dean Herbert
66f4516eee
Allow creating sample API models without specifying a ruleset
2021-11-04 15:23:04 +09:00
Dean Herbert
8733767416
Merge branch 'beatmap-refactor/beatmap-metadata-nullable-enable' into beatmap-refactor/remove-online-info
2021-11-04 15:23:02 +09:00
Dean Herbert
09f9731d74
Add temporary disable of failing r# inspection
2021-11-04 15:09:04 +09:00
Dean Herbert
d1e6d1cb98
Update some other missed incorrect null/empty usages
2021-11-04 14:50:43 +09:00
Dean Herbert
67d9590a79
Fix new inspections
2021-11-04 14:02:09 +09:00
Dan Balasescu
dd948e5ada
Merge pull request #15447 from peppy/fix-invalid-characters-zip-export
...
Fix beatmaps being exported with malformed filenames inside `.osz` zip files
2021-11-04 09:03:51 +09:00
Bartłomiej Dach
6e33fa088f
Add test case for drawable room with too long beatmap name
2021-11-03 17:32:53 +01:00
Dean Herbert
601b218119
Add test coverage for characters which are invalid in zip storage
2021-11-03 16:45:16 +09:00
Bartłomiej Dach
cf7545e36c
Merge branch 'master' into beatmap-card-basics
2021-11-03 00:11:03 +01:00
Dean Herbert
1bfa1365a0
Rename "null user" tests to better explain purpose
2021-11-02 17:13:37 +09:00
Dean Herbert
e472656b37
Add test coverage of room participants updating on room join
2021-11-02 17:13:37 +09:00
Dean Herbert
d4be6fc797
Add test coverage of skin with missing section header
2021-11-02 14:05:14 +09:00
Bartłomiej Dach
5962f16b1c
Implement basic card appearance
2021-11-01 19:41:11 +01:00
Bartłomiej Dach
d82564aab6
Add test scene for beatmap cards
2021-11-01 19:41:10 +01:00
dependabot[bot]
7747fd5810
Bump Microsoft.NET.Test.Sdk from 16.11.0 to 17.0.0
...
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest ) from 16.11.0 to 17.0.0.
- [Release notes](https://github.com/microsoft/vstest/releases )
- [Commits](https://github.com/microsoft/vstest/compare/v16.11.0...v17.0.0 )
---
updated-dependencies:
- dependency-name: Microsoft.NET.Test.Sdk
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
2021-11-01 17:01:54 +00:00
Dean Herbert
caa9d8997b
Merge branch 'master' into score-refactor/less-create-score-info
2021-11-01 22:59:11 +09:00
Bartłomiej Dach
0d65493b56
Mark test usages of Ruleset.CreateInstance()
as returning non-null
2021-11-01 12:12:21 +01:00
Bartłomiej Dach
5dcff7d8b7
Merge branch 'master' into score-refactor/less-create-score-info
2021-11-01 11:41:20 +01:00
Dean Herbert
b21e0e7efb
Merge branch 'beatmap-refactor/get-and-present' into beatmap-refactor/beatmap-overlays
2021-11-01 18:07:51 +09:00
Bartłomiej Dach
6a44cf3ff1
Add missing beatmap spec in test scene
2021-11-01 09:44:08 +01:00
Bartłomiej Dach
f5feed138d
Merge branch 'master' into score-refactor/isolated-serialisation
2021-11-01 09:43:51 +01:00
Dean Herbert
90a0a5e0b7
Fix attempting to set properties of null BeatmapSet
s in tests
2021-11-01 17:12:15 +09:00
Dean Herbert
63c9512ab1
Update dashboard components to use APIBeatmapSet
2021-11-01 16:04:01 +09:00
Dean Herbert
b98faf6159
Merge branch 'master' into score-refactor/isolated-serialisation
2021-11-01 15:49:25 +09:00
Dan Balasescu
9e633a1b17
Merge pull request #15321 from peppy/beatmap-refactor/download-tracker
...
Replace `DownloadTrackingComposite` with instantiable `DownloadTracker` components
2021-11-01 15:48:12 +09:00
Dean Herbert
6b250955d7
Add missing verbatim string markers
2021-11-01 14:24:38 +09:00
Dean Herbert
32817a4c66
Add test coverage of failure from incorrect case in skin.ini
filename
2021-11-01 14:24:38 +09:00
Dean Herbert
269a8df0ec
Fix HasReplay
not being corrrectly implemented by APIScoreInfo
2021-11-01 13:20:37 +09:00
Dean Herbert
19feae4a8e
Merge branch 'master' into beatmap-refactor/download-tracker
2021-11-01 13:15:36 +09:00
Bartłomiej Dach
8053b2c320
Merge branch 'master' into score-refactor/isolated-serialisation
2021-10-30 15:07:34 +02:00
Dean Herbert
bb9769aa17
Fix null ruleset in another place
2021-10-29 20:12:12 +09:00
Dean Herbert
22c2f48e4d
Fix more null rulesets
2021-10-29 19:05:42 +09:00
Dean Herbert
a16c8f1ebc
Update all beatmap overlay views to use APIBeatmap
/APIBeatmapSet
2021-10-29 18:50:55 +09:00
Dean Herbert
993a28b37e
Merge branch 'beatmap-refactor/difficulty-icons' into beatmap-refactor/beatmap-overlays
2021-10-29 18:35:26 +09:00
Dean Herbert
04acc7601c
Fix one more missed case
2021-10-29 18:35:15 +09:00
Dean Herbert
07e3ced315
Fix test scene and remove "impossible" nullable coalesce
2021-10-29 18:22:23 +09:00
Dean Herbert
8ad33d43d0
Merge branch 'beatmap-refactor/get-and-present' into beatmap-refactor/beatmap-overlays
2021-10-29 18:01:17 +09:00
Dean Herbert
3be9c487f8
Merge branch 'beatmap-refactor/download-tracker' into beatmap-refactor/beatmap-overlays
2021-10-29 18:01:12 +09:00
Dean Herbert
3598adb344
Fix test implementing old version of class
2021-10-29 17:04:56 +09:00
Dean Herbert
31403daa20
Change DrawableProfileScore
to use APIScoreInfo
2021-10-29 15:14:52 +09:00
Dean Herbert
17a83f701a
Store mods as APIMods
for the time being
2021-10-29 15:13:49 +09:00
Dean Herbert
f68d6dbc8f
Update score submission serialisation tests to use SubmittableScore
2021-10-29 14:32:31 +09:00
Dean Herbert
1944c255a7
Implement score interfaces
2021-10-29 13:49:30 +09:00
Dean Herbert
817369903a
Rename API score classes
2021-10-29 13:40:56 +09:00
Dean Herbert
3b095e1626
Merge branch 'master' into beatmap-refactor/download-tracker
2021-10-29 11:50:54 +09:00
smoogipoo
c96b07c625
Remove unnecessary/wrong code
2021-10-28 18:24:04 +09:00
smoogipoo
2b3e63470d
Merge branch 'master' into always-unique-test-online-ids
2021-10-28 18:23:45 +09:00
Dan Balasescu
6e79a0947a
Merge pull request #15340 from peppy/add-number-setting-source-test
...
Add visual test for `SettingsNumberBox` usage in settings source context
2021-10-28 18:19:45 +09:00
Dean Herbert
4f4f2503aa
Merge pull request #15335 from smoogipoo/cleanup-multiplayer-screen-tests
...
Clean up multiplayer-screen tests by removing intermediate screen
2021-10-28 17:28:26 +09:00
Dean Herbert
c0848486d6
Add missing test coverage for attempt count display
2021-10-28 17:27:16 +09:00
Dean Herbert
8076e22e70
Replace weird import handling
2021-10-28 17:27:16 +09:00
Dan Balasescu
b21f42ec76
Merge branch 'master' into add-number-setting-source-test
2021-10-28 17:25:52 +09:00
Dan Balasescu
e5a7589859
Merge pull request #15317 from peppy/beatmap-refactor/uncontested
...
Update `UpdateableBeatmapBackgroundSprite` to accept `IBeatmapInfo`
2021-10-28 17:24:49 +09:00
Dean Herbert
b096bf6cd1
Ensure all test beatmaps have unique OnlineIDs to avoid import conflicts
...
The order of operation of imports means that the already-imported
instances are considered most correct (they have usually been populated
using an online source, although that is skipped in tests), so on two
consecutive test imports in a test scene, the second will lose its
online IDs completely.
This aims to ensure that all test beatmaps will have online IDs, which
is the general expected behaviour.
2021-10-28 16:56:31 +09:00
Dean Herbert
6f5040722a
Merge branch 'master' into beatmap-refactor/uncontested
2021-10-28 16:37:26 +09:00
Dean Herbert
1e1f8c472a
Add icons to various progress notification states
2021-10-28 16:34:12 +09:00
Dean Herbert
dce19cf7e4
Add visual test for SettingsNumberBox
usage in settings source context
2021-10-28 15:42:06 +09:00
smoogipoo
e2c08fb2e5
Create room by clicking button
2021-10-28 15:41:59 +09:00
smoogipoo
b0b27a47d5
Rename test scene
2021-10-28 15:28:16 +09:00
smoogipoo
cf15282077
Merge branch 'master' into fix-playlists-room-subscreen-tests
2021-10-28 15:26:48 +09:00