Dean Herbert
017285b694
Update MusicController to handle deletions more correctly
2022-01-12 17:49:11 +09:00
Dean Herbert
e8dcbaf29a
Fix intro screen hitting null reference if intro beatmap is unavailable
2022-01-12 17:49:11 +09:00
Dean Herbert
33060990b7
Temporarily disable WorkingBeatmapCache and fix multiple invalid data flows
2022-01-12 17:00:16 +09:00
Dean Herbert
1d536fd0bc
Start introducing ILive
2022-01-12 17:00:16 +09:00
Dean Herbert
abd72c496b
"Update" MusicController
2022-01-12 17:00:16 +09:00
Dean Herbert
00e3af3366
Update model manager and many related classes to get things compiling again
2022-01-12 17:00:00 +09:00
Dean Herbert
842d508aee
Fix incorrect delgate capture leading to slow leak of audio tracks
...
During profile, it was found that the `Completed` delegate was
incorrectly also capturing `lastTrack`, leading to an unexpected
reference chain that led to a memory leak over a long period of time.
This solves the issue by moving the delegate construction to its own
method, where it won't capture the other variables.
2021-12-24 18:39:29 +09:00
Dean Herbert
729f681938
Update cases where equality can be used instead of primary key equality
2021-11-24 12:49:57 +09:00
Dean Herbert
54f72d68ca
Revert weird event flow in model manager/importers
2021-11-05 19:12:49 +09:00
Dean Herbert
6944151486
Apply batch fixing of built-in types using var
2021-10-27 13:04:41 +09:00
Henry Lin
89e8296eb1
Reset all types of adjustments in MusicController; Rename AllowRateAdjustments to AllowTrackAdjustments
2021-07-29 15:39:26 +08:00
Dean Herbert
06bd696cc2
Remove previous consumption logic in GetWorkingBeatmap
...
This should not be required since the introduction of `workingCache`,
which does the same thing in a more global way.
2021-05-31 14:11:58 +09:00
smoogipoo
6f623d8cca
Rename IsUserPaused -> UserPauseRequested
2020-11-02 16:08:59 +09:00
Dean Herbert
8f2cd0e8c5
Add matching requestedByUser parameter to Play method
2020-11-02 15:01:30 +09:00
Dean Herbert
d2f6303988
Change default value of requestedByUser to false
2020-11-02 14:56:50 +09:00
Bartłomiej Dach
941e8525af
Add flag parameter to allow non-user-pause via music controller
2020-10-31 16:07:54 +01:00
Dean Herbert
c86b37f60d
Add check to ensure MusicController doesn't play a delete pending beatmap's track
2020-10-09 13:11:24 +09:00
Dean Herbert
a17eac3692
Rename reload method to not mention beatmap unnecessarily
2020-09-25 12:27:08 +09:00
Dean Herbert
978f6edf38
Add basic track reloading support while inside the editor
2020-09-24 20:56:35 +09:00
Dean Herbert
ad5d6117c7
Remove unnecessary RunTask calls
2020-09-08 18:26:13 +09:00
Dean Herbert
b8e5acfef1
Merge branch 'master' into fix-music-controller-regressed
2020-09-04 20:10:43 +09:00
Salman Ahmed
3239576a23
Minor rewording of new comment
...
Co-authored-by: Dean Herbert <pe@ppy.sh>
2020-09-04 11:50:49 +03:00
Salman Ahmed
4236e5fe71
Replace useless "matching-code" comment with explanation of how it could happen
...
Co-authored-by: Dean Herbert <pe@ppy.sh>
2020-09-04 11:31:54 +03:00
Salman Ahmed
65d541456a
Slight rewording
2020-09-04 11:11:07 +03:00
Salman Ahmed
001509df55
Move music global action handling to an own component
...
Due to requiring components that are added at an OsuGame-level
2020-09-04 10:24:54 +03:00
Salman Ahmed
42895e27b6
Expose track change results on the methods
2020-09-04 10:24:54 +03:00
Salman Ahmed
54013790fc
Fix MusicController raising TrackChanged event twice
2020-09-04 10:24:31 +03:00
Dean Herbert
6a765d2d76
Add smooth fading between audio tracks on transition
2020-09-02 20:04:56 +09:00
smoogipoo
555b2196b7
Add xmldoc to MusicController.ResetTrackAdjustments()
2020-09-02 15:23:50 +09:00
Dean Herbert
db52260427
Rename and clarify comment regarding "previous" track disposal
2020-08-22 19:44:54 +09:00
Dean Herbert
308d9f5967
Ensure locally executed methods are always loaded before propagation
2020-08-21 18:43:58 +09:00
Dean Herbert
083bcde3cf
Fix beatmap transfer not working
2020-08-18 13:01:35 +09:00
Dean Herbert
d9debef156
Add explicit LoadTrack method
2020-08-17 15:38:16 +09:00
smoogipoo
688e447950
Fix potential hierarchy mutation from async context
2020-08-12 01:33:06 +09:00
smoogipoo
b64142dff9
Fix incorrect load state being used
2020-08-11 12:37:00 +09:00
smoogipoo
87ce1e3558
Remove impossible null case (DummyWorkingBeatmap)
2020-08-08 00:58:04 +09:00
smoogipoo
b8373e89b7
Move beatmap bind to BDL load()
2020-08-07 23:08:09 +09:00
smoogipoo
e87f50f74f
Rename method
2020-08-07 22:31:41 +09:00
smoogipoo
b6fb7a0d39
Fix possibly setting null track
2020-08-07 22:05:58 +09:00
smoogipoo
5002d69f69
Update inspections
2020-08-07 20:51:56 +09:00
smoogipoo
61b632516e
Ensure CurrentTrack is never null
2020-08-07 19:43:16 +09:00
smoogipoo
fe8c462498
Remove intermediate container
2020-08-06 17:00:17 +09:00
smoogipoo
0edd509397
Only change track when audio doesn't equal
2020-08-06 16:24:14 +09:00
smoogipoo
e9fc783b1d
Add back loop-on-completion
2020-08-06 16:24:14 +09:00
smoogipoo
5c05fe3988
Expose track from MusicController
2020-08-06 16:24:14 +09:00
smoogipoo
6e42b8219c
Move track to MusicController, compiles
2020-08-06 16:24:14 +09:00
Dean Herbert
e8f75a78e8
Also fix second instance of same execution
2020-07-31 22:02:12 +09:00
Dean Herbert
4d2a677080
Fix next track starting before previous one is paused
...
Closes #9651 .
2020-07-31 20:33:18 +09:00
Dean Herbert
7b7b92aa10
Fix potential crash when trying to ensure music is playing
2020-07-13 17:28:16 +09:00
Dean Herbert
1760cc2427
Fix behavioural regression by splitting methods out
2020-07-10 18:03:56 +09:00
