955 Commits

• Fix two implementation oversights
  Dean Herbert · 2022-12-02 16:05:14 +09:00
  809d02cda0
• Fix test failures when no hitobjects are present in a scrolling ruleset
  Dean Herbert · 2022-12-01 21:42:03 +09:00
  d8dd7e7e0f
• Fix multiple instances of last hitobject time being calculated incorrectly
  Dean Herbert · 2022-12-01 18:04:06 +09:00
  896f2d8f74
• Annotate Playfield.Mods as maybe-null
  Bartłomiej Dach · 2022-11-30 20:00:25 +01:00
  6ebde9a747
• Hide the game mouse cursor when playing osu!catch with relax mod
  Dean Herbert · 2022-11-30 18:13:53 +09:00
  5ce2d6f54a
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Remove unnecessary #nullable disable
  Bartłomiej Dach · 2022-11-20 15:31:51 +01:00
  0f382590e6
• Introduce IDrawableScrollingRuleset for editor consumption
  Salman Ahmed · 2022-11-20 04:11:10 +03:00
  58296bd4f0
• Fix FallbackSampleStore.GetAsync fallback logic
  Susko3 · 2022-11-13 18:47:28 +01:00
  56fd1f95b1
• Fix incorrect fallback logic

  Regressed when attempting to share implementation of binary search.

  Dean Herbert · 2022-10-20 23:08:44 +09:00
  5c13c443ff
• Refactor implementation to support hitobjects nested multiple levels deep
  Dean Herbert · 2022-10-20 22:30:30 +09:00
  26860a903e
• Fix nested objects in overlapping scrolling hit object container ruleset not using correct reference time
  Dean Herbert · 2022-10-18 16:15:21 +09:00
  d237c818f6
• Standardise control point search logic in OverlappingScrollAlgorithm

  Was using a very local algorithm which I cannot guarantee is correct.
  I'd rather it just use the one used everywhere else.

  Dean Herbert · 2022-10-18 16:01:05 +09:00
  ec3761ced9
• Update xmlodc and add nullability attributes
  Salman Ahmed · 2022-10-13 00:16:42 +03:00
  4fb156ef4e
• Remove default invisible cursor container from rulesets
  Salman Ahmed · 2022-10-12 17:50:47 +03:00
  7a6ecaff0d
• Rename various cursor symbols

  - `IProvideCursor.MenuCursor` -> `IProvideCursor.Cursor`
   - `MenuCursor` -> `MenuCursorContainer

  Salman Ahmed · 2022-10-11 16:21:01 +03:00
  9b45a9cf76
• Remove non-smoke key bindings on "Relax" mod instead
  Salman Ahmed · 2022-10-09 17:14:16 +03:00
  2d4f390372
• Fix scrolling nested hit object lifetime not set
  ekrctb · 2022-10-04 15:17:14 +09:00
  1cccd03480
• Add test for scrolling hit object lifetime
  ekrctb · 2022-10-04 15:17:11 +09:00
  781f5420b0
• Compute lifetime from entry in scrolling container
  ekrctb · 2022-10-04 15:12:28 +09:00
  5d80950eaf
• Merge pull request #20510 from sw1tchbl4d3r/high_bpm_judgements

  Clamp `LifetimeStart` of `HitObject`s to their judgement windows

  Dan Balasescu · 2022-09-28 17:49:35 +09:00
  cbed268ac9
• Clamp LifetimeStart of HitObject's to their judgement windows
  sw1tchbl4d3 · 2022-09-27 16:54:24 +02:00
  0cffbb7562
• Cleanup all other leftover binding instantiation
  o-dasher · 2022-09-25 16:02:40 -04:00
  feadac1f79
• Remove createLifetimeEntry from HitObjectEntryManager
  ekrctb · 2022-09-14 15:19:33 +09:00
  c59aa57450
• Factor out pooling logic from Playfield
  ekrctb · 2022-09-14 15:19:05 +09:00
  a9eba27129
• Fix null considerations in DrawableRulesetDependencies
  Dean Herbert · 2022-09-13 13:13:38 +09:00
  6bf6b7e125
• Fix one more inspection
  Salman Ahmed · 2022-09-13 03:45:31 +03:00
  0ca4be5e5b
• Merge branch 'master' into kps
  Dean Herbert · 2022-09-08 23:00:36 +09:00
  d4afc3629c
• Change FrameStableClock to inherit IGameplayClock
  Dean Herbert · 2022-09-08 18:24:18 +09:00
  6729bb3e1a
• Rename GameplayAdjustments -> AdjustmentsFromMods
  Dan Balasescu · 2022-09-08 17:14:06 +09:00
  b559d4ecdf
• Apply proposed changes to remove inheritance from MasterGameplayClockContainer
  Dean Herbert · 2022-09-07 17:49:05 +09:00
  75d0deef72
• Change NonGameplayAdjustments to GameplayAdjustments and convert TrueGameplayRate to extension method
  Dean Herbert · 2022-09-06 22:26:46 +09:00
  bc1212f4e6
• Use gameplay clock's TrueGameplayRate in FrameStabilityContainer?
  Dean Herbert · 2022-09-05 23:38:22 +09:00
  44b456e216
• Merge branch 'master' into kps
  Dean Herbert · 2022-08-31 15:41:42 +09:00
  7337d4c1aa
• Update usages of RemoveInternal
  Dean Herbert · 2022-08-29 15:57:40 +09:00
  105aa01e7d
• Update Remove/RemoveRange/RemoveAll calls in line with framework changes
  Dean Herbert · 2022-08-29 15:57:40 +09:00
  a215d009fe
• Code cleanup (CPS)
  Ryuki · 2022-08-24 17:13:23 +02:00
  5cddc7ed1f
• Tidy up attach logic
  Dean Herbert · 2022-08-24 19:36:01 +09:00
  f3847b90fd
• Merge branch 'master' into kps
  Dean Herbert · 2022-08-24 18:18:45 +09:00
  5129716612
• Merge branch 'master' into no-gameplay-clock-gameplay-offset
  Dean Herbert · 2022-08-23 17:36:06 +09:00
  ec61a94dc9
• Fix editor crashing on mobile releases
  Dean Herbert · 2022-08-22 15:57:24 +09:00
  19bba143ee
• Merge branch 'master' into kps
  Dean Herbert · 2022-08-20 15:24:58 +09:00
  da407aa827
• Fix `GameplayClockContainer potentially resetting external seeks
  Dean Herbert · 2022-08-18 18:54:10 +09:00
  2c6fd1ec6e
• Merge branch 'even-less-gameplay-clock' into even-nicer-frame-stability-clock
  Dean Herbert · 2022-08-15 20:22:30 +09:00
  43442dbf65
• Fix IsCatchingUp not being in correct state
  Dean Herbert · 2022-08-15 20:17:48 +09:00
  87760bbc06
• Seal FrameStabilityContainer

  No one should ever derive from this class. It is already too complex.

  Dean Herbert · 2022-08-15 19:31:02 +09:00
  1fc3d005c0
• Tidy up and document FrameStabilityContainer
  Dean Herbert · 2022-08-15 19:28:12 +09:00
  fff2b57905
• Fix incorrect handling of reference clocks when no parent IGameplayClock is available
  Dean Herbert · 2022-08-15 19:19:19 +09:00
  9bc2e91de0
• Remove unnecessary setClock shenanigans
  Dean Herbert · 2022-08-15 19:19:19 +09:00
  828b6f2c30
• Remove FrameStableClock (and redirect usages to FrameStabilityContainer)
  Dean Herbert · 2022-08-15 19:19:19 +09:00
  27569e2ed5