1
0
mirror of https://github.com/ppy/osu.git synced 2025-01-21 00:42:54 +08:00
Commit Graph

15637 Commits

Author SHA1 Message Date
Dean Herbert
782ce24ca6
Move player settings out of right flow 2024-11-27 17:09:15 +09:00
Dean Herbert
9c707ed341
Rename class and fix padding considerations 2024-11-27 16:47:54 +09:00
Dean Herbert
5ce55e9cb4
Merge branch 'master' into multi-spectator-settings-sidebar 2024-11-27 16:35:05 +09:00
Dean Herbert
573aaf6637
Merge pull request #27128 from frenzibyte/user-statistics-provider
Introduce `UserStatisticsProvider` component and add support for respecting selected ruleset
2024-11-27 13:13:47 +09:00
Joseph Madamba
9173a74552
Merge branch 'master' into xxx-add-localisation-support-for-menu-tip 2024-11-26 12:13:08 -08:00
Bartłomiej Dach
33c2eb1af7
Merge pull request #30881 from peppy/fix-editor-state-leaking
Fix hitobjects' samples getting in bad state when changing selection between objects
2024-11-26 13:54:50 +01:00
Bartłomiej Dach
3e373ae85e
Merge pull request #30868 from peppy/ur-perf-fix
Improve performance of UR calculations
2024-11-26 13:54:17 +01:00
Dean Herbert
3ecb3b674d
Don't reset state when changing from one selection to another in the editor
This was causing state pollution in the new selection. I can't see why
this needs to happen when a selection changes to another.

This fixes https://github.com/ppy/osu/issues/30839 and also the same
issue happening for the new combo toggle.

Tests all seem to pass, and I can't immediately find anything broken,
but YMMV.
2024-11-26 17:33:41 +09:00
Dean Herbert
e3ea38a366
Add setting to allow hold-for-pause to still exist
Users have asked for this multiple times since last release.

Not sure on the best default value, but I'm going with the
stable/classic one, at least for the initial release to avoid needing
migrations.

In the future we may reconsider this for new users.
2024-11-26 15:14:19 +09:00
Salman Alshamrani
dfa21574fd
Merge branch 'master' into xxx-add-localisation-support-for-menu-tip 2024-11-25 23:52:56 -05:00
Dean Herbert
bbe8f2ec44
Only update unstable rate counter when an applicable hitobject is reached 2024-11-25 21:13:18 +09:00
Dean Herbert
5668258182
Add incremental processing 2024-11-25 21:13:17 +09:00
Dean Herbert
33d725e889
Address unstable rate calculations as a list for marginal gains 2024-11-25 19:44:11 +09:00
Dean Herbert
605fe71f46
Make empty hitwindows readonly static and slightly improve comparison performance 2024-11-25 19:17:32 +09:00
Dean Herbert
82bdd8fbfc
Merge pull request #30861 from frenzibyte/fix-multiplayer-missing-hold-delay
Fix pause shortcut on multiplayer no longer requiring hold
2024-11-25 16:22:56 +09:00
Dean Herbert
876c2e468a
Merge pull request #30858 from frenzibyte/fix-match-settings-overlay-typo 2024-11-25 15:58:17 +09:00
tsrk.
cfaf972813
Merge branch 'master' into xxx-add-localisation-support-for-menu-tip 2024-11-24 18:24:43 +01:00
Dean Herbert
c34827a4ed
Merge pull request #30862 from frenzibyte/dont-scare-the-player
Don't play fail animation if restarting on fail
2024-11-24 23:11:19 +09:00
tsrk.
8611ed31c2
refactor(MenuTip): add localisation support
Signed-off-by: tsrk. <tsrk@tsrk.me>
2024-11-24 14:22:56 +01:00
Dean Herbert
888f02e3a6
Merge pull request #30855 from SupDos/tips-remove-fps
Remove FPS shortcut tip
2024-11-24 19:57:08 +09:00
Salman Alshamrani
6d0d7f3e75 Don't play fail animation if restarting on failure 2024-11-24 04:45:48 -05:00
Salman Alshamrani
f3155bfc7d Fix pause shortcut on multiplayer not delayed 2024-11-24 04:24:31 -05:00
Salman Alshamrani
956da0383f
Merge branch 'master' into multiplayer-remove-expired-item-removal 2024-11-23 22:19:21 -05:00
Salman Alshamrani
8f5d513d46 Fix room auto start duration setting applied to the wrong component 2024-11-23 22:16:29 -05:00
Salman Alshamrani
6b78553559
Merge branch 'master' into tips-remove-fps 2024-11-23 20:57:14 -05:00
SupDos
2f096f71d3 Remove FPS shortcut tip 2024-11-24 02:34:30 +01:00
Salman Alshamrani
608bda135a
Merge branch 'master' into fix-song-ticker-contrast 2024-11-23 20:14:33 -05:00
Salman Alshamrani
2f45ebeec8 Remove using directive 2024-11-23 20:13:57 -05:00
Sheppsu
3713bb48b7 expand and contract settings from hover 2024-11-23 01:09:58 -05:00
Dean Herbert
ce41c000a1
Merge pull request #30812 from smoogipoo/playlist-populate-on-enter
Fix joining playlists room sometimes not selecting the first item
2024-11-22 23:57:45 +09:00
Dean Herbert
04ed954387
Fix song ticker having very bad contrast against bright backgrounds
Closes #30814.
2024-11-22 18:17:55 +09:00
Dan Balasescu
e59ac9e7c8
No longer remove expired playlist items from Room model 2024-11-22 17:19:26 +09:00
Bartłomiej Dach
479ff7eb41
Merge pull request #30799 from peppy/fix-player-loader-focus-fux
Fix beatmap load not continuing when when settings slider is focused
2024-11-22 08:57:10 +01:00
Bartłomiej Dach
512d2c6e3b
Merge branch 'master' into multiplayer-nrt 2024-11-22 08:09:42 +01:00
Dean Herbert
6a0ac4c29e
Merge pull request #29640 from smoogipoo/mania-imperfect-ss
Make mania award SS even if there are GREAT judgements
2024-11-22 14:42:32 +09:00
Dan Balasescu
f738fb2a89
Populate rooms as soon as they're joined 2024-11-21 23:48:04 +09:00
Dan Balasescu
84ac3097c2
Populate parameter description
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2024-11-21 22:47:46 +09:00
Dan Balasescu
cc59434ea4
Fix crash due to being too forgiving of nulls
This one is super duper annoying to test, because we already have e.g.
`TestScenePlaylistsScreen`. The only way to test it would be to use an
`OsuGameTestScene`.

Maybe this is okay?
2024-11-21 20:52:34 +09:00
Dan Balasescu
dc45816566
Fix inspection 2024-11-21 20:41:14 +09:00
Dan Balasescu
6870c99eb2
Enable NRT for multiplayer and playlists 2024-11-21 20:32:09 +09:00
Dean Herbert
ae98f63b51
Fix beatmap load not continuing when when settings slider is focused
Regressed with recent sliderbar focus changes.

Closes #30716.
2024-11-21 02:28:35 +09:00
Fivoka
7726ca02b0 Changed multiplier from 2 to 3.5 2024-11-20 12:29:29 +01:00
Dean Herbert
6fba6de4dc
Merge branch 'master' into multiplayer-remove-cmc-and-composite 2024-11-20 17:24:55 +09:00
Dean Herbert
03de518484
Fix missing updateRoomPlaylist call 2024-11-20 16:56:22 +09:00
Dean Herbert
b070a50ac9
Merge pull request #30718 from frenzibyte/initial-key-counter-state
Fix key counter not updating activation state on initial load
2024-11-20 15:39:44 +09:00
Bartłomiej Dach
273095fd82
Merge pull request #30757 from peppy/fix-scroll-absolute-pos
Fix right click scroll at song select not quite matching scrollbar position
2024-11-19 10:40:00 +01:00
Dean Herbert
a2af4cbb50
Fix right click scroll at song select not quite matching scrollbar position
Closes https://github.com/ppy/osu/issues/30744.
2024-11-18 23:54:56 +09:00
Bartłomiej Dach
259e9ecf65
Deactivate new combo toggle on deselecting objects
Closes https://github.com/ppy/osu/issues/30713.

Was a point of discussion doing review:

	https://github.com/ppy/osu/pull/30214#discussion_r1798833139

Given it got pointed out immediately for something so minor, I'm
inclined to believe it's a rather undesirable change.
2024-11-18 15:13:32 +01:00
Sheppsu
7d4062d2ad remove redundant Scale attribute 2024-11-18 04:04:28 -05:00
Sheppsu
29e7adcd3b add player settings to multi spectator screen 2024-11-18 03:57:50 -05:00