66454 Commits

This Branch

This Branch

All Branches

• Fix getting slider head drops
  Fina · 2024-04-19 16:04:17 -07:00
  77814ec69f
• Add bool useSliderHead
  Fina · 2024-04-19 16:03:46 -07:00
  ca246015d5
• removed large tick misses from effectivemisscount
  Fina · 2024-04-11 19:07:48 -07:00
  dd17c898b3
• Cap Buzz Slider Related Misses

  After letting the comments @Flamiii left brew for a while, I realized they were very much right about the buzz slider thing. As such, I've implemented a quick and dirty untested fix that will hopefully have zero unintended side-effects :)
  
  I don't see this as a permanent or final solution yet. There's definitely some potential issues/inaccuracies that could arise with maps like Notch Hell or IOException's Black Rover, but afaik this implementation would not cause any issues that stable doesn't already have.

  Fina · 2024-04-10 20:31:52 -07:00
  2dd49036ed
• Merge branch 'estimation-removal' of https://github.com/Finadoggie/osu into estimation-removal
  Fina · 2024-03-23 14:43:31 -07:00
  c24f99ed5f
• Use sliderend data for all non-legacy scores

  As per suggestion by givikap, I was not aware that non-legacy cl scores stored this data

  Fina · 2024-03-23 14:43:26 -07:00
  58bc184e0a
• Merge branch 'master' into estimation-removal
  Fina · 2024-03-23 14:27:33 -07:00
  4f5f0e5b38
• Merge pull request #27692 from bdach/artist-sort-uses-title-as-tiebreaker

  Use title as tiebreaker when sorting beatmap carousel by artist

  Dan Balasescu · 2024-03-22 17:15:40 +09:00
  77660e57ea
• Use title as tiebreaker when sorting beatmap carousel by artist

  Closes https://github.com/ppy/osu/issues/27548.
  
  Reference: https://github.com/peppy/osu-stable-reference/blob/e53980dd76857ee899f66ce519ba1597e7874f28/osu!/GameplayElements/Beatmaps/BeatmapTreeManager.cs#L341-L347

  Bartłomiej Dach · 2024-03-22 08:41:10 +01:00
  a1880e89c2
• Add failing test case for desired artist sort behaviour
  Bartłomiej Dach · 2024-03-22 08:41:08 +01:00
  e2df098184
• Add slider ticks and reverse arrows to effective misscount

  Very much open to discussion on if these should be weighed differently

  Fina · 2024-03-21 23:49:54 -07:00
  6fe478c865
• Update OsuPerformanceCalculator.cs
  Fina · 2024-03-21 23:31:45 -07:00
  b0d20e68ae
• Merge pull request #2 from Finadoggie/dropped-tail-fix

  Use actual sliderends dropped instead of estimating

  Fina · 2024-03-21 23:29:53 -07:00
  c9e3c10841
• Merge branch 'estimation-removal' into dropped-tail-fix
  Fina · 2024-03-21 23:29:45 -07:00
  eb30b4aa38
• Merge pull request #1 from Finadoggie/miss-count-fix

  Miss count fix

  Fina · 2024-03-21 23:28:15 -07:00
  12afa8d654
• Use miss count for effective miss count

  No need to estimate misses for non-CL scores.

  Fina · 2024-03-21 23:24:37 -07:00
  840845527f
• Revert "Make length bonus account for sliders, use proper misscount for classic"

  This reverts commit 941c0487a4.

  Fina · 2024-03-21 23:17:10 -07:00
  3dafdc01bb
• Use actual sliderends dropped instead of estimating

  Score data for non-CL scores includes sliderends dropped, meaning no need to estimate.
  
  CL scores are still estimated.

  Fina · 2024-03-21 23:15:36 -07:00
  4db6f288d3
• Merge pull request #27418 from huoyaoyuan/convert-path-string-new

  Make slider path parsing more friendly with spans

  Salman Ahmed · 2024-03-22 05:35:20 +03:00
  b9b9ef671e
• Merge branch 'master' into convert-path-string-new
  Salman Ahmed · 2024-03-22 05:15:04 +03:00
  1efa08a1b8
• Make length bonus account for sliders, use proper misscount for classic
  Fina · 2024-03-21 19:02:36 -07:00
  941c0487a4
• Merge pull request #26937 from frenzibyte/fix-osu-logo-blocking-load

  Stop blocking player load when hovering over osu! logo

  Dean Herbert · 2024-03-21 21:52:25 +08:00
  970e45ff24
• Merge pull request #27639 from 64ArthurAraujo/verify-unused-audio-at-end

  Add verify checks to unused audio at the end

  Bartłomiej Dach · 2024-03-21 12:19:53 +01:00
  3e764ae4f0
• Merge pull request #27677 from smoogipoo/fix-catch-banana-fail

  Fix catch banana shower judgement causing fail when at 0 HP

  Bartłomiej Dach · 2024-03-21 11:23:51 +01:00
  983385bafc
• Merge pull request #27681 from smoogipoo/add-deployed-build-attribute

  Warn about not using an official "deployed" build

  Dean Herbert · 2024-03-21 14:13:40 +08:00
  c081cc7d77
• Adjust text slightly
  Dean Herbert · 2024-03-21 13:06:25 +08:00
  b99b0337cf
• Merge pull request #27079 from smoogipoo/tcm-resume

  Add delayed resume for taiko/catch/mania

  Dean Herbert · 2024-03-21 12:48:53 +08:00
  0589924dc6
• Merge pull request #27676 from bdach/add-logging-on-metadata-discard

  Add extended logging when discarding online metadata lookup results

  Dean Herbert · 2024-03-21 12:23:19 +08:00
  ef693ffbb6
• Add sounds to countdown
  Dean Herbert · 2024-03-21 11:45:48 +08:00
  55d66d4615
• Update resources
  Dean Herbert · 2024-03-21 11:42:22 +08:00
  a07d5115bf
• Warn about not using an official "deployed" build
  Dan Balasescu · 2024-03-21 00:47:45 +09:00
  ac7fca10d6
• Fix banana showers causing fails when hp is at 0
  Dan Balasescu · 2024-03-20 17:31:33 +09:00
  bf5640049a
• Add test for banana shower fail
  Dan Balasescu · 2024-03-20 17:31:11 +09:00
  66ace02e58
• Fix infinite health processor loop when no top-level objects

  This is unlikely to occur in actual gameplay, but occurs in the
  follow-up test.

  Dan Balasescu · 2024-03-20 17:30:37 +09:00
  c78e203df5
• Add extended logging when discarding online metadata lookup results

  Related to: https://github.com/ppy/osu/issues/27674
  
  Relevant log output for that particular case:
  
  	[network] 2024-03-20 07:25:30 [verbose]: Performing request osu.Game.Online.API.Requests.GetBeatmapRequest
  	[network] 2024-03-20 07:25:30 [verbose]: Request to https://dev.ppy.sh/api/v2/beatmaps/lookup successfully completed!
  	[network] 2024-03-20 07:25:30 [verbose]: GetBeatmapRequest finished with response size of 3,170 bytes
  	[database] 2024-03-20 07:25:30 [verbose]: [4fe02] [APIBeatmapMetadataSource] Online retrieval mapped Tsukiyama Sae - Hana Saku Iro wa Koi no Gotoshi (Log Off Now) [Destiny] to 744883 / 1613507.
  	[database] 2024-03-20 07:25:30 [verbose]: Discarding metadata lookup result due to mismatching online ID (expected: 1570982 actual: 1613507)
  	[network] 2024-03-20 07:25:30 [verbose]: Performing request osu.Game.Online.API.Requests.GetBeatmapRequest
  	[network] 2024-03-20 07:25:30 [verbose]: Request to https://dev.ppy.sh/api/v2/beatmaps/lookup successfully completed!
  	[network] 2024-03-20 07:25:30 [verbose]: GetBeatmapRequest finished with response size of 2,924 bytes
  	[database] 2024-03-20 07:25:30 [verbose]: [4fe02] [APIBeatmapMetadataSource] Online retrieval mapped Tsukiyama Sae - Hana Saku Iro wa Koi no Gotoshi (Log Off Now) [Easy] to 744883 / 1570982.
  	[database] 2024-03-20 07:25:30 [verbose]: Discarding metadata lookup result due to mismatching online ID (expected: 1613507 actual: 1570982)
  
  Note that the online IDs are swapped.

  Bartłomiej Dach · 2024-03-20 08:28:11 +01:00
  1f343b7545
• Merge pull request #27675 from peppy/remove-breadcrumb-control

  Remove unused `ScreenBreadcrumbControl`

  Bartłomiej Dach · 2024-03-20 08:02:36 +01:00
  8ee391530f
• Merge pull request #27630 from EVAST9919/editor-performance

  Improve editor performance for maps with many control points

  Dean Herbert · 2024-03-20 13:20:21 +08:00
  1f70019009
• Merge branch 'master' into remove-breadcrumb-control
  Salman Ahmed · 2024-03-20 08:11:03 +03:00
  0d6daef42b
• Merge pull request #27443 from jvyden/discord-rpc-invites

  Support Discord game invites in multiplayer lobbies

  Salman Ahmed · 2024-03-20 08:05:53 +03:00
  773daee50b
• Adjust code structure slightly
  Dean Herbert · 2024-03-20 12:52:54 +08:00
  fd509c82f5
• Use DI correctly
  Salman Ahmed · 2024-03-20 07:36:15 +03:00
  5f86b5a2fa
• Organise code, still hook up to RoomChanged to update room privacy mode, and use SkipIdenticalPresence + scheduling to avoid potential rate-limits
  Salman Ahmed · 2024-03-20 07:28:01 +03:00
  b11ae1c571
• Remove unused ScreenBreadcrumbControl

  See https://github.com/ppy/osu-framework/pull/6218#discussion_r1529932798.

  Dean Herbert · 2024-03-20 12:10:05 +08:00
  d83a53fc94
• Fix code style
  jvyden · 2024-03-19 17:03:30 -04:00
  1a08dbaa2b
• Show login overlay when joining room while not logged in
  jvyden · 2024-03-19 16:15:22 -04:00
  4305c3db5b
• Improve logging of RPC

  Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>

  jvyden · 2024-03-19 16:05:13 -04:00
  c71daba4f6
• Move room code from activity code, prevent duplicate RPC updates
  jvyden · 2024-03-19 16:03:37 -04:00
  0ecfa580d7
• Prevent potential threading issues
  jvyden · 2024-03-19 16:02:06 -04:00
  808d6e0943
• Merge branch 'master' into discord-rpc-invites
  jvyden · 2024-03-19 15:29:52 -04:00
  f851716a47
• Document GetLastObjectTime() exception on empty beatmap
  Bartłomiej Dach · 2024-03-19 19:19:07 +01:00
  e4418547fe