2659 Commits

• Merge pull request #32357 from Nunolin/mania-invert-end-notes

  Remove end note conversion in mania invert mod (causing unwanted jacks)

  Dan Balasescu · 2025-03-13 21:54:00 +09:00
  01828931a2
• Merge pull request #32344 from frenzibyte/mania-judgement-position-fix

  Improve handling for top-anchored judgement positions in osu!mania

  Dean Herbert · 2025-03-13 12:48:44 +09:00
  02579dc0a4
• Remove end note conversion in mania invert mod
  Nuno · 2025-03-13 01:02:34 +00:00
  a075a5641a
• Merge branch 'master' into mania-bring-back-touch-controls
  Dean Herbert · 2025-03-12 18:42:39 +09:00
  007198fd98
• Remove unused thing
  Dean Herbert · 2025-03-12 18:36:02 +09:00
  92d374a5bb
• Fix weird implementation of layout validation
  Dean Herbert · 2025-03-12 18:34:33 +09:00
  70693c8bb8
• Improve handling for top-anchored judgement positions in osu!mania
  Salman Alshamrani · 2025-03-12 03:05:10 -04:00
  5a5246a407
• Fix touch input area not handling settings changes
  Salman Alshamrani · 2025-03-11 09:17:19 -04:00
  b3ea63598e
• Apply suggested renames
  Salman Alshamrani · 2025-03-11 09:06:01 -04:00
  b64e69d581
• Add draw size invalidation handling to column extension logic

  Also indirectly makes the setting effective during gameplay as requested.

  Salman Alshamrani · 2025-03-11 08:28:24 -04:00
  2af3bebff3
• Fix multiple code inspections
  Dean Herbert · 2025-03-11 17:23:09 +09:00
  4565c271dd
• Fix failing tests
  Salman Alshamrani · 2025-03-10 22:40:24 -04:00
  d5e06102d4
• Fix code quality error
  Salman Alshamrani · 2025-03-10 06:49:52 -04:00
  905afd5714
• Replace toggles with a single dropdown
  Salman Alshamrani · 2025-03-10 04:45:32 -04:00
  857b8637ae
• Bring back mobile landscape column extension logic under a setting
  Salman Alshamrani · 2025-03-10 04:45:32 -04:00
  1f749250ac
• Bring back touch control under a setting
  Salman Alshamrani · 2025-03-10 03:48:45 -04:00
  edcc607f4b
• Hook up portarit setting with behaviour
  Salman Alshamrani · 2025-03-10 03:47:51 -04:00
  918e248cd2
• Add config settings for mania mobile modes
  Salman Alshamrani · 2025-03-10 03:47:06 -04:00
  3cf0031e16
• Add "discard unsaved changes" operation to beatmap editor

  Apparently useful in modding workflows when you want to test out a few
  different variants of a thing.
  
  Re-uses `Ctrl-L` binding from stable. Some folks may argue that the
  dialog makes the hotkey pointless, but I really do want to protect
  users from accidental data loss, and also if you want to power through
  it quickly, you can hit the 1 key when the dialog shows, which will
  bypass the hold-to-activate period (which wasn't intentional, but so
  many people want a bypass at this point that we're probably keeping that
  behaviour for power users).

  Bartłomiej Dach · 2025-03-05 14:34:44 +01:00
  3f461c0734
• Add support for legacy osu!mania barline height and colour spec
  Dean Herbert · 2025-02-28 15:13:13 +09:00
  cb29459a1e
• Add basic setup for mania legacy barline implementation
  Dean Herbert · 2025-02-28 14:43:00 +09:00
  3e8dafa3c5
• Merge branch 'master' into pp-dev
  Dean Herbert · 2025-02-17 11:59:14 +09:00
  ab88ccb081
• Flip the Y offset of skin judgement pieces on flipped scroll direction
  Salman Alshamrani · 2025-02-10 01:52:50 -05:00
  1e06c5cc4a
• Flip mania judgement anchor on flipped scroll direction
  Salman Alshamrani · 2025-02-10 01:52:12 -05:00
  a3cd62ec72
• Calculate hit windows in performance calculator instead of databased difficulty attributes (#31735)

  * Calculate hit windows in performance calculator instead of databased difficulty attributes
  
  * Apply mods to beatmap difficulty in osu! performance calculator
  
  * Remove `GreatHitWindow` difficulty attribute for osu!mania
  
  * Remove use of approach rate and overall difficulty attributes for osu!
  
  * Remove use of hit window difficulty attributes in osu!taiko
  
  * Remove use of approach rate attribute in osu!catch
  
  * Remove unused attribute IDs
  
  * Code quality
  
  * Fix `computeDeviationUpperBound` being called before `greatHitWindow` is set

  James Wilson · 2025-02-07 19:21:12 +09:00
  9f90ebb2f7
• Merge branch 'master' into pp-dev
  Dean Herbert · 2025-02-07 14:09:25 +09:00
  6c069b3373
• Merge pull request #31368 from frenzibyte/mobile-fix-mania

  Improve osu!mania playability on mobile devices

  Dean Herbert · 2025-02-01 14:49:46 +09:00
  cf3a379b1c
• Remove pointless comment
  Dean Herbert · 2025-02-01 14:48:13 +09:00
  cc3bb590c9
• Enable NRT on Column
  Salman Alshamrani · 2025-01-30 08:22:35 -05:00
  64b67252a2
• Fix skin SourceChanged event never being unbound
  Dean Herbert · 2025-01-29 18:16:04 +09:00
  e8d20fb402
• Avoid extra unnecessary DI

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Salman Alshamrani · 2025-01-25 19:12:42 -05:00
  ffc37cece0
• Revert unnecessary inheritance

  Everyone is right, too much inheritance and polymorphism backfires very badly.

  Salman Alshamrani · 2025-01-25 19:12:37 -05:00
  8151c3095d
• Refactor further to avoid weird non-virtual common method
  Bartłomiej Dach · 2025-01-24 13:14:31 +01:00
  daec91f61d
• Remove dependence of placement blueprints on IPositionSnapProvider
  Bartłomiej Dach · 2025-01-24 11:59:07 +01:00
  a6987f5c95
• Remove dependence of blueprint containers on IPositionSnapProvider
  Bartłomiej Dach · 2025-01-24 11:59:05 +01:00
  15b6e28ebe
• Merge branch 'master' into mobile-fix-mania
  Dean Herbert · 2025-01-24 17:03:00 +09:00
  56a611b47e
• Reapply "Fix triangles judgement mispositioned on a miss"

  This reverts commit 6ec718304e.

  Salman Alshamrani · 2025-01-21 05:45:37 -05:00
  b63d94101c
• Revert "Fix triangles judgement mispositioned on a miss"

  This reverts commit e5713e5239.

  Salman Alshamrani · 2025-01-21 04:58:27 -05:00
  6ec718304e
• Merge pull request #31527 from bdach/spectator-list-ready

  Show spectating users during gameplay

  Dan Balasescu · 2025-01-21 18:54:11 +09:00
  8f8246278a
• Merge branch 'master' into pp-dev
  Dean Herbert · 2025-01-21 13:19:01 +09:00
  aeca37c230
• Replace indexed skill access with skills.OfType<...>().Single() (#30034)

  * Replace indexed skill access with `skills.First(s is ...)`
  
  * Fix comment
  
  * Further refactoring to remove casts
  
  ---------
  
  Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>
  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  StanR · 2025-01-20 09:39:35 +00:00
  22e839d62b
• Remove redundant ToArray() calls in Osu/ManiaHitObjectComposer
  Berkan Diler · 2025-01-19 23:27:44 +01:00
  b6ce72b6d9
• Merge spectator list classes into one skinnable
  Bartłomiej Dach · 2025-01-17 11:23:14 +01:00
  3c4bfc0a01
• Add skinnable spectator list to default skins
  Bartłomiej Dach · 2025-01-15 14:29:53 +01:00
  99c7e164dc
• Fix failing tests

  - Caches `DrawableRuleset` in editor compose screen for mania playfield adjustment container (because it's used to wrap the blueprint container as well)
  - Fixes `ManiaModWithPlayfieldCover` performing a no-longer-correct direct cast with a naive-but-working approach.

  Salman Alshamrani · 2025-01-12 22:56:40 -05:00
  c1ac27d658
• Merge branch 'master' into mobile-fix-mania
  Salman Alshamrani · 2025-01-12 02:00:49 -05:00
  f121b03a78
• Fix DrawableManiaRuleset not cached as itself in subtypes

  i.e. editor mania ruleset

  Salman Alshamrani · 2025-01-04 02:36:06 -05:00
  a241d1f503
• Fix triangles judgement mispositioned on a miss

  Similar to mania's `ArgonJudgementPiece`.

  Salman Alshamrani · 2024-12-31 21:31:54 -05:00
  e5713e5239
• Simplify portrait check
  Salman Alshamrani · 2024-12-31 20:01:21 -05:00
  64e557d00f
• Replace ManiaTouchInputArea with touchable columns
  Salman Alshamrani · 2024-12-31 12:28:04 -05:00
  bea61d2483