Salman Ahmed
6fb9eb8b33
Move legacy beatmap combo offset to osu! processor
...
Better suited there, I intiailly wanted the whole legacy interface to reside in `osu.Game.Rulesets.Osu` but it's required in `ConvertHitObjectParser` and that's in the main game project, so had to leave the interface as-is for now.
2021-05-05 14:24:14 +03:00
Salman Ahmed
bf6e98345c
Remove and update pre-existing test cases
2021-05-05 14:23:18 +03:00
Salman Ahmed
71d3b44c78
Add test coverage for legacy beatmap combo offsets
2021-05-05 09:22:19 +03:00
Salman Ahmed
4cdfdcaddf
Expand the combo colours used for testing
...
To avoid potential false positive.
2021-05-05 09:22:01 +03:00
Salman Ahmed
fda6d8685c
Let LegacyBeatmapSkinColourTest inherit from TestPlayer instead
2021-05-05 09:21:09 +03:00
Salman Ahmed
51ff59242d
Use legacy beatmap combo indices for legacy beatmap skins
2021-05-05 07:43:25 +03:00
Salman Ahmed
cd6d070b4a
Consider "combo offsets" as legacy logic and separate from combo information
2021-05-05 07:43:08 +03:00
Salman Ahmed
eeeb001d62
Refactor combo colour retrieval logic to request skin lookups instead
2021-05-05 07:17:27 +03:00
Salman Ahmed
78794935b4
Handle combo colour lookups in other skins
2021-05-05 07:15:11 +03:00
Salman Ahmed
9be8d3f0d2
Add overridable combo colour retrieval method and handle in legacy skin
2021-05-05 07:15:07 +03:00
Salman Ahmed
f95744170f
Add skin config lookup for combo colours
2021-05-05 07:06:26 +03:00
Bartłomiej Dach
9710842217
Merge pull request #12669 from peppy/fix-selection-handler-visibility
2021-05-04 20:59:37 +02:00
Bartłomiej Dach
4185053120
Merge branch 'master' into fix-selection-handler-visibility
2021-05-04 20:21:05 +02:00
Dan Balasescu
f2f41545f8
Merge pull request #12667 from peppy/fix-editor-threading-failure
...
Remove unsafe access to Composer.HitObjects
2021-05-04 16:36:50 +09:00
Dan Balasescu
9b8840e76e
Merge pull request #12668 from peppy/fix-xmldoc-typo
...
Fix use of non-existent word in `OsuFocusedOverlayContainer` xmldoc
2021-05-04 16:27:15 +09:00
Dean Herbert
b28e1569ca
Remove no-longer-relevant matching comment
2021-05-03 20:09:50 +09:00
Dean Herbert
3268a75f05
Remove intermediate container to fix tests
2021-05-03 17:35:56 +09:00
Dean Herbert
839ac968a9
Fix tooltips displaying for hidden SelectionHandler content
2021-05-03 17:28:24 +09:00
Dean Herbert
3dd4b7b746
Fix use of non-existent word in OsuFocusedOverlayContainer xmldoc
2021-05-03 15:08:34 +09:00
Dean Herbert
8c9cfb6301
Remove unsafe access to Composer.HitObjects
2021-05-03 14:28:35 +09:00
Dean Herbert
d8d2c731ee
Merge pull request #12663 from Joehuu/fix-profile-subsection-counters
2021-05-03 12:15:28 +09:00
Joseph Madamba
cc056088bd
Update profile subsections to use counters instead of missing text in line with web
2021-05-02 14:44:20 -07:00
Joseph Madamba
3e74d61dab
Add best count from api
2021-05-02 13:33:25 -07:00
Joseph Madamba
59cb5f4679
Get recent count from api instead
2021-05-02 13:33:25 -07:00
Dean Herbert
d6f2e0defb
Merge pull request #12656 from frenzibyte/revert-humanizer-bump
...
Downgrade Humanizer back to 2.8.26
2021-05-02 18:13:38 +09:00
Salman Ahmed
3aa18e19c9
Revert "Bump Humanizer from 2.8.26 to 2.9.9"
...
This reverts commit 1e7feff49d
2021-05-02 11:30:44 +03:00
Dean Herbert
a8db63498a
Merge pull request #12650 from frenzibyte/selection-box-use-aabb
...
Compute selection box area using the bounding box of the blueprints instead
2021-05-02 13:30:01 +09:00
Dean Herbert
2e24b69d62
Merge pull request #12617 from Joehuu/fix-pp-column-approved-maps
...
Fix approved maps not displaying pp column on score table
2021-05-02 13:27:39 +09:00
Salman Ahmed
b83aa0bd76
Avoid LINQ in update
2021-05-02 06:21:14 +03:00
Salman Ahmed
0aa17e7c95
Rewrite selection box computation logic with RectangleF's helper methods
2021-05-02 02:51:06 +03:00
Salman Ahmed
07fe99025f
Use bounding box of blueprint for computing selection box area
2021-05-02 02:36:40 +03:00
Joseph Madamba
137be5dc97
Use equality operator instead of null coalescing
...
Co-Authored-By: Salman Ahmed <frenzibyte@gmail.com>
2021-05-01 14:14:07 -07:00
Dean Herbert
05e18e3ee3
Merge pull request #12558 from JustusFT/justusft/mania-color-snap
...
Add snap color option for osu!mania
2021-05-01 23:52:54 +09:00
Dean Herbert
a551958eeb
Move caching of IBeatmap to base DrawableRuleset
2021-05-01 21:32:45 +09:00
Dean Herbert
db815f7930
Tidy up implementation in DrawableNote
2021-05-01 20:39:10 +09:00
Justus Franklin Tumacder
0b06c5bcb1
Remove unneeded test data
2021-05-01 15:00:18 +08:00
Justus Franklin Tumacder
0d077b7a5d
Fix GetClosestBeatDivisor returning the wrong divisor
2021-05-01 14:13:42 +08:00
Justus Franklin Tumacder
fdf8c12947
Replace BeatDivisorFinder with GetClosestBeatDivisor
2021-05-01 11:57:47 +08:00
Justus Franklin Tumacder
ecb053b0de
Merge branch 'master' of https://github.com/ppy/osu into justusft/mania-color-snap
2021-05-01 11:20:28 +08:00
Dean Herbert
cbc7753f23
Merge pull request #12564 from Joehuu/fix-beatmap-info-download-button-content-scaling
...
Fix beatmap info download button content not scaling on mouse down
2021-05-01 10:43:59 +09:00
Bartłomiej Dach
bb6f28d76b
Merge pull request #12632 from EVAST9919/barrel-roll
2021-04-30 23:03:56 +02:00
Bartłomiej Dach
9cb55ca245
Merge branch 'master' into barrel-roll
2021-04-30 22:27:27 +02:00
Bartłomiej Dach
0d1a89cb60
Merge pull request #12634 from peppy/remove-unused-triangles
2021-04-30 22:26:29 +02:00
Bartłomiej Dach
eef135f8dc
Merge branch 'master' into remove-unused-triangles
2021-04-30 21:51:23 +02:00
Joseph Madamba
786ab163f6
Rename extension and move to bottom of file
2021-04-30 12:40:16 -07:00
Dan Balasescu
34a8a75f07
Merge pull request #12588 from Naxesss/basic-compose-checks
...
Add unsnapped and concurrent object checks
2021-05-01 00:20:02 +09:00
Dan Balasescu
e6eea73b8b
Merge branch 'master' into basic-compose-checks
2021-04-30 23:41:46 +09:00
Dan Balasescu
872c52b35f
Merge pull request #12625 from peppy/simpler-editor-move-events
...
Refactor `SelectionBlueprint` and `MoveSelectionEvent` to work in screen-space coordinates
2021-04-30 19:37:31 +09:00
Dan Balasescu
c303043841
Merge branch 'master' into simpler-editor-move-events
2021-04-30 18:55:39 +09:00
Dan Balasescu
5285b71ecb
Merge pull request #12596 from peppy/abstract-blueprint-handling
...
Make editor blueprint/selection components abstract
2021-04-30 18:55:20 +09:00
