ekrctb
6d18b3db00
Avoid empty list allocation
2021-04-12 18:49:38 +09:00
ekrctb
f1b8171e38
Remove #nullable true for now to suppress inspector
2021-04-12 17:13:48 +09:00
ekrctb
3c28c09ab5
Add more FramedReplayInputHandler tests
2021-04-12 16:18:35 +09:00
ekrctb
e19e8ff2a3
Rewrite FramedReplayInputHandler for robustness
...
This commit changes the semantics of `CurrentFrame` and `NextFrame` of the class.
The ordering of `NextFrame.Time` and `CurrentFrame.Time` was dependent on the current direction.
Now, it should always satisfy `CurrentFrame.Time <= CurrentTime <= NextFrame.Time` except at the start/end.
This change, however, doesn't break existing deriving classes if the template code pattern usage of interpolation is used.
The deriving class code can be simplified due to the elimination of nullable types. I didn't include those changes in this commit.
I removed `StreamingFramedReplayInputHandlerTest` for now, as it is almost-duplicate of `FramedReplayInputHandlerTest`. I'll include more tests in later commits.
This commit fixes #6150 .
2021-04-12 16:18:11 +09:00
ekrctb
d6d8ea5b6b
Throw when getting a frame of an empty replay
2021-04-12 11:17:56 +09:00
Dean Herbert
4853ac802c
Merge pull request #12367 from Joehuu/lazy-flashlight
...
Add follow delay setting to osu! flashlight mod
2021-04-11 19:07:06 +09:00
Joseph Madamba
a42714540b
Add follow delay setting to osu! flashlight mod
2021-04-10 23:04:15 -07:00
Dean Herbert
ab49e84d17
Merge pull request #12356 from peppy/update-framework
...
Update framework
2021-04-10 03:34:24 +09:00
Dean Herbert
b66ef2fdec
Update framework
2021-04-10 02:14:28 +09:00
Dean Herbert
dfe3240b45
Merge pull request #12353 from nekodex/songselect-hoversamples
...
Add a hover sample type for SongSelect buttons
2021-04-10 01:45:47 +09:00
Dan Balasescu
9aa30fb323
Merge pull request #11688 from Syriiin/diffcalc/dynamic-history
...
Implement dynamic previous hitobject retention for Skill class
2021-04-10 01:25:07 +09:00
Dean Herbert
affc878db9
Update resources
2021-04-10 01:03:15 +09:00
Samuel Cattini-Schultz
bfd3d0cce9
Implement custom enumerator for ReverseQueue to avoid allocations
2021-04-10 01:16:54 +10:00
Dean Herbert
8bd972c525
Merge pull request #12354 from nekodex/reduce-sample-pitch-randomisation
...
Reduce the randomised pitch range of hover sounds
2021-04-09 23:43:51 +09:00
Jamie Taylor
ffacd38e57
Reduce the randomised pitch range of hover sounds
2021-04-09 23:03:14 +09:00
Jamie Taylor
8a0da06e89
Add a hover sample type for SongSelect buttons
2021-04-09 23:00:40 +09:00
Dean Herbert
cceb10cc85
Merge pull request #12337 from Naxesss/slider-path-segments
...
Improve UX of correcting invalid slider path types
2021-04-09 19:26:49 +09:00
Dean Herbert
c0837b1c88
Merge pull request #12340 from smoogipoo/add-slider-whistle
...
Add support for sliderwhistle
2021-04-09 18:12:46 +09:00
Naxess
f64b2095bf
Carry over the previous path type
2021-04-09 11:04:00 +02:00
Naxess
0af6d77192
Test for path type transfer
2021-04-09 11:03:38 +02:00
Dean Herbert
1dbc7e821e
Merge branch 'master' into add-slider-whistle
2021-04-09 17:11:48 +09:00
Dean Herbert
9b16e1c38d
Merge pull request #12349 from ekrctb/fix-catch-replay-delay-alternative
...
Fix catcher position update delayed one frame (alternative solution)
2021-04-09 16:44:02 +09:00
ekrctb
6d0dc62502
Make sure latest catcher position is used for catching logic
...
A replay frame processed in CatchInputManager is applied to catcher in `CatcherArea`.
The catcher position is then used for the catching logic for each hit object under `HitObjectContainer`.
Thus, if `HitObjectContainer` came before `CatcherArea`, the replay input is delayed one frame.
That was one reason why the catch autoplay misses hit objects (especially when fast-forwarded).
2021-04-09 16:04:45 +09:00
ekrctb
b10ee7482d
Add a failing test to check catch replay accuracy
2021-04-09 15:58:23 +09:00
Dan Balasescu
e3c75cd4aa
Merge pull request #12348 from peppy/fix-score-submission-ruleset-id-missing
...
Fix scores not being accepted due to missing ruleset ID
2021-04-09 15:54:19 +09:00
smoogipoo
9b0ce2999f
Fix legacy encoder
2021-04-09 15:28:42 +09:00
smoogipoo
f2e811928b
Rework slider hackery to not overwrite Samples
2021-04-09 15:28:08 +09:00
Dean Herbert
51fee79ef1
Fix scores not being accepted due to missing ruleset ID
2021-04-09 15:18:02 +09:00
Dean Herbert
a4b4033bf0
Merge pull request #12347 from smoogipoo/remove-obsoletes
...
Remove obsolete code
2021-04-09 14:44:33 +09:00
smoogipoo
9490786d09
Merge branch 'master' into add-slider-whistle
2021-04-09 14:19:16 +09:00
smoogipoo
76981f2547
Remove unused using
2021-04-09 13:58:24 +09:00
smoogipoo
8293b06c0a
Remove obsolete code
2021-04-09 13:56:58 +09:00
Dan Balasescu
e89b962bd3
Merge pull request #12344 from peppy/fix-solo-score-api-routes
...
Fix slightly incorrect solo score submission routes
2021-04-08 23:55:16 +09:00
Dan Balasescu
d1b680365c
Merge pull request #12343 from peppy/update-rider-metadata
...
Update rider metadata files for 2021.1
2021-04-08 23:53:10 +09:00
Dean Herbert
5dd6f19ec5
Update rider metadata files for 2021.1
2021-04-08 23:15:34 +09:00
Dean Herbert
24ae5b9169
Fix slightly incorrect solo score submission routes
2021-04-08 23:15:08 +09:00
smoogipoo
8efa381d3a
Actually use whistle sample for sliderwhistle
2021-04-08 23:13:16 +09:00
Dan Balasescu
7e1739812d
Merge branch 'master' into add-slider-whistle
2021-04-08 22:23:50 +09:00
Dan Balasescu
0f38436aaa
Merge pull request #12342 from smoogipoo/fix-test-failure
...
Fix intermittent test failure
2021-04-08 22:23:37 +09:00
smoogipoo
70cd018a98
Fix intermittent test failure
2021-04-08 21:38:58 +09:00
smoogipoo
7d291ed7d7
Don't serialise OriginalSamples
2021-04-08 20:57:50 +09:00
smoogipoo
7713c8a45f
Add support for sliderwhistle
2021-04-08 20:20:09 +09:00
Naxess
2d94484566
Use lambda expression
...
Apparently CI dislikes this not being a lambda.
2021-04-08 12:49:46 +02:00
Dean Herbert
1e23f671fa
Merge pull request #12321 from smoogipoo/add-spectate-button-and-state
...
Add multiplayer spectating user state and button
2021-04-08 19:48:58 +09:00
Naxess
9a675a2219
Correct 4+ point perfect curves to Bezier
2021-04-08 12:33:43 +02:00
Naxess
7d2b54ca42
Add change to Bezier test
2021-04-08 12:32:45 +02:00
Naxess
4110d1675d
Add path type menu test cases
2021-04-08 11:46:52 +02:00
Naxess
be4520fe33
Fix index out of range possibility
2021-04-08 11:46:00 +02:00
Dan Balasescu
52f8358bff
Merge pull request #12334 from peppy/fix-song-select-absolute-scroll
...
Fix regressions caused by having nested global input manager
2021-04-08 18:11:46 +09:00
smoogipoo
fd2a14a0bf
Only set button state once
2021-04-08 16:31:40 +09:00
