Robin Avery
|
6c9594ee35
|
Simplify and rearrange SkinSelectionHandler
The file has been restructured and reworded such that there are as few
differences as possible from b36b40cb34.
|
2021-06-07 02:40:15 -04:00 |
|
Robin Avery
|
29fa4fdf57
|
Refactor unacceptable syntax
|
2021-06-07 01:08:39 -04:00 |
|
Robin Avery
|
133d72a8c0
|
Rename UsingClosestAnchor
It is now "OverridesClosestAnchor". The logic is inverted accordingly.
|
2021-06-07 00:14:36 -04:00 |
|
Robin Avery
|
f28916e30f
|
Remove all UsingClosestAnchor() extension logic
It is replaced with ISkinnableDrawable.UsingClosestAnchor.
|
2021-06-07 00:04:53 -04:00 |
|
Robin Avery
|
ce635af83e
|
Add UsingClosestAnchor to ISkinnableDrawable
Also implement it as an auto property in its inheritors.
The auto properties default to true.
|
2021-06-06 23:47:47 -04:00 |
|
Robin Avery
|
6a456e53f4
|
Rename overly long method
|
2021-06-06 13:28:17 -04:00 |
|
Robin Avery
|
888882ac63
|
Remove first-person comment
|
2021-06-06 13:27:13 -04:00 |
|
Robin Avery
|
da1c38d5a9
|
Uninvert logic of SkinnableInfo.UsingClosestAnchor
Also rename "IsUsingClosestAnchor" to simply "UsingClosestAnchor".
|
2021-06-06 10:13:35 -04:00 |
|
Robin Avery
|
63346f6b75
|
Refactor getTieredComponent
|
2021-06-06 09:40:58 -04:00 |
|
Robin Avery
|
c9f5808bf2
|
Move lookup logic to DrawableExtensions
This is now a global lookup to be shared by serialization and editor.
|
2021-06-06 06:58:21 -04:00 |
|
Robin Avery
|
4aee76456f
|
Replace localised strings with static English
|
2021-06-06 05:34:32 -04:00 |
|
Robin Avery
|
c452715bf1
|
Allow skin elements to find closest anchor
- Resolves ppy/osu#13252
- Add localisation strings for the context menu instead of using enum
|
2021-06-06 01:32:04 -04:00 |
|
Salman Ahmed
|
7c6400735f
|
Merge branch 'master' into remove-hud-component-lookup
|
2021-06-01 10:17:52 +03:00 |
|
Dean Herbert
|
17fa2426d4
|
Merge branch 'master' into legacy-skin-resource-improvements
|
2021-05-31 19:36:09 +09:00 |
|
Dean Herbert
|
65709ec7d7
|
Move leagcy resource store construction local to DefaultLegacySkin
|
2021-05-31 19:14:49 +09:00 |
|
Dean Herbert
|
b16d10bd95
|
Provide game-wide resources via IStorageResourceProvider
|
2021-05-31 18:57:47 +09:00 |
|
Salman Ahmed
|
02d18c7a49
|
Merge branch 'master' into remove-hud-component-lookup
|
2021-05-31 09:23:04 +03:00 |
|
Salman Ahmed
|
fb81e5133f
|
Merge branch 'master' into catch-hide-combo-workaround
|
2021-05-30 14:16:46 +03:00 |
|
Salman Ahmed
|
53cbf369d7
|
Fix potential nullref
|
2021-05-29 21:22:46 +03:00 |
|
Salman Ahmed
|
42618c713f
|
Merge branch 'master' into legacy-beatmap-skin-hud-fallback
|
2021-05-29 20:56:05 +03:00 |
|
Dean Herbert
|
b36b40cb34
|
Remove unnecessary double specification
|
2021-05-26 15:20:47 +09:00 |
|
kamp
|
65649e5a62
|
Prevent skin editor crash when scaling 0 area drawables
Some skinnable drawables can have 0 width or height in certain
cases, leading to division by 0 and a crash when the position is
updated.
|
2021-05-24 21:36:42 +02:00 |
|
Dean Herbert
|
caa2c5638e
|
Fix legacy combo counter not accounting for song progress bar
|
2021-05-23 16:46:57 +09:00 |
|
Dean Herbert
|
45c6a9ca91
|
Merge branch 'refactor-selection-rotate-logic' into fix-flip-logic-discrepancy
|
2021-05-22 21:17:58 +09:00 |
|
Dean Herbert
|
7d88a19d7f
|
Remove unnecessary field storage of origin reference
|
2021-05-22 21:03:40 +09:00 |
|
Dean Herbert
|
34a5b22b79
|
Merge branch 'master' into refactor-selection-rotate-logic
|
2021-05-22 20:52:28 +09:00 |
|
Dean Herbert
|
485728ca4e
|
Merge pull request #12866 from peppy/refactor-selection-scale-logic
Add proper scaling support to skin editor
|
2021-05-22 20:07:03 +09:00 |
|
Dean Herbert
|
bb2fae55ce
|
Merge branch 'master' into refactor-selection-rotate-logic
|
2021-05-21 19:19:54 +09:00 |
|
Dean Herbert
|
0d575f5728
|
Remove incorrect (and unintended) modulus logic
|
2021-05-21 15:06:53 +09:00 |
|
Dean Herbert
|
f9d51656b6
|
Fix scaling of rotated items not behaving in an understandable way
|
2021-05-21 15:02:36 +09:00 |
|
Dan Balasescu
|
7845d07dd5
|
Merge pull request #12886 from peppy/fix-skin-editor-context-menu-sticking
Fix skin editor context menus not dismissing when clicking away
|
2021-05-20 21:03:35 +09:00 |
|
Dean Herbert
|
1848bd902d
|
Fix skin editor context menus not dismissing when clicking away
|
2021-05-20 19:51:07 +09:00 |
|
Dean Herbert
|
df5970fab4
|
Create base implementations of the two most common TernaryStateMenuItems
|
2021-05-20 19:34:53 +09:00 |
|
Dean Herbert
|
20f1ef4318
|
Extract common implementation of updating drawable position from screen space pos
|
2021-05-20 18:35:13 +09:00 |
|
Dean Herbert
|
6f75c59760
|
Fix flip logic not using the full selection quad
|
2021-05-20 18:31:51 +09:00 |
|
Dean Herbert
|
95c78b9185
|
Split out common selection quad logic
|
2021-05-20 18:24:25 +09:00 |
|
Dean Herbert
|
27e81d6504
|
Implement proper rotation algorithm for skin editor
|
2021-05-20 18:21:16 +09:00 |
|
Salman Ahmed
|
43094425e2
|
Merge branch 'legacy-beatmap-skin-hud-fallback' into catch-hide-combo-workaround
|
2021-05-19 23:18:27 +03:00 |
|
Salman Ahmed
|
9f3ea150f5
|
Fix legacy beatmap skins not falling back properly on HUD components
|
2021-05-19 23:01:29 +03:00 |
|
Bartłomiej Dach
|
788f1fcf48
|
Merge branch 'master' into disable-skin-editor-border
|
2021-05-19 21:52:29 +02:00 |
|
Salman Ahmed
|
21ca9c8431
|
Merge branch 'master' into beatmap-skin
|
2021-05-19 22:39:32 +03:00 |
|
Dean Herbert
|
eb5db8ff03
|
Disable border display on skin editor to avoid crashes
This wasn't being displayed correctly anyway, so rather than fixing
let's just remove it for now.
Closes #12868.
|
2021-05-20 02:01:46 +09:00 |
|
Dean Herbert
|
22337e0fc7
|
Add comment explaining why origin is flipped
|
2021-05-20 01:59:30 +09:00 |
|
Dean Herbert
|
363aec8179
|
Merge branch 'master' into hit-error-skinnable
|
2021-05-20 01:51:45 +09:00 |
|
Dean Herbert
|
a55879e511
|
Fix oversights in scale algorithm
|
2021-05-20 01:47:31 +09:00 |
|
Dean Herbert
|
14af86d6c5
|
Use the same code path for all scaling
|
2021-05-19 21:46:41 +09:00 |
|
Dean Herbert
|
6a3c58b9ad
|
Implement proper scaling algorithms
|
2021-05-19 19:58:55 +09:00 |
|
Salman Ahmed
|
825d61e22c
|
Separate default beatmap skins from DefaultSkin
|
2021-05-19 12:06:10 +03:00 |
|
Salman Ahmed
|
9806d94b74
|
Move beatmap skin info creation to static method at IBeatmapSkin
|
2021-05-19 11:58:00 +03:00 |
|
Salman Ahmed
|
c98d036b48
|
Merge branch 'master' into catch-hide-combo-workaround
|
2021-05-18 17:47:20 +03:00 |
|