658 Commits

• Fix and use score user's IsBot property in results screen animation

  While a mod-created replay did flag itself as performed by a bot, the extension method converting it into a Score did not copy all the generated properties.
  
  As noted, it might be preferable for ModCreatedUser to inherit APIUser and forward it as-is to the Score instance.
  
  Related to PR #24675

  Nabile Rahmani · 2023-08-29 23:28:50 +02:00
  b658b0e346
• Privatise setter
  Bartłomiej Dach · 2023-08-01 18:09:48 +02:00
  f7d5ac9f92
• Show extended statistics in multiplayer spectator automatically
  Dean Herbert · 2023-08-01 20:02:36 +09:00
  df504e1fc2
• Merge branch 'master' into fix-replay-export-queued-op
  Bartłomiej Dach · 2023-07-30 14:58:14 +02:00
  1f7f336fd5
• Merge pull request #24361 from peppy/fix-editor-global-music-hotkey-conflicts

  Disallow interacting with the global track state in `Player` and `Editor`

  Bartłomiej Dach · 2023-07-30 12:28:53 +02:00
  e208f38bcb
• Remove pending export operation if active score is changed
  Dean Herbert · 2023-07-30 16:41:45 +09:00
  6d5b3617b3
• Don't queue export replay operations if button is disabled
  Dean Herbert · 2023-07-30 16:41:33 +09:00
  35ec55c1f6
• Fix ReplayDownloadButton handling key repeat
  Dean Herbert · 2023-07-26 15:21:43 +09:00
  e26afc2b89
• Disallow interacting with the global track state in Player and Editor
  Dean Herbert · 2023-07-25 20:20:53 +09:00
  3485b72eaa
• Fix differing anchor specs on statistics panel flow items
  Bartłomiej Dach · 2023-07-13 20:00:29 +02:00
  20bde40ce2
• Disable masking on inner scroll container
  Dean Herbert · 2023-07-13 19:01:59 +09:00
  2c27b17c85
• Rename StatisticContainer to StatisticItemContainer and add a background
  Dean Herbert · 2023-07-13 18:59:11 +09:00
  e34839c891
• Change OverallRanking to use a two-column layout similar to statistics table
  Dean Herbert · 2023-07-13 18:45:32 +09:00
  b333945cde
• Adjust metrics of HitEventTimingDistributionGraph
  Dean Herbert · 2023-07-13 18:45:32 +09:00
  0881f4772c
• Adjust metrics of SimpleStatisticTable
  Dean Herbert · 2023-07-13 18:45:32 +09:00
  947b40149f
• Centralise font size specification for statistic items (and reduce slightly)
  Dean Herbert · 2023-07-13 18:31:40 +09:00
  d54cf63983
• Adjust metrics of PerformanceBreakdown
  Dean Herbert · 2023-07-13 18:30:57 +09:00
  f223fd7c3b
• Adjust metrics of OverallRanking
  Dean Herbert · 2023-07-13 18:30:57 +09:00
  7637a9e603
• Remove more GridContainer nonsense
  Dean Herbert · 2023-07-13 18:30:57 +09:00
  98bf15182e
• Fix animation restarting unexpectedly
  Dean Herbert · 2023-07-13 15:07:26 +09:00
  1d62a041cc
• Fix graph breaking when resized vertically
  Dean Herbert · 2023-07-13 14:57:01 +09:00
  21f26f98da
• Split bar drawable creation into own method
  Dean Herbert · 2023-07-13 14:43:41 +09:00
  e2b5abd4e8
• Fix timing distribution graph sometimes not displaying correctly

  Weird "basal" height logic just didn't make any sense (was getting stuck at 1 when `DrawHeight` was 0)

  Dean Herbert · 2023-07-12 19:21:39 +09:00
  4f4c481a67
• Adjust results screen transition tweens to feel better
  Dean Herbert · 2023-07-07 17:39:54 +09:00
  82babbf8fa
• Silence a few remaining nullability warnings
  Bartłomiej Dach · 2023-07-04 22:39:26 +02:00
  e2ddcb2349
• Make ScoreInfo.BeatmapInfo nullable
  Dean Herbert · 2023-07-04 14:50:34 +09:00
  d74b1e148d
• Manual fixes to reduce warnings to zero
  Dean Herbert · 2023-06-24 01:52:53 +09:00
  df5b389629
• Automated pass
  Dean Herbert · 2023-06-24 01:00:03 +09:00
  0ab0c52ad5
• Fix potential null ref in ResultsScreen
  Dean Herbert · 2023-06-21 17:50:06 +09:00
  655491ae2d
• Improve and combine logic that exists in two classes
  Dean Herbert · 2023-06-21 17:48:12 +09:00
  9ca772421d
• Also add hotkey to export replays
  Dean Herbert · 2023-06-20 16:54:37 +09:00
  4bd121d3b8
• Apply NRT and hotkey support to save replay button at results screen
  Dean Herbert · 2023-06-20 16:29:15 +09:00
  1e0e29847f
• Also move GetMaxAchievableCombo
  Dean Herbert · 2023-06-16 15:26:13 +09:00
  362aa4b376
• Add tooltips to truncated text
  Joseph Madamba · 2023-06-08 19:44:07 -07:00
  85fedbd025
• Remove redundant nullable suppression directives
  Salman Ahmed · 2023-06-07 08:20:41 +03:00
  62cb6a98ca
• Simplify column dimensions code

  `dimensions` would always receive exactly one item, so might as well
  inline it.
  
  And yes, at this point the grid container is mostly a glorified
  `FillFlowContainer { Direction = FlowDirection.Vertical }`, but I am not
  touching that in this pull pending further decisions with respect to
  direction.

  Bartłomiej Dach · 2023-06-03 19:40:01 +02:00
  602d5db3bb
• Return StatisticItems rather than StatisticRows from ruleset

  There were no usages of more than one column being provided per row, so
  it seemed like unnecessarily complexity. I'm currently trying to reduce
  complexity so we can improve the layout of the results screen, which
  currently has up to three levels of nested `GridContainer`s.
  
  Of note, I can't add backwards compatibility because the method
  signature has not changed in `Ruleset` (only the return type). If we do
  want to keep compatibility with other rulesets, we could designate a new
  name for the updated method.

  Dean Herbert · 2023-06-01 14:35:15 +09:00
  985604fab5
• Remove unused Dimension specification from StatisticItem
  Dean Herbert · 2023-06-01 14:25:18 +09:00
  dc595b83f1
• Fix CI issues
  Dan Balasescu · 2023-05-23 19:32:19 +09:00
  7658536b5a
• Remove ScoreManager.GetTotalScore()
  Dan Balasescu · 2023-05-18 20:08:49 +09:00
  f3591f83a2
• Centralise accuracy cutoff constants and add lookup helper methods
  Dean Herbert · 2023-02-09 15:41:58 +09:00
  cf009432cc
• adjust RankNotch gap size to match original value
  Walavouchey · 2023-02-09 02:20:05 +01:00
  57312279f0
• move rank accuracy requirements to class-local constants
  Walavouchey · 2023-02-09 00:46:24 +01:00
  fd93bd3f50
• use Precision.AlmostEquals for bounds check
  Walavouchey · 2023-02-08 23:59:19 +01:00
  ee40444fd3
• display RankBadges on on their sector centres

  the D `RankBadge` does this anyway. the A and S badges are slightly off
  centre to prevent overlap with the SS badge

  Walavouchey · 2023-02-08 14:01:40 +01:00
  0531c010eb
• ensure AccuracyCircle doesn't land in gaps created by RankNotches
  Walavouchey · 2023-02-08 13:20:53 +01:00
  6ace6bfee1
• Allow unsubscribing from solo statistics updates

  This is more of a safety item. To avoid potential duplicate key in
  dictionary errors (and also avoid being slightly memory-leaky), allow
  `SoloStatisticsWatcher` consumers to dispose of the subscriptions they
  take out.

  Bartłomiej Dach · 2022-12-28 08:07:48 +01:00
  3c0b8af8f1
• Convert SoloResultsScreen to NRT
  Bartłomiej Dach · 2022-12-28 07:54:36 +01:00
  04f9a354c3
• Fix incorrect accuracy display on overall ranking view
  Bartłomiej Dach · 2022-12-27 19:51:51 +01:00
  e90619244d
• Only show global rankings on results screen when progressing from gameplay
  Bartłomiej Dach · 2022-12-26 23:35:45 +01:00
  01cf96e240