Dean Herbert
684fef7f8c
Fix MaxIntervals incorrectly factoring distance spacing multipiler into snap calculation
2022-05-06 17:09:02 +09:00
Dean Herbert
246479bf34
Fix snap extent not working correctly on sliders (and providing incorrect time values)
2022-05-06 15:54:37 +09:00
Dean Herbert
32b40bdabf
Rename DistanceBetweenTick to be plural
2022-05-06 15:45:36 +09:00
Dean Herbert
5029710de7
Merge branch 'master' into distance-snapping-test
2022-05-05 22:00:40 +09:00
Dan Balasescu
e46f99bdba
Merge branch 'master' into dialog-overlay-thread-woes
2022-05-05 20:57:51 +09:00
Bartłomiej Dach
a9eae3a544
Merge branch 'master' into snapping-tidy-distance
2022-05-05 13:15:24 +02:00
Dan Balasescu
39d10487b9
Merge branch 'master' into snapping-tidy-distance
2022-05-05 19:55:55 +09:00
Salman Ahmed
542bb54ba0
Merge branch 'master' into beatmap-selection-keybinding
2022-05-05 13:44:08 +03:00
Dean Herbert
684db27bb8
Reword binding text to read better
2022-05-05 19:40:44 +09:00
Dan Balasescu
ab2e30d625
Merge pull request #18101 from peppy/cache-at-interface
...
Move caching specification to interface for several editor interfaces
2022-05-05 19:36:08 +09:00
Dean Herbert
e83604a1fc
Merge branch 'master' into cache-at-interface
2022-05-05 18:54:24 +09:00
Dean Herbert
b9d8b7e413
Fix end time extent not being accounted for in new snap implementation
2022-05-05 18:49:12 +09:00
Dean Herbert
7b71fb860b
Expose DistanceSpacingMultiplier for test usage
2022-05-05 18:49:12 +09:00
Salman Ahmed
67341db0e7
Wrap BeatmapOnlineLookupQueue cache request in a task
2022-05-05 12:40:02 +03:00
Dean Herbert
b2e9be70a5
Rewrite CircularDistanceSnapGrid snapping implementation to use snap provider
2022-05-05 17:52:36 +09:00
Dean Herbert
947a68006a
Add note about IDistanceSnapProvider not multiplying DistanceSpacing itself
2022-05-05 17:50:17 +09:00
Dean Herbert
4c884aea5d
Fix CircularDistanceSnapGrid returning an incorrect time value when distance spacing is not 1.0
2022-05-05 17:09:14 +09:00
Dean Herbert
786c7f14d3
Expose DistanceSpacingMultiplier to distance
2022-05-05 17:08:53 +09:00
Dean Herbert
de9b3d33eb
Rename misleading DistanceSpacing variable
2022-05-05 17:08:09 +09:00
Dean Herbert
c3d2648f85
Reword weird xmldoc
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2022-05-05 17:07:05 +09:00
Dean Herbert
4226583afd
Merge branch 'cache-at-interface'
2022-05-05 16:52:03 +09:00
Dean Herbert
19cf9dc20b
Merge branch 'snapping-tidy-distance'
2022-05-05 16:51:32 +09:00
Dean Herbert
5a1ac71d90
Remove unnecessary type specification in HitObjectComposer's caching
2022-05-05 16:44:37 +09:00
Dean Herbert
1c6a233cc0
Move snap provider caching to interfaces
2022-05-05 16:44:37 +09:00
Dean Herbert
b411b59006
Move IPlacementHandler caching to interface
2022-05-05 16:43:02 +09:00
Dean Herbert
977e6d8a80
Add xmldoc for IDistanceSnapProvider and related properties
2022-05-05 16:25:45 +09:00
Dean Herbert
6227e3f876
Add comprehensive documentation of BeatmapInfo.DistanceSpacing
2022-05-05 16:25:45 +09:00
Dean Herbert
1fce0da331
Reword slightly, to allow better conformity with IDistanceSnapProvider
2022-05-05 16:04:34 +09:00
Dean Herbert
f6fc926f1a
Add xmldoc and rename methods in IPositionSnapProvider for legibility
2022-05-05 15:58:21 +09:00
Dean Herbert
f6a6a11391
Remove DialogOverlay local fades (is already managed by PopupDialogs themselves)
2022-05-05 15:02:23 +09:00
Dean Herbert
326ff3b6e9
Fix CurrentDialog being updated twice, unsafe variable access
2022-05-05 14:55:05 +09:00
Dean Herbert
a27fcda9f1
Fix failing tests due to CurrentDialog being unexpectedly not set after Push
2022-05-05 01:52:39 +09:00
Salman Ahmed
e294069e2f
Merge branch 'master' into beatmap-selection-keybinding
2022-05-04 16:48:49 +03:00
Salman Ahmed
9416346c94
Globalise beatmap selection key bindings as "group" selection
2022-05-04 16:46:32 +03:00
Dean Herbert
e920bbd497
Merge pull request #18081 from bdach/mod-overlay/test-coverage-parity
...
Port test coverage from old mod select overlay to new design
2022-05-04 20:24:50 +09:00
Dean Herbert
383245f43a
Fix dialoged pushed to DialogOverlay too early potentially doing cross-thread transforms
...
As seen at https://github.com/ppy/osu/runs/6287700705?check_suite_focus=true .
2022-05-04 20:23:36 +09:00
Dean Herbert
5f11ff564b
Merge branch 'master' into mod-overlay/test-coverage-parity
2022-05-04 19:40:56 +09:00
Dean Herbert
3eead5a6a3
Rename FlushAnimation to FlushPendingSelections to better match purpose
2022-05-04 19:40:08 +09:00
Bartłomiej Dach
bf80dd864c
Merge branch 'master' into fix-editor-toolbox-click-through
2022-05-04 11:57:32 +02:00
Dean Herbert
4e0f899159
Rename value changed variable
2022-05-04 18:13:30 +09:00
Salman Ahmed
f5d4f02200
Use ToUpper for key binding text
2022-05-04 11:59:29 +03:00
Salman Ahmed
0b8fd2e39f
Improve distance spacing toast inline with key binding changes
2022-05-04 11:43:19 +03:00
Dean Herbert
b325f0ee0b
Combine editor toolbox container implementation and fix input blocking
...
Until now, toolbox scroll areas would block input from arriving behind
them, even when no visible element was clicked.
In addition, clicking on a button inside a toolbox would still send a
`MouseDown` event to things behind it. Specifically, the editor's
`HitObjectComposer` would receive these events and also place objects
when the user does not expect them to be placed.
This fixes another regression that occurred due to `ScrollContainer`s no
longer blocking input theirselves.
2022-05-04 17:41:30 +09:00
Salman Ahmed
3d2072498e
Merge branch 'master' into distance-spacing-osd
2022-05-04 11:41:12 +03:00
Dean Herbert
a66743266f
Remove unused ScrollingToolboxGroup class
2022-05-04 17:20:58 +09:00
Salman Ahmed
6f52a0b5eb
Merge branch 'master' into distance-spacing-osd
2022-05-04 11:10:18 +03:00
Dean Herbert
40f1ceca0a
Merge branch 'master' into distance-spacing-keybinding
2022-05-04 16:34:01 +09:00
Dean Herbert
732739715a
Remove "grid" from strings
2022-05-04 16:31:20 +09:00
Salman Ahmed
504ca5be31
Fix scrolling no longer adjusting distance spacing by amount
2022-05-04 09:52:33 +03:00
Salman Ahmed
813d6fed48
Split activation keybind to separate increase/decrease keybinds
2022-05-04 09:00:54 +03:00
