Dean Herbert
67746e1369
Move retry sample playback to PlayerLoader
2023-07-07 15:36:17 +09:00
Dean Herbert
170bc5bfce
Add support for skinnable "retry" sound
2023-07-06 12:25:15 +09:00
Bartłomiej Dach
f3576b88a4
Merge pull request #24121 from peppy/fix-judged-fallback
...
Fix fallback for `Judged` to be more correct
2023-07-05 22:15:04 +02:00
Dean Herbert
00c68cad53
Fix new scoring related properties not storing to realm due to internal spec
2023-07-05 19:47:44 +09:00
Dean Herbert
49e5558e4f
Merge pull request #24072 from smoogipoo/diffcalc-total-scorev1
...
Add difficulty attributes to facilitate conversion from legacy score, and convert existing scores
2023-07-05 18:47:18 +09:00
Dean Herbert
3f8dfc7cb0
Fix fallback for Judged to be more correct
...
Without this change, when the `Judged` value is checked on an
`HitObjectLifetimeEntry` it would return `true` if a `DrawableHitObject`
has not yet been associated with the entry. Which is completely wrong.
Of note, the usage in `DrawableHitObject` will have never fallen through
to this incorrect value as they always have a result populated:
f26f001e1d/osu.Game/Rulesets/Objects/Drawables/DrawableHitObject.cs (L721-L726)
2023-07-05 18:03:58 +09:00
Bartłomiej Dach
6c4e52821d
Redirect judgement-related flags from DHO to HOLE
2023-07-04 23:45:08 +02:00
Bartłomiej Dach
0ceaf3c451
Ensure synthetic entries from non-pooled DHO are linked to parents
2023-07-04 23:45:08 +02:00
Bartłomiej Dach
bae7670855
Redirect HitObjectEntryManager child mapping to HOLE
2023-07-04 23:41:06 +02:00
Bartłomiej Dach
6dc8c7b617
Add HitObjectLifetimeEntry.NestedEntries
2023-07-04 23:39:56 +02:00
Dean Herbert
f2aa80f413
Rename and adjust xmldoc on TotalScoreVersion
2023-07-04 20:04:02 +09:00
Dean Herbert
aee89e5e4b
Rewrite comment regarding LegacyTotalScore
2023-07-04 19:59:57 +09:00
Dean Herbert
664294cef4
Fix cancelled progress notifications requiring exit confirmation
2023-07-04 18:39:19 +09:00
Dean Herbert
dd9998127e
Count missing beatmaps as errored items
2023-07-04 18:35:03 +09:00
Dean Herbert
d3eb06578e
Improve messaging around failed scores
2023-07-04 18:34:53 +09:00
Dean Herbert
56bfb92ba6
Allow user cancellation
2023-07-04 18:22:10 +09:00
Dean Herbert
257a96ef60
Fix background beatmap processor thread not correctly exiting
2023-07-04 18:21:22 +09:00
Dean Herbert
4de15f975e
Fix realm silly business
2023-07-04 18:08:26 +09:00
Dean Herbert
a0c3fa9c13
Move preconditions to realm migration step to simplify marker version logic
2023-07-04 17:53:53 +09:00
Dean Herbert
1629024111
ILegacyScoreProcessor -> ILegacyScoreSimulator
2023-07-04 17:32:54 +09:00
Dean Herbert
3b5f3b67a7
Tidy up and improve messaging on completion notification
2023-07-04 15:53:24 +09:00
Dean Herbert
1a6381bcbb
Reduce code repetition for sleep logic
2023-07-04 15:35:09 +09:00
Dean Herbert
67650831bd
Remove unnecessary null check
2023-07-04 14:19:25 +09:00
Dean Herbert
4203e2183d
Merge branch 'master' into diffcalc-total-scorev1
2023-07-04 14:15:24 +09:00
Bartłomiej Dach
21f758947d
Merge branch 'master' into availability-fixes
2023-07-02 20:38:37 +02:00
Bartłomiej Dach
7b3cb5b410
Merge pull request #24068 from peppy/fix-sign-out-string
...
Use more correct localised string source for "sign out" text
2023-07-02 19:20:24 +02:00
Dean Herbert
95c30fe12a
Duplicate sign out string for now
2023-07-03 00:14:26 +09:00
Dean Herbert
b3c874fdc5
Merge pull request #24099 from bdach/fix-oob-selection-box-again
...
Fix edge cases where selection buttons go outside playfield bounds
2023-07-02 09:37:50 +09:00
Bartłomiej Dach
d017be50f1
Merge pull request #24081 from Cootz/restore-scores-after-bearmap-reinstallation
...
Reattach any orphaned scores when a beatmap is imported
2023-07-01 22:33:38 +02:00
Bartłomiej Dach
9eec1337b3
Use slightly different condition for better UX
2023-07-01 21:39:08 +02:00
Bartłomiej Dach
183777f8df
Fix edge cases where selection buttons go outside playfield bounds
...
Addresses
https://github.com/ppy/osu/discussions/23599#discussioncomment-6300885 .
2023-07-01 21:27:17 +02:00
Bartłomiej Dach
1ce60378be
Rewrite comments further
2023-07-01 20:37:33 +02:00
Bartłomiej Dach
fe2ca5cfef
Merge pull request #24087 from peppy/less-tablet-error-spam
...
Ensure "tablet support disabled" notification is only shown once
2023-07-01 18:46:27 +02:00
Dean Herbert
5f880397a9
Increase the minimum size of the scroll bar
...
Allows easier targetting when there is a lot of content in the scroll view
As discussed in https://github.com/ppy/osu/discussions/24095#discussioncomment-6332398 .
2023-07-02 00:04:56 +09:00
Dean Herbert
5bd91a531d
Tidy up comments and code
2023-07-01 23:37:22 +09:00
Dean Herbert
a4a9223726
Move score re-attach to PostImport
2023-07-01 23:12:04 +09:00
Cootz
8d25e2c3e1
Add importer update test
2023-07-01 09:49:06 +03:00
Dean Herbert
e2db6159d6
Ensure "tablet support disabled" notification is only shown once
2023-06-30 13:47:55 +09:00
Bartłomiej Dach
1f3d833b05
Merge pull request #24080 from peppy/star-rating-no-rounding
...
Never remove significant digits from star rating displays
2023-06-29 21:27:30 +02:00
Dan Balasescu
426f11b824
Apply a few other code reviews
2023-06-29 17:28:06 +09:00
Dan Balasescu
c6ad184d94
Move Ruleset method to ILegacyRuleset interface
2023-06-29 17:24:37 +09:00
Dan Balasescu
6822871dab
Move population of LegacyTotalScore to ScoreImporter
2023-06-29 17:21:24 +09:00
Dan Balasescu
ddd870e843
Make LegacyTotalScore nullable
2023-06-29 17:19:10 +09:00
Dan Balasescu
c816281494
Make BackgroundBeatmapProcessor task long-running
2023-06-29 17:16:33 +09:00
Dan Balasescu
829044de59
Revert unintented change
2023-06-29 17:15:48 +09:00
Cootz
87308abec2
Merge branch 'master' into restore-scores-after-bearmap-reinstallation
2023-06-29 08:29:41 +03:00
Cootz
47ccbddfb1
Reword comment
2023-06-29 08:08:10 +03:00
Cootz
351f217c8c
Reassign existing scores to new/re-exported beatmap
2023-06-29 08:07:43 +03:00
Dean Herbert
34f53965c4
Never remove significant digits from stsar rating displays
...
Closes https://github.com/ppy/osu/issues/24079 .
2023-06-29 13:55:04 +09:00
Bartłomiej Dach
90cb3dac86
Merge pull request #24076 from bastianpedersen/localise-chat-notifications
...
Localise chat related notifications
2023-06-28 22:36:53 +02:00
