49053 Commits

This Branch

This Branch

All Branches

• Add safeties to skip attempted import of the intro beatmap when osu! ruleset not present

  In general running this import will not cause any critical failures, but
  the import itself *will* fail – and more loudly with the upcoming
  changes to `RulesetStore` (https://github.com/ppy/osu/pull/16890). Due
  to it being a loud failure, it will cause the notification overlay to
  display a parsing error, which can interrupt the flow of some tests.
  
  See test failure at
  https://github.com/ppy/osu/runs/5268848949?check_suite_focus=true as an
  example (video coverage at
  https://github.com/ppy/osu/pull/16890#issuecomment-1046542243).

  Dean Herbert · 2022-02-21 16:21:38 +09:00
  656c58567d
• Merge pull request #16933 from bdach/mod-overlay/basic-colour-theme

  Add all colour constants for "basic" colour theme to `OsuColour`

  Dean Herbert · 2022-02-21 11:12:34 +09:00
  85e2f68a64
• Remove static OverlayColourProviders
  Bartłomiej Dach · 2022-02-20 21:09:08 +01:00
  36a00c1ee2
• Remove all references to static OverlayColourProviders
  Bartłomiej Dach · 2022-02-20 21:09:08 +01:00
  ce0db9d4db
• Add Colour0 to OverlayColourProvider
  Bartłomiej Dach · 2022-02-20 21:09:08 +01:00
  79ba37bbab
• Add comments about OverlayColourProvider vs OsuColour distinction
  Bartłomiej Dach · 2022-02-20 21:08:58 +01:00
  2592f0900d
• Add all colour constants for "basic" colour theme to OsuColour
  Bartłomiej Dach · 2022-02-20 21:00:49 +01:00
  e20ae5b871
• Merge pull request #16910 from peppy/fix-storyboard-background-replacement

  Fix storyboard background replacement logic not working for beatmaps with multiple backgrounds

  Dan Balasescu · 2022-02-18 19:08:52 +09:00
  65ffcefdf9
• Merge pull request #16907 from uzervlad/copy-screenshots

  Copy screenshots to clipboard

  Dean Herbert · 2022-02-18 16:31:33 +09:00
  c287b169f1
• Fix storyboard background replacement logic not working for beatmaps with multiple backgrounds

  In the case where the background image of individual difficulties is
  different, querying the beatmap *set*'s metadata as we were will cause
  issues.
  
  I haven't added test coverage for this but can if required. Can be
  manually tested using https://osu.ppy.sh/beatmapsets/1595773#osu/3377474
  (specifically the highest difficulty).
  
  Closes https://github.com/ppy/osu/discussions/16873.

  Dean Herbert · 2022-02-18 16:24:19 +09:00
  e49da2948d
• Update ScreenshotManager.cs
  OctopuSSX · 2022-02-17 20:43:36 +03:00
  08317b4265
• Merge pull request #16895 from bdach/better-new-difficulty-naming

  Name newly created difficulties in a better way

  Dean Herbert · 2022-02-17 21:54:09 +09:00
  2022.217.0 d7ef0e4174
• Merge pull request #16903 from peppy/fix-leaderboard-display

  Fix beatmap overlay leaderboards and links not working

  Dean Herbert · 2022-02-17 21:52:17 +09:00
  48dc2cbe72
• Fix incorrect mappings
  Dean Herbert · 2022-02-17 21:12:51 +09:00
  9d0023c750
• Fix beatmap overlay leaderboards and links not working

  Completely aware that this isn't how it should be done, but would like
  to get this out in a hotfix release today. Maybe changes opinions on
  https://github.com/ppy/osu/pull/16890 structure?

  Dean Herbert · 2022-02-17 21:05:00 +09:00
  3d5ed24e20
• Merge branch 'master' into better-new-difficulty-naming
  Dean Herbert · 2022-02-17 19:21:33 +09:00
  bbc4ea1203
• Merge pull request #16898 from smoogipoo/fix-mania-pp-score-multiplier

  Fix mania PP calculator applying incorrect score multiplier

  Dean Herbert · 2022-02-17 19:21:08 +09:00
  13b6cfb5ed
• Merge pull request #16880 from smoogipoo/remove-playlistitem-beatmap

  Remove beatmap bindable from PlaylistItem

  Dean Herbert · 2022-02-17 17:47:00 +09:00
  4889750959
• Merge branch 'master' into remove-playlistitem-beatmap
  Dean Herbert · 2022-02-17 17:19:26 +09:00
  2a1edcdf73
• Merge pull request #16901 from peppy/update-framework

  Update framework

  Dan Balasescu · 2022-02-17 17:12:30 +09:00
  510d1d6277
• Update framework
  Dean Herbert · 2022-02-17 16:45:20 +09:00
  dc74d17478
• Merge pull request #16891 from smoogipoo/fix-mania-hitwindow-attrib

  Fix mania hit window attribute improperly considering rate-adjustment mods

  Dean Herbert · 2022-02-17 14:03:51 +09:00
  64360f2b37
• Fix mania PP calculator applying incorrect score multiplier
  Dan Balasescu · 2022-02-17 14:03:39 +09:00
  39a7bbdb9a
• Merge pull request #16897 from peppy/add-back-mod-multiplier

  Revert changes to mod multiplier display

  Dean Herbert · 2022-02-17 14:02:42 +09:00
  03d3501a3c
• Revert "Merge pull request #16889 from smoogipoo/remove-mod-multiplier"

  This reverts commit 252b945d3b, reversing
  changes made to a1b39a96cf.

  Dean Herbert · 2022-02-17 13:26:12 +09:00
  7307e68e9c
• Merge pull request #16896 from Stedoss/remove-creator-from-playlist-item-beatmap-text

  Remove creator name from playlist item panel beatmap text

  Dan Balasescu · 2022-02-17 12:46:02 +09:00
  9410fb46af
• Remove creator name from playlist item panel beatmap text
  Stedoss · 2022-02-17 03:04:16 +00:00
  aac1c53b06
• Adjust beatmap creation test cases to new behaviour
  Bartłomiej Dach · 2022-02-17 00:28:18 +01:00
  e459523afe
• Use best-name-finding helper in new difficulty creation flow
  Bartłomiej Dach · 2022-02-17 00:28:18 +01:00
  8a08bb7aaf
• Implement best-name-finding helper method
  Bartłomiej Dach · 2022-02-17 00:28:17 +01:00
  e09570c31b
• Add tests showing expected behaviour of naming helper
  Bartłomiej Dach · 2022-02-17 00:28:13 +01:00
  cb9ffc655a
• Add explanatory note
  Dan Balasescu · 2022-02-16 20:07:58 +09:00
  0b37efc985
• Fix improperly considering rate adjustment mods
  Dan Balasescu · 2022-02-16 19:51:42 +09:00
  a0ee86ddd2
• Merge pull request #16886 from peppy/clarify-parenthesis

  Clarify ambiguous conditionals in `LegacyStageBackground`

  Dan Balasescu · 2022-02-16 19:15:21 +09:00
  1f9892802c
• Merge pull request #16889 from smoogipoo/remove-mod-multiplier

  Remove mod multipliers from applying to scores

  Dean Herbert · 2022-02-16 17:59:26 +09:00
  2022.216.0 252b945d3b
• Update failing test to not account for no-longer-existing multiplier
  Dean Herbert · 2022-02-16 17:33:55 +09:00
  28fcad9281
• Update xmldoc to mention that multipliers are not applied anywhere
  Dean Herbert · 2022-02-16 17:32:22 +09:00
  23933fc881
• No longer require Mod implementation
  Dan Balasescu · 2022-02-16 16:36:02 +09:00
  4c1413e0c7
• Remove mod multipliers from being applied to scores
  Dan Balasescu · 2022-02-16 16:27:27 +09:00
  5dd9771c5f
• Use score multiplier attribute in ManiaPerformanceCalculator
  Dan Balasescu · 2022-02-16 16:24:40 +09:00
  d4bf335fcc
• Store beatmap to a field instead
  Dan Balasescu · 2022-02-16 16:03:08 +09:00
  55d9f0b44b
• Revert styling change
  Dan Balasescu · 2022-02-16 15:51:18 +09:00
  edd31bf3aa
• Clarify ambiguous conditionals in LegacyStageBackground
  Dean Herbert · 2022-02-16 15:27:49 +09:00
  f703828e1b
• Merge pull request #16884 from smoogipoo/difficulty-attribute-xmldocs

  Add XMLDocs to difficulty attribute properties

  Dean Herbert · 2022-02-16 14:37:59 +09:00
  a1b39a96cf
• Merge branch 'master' into remove-playlistitem-beatmap
  Dean Herbert · 2022-02-16 14:24:57 +09:00
  7e24b36f26
• Add XMLDocs to difficulty attribute properties
  Dan Balasescu · 2022-02-16 14:09:19 +09:00
  84e82ef5e4
• Merge pull request #16879 from smoogipoo/fix-multi-cache-dependencies

  Fix incorrectly cached lookup components in tests

  Dean Herbert · 2022-02-16 11:51:39 +09:00
  74a0e002dc
• Expose read-only list from request
  Dan Balasescu · 2022-02-16 11:30:03 +09:00
  5db63a8751
• Rename "client" fields in tests to specify whether spectator or multiplayer
  Dean Herbert · 2022-02-16 09:52:18 +09:00
  6a08fd57ef
• Merge branch 'master' into fix-multi-cache-dependencies
  Dean Herbert · 2022-02-16 09:44:37 +09:00
  187870b794