1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-19 10:55:07 +08:00
Commit Graph

62112 Commits

Author SHA1 Message Date
Hydria
ef2134a92a Fix issue with processing LN orders
Related Issue: https://github.com/ppy/osu/issues/22756

The trigger in question happens when
(1) in a chord: a longer LN, then a shorter LN is processed respectively.
(2) in a chord: a long LN, then a note is processed respectively.

however, given the opposite processing step, it will fail to trigger.

We observe that both situations have the same pattern, however has undeterministic results, which only depends on the order the mapper placed each note.
2023-07-22 10:45:48 +01:00
Dao Heng Liu
ef74084a2e
make list of tournaments in SetupScreen dropdown alphabetically sorted 2023-07-22 09:59:00 +01:00
Dao Heng Liu
e0fe5c77d5
add reload tournaments list button to tourney setup screen 2023-07-22 09:44:02 +01:00
Bartłomiej Dach
bc46502deb
Merge pull request #24313 from peppy/tournament-use-development-env
Change tournament tests to use development folder
2023-07-21 22:02:04 +02:00
Bartłomiej Dach
e2e3581674
Merge pull request #24292 from peppy/legacy-skin-alignment
Fix some UI elements in legacy skins not always aligning correctly
2023-07-21 21:48:03 +02:00
Bartłomiej Dach
92c40c9ced
Remove superfluous container 2023-07-21 21:20:28 +02:00
Bartłomiej Dach
d055d16ba7
Remove superfluous CanBeNull dependency specs
As stated before, not required in NRT-annotated files if auto-properties
are already marked nullable.
2023-07-21 21:19:40 +02:00
Bartłomiej Dach
7ace50f442
Touch up dialogs a bit 2023-07-21 21:17:14 +02:00
Bartłomiej Dach
f197703fe1
Merge branch 'master' into tourney-dangerous-action-confirm 2023-07-21 21:13:48 +02:00
Bartłomiej Dach
2f6d125588
Merge pull request #24309 from peppy/tournament-team-editor-improvements
General improvements to tournament client team editor and buttons
2023-07-21 20:18:30 +02:00
Bartłomiej Dach
e9c76842e6
Merge pull request #24220 from peppy/editor-metrics
Update various editor design language (and centre playfield / timeline)
2023-07-21 20:12:25 +02:00
Bartłomiej Dach
2ef843261b
Adjust failing test after metrics changes 2023-07-21 19:08:40 +02:00
Dean Herbert
fd2bdc10c7 Fix "key count" setting showing as "circle size" in osu!mania editor
Closes https://github.com/ppy/osu/issues/12904.
2023-07-21 18:52:29 +09:00
Dean Herbert
d23c73a2f1
Adjust with better numbers based off 1920x1080 resolution
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2023-07-21 17:25:38 +09:00
Dean Herbert
cfcfe20221 Reduce scale and better align user panel 2023-07-21 15:46:28 +09:00
Dean Herbert
b5c3231feb Fix SettingsNumberBox having additional margin 2023-07-21 15:46:28 +09:00
Dean Herbert
741c3b8d21 Reduce spacing in settings items 2023-07-21 15:39:40 +09:00
Dean Herbert
ac4ad1e78c Change tournament tests to use development folder
Unsure there was a reason for this not to be the case (looks to have
been an oversight).
2023-07-21 15:35:03 +09:00
Dean Herbert
9d71e8f20d Merge branch 'master' into tournament-team-editor-improvements 2023-07-21 15:30:02 +09:00
Dean Herbert
82a5ba66e1 Align mode switcher with rest of interface 2023-07-21 15:27:42 +09:00
Dean Herbert
cdcb10e0e7 Fix timeline centre point being ever-so-slight off 2023-07-21 15:26:41 +09:00
Dean Herbert
b58354ac64 Fix playfield getting cut off (again) at tall aspect ratios 2023-07-21 15:20:20 +09:00
Dean Herbert
f489dbd7a9 Reduce width of right toolbar ever so slightly (and use more shared constants) 2023-07-21 14:39:15 +09:00
Dean Herbert
870f3e324a Adjust "test" button to better align with rest of interface 2023-07-21 14:26:33 +09:00
Dean Herbert
ca3d1538ae Merge branch 'master' into editor-metrics 2023-07-21 14:26:32 +09:00
Dean Herbert
2cb1a6fdaa Adjust metrics further 2023-07-21 14:23:53 +09:00
Dean Herbert
b29a2081ac Merge branch 'master' into menu-star-fountains 2023-07-21 14:21:16 +09:00
Dao Heng Liu
bf9c25f429 add confirmation dialog to delete team/round buttons in tourney editor screens 2023-07-20 23:28:31 +01:00
Dao Heng Liu
2825671e28 pass action instead of storage to TournamentClearAllDialog 2023-07-20 23:01:14 +01:00
Dao Heng Liu
3c05246baf fix weird handling of dialogOverlay in tourney client 2023-07-20 22:52:02 +01:00
Dao Heng Liu
fa480cc27b remove #nullable disable, pass action instead of container to DangerousActionDialog 2023-07-20 22:52:02 +01:00
Dao Heng Liu
68495c937d fix ResetBracketTeams tests
also fixes formatting and var naming issues
2023-07-20 22:52:02 +01:00
Dao Heng Liu
e67253ed1e remove unused code 2023-07-20 22:52:02 +01:00
Dao Heng Liu
e3a7b6969a add confirmation dialog for Clear All button in TournamentEditorScreen 2023-07-20 22:52:02 +01:00
Dao Heng Liu
41638ff4b7 move LadderResetTeamsDialog.cs into editor screens components 2023-07-20 22:52:02 +01:00
Dao Heng Liu
8cd81681b2 reorder LadderEditorScreen tests 2023-07-20 22:52:02 +01:00
Dao Heng Liu
3510394699 add ladder editor reset teams confirmation dialog test 2023-07-20 22:52:02 +01:00
Dao Heng Liu
e7795296e2 refactor LadderResetTeamsDialog.cs 2023-07-20 22:52:02 +01:00
Dao Heng Liu
2833497e5b add dialogoverlay to tournament client, confirmation dialog for resetting bracket teams 2023-07-20 22:52:00 +01:00
Bartłomiej Dach
c77d3cd6bd
Merge pull request #24294 from peppy/toggle-all-freemods
Add ability to toggle all free mods quickly at multiplayer song select
2023-07-20 22:32:53 +02:00
Bartłomiej Dach
fedf830b82
Merge pull request #24308 from peppy/tournament-ladder-improvements
General improvements to tournament client ladder editor
2023-07-20 21:40:57 +02:00
Bartłomiej Dach
166efd1aa8
Merge pull request #24291 from peppy/editor-cyclic-selection
Add support for cyclic selection in beatmap editor
2023-07-20 21:31:08 +02:00
Bartłomiej Dach
07e0a703d7
Adjust inline comment 2023-07-20 20:51:39 +02:00
Bartłomiej Dach
48024cd17f
Add test coverage of double click behaviour 2023-07-20 20:51:17 +02:00
Bartłomiej Dach
f60a6e9893
Fix test step descriptions 2023-07-20 20:47:33 +02:00
Dean Herbert
f0cec04619 Fix nullability warning 2023-07-21 03:47:32 +09:00
Dean Herbert
97e572d4da Make dragging ladder more snappy 2023-07-21 03:34:41 +09:00
Dean Herbert
fb4eaaeae9 Add grid snapping to ladder editor 2023-07-21 03:34:41 +09:00
Dean Herbert
ca14b4a35f Move ladder editor controls to control panel 2023-07-21 03:34:41 +09:00
Dean Herbert
ac6a103721 Add masking around ladder view 2023-07-21 03:34:41 +09:00