39356 Commits

This Branch

This Branch

All Branches

• Merge pull request #12778 from peppy/skin-editor-shortcut-fix

  Change default skin editor shortcut to Ctrl+Shift+S

  Dan Balasescu · 2021-05-13 22:14:03 +09:00
  63fbbc848e
• Merge pull request #12763 from peppy/skin-editor-default-placement-location

  Give newly added skin components a centered location to make them easier to find

  Dan Balasescu · 2021-05-13 21:42:02 +09:00
  c519e4f558
• Merge branch 'master' into skin-editor-default-placement-location
  Dan Balasescu · 2021-05-13 20:58:31 +09:00
  1b62947469
• Merge pull request #12750 from peppy/skin-serialisation

  Add skin editor saving / loading support

  Dan Balasescu · 2021-05-13 20:58:03 +09:00
  746862dcb1
• Merge pull request #12768 from frenzibyte/fix-two-hovered-handles

  Fix rotation handle visibility logic not handling two handles hovered at one point

  Dean Herbert · 2021-05-13 20:57:47 +09:00
  ee67c0ddc7
• Merge branch 'master' into skin-serialisation
  Dan Balasescu · 2021-05-13 19:49:55 +09:00
  3c471837f8
• Merge branch 'master' into fix-two-hovered-handles
  Dan Balasescu · 2021-05-13 19:24:42 +09:00
  a3869c02f4
• Merge branch 'skin-serialisation' into skin-editor-default-placement-location
  Dean Herbert · 2021-05-13 19:09:34 +09:00
  b939318922
• Fix broken exception message
  Dean Herbert · 2021-05-13 19:06:58 +09:00
  e5f765d1a8
• SkinnableTargetWrapper -> SkinnableTargetComponentsContainer
  smoogipoo · 2021-05-13 18:54:30 +09:00
  2f025f1967
• Improve ability to parse xmldoc of SkinnableTargetWrapper

  Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>

  Dean Herbert · 2021-05-13 18:40:28 +09:00
  01bc71acd2
• Use ScheduleAfterChildren to better match comment
  Dean Herbert · 2021-05-13 17:29:11 +09:00
  ebce3fd3c7
• Use interface in place of SkinnableTargetContainer
  Dean Herbert · 2021-05-13 17:25:51 +09:00
  3ea469813c
• Remove outdated TODO
  Dean Herbert · 2021-05-13 17:22:05 +09:00
  0959e7156a
• Rename SkinnableElementTargetContainer to SkinnableTargetContainer
  Dean Herbert · 2021-05-13 17:07:38 +09:00
  106fa97a11
• Rename ISkinnableComponent to ISkinnableDrawable
  Dean Herbert · 2021-05-13 17:06:00 +09:00
  7921dc7ece
• Replace ISkinSerialisable with IsEditable property
  Dean Herbert · 2021-05-13 17:03:17 +09:00
  cdcd31b546
• Reword xmldoc to read better
  Dean Herbert · 2021-05-13 16:43:42 +09:00
  dd6a06a302
• Fix incorrect exception text
  Dean Herbert · 2021-05-13 16:42:43 +09:00
  9dfa48b22e
• Remove left-over debug logging
  Dean Herbert · 2021-05-13 16:42:13 +09:00
  19223ba013
• Remove unused DI resolution
  Dean Herbert · 2021-05-13 16:41:36 +09:00
  5818ed4c8c
• Enable autoplay in skin editor tests
  Dean Herbert · 2021-05-13 14:55:11 +09:00
  e0e9106921
• Merge pull request #12758 from Naxesss/verify-settings-ui

  Add setting UI components to the verify screen

  Dean Herbert · 2021-05-13 14:35:35 +09:00
  5b71d8ca37
• Move DI resolution to inside BDL parameters
  Dean Herbert · 2021-05-13 13:54:06 +09:00
  b81f86bd4d
• Simplify binding flow in InterpretationSection
  Dean Herbert · 2021-05-13 13:51:41 +09:00
  c6648112e5
• Tidy up specification of SettingsSection
  Dean Herbert · 2021-05-13 13:45:10 +09:00
  cdcbaf4291
• Change default skin editor shortcut to Ctrl+Shift+S

  Avoids a conflict with song select's random rewind functionality. As
  mentioned in #12776.

  Dean Herbert · 2021-05-13 13:34:04 +09:00
  23e284b8b3
• Add JsonConstructor attribute to SkinnableTargetWrapper
  Dean Herbert · 2021-05-13 13:16:20 +09:00
  db19617b8b
• Standardise naming of methods related to SkinnableInfo
  Dean Herbert · 2021-05-13 13:14:49 +09:00
  3b862798e9
• Add xmldoc to SkinnableElementTargetContainer
  Dean Herbert · 2021-05-13 13:13:22 +09:00
  581e7940c7
• Add xmldoc and tidy up logic in Skin
  Dean Herbert · 2021-05-13 13:09:33 +09:00
  c93ed541f3
• Set default for bindable in object initializer

  Fixes the CI failure.

  Naxess · 2021-05-13 06:08:48 +02:00
  47948d7b34
• Remove stray comment
  Dean Herbert · 2021-05-13 13:07:06 +09:00
  992a052426
• Reorder fields in SkinEditor
  Dean Herbert · 2021-05-13 13:04:17 +09:00
  469a7f5d2a
• Move field upwards in class
  Dean Herbert · 2021-05-13 13:03:23 +09:00
  2bf8635ffd
• Remove duplicated call to base.GetDrawableComponent
  Dean Herbert · 2021-05-13 13:02:55 +09:00
  a38cb61b08
• Also refresh when interpreted difficulty changes
  Naxess · 2021-05-13 06:00:21 +02:00
  fb305130de
• Use local bound copy in InterpretationSection as well

  Else we're relying on the `VerifyScreen`'s bindable instance, and by extension the `VerifyScreen` instance itself.

  Naxess · 2021-05-13 05:59:49 +02:00
  ee0a6ba93e
• Add xmldoc to SkinnableInfo
  Dean Herbert · 2021-05-13 12:57:28 +09:00
  6caf4e3879
• Keep track of local bound copy
  Naxess · 2021-05-13 05:46:47 +02:00
  e80d8f6922
• Use more consistent lambda discards
  Naxess · 2021-05-13 05:38:45 +02:00
  04c1585eb2
• Merge branch 'master' into skin-serialisation
  Dean Herbert · 2021-05-13 12:35:06 +09:00
  8b9ac86d4b
• Merge pull request #12754 from peppy/skin-instantiation-info

  Add `SkinInfo.InstantiationInfo` to allow creating different skin types

  Dean Herbert · 2021-05-13 12:34:14 +09:00
  8bf05e142b
• Merge pull request #12777 from smoogipoo/fix-test-failure

  Fix possible multiplayer test failure

  Dean Herbert · 2021-05-13 12:33:59 +09:00
  fb13ed52f7
• Use local bound copy for HiddenIssueTypes
  Naxess · 2021-05-13 05:25:20 +02:00
  e86834b740
• Isolate refreshing to IssueList
  Naxess · 2021-05-13 05:25:02 +02:00
  c8d21f2c3f
• Fix possible test failure
  smoogipoo · 2021-05-13 11:53:50 +09:00
  5b03092968
• Split ShowIssueTypes dict into hidden and configurable lists

  This way `VerifyScreen` is decoupled from which options `VisibilitySection` provides.
  
  Bindings are a bit less neat, though.

  Naxess · 2021-05-13 04:50:32 +02:00
  fbb76ba598
• Set interpreted difficulty to correct default
  Naxess · 2021-05-13 04:36:20 +02:00
  dd8423c4c4
• Remove unnecessary local variable

  This now exists in `VerifyScreen`, which we can access from here.

  Naxess · 2021-05-13 04:30:40 +02:00
  6806e40ad9