Dean Herbert
c78b5112c6
Fix OAuth refresh attempt when no network available causing full logout (part 2)
...
This time for `SocketException`s. I seem to recall looking at this and
deciding there was a reason to not catch socket exceptions, but on
revisiting it seems sane to do so.
This covers a fail case like reported:
```
2023-10-06 03:24:17 [verbose]: Request to https://lazer.ppy.sh/oauth/token failed with System.Net.Http.HttpRequestException: No such host is known. (lazer.ppy.sh:443)
2023-10-06 03:24:17 [verbose]: ---> System.Net.Sockets.SocketException (11001): No such host is known.
2023-10-06 03:24:17 [verbose]: at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.ThrowException(SocketError error, CancellationToken cancellationToken)
```
Closes https://github.com/ppy/osu/issues/24890 (again).
2023-10-06 18:24:22 +09:00
Dean Herbert
7227f5c881
Fix a couple of compilation errors
2023-10-06 18:13:02 +09:00
Dean Herbert
936a21a661
Fix redundant bindable initialisation in SongSelect
2023-10-06 16:51:56 +09:00
Dean Herbert
1d7b8ea21a
Fix incorrect implementation of IHasCurrentValue in FooterButtonFreeMods
2023-10-06 16:51:40 +09:00
Dean Herbert
f2e56bbb65
Fix publicly-settable bindables
2023-10-06 16:51:24 +09:00
Dean Herbert
f9021bf551
Remove pointless test class in TestSceneStoryboardSamples
2023-10-06 16:43:28 +09:00
Dean Herbert
1005b7ac85
Fix incorrect test assumption in TestSceneEditorClock
...
I don't know what this test was trying to do, but it was wrong. Any
offset which is applied should be invisible to the clock's final
`CurrentTime` (and to the user).
2023-10-06 16:43:28 +09:00
Dean Herbert
354193c53a
Merge branch 'master' into clock-fix-attempt-2
2023-10-06 16:43:27 +09:00
Dean Herbert
cc6210035f
Merge pull request #25023 from bdach/skinning-max-size-update
...
Adjust gameplay element maximum size limits for backwards compatibility
2023-10-06 14:37:15 +09:00
Bartłomiej Dach
96bb8ed150
Apply feedback regarding maximum osu! element sizings
...
- `default-N` number sprites maximum size increased by 1.25x to a total
of 320x320 to counteract the 0.8x factor applied onto them when
displayed on a hitcircle.
- `sliderb` and parts' maximum size increased to 384x384, to match
`sliderfollowcircle`, as the two are apparently sometimes used
interchangeably by skinners to achieve different visual effects.
2023-10-05 22:33:49 +02:00
Bartłomiej Dach
0ae4a0f11f
Adjust gameplay element maximum size limits for backwards compatibility
...
The new limits were chosen by sampling across over 4000 skins. The
methodology for doing so is described in the following gist:
https://gist.github.com/bdach/6228ba41d128b23d1f89142f404108a3
2023-10-05 20:37:10 +02:00
Bartłomiej Dach
4d315cb718
Merge pull request #25016 from peppy/fix-waveform-comparison-crash
...
Fix `WaveformComparisonDisplay` potentially crashing on invalid track length
2023-10-05 20:02:44 +02:00
Dean Herbert
9649cc865d
Merge pull request #25013 from smoogipoo/new-diffcalc-workflow
...
Add new GitHub Actions diffcalc spreadsheet generator workflow
2023-10-05 23:57:20 +09:00
Dean Herbert
d034a3c45d
Merge pull request #25010 from bdach/swell-cheesing
...
Allow judging at most one swell tick per frame
2023-10-05 23:50:38 +09:00
Dean Herbert
c66423279c
Merge branch 'master' into swell-cheesing
2023-10-05 23:08:21 +09:00
Dean Herbert
d660395850
Ensure there's no chance of a press being ignored during rewind flow
2023-10-05 23:02:45 +09:00
Dean Herbert
61fd4186af
Ensure regenerateDisplay is eventually performed if originally called before load
2023-10-05 22:55:23 +09:00
Bartłomiej Dach
b0176dcbf7
Merge pull request #24975 from frenzibyte/crop-gameplay-textures
...
Crop oversized gameplay textures instead of downscaling them
2023-10-05 10:41:40 +02:00
Bartłomiej Dach
c195fbe76f
Merge branch 'master' into crop-gameplay-textures
2023-10-05 09:35:58 +02:00
Bartłomiej Dach
0f7093cb22
Merge pull request #25015 from peppy/fix-intermittent-test-failure
...
Fix `TestReplayExport` intermittent failure
2023-10-05 08:17:42 +02:00
Dean Herbert
76cc2f9f22
Fix WaveformComparisonDisplay potentially crashing on invalid track length
...
As seen at https://github.com/ppy/osu/runs/17415814918#r0s2 .
2023-10-05 14:58:55 +09:00
Dean Herbert
5a0faaa0b1
Fix TestReplayExport intermittent failure
...
The previous fix was not working as it was checking the path for the
prefix `_`, not the filename.
See https://github.com/ppy/osu/runs/17415814653#r0s2 which clearly shows
this.
2023-10-05 14:30:06 +09:00
Dan Balasescu
2e0ca45773
Remove duplicated usage instructions
2023-10-05 14:09:58 +09:00
Dan Balasescu
bca257eeda
Add description
2023-10-05 13:32:20 +09:00
Dean Herbert
f8455af0d0
Fix double interpolation being applied when applyOffsets=false
2023-10-05 13:20:52 +09:00
Dan Balasescu
9f350ce13c
Add new difficulty calculation github action
2023-10-05 13:20:07 +09:00
Bartłomiej Dach
a1368df62f
Allow judging at most one swell tick per frame
2023-10-04 19:08:03 +02:00
Bartłomiej Dach
2ae1a24355
Add failing test covering counting multiple swell hits per frame
2023-10-04 19:08:02 +02:00
Dean Herbert
20342d430d
Update framework
2023-10-04 23:55:38 +09:00
Bartłomiej Dach
bd71403309
Merge branch 'master' into health-animates-in-intro
2023-10-04 13:53:42 +02:00
Bartłomiej Dach
66824ce8ca
Merge pull request #25006 from smoogipoo/fix-spinner-precision
...
Fix spinner requirements being susceptible to FP precision
2023-10-04 10:03:49 +02:00
Dean Herbert
a186d97edf
Update framework
2023-10-04 16:57:54 +09:00
Dean Herbert
5a17a86d1d
Merge branch 'master' into clock-fix-attempt-2
2023-10-04 16:57:49 +09:00
Dean Herbert
658b6a166f
Fix regression in Tracking state handling
...
It turns out multiple components depend on `Tracking` eventually
becoming `false` at the end of a slider. With my previous changes, this
was no longer the case (as could be seen by the legacy cursor particles
test failure, and heard by slider slide taking too long to stop).
2023-10-04 16:11:40 +09:00
Marvin Schürz
6d97f89399
Rename OnlinePlayScreen.LoungeSubScreen to Lounge
2023-10-04 08:37:22 +02:00
Marvin Schürz
6bd51b32b4
Make resolved multiplayerClient field nullable
2023-10-04 08:35:45 +02:00
Marvin Schürz
0726ccb988
Fix formatting
2023-10-04 08:32:18 +02:00
Marvin Schürz
74ed3bc4ff
Rename loadRoom to lookupRoom
2023-10-04 08:31:50 +02:00
Marvin Schürz
bfeafd6f70
Fix formatting
2023-10-04 08:30:48 +02:00
Dean Herbert
d14d885d19
Add test coverage of very fast slider
2023-10-04 14:58:05 +09:00
Dan Balasescu
48209872bf
Fix spinner requirements being susceptible to FP precision
2023-10-04 13:53:33 +09:00
Dean Herbert
cfb18e18c0
Add better commenting around legacy last tick edge case
2023-10-04 13:45:26 +09:00
Dean Herbert
9361b1879c
Add note about early return in DrawableSliderBall.Update
2023-10-04 13:45:26 +09:00
Dean Herbert
425fc9d61f
Merge branch 'master' into legacy-tick-test-coverage
2023-10-04 13:45:26 +09:00
Dean Herbert
8d91991214
Fix difficulty calculation not correct handling slider leniency anymore
2023-10-04 13:45:26 +09:00
Dean Herbert
72cbc3b9cf
Merge pull request #24965 from peppy/legacy-tick-not-so-legacy-after-all
...
Tidy up `LegacyLastTickOffset` usages and stop passing everywhere
2023-10-04 11:42:32 +09:00
Dan Balasescu
854b797ab5
Merge branch 'master' into legacy-tick-not-so-legacy-after-all
2023-10-04 10:52:13 +09:00
Marvin Schürz
fe5177fa4f
Remove unused import
2023-10-04 00:50:48 +02:00
Marvin Schürz
5469d134cb
Add missing parameter description to docs.
2023-10-04 00:28:01 +02:00
Marvin Schürz
5678d90461
Reduce silliness of notification test case
2023-10-04 00:20:38 +02:00
