Dean Herbert
a047456354
Revert changes to make HitObject abstract
2020-02-25 19:07:15 +09:00
Dean Herbert
ffc7eaa3f2
Fix hitobjects with unknown lifetimes by enforcing non-null judgement
...
We've seen multiple cases where DrawableHitObject are stuck in the lifetime management container
due to not implementing a judgement (meaning they are never "hit" or "missed"). To avoid this going forward
CreateJudgement() must be implemented and return a non-null judgement.
This fixes BananaShower and JuiceStreams in osu!catch.
This also makes HitObject abstract and cleans up convert HitObject implementations.
2020-02-23 13:49:06 +09:00
Dean Herbert
cd666166d5
Merge pull request #7809 from voidedWarranties/proposal-difficulty-icon-select
...
Allow selecting/playing a specific difficulty using the beatmapset difficulty icons
2020-02-21 10:24:12 +09:00
smoogipoo
1a689231c2
Support null leaderboard position
2020-02-20 14:51:25 +09:00
voidedWarranties
8c81f1e684
Move CarouselBeatmap access to private, test using indices
2020-02-15 17:51:55 -08:00
voidedWarranties
8e1ecddb1d
Add testing
2020-02-14 17:23:24 -08:00
Dean Herbert
333f976580
Fix test finding deleted beatmaps under dotnet-test
2020-02-11 17:47:10 +09:00
Dean Herbert
926cde9afc
Fix potential test failures
2020-02-10 18:17:59 +09:00
Dean Herbert
d61516e10c
Add failing tests
2020-02-10 16:59:54 +09:00
Dan Balasescu
93952d438f
Merge pull request #7677 from peppy/decouple-mod-select-bindable
...
Decouple ModSelectOverlay from global SelectedMods
2020-02-03 16:27:47 +09:00
Dean Herbert
9183c78319
Fix crash on exiting song select with ctrl-enter autoplay
2020-02-03 16:04:32 +09:00
Bartłomiej Dach
e90ae667b7
Add failing tests
2020-02-01 16:08:24 +01:00
Bartłomiej Dach
a74d22d9e5
Extract beatmap stats test to separate scene
2020-02-01 15:50:33 +01:00
Dean Herbert
ab7bbf38a8
Set default beatmap later in test initialisation
2020-01-31 16:14:55 +09:00
Dean Herbert
5f48affcba
Centralise screen exit logic to ScreenTestScene
2020-01-31 14:19:29 +09:00
smoogipoo
f457ecaf83
Fix random test failures
2020-01-29 13:54:12 +09:00
Dean Herbert
fd7f07433d
Ensure selection has occurred before storing value
2020-01-27 18:26:44 +09:00
Dean Herbert
1f0aaabf7b
Add tests
2020-01-27 12:21:17 +09:00
smoogipoo
bb390b4470
Add test
2020-01-24 19:40:20 +09:00
Dean Herbert
56724d2580
Merge branch 'master' into #7146
2020-01-10 01:08:20 +08:00
Dean Herbert
ab9603b06a
Merge remote-tracking branch 'upstream/master' into #7146
2020-01-09 17:08:12 +08:00
smoogipoo
91735ff367
Update MathUtils namespace usages
2020-01-09 13:43:44 +09:00
Lucas A
3bd3ebad49
Move placeholders to a dedicated namespace
2020-01-04 19:56:34 +01:00
Willy Tu
e23c71be80
Update Resolved and Cached attribute issues
2020-01-03 11:34:26 -08:00
Willy Tu
0a4e180ce7
Merge branch 'master' of github.com:ppy/osu into #7146
2020-01-03 11:32:06 -08:00
Dean Herbert
69227d6179
Add asserts
2019-12-22 06:37:18 +09:00
Dean Herbert
725008286f
Move test and remove pointless duplicate tests
2019-12-22 06:09:16 +09:00
Dean Herbert
df14f473c2
Split tests out
2019-12-20 19:52:54 +09:00
Willy Tu
6abbd33b51
Fixed CI issues
2019-12-19 21:57:14 -08:00
Willy Tu
8ab26e8889
Update Tests with dependencies on LeaderboardScore. Added its dependency on DialogOverlay for the tests. Added test for deleting individual local score
2019-12-19 21:29:54 -08:00
Dean Herbert
54572b6de9
Update selected mdos references
2019-12-18 16:42:18 +09:00
Dean Herbert
d7eb4f73f4
Merge branch 'master' into update-beatmap-settings
2019-12-16 14:57:57 +09:00
Dean Herbert
bc31146560
Mods -> SelectedMods
2019-12-13 21:45:38 +09:00
unknown
3945e7403a
improve tests and refactor AdvancedStats
2019-12-13 09:39:54 +08:00
unknown
ec5b506960
apply mod difficulty settings during song select
2019-12-12 23:41:46 +08:00
Dean Herbert
cdde5d1d69
Fix song select filters not reapplied if in a child screen
...
Closes https://github.com/ppy/osu/issues/6980 .
2019-12-10 02:30:23 +09:00
Dean Herbert
f0d49d0cdf
Decouple APILegacyScoreInfo from ScoreInfo
2019-12-03 15:31:11 +09:00
Dean Herbert
296fff9243
Merge remote-tracking branch 'upstream/master' into fix-carousel-double-filter
2019-11-15 18:20:36 +09:00
Dean Herbert
b8bb97607b
Merge remote-tracking branch 'upstream/master' into fix-mod-retention
2019-11-15 13:46:44 +09:00
Dean Herbert
e81dfcad4c
Fix remaining cases of pollution
2019-11-15 11:46:32 +09:00
Dean Herbert
22c3be2c6f
Clear count variables on carousel creation
2019-11-15 11:26:01 +09:00
Dean Herbert
1109d201c3
Add failing test
2019-11-14 13:28:13 +09:00
Dean Herbert
2fe068174a
Fix unnecessary string interpolation
2019-11-13 19:42:33 +09:00
Dean Herbert
2cd156f3d4
Clean up carousel tests
2019-11-13 19:09:03 +09:00
Dean Herbert
bca1be0bfa
Add failing test
2019-11-13 18:54:33 +09:00
Huo Yaoyuan
ccc8aa6fa4
Apply brace style.
2019-11-11 20:13:13 +08:00
Bartłomiej Dach
022cc13952
Add beatmap carousel item sorting stability test
...
Add visual test to ensure sorting stability when sorting criteria are
applied in the beatmap carousel.
2019-10-27 22:55:46 +01:00
smoogipoo
12cd57744b
Make RulestStore initialise at construction time
2019-10-15 16:14:06 +09:00
Dan Balasescu
69b9e359bf
Merge branch 'master' into fix-ss-track-playback
2019-10-09 12:26:07 +09:00
Dean Herbert
8ebccfe31f
Add comprehensive audio state tests
2019-10-08 17:03:13 +09:00
