23 Commits

• Fix editor not showing beatmap background in some cases
  Dean Herbert · 2026-04-01 02:03:11 +09:00
  5c20254f76
• Fix editor background taking too long to load with certain storyboards (#37038)

  TL;DR the clock was being set too late, causing more transforms to be
  created than necessary.
  
  This solves the issue by way of a refactor (sorry). Overall this should
  simplify handling of things as more of the logic is shared with the
  known good-state `BeatmapBackgroundWithStoryboard`.
  
  I did try without a refactor (just delaying the creation until the clock
  arrives) but this version made more sense because background generally
  expect to do their main load in BDL to aid in smooth transitions. And we
  can't get the clock by there. (although arguably we could just use a
  similar method to `BeatmapBackgroundWithStoryboard` and forego using the
  editor clock).
  
  Of note, I removed the black background overdraw hack. There are edge
  cases where it will lead to weird transitions, but these are far and few
  between. Basically you need a storyboard which sets the flag to hide the
  beatmap background and has transparency in it. This is no longer as
  flagrantly bad as things used to be (which led to the inline fix) as far
  as I can tell, but feel free to prove me wrong. If this is a blocker
  I'll probably just add a permanent black box (which does fix this).
  
  Closes #36875.

  Dean Herbert · 2026-03-23 09:26:34 +01:00
  95648a3d27
• Avoid spinning another load thread on initial storyboard load
  Salman Ahmed · 2023-11-11 02:57:17 +03:00
  bb912bc616
• Schedule outside of UnloadStoryboard and fix disposal happening on update thread
  Salman Ahmed · 2023-11-11 02:56:45 +03:00
  080f13e34d
• Hide background sprite when storyboard finishes loading
  Salman Ahmed · 2023-11-09 23:23:57 +03:00
  59998b507a
• Remove fade out transition

  Unnecessary addition from this PR, makes the background fade to ugly black during transition between screens.

  Salman Ahmed · 2023-11-09 23:03:30 +03:00
  e947158969
• Fix background crash on a beatmap with no storyboard
  Salman Ahmed · 2023-11-09 22:57:20 +03:00
  768a31b2f5
• Unload beatmap storyboard background when no longer present
  Salman Ahmed · 2023-11-09 17:20:11 +03:00
  bd8409219f
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Fix storyboard samples rate not adjusted from actual gameplay mods
  Salman Ahmed · 2022-03-02 20:56:18 +03:00
  cbb8dc2891
• Rewrite storyboard clock management in slightly different way
  Bartłomiej Dach · 2022-01-11 22:00:04 +01:00
  76d5225bb9
• Add clarification comment about explicit ProcessFrame() call
  Bartłomiej Dach · 2021-12-27 21:13:04 +01:00
  568cab6808
• Fix menu background storyboard stopping after track reload
  Bartłomiej Dach · 2021-12-27 12:30:53 +01:00
  9f8ad9f833
• Tidy up code
  Dean Herbert · 2021-06-04 15:18:16 +09:00
  19a44d65c5
• apply suggestions

  - apply 0 alpha to beatmap background if storyboard replaces it
  - use an AudioContainer to mute all samples coming from the storyboard

  Nathan Alo · 2021-06-04 13:56:10 +08:00
  996c156106
• use created storyboard to check for drawables instead
  Nathan Alo · 2021-06-03 13:56:14 +08:00
  d7d0dde5d2
• apply suggestions

  - Replace the sprite with a solid black box when a storyboard requests it.
  - Create a new storyboard instance and exclude the fail layer as well as strip all samples from it
  - Do not attempt in creating the storyboard when it isn't needed

  Nathan Alo · 2021-06-03 13:27:00 +08:00
  62b07fb9ce
• Revert "refactor BeatmapBackgroundWithStoryboard to reduce overhead"

  This reverts commit 277545bb06.

  Dean Herbert · 2021-06-03 12:33:16 +09:00
  a62dd7cca0
• refactor BeatmapBackgroundWithStoryboard to reduce overhead

  This avoids loading the sprite if its not needed and instead of hiding it, it is removed when the storyboard replaces the background or there is a video.
  
  This also only initializes DrawableStoryboard if there are any elements in any layer.

  Nathan Alo · 2021-06-02 20:27:12 +08:00
  277545bb06
• remove fade
  Nathan Alo · 2021-06-02 16:28:22 +08:00
  3c3ef13632
• fix inspect code issues and cleanup code
  Nathan Alo · 2021-06-02 16:12:41 +08:00
  e66f6e8f91
• implement BeatmapBackgroundWithStoryboard
  Nathan Alo · 2021-06-02 15:50:58 +08:00
  dec18ef826