53 Commits

• Turn tests green, for a short while, maybe (#37218)

  ## [Rewrite `BackgroundMusicManager` to not run into framework
  breakage](https://github.com/ppy/osu/commit/622216d8911832c39fa4e126b2810e4e0f46cbf7)
  
  The attempted proper fix to this was
  https://github.com/ppy/osu-framework/pull/6727. Unfortunately when
  presented with [the framework
  bump](https://github.com/ppy/osu/pull/37217) with that change, CI says
  "you're stupid" and fails on some disposal idiocy that of course is
  undebuggable and irreproducible:
  
  The active test run was aborted. Reason: Test host process crashed :
  Unhandled exception. System.AggregateException: One or more errors
  occurred. (Object reference not set to an instance of an object.)
  ---> System.NullReferenceException: Object reference not set to an
  instance of an object.
  at osu.Framework.Audio.Sample.SampleChannelBass.Dispose(Boolean
  disposing)
  at System.Threading.ExecutionContext.RunInternal(ExecutionContext
  executionContext, ContextCallback callback, Object state)
  	--- End of stack trace from previous location ---
  at System.Threading.ExecutionContext.RunInternal(ExecutionContext
  executionContext, ContextCallback callback, Object state)
  at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task&
  currentTaskSlot, Thread threadPoolThread)
  	   --- End of inner exception stack trace ---
  	   at osu.Framework.Audio.AudioCollectionManager`1.UpdateChildren()
  	   at osu.Framework.Audio.AudioCollectionManager`1.UpdateChildren()
  	   at osu.Framework.Audio.AudioCollectionManager`1.UpdateChildren()
  	   at osu.Framework.Audio.AudioCollectionManager`1.UpdateChildren()
  	   at osu.Framework.Threading.AudioThread.OnExit()
  at osu.Framework.Threading.GameThread.setExitState(GameThreadState
  exitState)
  	   at osu.Framework.Threading.GameThread.RunSingleFrame()
  at osu.Framework.Threading.GameThread.<createThread>g__runWork|70_0()
  at System.Threading.ExecutionContext.RunInternal(ExecutionContext
  executionContext, ContextCallback callback, Object state)
  	--- End of stack trace from previous location ---
  at System.Threading.ExecutionContext.RunInternal(ExecutionContext
  executionContext, ContextCallback callback, Object state)
  
  
  (https://github.com/ppy/osu/actions/runs/24019928154/job/70046733058?pr=37217#step:5:119)
  
  I no longer have the energy for any of this shit.
  
  @nekodex would appreciate if you could check that I actually haven't
  broken anything with the bgm here. Seems okay to me in test scenes at
  least.
  
  ## [Apply lowest-effort maybe-fixing changes to a bunch of flaking
  tests](https://github.com/ppy/osu/commit/7bd3ca4adfcce5b90add11565a13f3fe9177ad5e)
  
  None of the failures are reproducible locally, of course. I'm tired of
  this. If anyone else wants to subject themselves to actually
  investigating any of these, by all means, godspeed and good luck.

  Bartłomiej Dach · 2026-04-06 17:59:39 +09:00
  809298ddeb
• Move v2 files to final location

  This contains only renames and namespace updates.

  Dean Herbert · 2026-03-03 16:45:15 +09:00
  c28c64940a
• Update existing tests to work with Song Select v2
  Dean Herbert · 2025-07-01 17:25:38 +09:00
  397b9b3994
• Fix SHOCKING test

  What the actual heck is that magic number stupidity.
  
  I'm not looking into why the test falls over so badly that it apparently
  dies on some main menu logic just because assertions fail, because the
  main menu logic is for hold-to-song-select-v2 and is thus temporary.

  Bartłomiej Dach · 2025-06-13 10:34:14 +02:00
  f4bf2ae7a5
• Mark recommendation test as flaky

  Will revisit during song select refactoring no doubt.

  Dean Herbert · 2025-01-07 17:58:12 +09:00
  b8a10d9b0e
• Fix test
  Dan Balasescu · 2024-12-13 17:41:55 +09:00
  edbaaa9468
• Add test and null protections
  Joseph Madamba · 2024-12-12 15:23:00 -08:00
  f7364de01a
• Fix more test / component breakage
  Salman Alshamrani · 2024-11-17 20:36:12 -05:00
  b106833663
• Fix various test failures
  Salman Alshamrani · 2024-11-17 19:13:29 -05:00
  caf56afba6
• Make class partial
  Dan Balasescu · 2024-11-07 17:28:31 +09:00
  4d7fd236c5
• Fix tests not working by forgoing beatmap updates
  Dan Balasescu · 2024-11-07 17:26:10 +09:00
  bd630c189e
• Fix intermittent beatmap recommendations test
  Dan Balasescu · 2024-11-06 21:12:16 +09:00
  35d004cdc2
• Fix occasional test failures in TestSceneBetmapRecommendations

  The game was being constructed befor the API was setup, which could mean
  depending on test execution ordering and speed, the recommendations
  array would not be filled.
  
  Easy to reproduce by `[Solo]`ing `TestCorrectStarRatingIsUsed`.
  
  See https://github.com/ppy/osu/runs/28689915929#r0s0.

  Dean Herbert · 2024-08-13 17:28:16 +09:00
  14a00621f8
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Fix regressing BeatmapRecommendations tests due to diffcalc running at
  Dean Herbert · 2022-07-01 17:10:15 +09:00
  0e1f08eff8
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Use new own profile statistics in difficulty recommender
  Endrik Tombak · 2022-06-08 17:44:57 +03:00
  bf67b35ade
• Remove Task from the inner-most Import method in RealmArchiveModelImporter

  One of my pending work items for post-realm merge.
  
  The lowest-level import task is no longer asynchronous, as we don't want
  it to span multiple threads to allow easier interaction with realm.
  Removing the `Task` spec simplifies a heap of usages.
  
  Individual usages should decide whether they want to run the import
  asynchronously, by either using an alternative override or spooling up a
  thread themselves.

  Dean Herbert · 2022-01-25 15:30:29 +09:00
  778d2a71b4
• Fix a couple of minor issues with TestSceneBeatmapRecommendations
  Dean Herbert · 2022-01-12 17:49:10 +09:00
  8e79898e26
• Update usages to new naming
  Dean Herbert · 2022-01-06 22:54:43 +09:00
  00177a3ae1
• Replace usage of .Result with .WaitSafelyForResult
  Dean Herbert · 2022-01-04 11:51:41 +09:00
  73b40e6833
• Replace one more usage
  Dean Herbert · 2021-11-24 18:29:33 +09:00
  0fe27cc8a1
• Merge pull request #15778 from peppy/ruleset-info-id-usage

  Update usages of `RulesetInfo.ID` to use `OnlineID` instead

  Dan Balasescu · 2021-11-24 16:55:28 +09:00
  74b6c33fab
• Update mock RulesetInfo usage to set OnlineID instead of ID
  Dean Herbert · 2021-11-24 15:50:26 +09:00
  f283770f34
• Revert changes causing BeatmapSet.Metadata to be expectedly null in some tests
  Dean Herbert · 2021-11-24 14:52:08 +09:00
  44c34ca7b2
• Fix cases of dynamically assigning Beatmaps to BeatmapSetInfo using list assignment
  Dean Herbert · 2021-11-24 13:27:37 +09:00
  8c60f37508
• Use new helper method
  Dean Herbert · 2021-11-15 19:19:53 +09:00
  4856180912
• Fix TestSceneBeatmapRecommendations testing with an online ID of 0
  Dean Herbert · 2021-11-15 19:19:53 +09:00
  86b8fd3720
• Rename BeatmapSetInfo.OnlineBeatmapSetID to OnlineID to match interface
  Dean Herbert · 2021-11-12 17:52:44 +09:00
  692e846acd
• Rename BeatmapInfo.OnlineBeatmapID to OnlineID to match interface
  Dean Herbert · 2021-11-12 17:46:24 +09:00
  6a098a8634
• Rename BeatmapInfo.Version to DifficultyName to match underlying interface
  Dean Herbert · 2021-11-11 17:20:53 +09:00
  51a353e12d
• Rename BeatmapInfo.StarDifficulty to StarRating to match underlying interface
  Dean Herbert · 2021-11-11 17:19:46 +09:00
  ebe58cee11
• Rename User to APIUser and move to correct namespace
  Dean Herbert · 2021-11-07 11:26:01 +09:00
  0ecf5f201c
• Initial push to use ILive in import process
  Dean Herbert · 2021-09-30 22:55:25 +09:00
  a2e61883e3
• Fix TestSettingsMigration's usage of RecycleLocalStorage
  Dean Herbert · 2021-08-18 16:39:10 +09:00
  2758a83d55
• Add return bool to HandleRequest to better trigger failures
  Dean Herbert · 2021-03-23 18:17:29 +09:00
  aeff9bd853
• Revert EF Core to version 2.2

  This reverts commit f3faad74d5, reversing
  changes made to 712e7bc7bf.
  
  Several issues arose after migrating to 5.0, including, but possibly not
  limited to, performance regressions in song select, as well as failures
  when attempting to save beatmaps after metadata changes in the editor.

  Bartłomiej Dach · 2021-03-21 11:05:15 +01:00
  a16c0641b2
• Add comments marking workarounds required for EFcore 5
  Dean Herbert · 2021-03-15 13:29:26 +09:00
  fce21f23d6
• Actualize tests
  Roman Kapustin · 2021-03-11 21:02:40 +03:00
  c6c616f244
• Remove unnecessary resolved recommender in test
  Dean Herbert · 2020-12-22 14:42:12 +09:00
  c6be969e33
• Add test for recommending current ruleset
  Endrik Tombak · 2020-12-03 20:07:42 +02:00
  e792f07084
• Apply review suggestions
  Endrik Tombak · 2020-12-03 19:44:12 +02:00
  48dad61a46
• Remove no longer necessary force calculation

  Is no longer necessary because recommender uses bindable state value changes, compared to when the test was written, and runs the state change once on load

  Endrik Tombak · 2020-11-21 14:36:43 +02:00
  07db977af5
• Add clarifying comment about pp choice
  Endrik Tombak · 2020-05-01 19:46:49 +03:00
  d30e4061cc
• Add failing test
  Endrik Tombak · 2020-05-01 19:43:18 +03:00
  3cf60e6e00
• Improve test code quality & safety
  Bartłomiej Dach · 2020-05-01 16:59:45 +02:00
  2913a81835
• Fix comment
  Endrik Tombak · 2020-04-25 10:37:18 +03:00
  f68a7401b9
• Other review suggestions
  Endrik Tombak · 2020-04-25 10:36:19 +03:00
  e65acc3401
• Fix typo
  Endrik Tombak · 2020-04-25 10:25:07 +03:00
  e906ec4d92
• Use GetRuleset
  Endrik Tombak · 2020-04-25 10:22:19 +03:00
  52416ea90a