Dean Herbert
83b0e4572a
Fix test failures
2022-01-25 16:51:21 +09:00
Dan Balasescu
d8270fe14f
Merge pull request #16604 from peppy/less-async-import
...
Remove `Task` from the inner-most `Import` method in `RealmArchiveModelImporter`
2022-01-25 16:47:07 +09:00
Dan Balasescu
1c6ad56821
Merge pull request #16595 from peppy/realm-block-timeout-assert-failure
...
Fix a failed `BlockAllOperations` leaving update realm in unretrieved state
2022-01-25 16:03:13 +09:00
Dean Herbert
778d2a71b4
Remove Task from the inner-most Import method in RealmArchiveModelImporter
...
One of my pending work items for post-realm merge.
The lowest-level import task is no longer asynchronous, as we don't want
it to span multiple threads to allow easier interaction with realm.
Removing the `Task` spec simplifies a heap of usages.
Individual usages should decide whether they want to run the import
asynchronously, by either using an alternative override or spooling up a
thread themselves.
2022-01-25 15:30:29 +09:00
Dean Herbert
ae0fea8e26
Fix compilation issues due to misnamed fild
2022-01-25 15:29:45 +09:00
Dan Balasescu
47a13c2eb0
Merge pull request #16603 from peppy/update-framework
...
Update framework
2022-01-25 15:15:49 +09:00
Dean Herbert
35e1c7de7d
Merge branch 'master' into realm-block-timeout-assert-failure
2022-01-25 15:05:11 +09:00
Dean Herbert
bda77fb6b3
Merge branch 'master' into realm-block-timeout-assert-failure
2022-01-25 14:47:34 +09:00
Dean Herbert
56d7d81465
Fix broken test due to SynchronizationContext never running expected work
2022-01-25 14:47:21 +09:00
Dan Balasescu
bfa521bdd2
Merge pull request #16593 from peppy/realm-clean-up
...
Clean up realm naming
2022-01-25 14:33:53 +09:00
Dan Balasescu
b2114bd2f0
Merge pull request #16601 from peppy/fix-storage-migration-test-failures
...
Fix `TestMigration` failing due to changes in realm migration logic
2022-01-25 14:33:35 +09:00
Dean Herbert
86c844bd58
Update remaining usages of GetSuitableHost in template projects
2022-01-25 14:15:29 +09:00
Dean Herbert
8116806db3
Add test coverage of calling BlockAllOperations a second time after timeout
2022-01-25 14:00:58 +09:00
Dean Herbert
dd2caea694
Update GetSuitableHost usages in line with new HostOptions
2022-01-25 13:52:02 +09:00
Dean Herbert
bbcc149e2e
During import if files are found to be missing, ensure they are restored
...
This is one step closer to sanity in terms of physical files. As per the
comment I have left in place, we really should be checking file sizes or
hashes, but to keep things simple and fast I've opted to just cover the
"missing file" scenario for now.
Ran into this when testing against a foreign `client.realm` by:
- Noticing a beatmap doesn't load
- Deleting said beatmap
- Downloading via beatmap overlay
- Beatmap is restored but still doesn't work
Note that I've kept the logic where this will undelete an existing
import rather than create one from fresh, as I think that is beneficial
to the user (ie. it will still keep any linked scores on restore).
2022-01-25 13:44:54 +09:00
Dean Herbert
d7342880f5
Update remaining cases of clashes with realm.Write and realm.RegisterForNotifications
2022-01-25 13:09:48 +09:00
Dean Herbert
e23b10e6a5
Update remaining cases of clashing variable name in realm.Run(realm..
2022-01-25 13:04:05 +09:00
Dean Herbert
3e5c9e8436
Fix cases of Access instead of Realm
2022-01-25 12:58:15 +09:00
Dean Herbert
2d34831b5f
Fix TestMigration failing due to changes in realm migration logic
...
Fixes failures as seen at https://github.com/ppy/osu/runs/4927916031?check_suite_focus=true .
2022-01-25 12:54:40 +09:00
Dean Herbert
f30894840c
Update terminology to realm "instance" rather than "context"
...
This matches the terminology used by realm themselves, which feels
better.
2022-01-24 20:38:38 +09:00
Dean Herbert
6eb2c28e41
Rename RealmContextFactory to RealmAccess
2022-01-24 20:38:07 +09:00
Dean Herbert
9ff9611296
Merge branch 'master' into realm-stable-subscriptions
2022-01-24 18:25:47 +09:00
Dean Herbert
d7db6fa918
Merge branch 'master' into custom-meter
2022-01-24 15:46:44 +09:00
Dean Herbert
6581e8c2d3
Merge pull request #16549 from Susko3/LoginPanel-flag
...
Hide the login panel when clicking the country flag
2022-01-24 15:38:50 +09:00
Dean Herbert
40aa873190
Rename register methods to better explain their purpose
2022-01-24 14:37:36 +09:00
Bartłomiej Dach
e236f5d604
Add failing test coverage for correct beatmap filename generation on save
2022-01-23 20:28:19 +01:00
Dean Herbert
0709a2ac9b
Add test coverage of realm subscription scenarios
2022-01-23 20:28:13 +09:00
Dean Herbert
db86394355
Fix TestResources returning a test BeatmapSetInfo that can't be laoded directly into realm
2022-01-23 20:28:04 +09:00
Salman Ahmed
1ea5a2e6a7
Fix incorrect assert step name
2022-01-23 10:11:12 +03:00
Bartłomiej Dach
f39f2c93b5
Add control for arbitrary-numerator time signatures
2022-01-22 20:50:31 +01:00
Bartłomiej Dach
735414bc49
Replace TimeSignatures enum with struct for storage of arbitrary meter
2022-01-22 20:50:31 +01:00
Dean Herbert
6a076a684e
Merge branch 'realm-context-use-update-when-feasible' into realm-stable-subscriptions
2022-01-22 13:14:25 +09:00
Dean Herbert
c9db0181d0
Attempt to fix test failures on windows due to context being held open
2022-01-22 12:24:05 +09:00
Susko3
9b63f15e68
Add failing test
2022-01-21 13:58:30 +01:00
Dean Herbert
1f157d729d
Update existing subscriptions to new style
...
Fix missing detach calls in `MusicController`
2022-01-21 20:05:03 +09:00
Dean Herbert
114c9e8c1f
Update all usages of CreateContext to use either Run or Write
2022-01-21 17:27:08 +09:00
Dean Herbert
70cc03fe43
Avoid constructor overhead for realm RealmKeyBinding parameterless constructor
2022-01-20 17:29:07 +09:00
Dan Balasescu
7509b31176
Merge pull request #16519 from peppy/fix-legacy-score-import-classic-mod
...
Fix legacy score imports not correctly getting classic mod assigned
2022-01-20 14:28:29 +09:00
Dan Balasescu
4f86a2cb61
Merge pull request #16525 from bdach/beatmap-listing-overflow-and-scrolling
...
Improve usability of expanded card content on beatmap listing
2022-01-20 14:14:44 +09:00
Bartłomiej Dach
4cad5890c6
Add test coverage for news sidebar showing wrong headers
2022-01-19 23:12:35 +01:00
Bartłomiej Dach
d925e44b40
Add test coverage for beatmap card expanded content clipping
2022-01-19 22:08:52 +01:00
Bartłomiej Dach
fea4400c03
Remove unused using directive
2022-01-19 18:49:37 +01:00
Dean Herbert
a002dacdce
Add test coverage of various ScoreInfo mod set operations
2022-01-19 14:34:27 +09:00
Dean Herbert
bb6f40d16e
Add test coverage of all mod storages containing classic mod post-import
2022-01-19 14:34:27 +09:00
Dan Balasescu
581873f944
Merge pull request #16497 from peppy/top-local-rank-optimisation
...
Rewrite `TopLocalRank` to use realm subscriptions
2022-01-19 14:22:12 +09:00
Dan Balasescu
3e5d29ed00
Merge pull request #16505 from peppy/remove-base-difficulty-usage
...
Remove all usage of `BaseDifficulty` (and access `Difficulty` instead)
2022-01-19 13:53:55 +09:00
Dean Herbert
201f2d7813
Add comprehensive test coverage for TopLocalRank
2022-01-19 13:48:00 +09:00
Dan Balasescu
2556f1cb87
Merge branch 'master' into optimise-set-detach-part-2
2022-01-19 13:20:38 +09:00
Dan Balasescu
f6f44029e8
Merge pull request #16507 from peppy/more-ingore-rules
...
Add some missing `IgnoredAttributes` to reduce automapper overhead
2022-01-19 12:26:37 +09:00
Bartłomiej Dach
7df18c7767
Merge branch 'master' into playlist-test-coverage
2022-01-18 20:17:48 +01:00
Dean Herbert
96d07e20ed
Revert nunit test adaptor version bump until console output bug is resolved
...
Tests have started to output too much log content, causing viewing CI
failures to be painfully impossible. Roll back for now.
Fix may be related to
https://github.com/nunit/nunit3-vs-adapter/issues/941 , although we don't
use filter.
2022-01-19 02:18:58 +09:00
Dean Herbert
1db2135d70
Update tests to match new behaviour
2022-01-19 01:05:47 +09:00
Dean Herbert
67bf95bc91
Remove all usage of AuthorString
2022-01-18 23:30:40 +09:00
Dean Herbert
7f65f3a47f
Remove all usage of BaseDifficulty (and access Difficulty instead)
2022-01-18 22:57:39 +09:00
Dean Herbert
02baad30d7
Merge branch 'master' into global-bindable-thread-safety
2022-01-18 18:12:00 +09:00
Dan Balasescu
73a1f27ce5
Merge branch 'master' into realm-integration/score-and-beatmaps
2022-01-18 17:31:37 +09:00
Dean Herbert
3e9e7a8fb6
Fix PLaylistsResultsScreen tests falling over due to missing beatmap
2022-01-18 16:48:27 +09:00
Dean Herbert
8978b88f69
Add test coverage of startup ruleset being non-default
2022-01-18 16:22:15 +09:00
Dan Balasescu
b4fdd8a986
Merge pull request #16489 from peppy/aggregate-score-tests
...
Add test coverage of aggregate scores displaying correctly at multiplayer/playlists screens
2022-01-18 16:03:06 +09:00
Dean Herbert
7084183d6c
Fix test beatmaps created without hash being populated
2022-01-18 15:43:02 +09:00
Dean Herbert
1b62a685f3
Merge branch 'master' into realm-integration/score-and-beatmaps
2022-01-18 15:07:59 +09:00
Dean Herbert
d26f4d50bd
Add test coverage of aggregate room scores displaying correctly
2022-01-18 14:00:12 +09:00
Dean Herbert
c3d3c03f0f
Fix TestScenePlaylistsScreen crashing on entering room
2022-01-18 13:42:41 +09:00
Dean Herbert
da9a60a695
Update broken test scenes to match new OsuTestScene logic
2022-01-18 13:41:50 +09:00
Dean Herbert
125439d177
Update all (non-NET6) nuget packages
2022-01-18 11:09:26 +09:00
Dan Balasescu
e9c96908d5
Merge pull request #16481 from peppy/fix-scores-container-tests
...
Rewrite `TestSceneScoresContainer` to work again
2022-01-17 20:39:14 +09:00
Dean Herbert
0ba0b5f11a
Fix test step not being until when it needs to be
2022-01-17 19:45:32 +09:00
Dan Balasescu
f6b9d36acf
Remove unused using
2022-01-17 17:06:04 +09:00
Dean Herbert
a80e461000
Add better test coverage of user top scores
2022-01-17 16:23:58 +09:00
Dean Herbert
12fd279b7d
Add test to check full flow of rebinding gameplay key bindings
...
Addresses a regression found in realm PR that was not covered by tests.
2022-01-17 16:00:17 +09:00
Dean Herbert
6436b6186f
Rewrite TestScenScoresContainer to work again
2022-01-17 15:15:39 +09:00
Dean Herbert
5dc7425b2c
Fix incorrect realm (non-isolated instance) being used in two test scenes
2022-01-17 14:55:23 +09:00
Dean Herbert
90166829c3
Update tests which were importing scores without a valid beatmap
2022-01-17 14:47:19 +09:00
Bartłomiej Dach
03e4ec4214
Merge branch 'master' into realm-integration/score-and-beatmaps
2022-01-15 14:45:42 +01:00
Susko3
19467e58c1
Remove unused params from BDL methods
2022-01-15 01:06:39 +01:00
Susko3
9af9155e66
Fix osu.Game.Tests.Android not building
2022-01-14 17:37:58 +01:00
Dean Herbert
8d4a3cc569
Remove pointless Metadata set
2022-01-14 23:27:33 +09:00
Dean Herbert
9900a3f408
Remove outdated comment
2022-01-14 21:40:35 +09:00
Dean Herbert
289ae7c72f
Update one more mismatched test implementation
2022-01-14 21:39:42 +09:00
Dean Herbert
a59dcccab7
Add local ContextFactory caching to all remaining test scenes that create local managers
2022-01-14 19:59:21 +09:00
Dean Herbert
eb5f15a77e
Merge pull request #16420 from bdach/slider-paste-parsing-failures-2
...
Fix pasted sliders having sample points with time at infinity
2022-01-13 23:28:49 +09:00
Dean Herbert
4f8d29c1c0
Merge branch 'master' into realm-integration/score-and-beatmaps
2022-01-13 18:25:09 +09:00
Dean Herbert
7147799895
Merge pull request #16273 from Joehuu/fix-remaining-identifier-names
...
Normalise more identifier names
2022-01-13 17:06:57 +09:00
Dean Herbert
e1f5acd689
Remove names from user dictionary
2022-01-13 12:40:19 +09:00
Joseph Madamba
b245ffefc1
Merge remote-tracking branch 'upstream/master' into fix-remaining-identifier-names
2022-01-12 15:05:07 -08:00
Dan Balasescu
672c1d36dc
Fix intermitten screen navigation tests
2022-01-13 05:52:04 +09:00
Bartłomiej Dach
07fc772c24
Merge branch 'master' into slider-paste-parsing-failures-2
2022-01-12 19:06:36 +01:00
Dean Herbert
2212bea17f
Fix test failures due to double BeginPlaying calls
2022-01-13 01:34:29 +09:00
Dean Herbert
b2d09b7b10
Fix further warnings
2022-01-12 23:42:12 +09:00
Dean Herbert
b5f670cc5b
Add far too many fixes for ruleset non-nullable requirements
2022-01-12 23:24:11 +09:00
Dean Herbert
51251e3204
Fix CI reported warnings
2022-01-12 22:39:00 +09:00
Dean Herbert
38cc1ce098
Add missing ruleset in test scores
2022-01-12 18:51:30 +09:00
Dean Herbert
34aa1bf21d
Sanitise and remove some usages of Detach which are no longer required
2022-01-12 17:49:11 +09:00
Dean Herbert
f24b2b1be3
Make copying detached changes to realm only exposed for BeatmapSet
...
Also fixes remaining issues with the copy process.
2022-01-12 17:49:11 +09:00
Dean Herbert
a307f7e90e
Add test coverage of updating via copying changes from detached instance
2022-01-12 17:49:11 +09:00
Dean Herbert
c92aff8d2b
Add test of cyclic beatmap/beatmapset references
2022-01-12 17:49:11 +09:00
Dean Herbert
509301d94f
Update detach test to assert correct behaviour
2022-01-12 17:49:11 +09:00
Dean Herbert
e0c59f4b3c
Localise EF context factory usage to migration only
2022-01-12 17:49:11 +09:00
Dean Herbert
bf4133021b
Update migration test to use realm file as test
2022-01-12 17:49:11 +09:00
Dean Herbert
7dba3c3551
Fix most remaining test issues
2022-01-12 17:49:11 +09:00
