Bartłomiej Dach
|
59bd6d827e
|
Add failing test case for overlapping objects blocking each other when not intended
|
2023-09-08 10:01:32 +02:00 |
|
Bartłomiej Dach
|
e71fef4b6a
|
Remove braces
|
2023-09-07 18:47:03 +02:00 |
|
Bartłomiej Dach
|
2bb869732e
|
Delete outdated warning disables
|
2023-09-07 18:47:01 +02:00 |
|
Dean Herbert
|
dcbdc114ce
|
Remove precision limitations of SliderVelocity
|
2023-09-07 17:41:58 +09:00 |
|
Dean Herbert
|
b34a36f6ce
|
Remove all usage of LegacyDifficultyControlPoint
|
2023-09-07 17:41:57 +09:00 |
|
Dean Herbert
|
b1a9f50065
|
Merge pull request #24736 from isakvik/negative-ar-adjustment
Allow "Difficulty Adjust" mod's extended AR selection to go below zero
|
2023-09-07 17:17:59 +09:00 |
|
Bartłomiej Dach
|
323a4f4522
|
Only show preempt time when limits are extended
|
2023-09-07 08:30:02 +02:00 |
|
Dean Herbert
|
4d12678c9d
|
Merge pull request #24734 from Joehuu/hd-badges
Use `@2x` variant of profile badges
|
2023-09-07 15:26:58 +09:00 |
|
Bartłomiej Dach
|
bd633889e7
|
Remove local preempt time calculation
And just use a hitcircle, and read the actual value. Comes with 100%
less chance of forgetting to update either place in the future.
|
2023-09-07 08:23:50 +02:00 |
|
Bartłomiej Dach
|
9c6f77b26e
|
Fix too many things being exposed
|
2023-09-07 08:11:04 +02:00 |
|
Dean Herbert
|
281c2f6de1
|
Merge pull request #24733 from Joehuu/wedge-title-artist-link
Link new song select wedge title and artist to search text box
|
2023-09-07 14:51:43 +09:00 |
|
Dean Herbert
|
e05d7d5f8d
|
Inline local control
|
2023-09-07 14:22:06 +09:00 |
|
Dean Herbert
|
d2a6235135
|
Fix code quality issues
|
2023-09-07 14:19:19 +09:00 |
|
Dean Herbert
|
5db262ba3b
|
Merge pull request #24735 from Joehuu/minor-profile-changes
Update badge header background color in line with web
|
2023-09-07 13:20:19 +09:00 |
|
Joseph Madamba
|
0bbe28dcc9
|
Update badge header background color in line with web
|
2023-09-06 16:43:32 -07:00 |
|
isakvik
|
2ab11ab568
|
adds new diffsetting control that shows millisecond values for approach rate override
|
2023-09-07 01:41:22 +02:00 |
|
Joseph Madamba
|
5ee412cc9a
|
Use @2x variant of profile badges
|
2023-09-06 16:17:53 -07:00 |
|
Joseph Madamba
|
d0780fb765
|
Add comment explaining the max width
|
2023-09-06 15:01:55 -07:00 |
|
Joseph Madamba
|
97bd90c0ff
|
Link new song select wedge title and artist to search text box
|
2023-09-06 14:41:10 -07:00 |
|
isakvik
|
3db0d0d341
|
extendable minimum AR value for osu!std diff adjust mod, set to -10
|
2023-09-06 23:26:34 +02:00 |
|
Bartłomiej Dach
|
ce4b523950
|
Merge branch 'master' into fix-mania-skin-lookups-no-sprites
|
2023-09-06 19:29:13 +02:00 |
|
Bartłomiej Dach
|
9b202b5f21
|
Merge pull request #24726 from peppy/skin-lookup-debug
Add debug output for skin configuration lookups
|
2023-09-06 19:28:59 +02:00 |
|
Bartłomiej Dach
|
17e791d984
|
Merge branch 'master' into skin-lookup-debug
|
2023-09-06 18:44:50 +02:00 |
|
Bartłomiej Dach
|
fe3683ed5b
|
Adjust formatting slightly
The uneven spacing was bothering me...
|
2023-09-06 18:41:27 +02:00 |
|
Bartłomiej Dach
|
f9db0fad88
|
Ignore unused thing inspection harder
|
2023-09-06 18:37:17 +02:00 |
|
Dean Herbert
|
dce6adb895
|
Add text explanation of icons
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
|
2023-09-07 01:23:56 +09:00 |
|
Bartłomiej Dach
|
0df77e3e2d
|
Merge pull request #24728 from peppy/rename-slider-velocity-duplicate
Rename `SliderVelocity` to `SliderVelocityMultiplier` to distinguish from `Velocity`
|
2023-09-06 17:29:06 +02:00 |
|
Dean Herbert
|
1a37543d28
|
Rename SliderVelocity to SliderVelocityMultiplier to distinguish from Velocity
|
2023-09-06 19:01:08 +09:00 |
|
Dean Herbert
|
d06490220d
|
Add better xmldoc for Slider.Velocity
|
2023-09-06 18:58:58 +09:00 |
|
Dean Herbert
|
88b9d3237a
|
Fix osu!mania legacy skin configurations not working when notes are not skinned
|
2023-09-06 18:03:54 +09:00 |
|
Dean Herbert
|
14936677fc
|
Ignore unused thing inspection
|
2023-09-06 18:03:40 +09:00 |
|
Dean Herbert
|
6c95b88589
|
Add debug output for skin configuration lookups
We've struggle with debugging these over the years so I think this was
worth a couple of hours of work.
Example of osu! lookups:
```log
[runtime] 2023-09-06 08:38:30 [verbose]: BeatmapSkinProvidingContainer.GetConfig(lookup: SpinnerFrequencyModulate)
[runtime] 2023-09-06 08:38:30 [verbose]: |-SkinProvidingContainer+DisableableSkinSource{ skin: SkinTransformer{ Skin: LegacyBeatmapSkin{ Name: Vickeblanka - Lucky Ending (TV Size) (tears_) [Normal] } } }.GetConfig(lookup: SpinnerFrequencyModulate)
[runtime] 2023-09-06 08:38:30 [verbose]: |-RulesetSkinProvidingContainer.GetConfig(lookup: SpinnerFrequencyModulate)
[runtime] 2023-09-06 08:38:30 [verbose]: |-|-SkinProvidingContainer+DisableableSkinSource{ skin: SkinTransformer{ Skin: LegacySkin{ Name: Test Skin [test-skin] } } }.GetConfig(lookup: SpinnerFrequencyModulate)
[runtime] 2023-09-06 08:38:30 [verbose]: |-|-|-SkinTransformer{ Skin: LegacySkin{ Name: Test Skin [test-skin] } }.GetConfig(lookup: SpinnerFrequencyModulate)
[runtime] 2023-09-06 08:38:30 [verbose]: |-|-|-|-LegacySkin{ Name: Test Skin [test-skin] }.GetConfig(lookup: SpinnerFrequencyModulate) 🟢
[runtime] 2023-09-06 08:38:30 [verbose]: |-|-SkinProvidingContainer+DisableableSkinSource{ skin: SkinTransformer{ Skin: DefaultLegacySkin{ Name: osu! "classic" (2013) } } }.GetConfig(lookup: SpinnerFrequencyModulate)
[runtime] 2023-09-06 08:38:30 [verbose]: |-|-|-SkinTransformer{ Skin: DefaultLegacySkin{ Name: osu! "classic" (2013) } }.GetConfig(lookup: SpinnerFrequencyModulate)
[runtime] 2023-09-06 08:38:30 [verbose]: |-|-|-|-DefaultLegacySkin{ Name: osu! "classic" (2013) }.GetConfig(lookup: SpinnerFrequencyModulate) 🟢
[runtime] 2023-09-06 08:38:30 [verbose]: |-|-SkinProvidingContainer+DisableableSkinSource{ skin: osu.Game.Skinning.ResourceStoreBackedSkin }.GetConfig(lookup: SpinnerFrequencyModulate)
[runtime] 2023-09-06 08:38:30 [verbose]: |-|-|-osu.Game.Skinning.ResourceStoreBackedSkin.GetConfig(lookup: SpinnerFrequencyModulate) 🔴
[runtime] 2023-09-06 08:38:30 [verbose]: |-|-SkinProvidingContainer+DisableableSkinSource{ skin: TrianglesSkin{ Name: osu! "triangles" (2017) } }.GetConfig(lookup: SpinnerFrequencyModulate)
[runtime] 2023-09-06 08:38:30 [verbose]: |-|-|-TrianglesSkin{ Name: osu! "triangles" (2017) }.GetConfig(lookup: SpinnerFrequencyModulate) 🔴
[runtime] 2023-09-06 08:38:30 [verbose]:
[runtime] 2023-09-06 08:38:30 [verbose]: BeatmapSkinProvidingContainer.GetConfig(lookup: ScorePrefix)
[runtime] 2023-09-06 08:38:30 [verbose]: |-SkinProvidingContainer+DisableableSkinSource{ skin: SkinTransformer{ Skin: LegacyBeatmapSkin{ Name: Vickeblanka - Lucky Ending (TV Size) (tears_) [Normal] } } }.GetConfig(lookup: ScorePrefix)
[runtime] 2023-09-06 08:38:30 [verbose]: |-RulesetSkinProvidingContainer.GetConfig(lookup: ScorePrefix)
[runtime] 2023-09-06 08:38:30 [verbose]: |-|-SkinProvidingContainer+DisableableSkinSource{ skin: SkinTransformer{ Skin: LegacySkin{ Name: Test Skin [test-skin] } } }.GetConfig(lookup: ScorePrefix)
[runtime] 2023-09-06 08:38:30 [verbose]: |-|-|-SkinTransformer{ Skin: LegacySkin{ Name: Test Skin [test-skin] } }.GetConfig(lookup: ScorePrefix)
[runtime] 2023-09-06 08:38:30 [verbose]: |-|-|-|-LegacySkin{ Name: Test Skin [test-skin] }.GetConfig(lookup: ScorePrefix) 🟢
[runtime] 2023-09-06 08:38:30 [verbose]: |-|-SkinProvidingContainer+DisableableSkinSource{ skin: SkinTransformer{ Skin: DefaultLegacySkin{ Name: osu! "classic" (2013) } } }.GetConfig(lookup: ScorePrefix)
[runtime] 2023-09-06 08:38:30 [verbose]: |-|-|-SkinTransformer{ Skin: DefaultLegacySkin{ Name: osu! "classic" (2013) } }.GetConfig(lookup: ScorePrefix)
[runtime] 2023-09-06 08:38:30 [verbose]: |-|-|-|-DefaultLegacySkin{ Name: osu! "classic" (2013) }.GetConfig(lookup: ScorePrefix) 🟢
[runtime] 2023-09-06 08:38:30 [verbose]: |-|-SkinProvidingContainer+DisableableSkinSource{ skin: osu.Game.Skinning.ResourceStoreBackedSkin }.GetConfig(lookup: ScorePrefix)
[runtime] 2023-09-06 08:38:30 [verbose]: |-|-|-osu.Game.Skinning.ResourceStoreBackedSkin.GetConfig(lookup: ScorePrefix) 🔴
[runtime] 2023-09-06 08:38:30 [verbose]: |-|-SkinProvidingContainer+DisableableSkinSource{ skin: TrianglesSkin{ Name: osu! "triangles" (2017) } }.GetConfig(lookup: ScorePrefix)
[runtime] 2023-09-06 08:38:30 [verbose]: |-|-|-TrianglesSkin{ Name: osu! "triangles" (2017) }.GetConfig(lookup: ScorePrefix) 🔴
```
Example of osu!mania lookups:
```log
[runtime] 2023-09-06 08:28:34 [verbose]: |-RulesetSkinProvidingContainer.GetConfig(lookup: [ManiaSkinConfigurationLookup lookup:ColumnWidth col:0])
[runtime] 2023-09-06 08:28:34 [verbose]: |-|-SkinProvidingContainer+DisableableSkinSource{ skin: SkinTransformer{ Skin: LegacySkin{ Name: Test Skin [test-skin] } } }.GetConfig(lookup: [ManiaSkinConfigurationLookup lookup:ColumnWidth col:0])
[runtime] 2023-09-06 08:28:34 [verbose]: |-|-|-SkinTransformer{ Skin: LegacySkin{ Name: Test Skin [test-skin] } }.GetConfig(lookup: [LegacyManiaSkinConfigurationLookup lookup:ColumnWidth col:0 totalcols:4])
[runtime] 2023-09-06 08:28:34 [verbose]: |-|-|-|-LegacySkin{ Name: Test Skin [test-skin] }.GetConfig(lookup: [LegacyManiaSkinConfigurationLookup lookup:ColumnWidth col:0 totalcols:4]) 🔴
[runtime] 2023-09-06 08:28:34 [verbose]: |-|-SkinProvidingContainer+DisableableSkinSource{ skin: SkinTransformer{ Skin: DefaultLegacySkin{ Name: osu! "classic" (2013) } } }.GetConfig(lookup: [ManiaSkinConfigurationLookup lookup:ColumnWidth col:0])
[runtime] 2023-09-06 08:28:34 [verbose]: |-|-|-SkinTransformer{ Skin: DefaultLegacySkin{ Name: osu! "classic" (2013) } }.GetConfig(lookup: [LegacyManiaSkinConfigurationLookup lookup:ColumnWidth col:0 totalcols:4])
[runtime] 2023-09-06 08:28:34 [verbose]: |-|-|-|-DefaultLegacySkin{ Name: osu! "classic" (2013) }.GetConfig(lookup: [LegacyManiaSkinConfigurationLookup lookup:ColumnWidth col:0 totalcols:4]) 🟢
[runtime] 2023-09-06 08:28:34 [verbose]:
[runtime] 2023-09-06 08:28:34 [verbose]: BeatmapSkinProvidingContainer.GetConfig(lookup: [ManiaSkinConfigurationLookup lookup:ColumnSpacing col:0])
[runtime] 2023-09-06 08:28:34 [verbose]: |-SkinProvidingContainer+DisableableSkinSource{ skin: SkinTransformer{ Skin: LegacyBeatmapSkin{ Name: antiPLUR - Runengon (Raveille) [Easy] } } }.GetConfig(lookup: [ManiaSkinConfigurationLookup lookup:ColumnSpacing col:0])
[runtime] 2023-09-06 08:28:34 [verbose]: |-RulesetSkinProvidingContainer.GetConfig(lookup: [ManiaSkinConfigurationLookup lookup:ColumnSpacing col:0])
[runtime] 2023-09-06 08:28:34 [verbose]: |-|-SkinProvidingContainer+DisableableSkinSource{ skin: SkinTransformer{ Skin: LegacySkin{ Name: Test Skin [test-skin] } } }.GetConfig(lookup: [ManiaSkinConfigurationLookup lookup:ColumnSpacing col:0])
[runtime] 2023-09-06 08:28:34 [verbose]: |-|-|-SkinTransformer{ Skin: LegacySkin{ Name: Test Skin [test-skin] } }.GetConfig(lookup: [LegacyManiaSkinConfigurationLookup lookup:ColumnSpacing col:0 totalcols:4])
[runtime] 2023-09-06 08:28:34 [verbose]: |-|-|-|-LegacySkin{ Name: Test Skin [test-skin] }.GetConfig(lookup: [LegacyManiaSkinConfigurationLookup lookup:ColumnSpacing col:0 totalcols:4]) 🔴
[runtime] 2023-09-06 08:28:34 [verbose]: |-|-SkinProvidingContainer+DisableableSkinSource{ skin: SkinTransformer{ Skin: DefaultLegacySkin{ Name: osu! "classic" (2013) } } }.GetConfig(lookup: [ManiaSkinConfigurationLookup lookup:ColumnSpacing col:0])
[runtime] 2023-09-06 08:28:34 [verbose]: |-|-|-SkinTransformer{ Skin: DefaultLegacySkin{ Name: osu! "classic" (2013) } }.GetConfig(lookup: [LegacyManiaSkinConfigurationLookup lookup:ColumnSpacing col:0 totalcols:4])
[runtime] 2023-09-06 08:28:34 [verbose]: |-|-|-|-DefaultLegacySkin{ Name: osu! "classic" (2013) }.GetConfig(lookup: [LegacyManiaSkinConfigurationLookup lookup:ColumnSpacing col:0 totalcols:4]) 🟢
[runtime] 2023-09-06 08:28:34 [verbose]:
```
|
2023-09-06 18:03:40 +09:00 |
|
Bartłomiej Dach
|
eddb879973
|
Merge pull request #24722 from peppy/beatmap-status-pill-animation
Add animation support for beatmap status pills
|
2023-09-06 09:59:21 +02:00 |
|
Bartłomiej Dach
|
b5e812eb3e
|
Merge pull request #24723 from bdach/beatmap-carousel-split-missing-status
Fix status on carousel beatmap set not showing in split difficulty mode
|
2023-09-06 09:35:38 +02:00 |
|
Bartłomiej Dach
|
65e51691ca
|
Merge pull request #24712 from Joehuu/beatmap-options-popover
Implement beatmap options popover
|
2023-09-06 09:31:53 +02:00 |
|
Bartłomiej Dach
|
63e92f8fab
|
Fix status on carousel beatmap set not showing in split difficulty mode
|
2023-09-06 08:25:19 +02:00 |
|
Bartłomiej Dach
|
b884f1af4a
|
Assign random statuses to beatmap sets in carousel test
Just to have visual coverage of the statuses before fixing them not
propagating to split difficulty mode.
|
2023-09-06 08:25:07 +02:00 |
|
Dean Herbert
|
dded7fe6ca
|
Merge branch 'master' into beatmap-options-popover
|
2023-09-06 15:16:34 +09:00 |
|
Dean Herbert
|
1ca713f649
|
Merge pull request #22116 from mk56-spn/beatmap_wedge_clean_ii
New beatmap information wedge design implementation
|
2023-09-06 15:10:29 +09:00 |
|
Dean Herbert
|
034c887dcb
|
Add animation support for beatmap status pills
To be used in conjunction with https://github.com/ppy/osu/pull/22116
|
2023-09-06 15:04:25 +09:00 |
|
Joseph Madamba
|
73604d171a
|
Make "general" a common string
|
2023-09-05 23:00:07 -07:00 |
|
Dean Herbert
|
4dafd4c4a2
|
Merge pull request #24720 from bdach/overlapping-hit-circle-input
Block input to objects lying under already-hit hitcircles when classic note lock is active
|
2023-09-06 13:56:47 +09:00 |
|
Joseph Madamba
|
701e24e8d3
|
Move hide button to end and make it work
|
2023-09-05 18:50:31 -07:00 |
|
Joseph Madamba
|
6d2e57b73e
|
Add localisation support to beatmap options popover
|
2023-09-05 18:43:42 -07:00 |
|
Joseph Madamba
|
69fa8747f0
|
Explicitly add beatmapinfo param to edit call
|
2023-09-05 18:35:35 -07:00 |
|
Joseph Madamba
|
9565039192
|
Hide beatmap options popover when beatmap changes
|
2023-09-05 18:24:54 -07:00 |
|
Joseph Madamba
|
9f10082ffc
|
Revert param removal of delete beatmap and clear scores methods
|
2023-09-05 18:24:53 -07:00 |
|
Joseph Madamba
|
8e8fae0fba
|
Fix left padding adding shear width
|
2023-09-05 15:21:23 -07:00 |
|
Joseph Madamba
|
3f92dae55c
|
Move star rating display and status pill out of reloadable content
|
2023-09-05 15:20:20 -07:00 |
|
Joseph Madamba
|
676240928e
|
Move actual star updating to star rating display
|
2023-09-05 14:57:55 -07:00 |
|