1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-13 07:43:00 +08:00
Go to file
Dean Herbert 6c95b88589 Add debug output for skin configuration lookups
We've struggle with debugging these over the years so I think this was
worth a couple of hours of work.

Example of osu! lookups:

```log
[runtime] 2023-09-06 08:38:30 [verbose]: BeatmapSkinProvidingContainer.GetConfig(lookup: SpinnerFrequencyModulate)
[runtime] 2023-09-06 08:38:30 [verbose]: |-SkinProvidingContainer+DisableableSkinSource{ skin: SkinTransformer{ Skin: LegacyBeatmapSkin{ Name: Vickeblanka - Lucky Ending (TV Size) (tears_) [Normal] } } }.GetConfig(lookup: SpinnerFrequencyModulate)
[runtime] 2023-09-06 08:38:30 [verbose]: |-RulesetSkinProvidingContainer.GetConfig(lookup: SpinnerFrequencyModulate)
[runtime] 2023-09-06 08:38:30 [verbose]: |-|-SkinProvidingContainer+DisableableSkinSource{ skin: SkinTransformer{ Skin: LegacySkin{ Name: Test Skin [test-skin] } } }.GetConfig(lookup: SpinnerFrequencyModulate)
[runtime] 2023-09-06 08:38:30 [verbose]: |-|-|-SkinTransformer{ Skin: LegacySkin{ Name: Test Skin [test-skin] } }.GetConfig(lookup: SpinnerFrequencyModulate)
[runtime] 2023-09-06 08:38:30 [verbose]: |-|-|-|-LegacySkin{ Name: Test Skin [test-skin] }.GetConfig(lookup: SpinnerFrequencyModulate) 🟢
[runtime] 2023-09-06 08:38:30 [verbose]: |-|-SkinProvidingContainer+DisableableSkinSource{ skin: SkinTransformer{ Skin: DefaultLegacySkin{ Name: osu! "classic" (2013) } } }.GetConfig(lookup: SpinnerFrequencyModulate)
[runtime] 2023-09-06 08:38:30 [verbose]: |-|-|-SkinTransformer{ Skin: DefaultLegacySkin{ Name: osu! "classic" (2013) } }.GetConfig(lookup: SpinnerFrequencyModulate)
[runtime] 2023-09-06 08:38:30 [verbose]: |-|-|-|-DefaultLegacySkin{ Name: osu! "classic" (2013) }.GetConfig(lookup: SpinnerFrequencyModulate) 🟢
[runtime] 2023-09-06 08:38:30 [verbose]: |-|-SkinProvidingContainer+DisableableSkinSource{ skin: osu.Game.Skinning.ResourceStoreBackedSkin }.GetConfig(lookup: SpinnerFrequencyModulate)
[runtime] 2023-09-06 08:38:30 [verbose]: |-|-|-osu.Game.Skinning.ResourceStoreBackedSkin.GetConfig(lookup: SpinnerFrequencyModulate) 🔴
[runtime] 2023-09-06 08:38:30 [verbose]: |-|-SkinProvidingContainer+DisableableSkinSource{ skin: TrianglesSkin{ Name: osu! "triangles" (2017) } }.GetConfig(lookup: SpinnerFrequencyModulate)
[runtime] 2023-09-06 08:38:30 [verbose]: |-|-|-TrianglesSkin{ Name: osu! "triangles" (2017) }.GetConfig(lookup: SpinnerFrequencyModulate) 🔴
[runtime] 2023-09-06 08:38:30 [verbose]:
[runtime] 2023-09-06 08:38:30 [verbose]: BeatmapSkinProvidingContainer.GetConfig(lookup: ScorePrefix)
[runtime] 2023-09-06 08:38:30 [verbose]: |-SkinProvidingContainer+DisableableSkinSource{ skin: SkinTransformer{ Skin: LegacyBeatmapSkin{ Name: Vickeblanka - Lucky Ending (TV Size) (tears_) [Normal] } } }.GetConfig(lookup: ScorePrefix)
[runtime] 2023-09-06 08:38:30 [verbose]: |-RulesetSkinProvidingContainer.GetConfig(lookup: ScorePrefix)
[runtime] 2023-09-06 08:38:30 [verbose]: |-|-SkinProvidingContainer+DisableableSkinSource{ skin: SkinTransformer{ Skin: LegacySkin{ Name: Test Skin [test-skin] } } }.GetConfig(lookup: ScorePrefix)
[runtime] 2023-09-06 08:38:30 [verbose]: |-|-|-SkinTransformer{ Skin: LegacySkin{ Name: Test Skin [test-skin] } }.GetConfig(lookup: ScorePrefix)
[runtime] 2023-09-06 08:38:30 [verbose]: |-|-|-|-LegacySkin{ Name: Test Skin [test-skin] }.GetConfig(lookup: ScorePrefix) 🟢
[runtime] 2023-09-06 08:38:30 [verbose]: |-|-SkinProvidingContainer+DisableableSkinSource{ skin: SkinTransformer{ Skin: DefaultLegacySkin{ Name: osu! "classic" (2013) } } }.GetConfig(lookup: ScorePrefix)
[runtime] 2023-09-06 08:38:30 [verbose]: |-|-|-SkinTransformer{ Skin: DefaultLegacySkin{ Name: osu! "classic" (2013) } }.GetConfig(lookup: ScorePrefix)
[runtime] 2023-09-06 08:38:30 [verbose]: |-|-|-|-DefaultLegacySkin{ Name: osu! "classic" (2013) }.GetConfig(lookup: ScorePrefix) 🟢
[runtime] 2023-09-06 08:38:30 [verbose]: |-|-SkinProvidingContainer+DisableableSkinSource{ skin: osu.Game.Skinning.ResourceStoreBackedSkin }.GetConfig(lookup: ScorePrefix)
[runtime] 2023-09-06 08:38:30 [verbose]: |-|-|-osu.Game.Skinning.ResourceStoreBackedSkin.GetConfig(lookup: ScorePrefix) 🔴
[runtime] 2023-09-06 08:38:30 [verbose]: |-|-SkinProvidingContainer+DisableableSkinSource{ skin: TrianglesSkin{ Name: osu! "triangles" (2017) } }.GetConfig(lookup: ScorePrefix)
[runtime] 2023-09-06 08:38:30 [verbose]: |-|-|-TrianglesSkin{ Name: osu! "triangles" (2017) }.GetConfig(lookup: ScorePrefix) 🔴
```

Example of osu!mania lookups:

```log
[runtime] 2023-09-06 08:28:34 [verbose]: |-RulesetSkinProvidingContainer.GetConfig(lookup: [ManiaSkinConfigurationLookup lookup:ColumnWidth col:0])
[runtime] 2023-09-06 08:28:34 [verbose]: |-|-SkinProvidingContainer+DisableableSkinSource{ skin: SkinTransformer{ Skin: LegacySkin{ Name: Test Skin [test-skin] } } }.GetConfig(lookup: [ManiaSkinConfigurationLookup lookup:ColumnWidth col:0])
[runtime] 2023-09-06 08:28:34 [verbose]: |-|-|-SkinTransformer{ Skin: LegacySkin{ Name: Test Skin [test-skin] } }.GetConfig(lookup: [LegacyManiaSkinConfigurationLookup lookup:ColumnWidth col:0 totalcols:4])
[runtime] 2023-09-06 08:28:34 [verbose]: |-|-|-|-LegacySkin{ Name: Test Skin [test-skin] }.GetConfig(lookup: [LegacyManiaSkinConfigurationLookup lookup:ColumnWidth col:0 totalcols:4]) 🔴
[runtime] 2023-09-06 08:28:34 [verbose]: |-|-SkinProvidingContainer+DisableableSkinSource{ skin: SkinTransformer{ Skin: DefaultLegacySkin{ Name: osu! "classic" (2013) } } }.GetConfig(lookup: [ManiaSkinConfigurationLookup lookup:ColumnWidth col:0])
[runtime] 2023-09-06 08:28:34 [verbose]: |-|-|-SkinTransformer{ Skin: DefaultLegacySkin{ Name: osu! "classic" (2013) } }.GetConfig(lookup: [LegacyManiaSkinConfigurationLookup lookup:ColumnWidth col:0 totalcols:4])
[runtime] 2023-09-06 08:28:34 [verbose]: |-|-|-|-DefaultLegacySkin{ Name: osu! "classic" (2013) }.GetConfig(lookup: [LegacyManiaSkinConfigurationLookup lookup:ColumnWidth col:0 totalcols:4]) 🟢
[runtime] 2023-09-06 08:28:34 [verbose]:
[runtime] 2023-09-06 08:28:34 [verbose]: BeatmapSkinProvidingContainer.GetConfig(lookup: [ManiaSkinConfigurationLookup lookup:ColumnSpacing col:0])
[runtime] 2023-09-06 08:28:34 [verbose]: |-SkinProvidingContainer+DisableableSkinSource{ skin: SkinTransformer{ Skin: LegacyBeatmapSkin{ Name: antiPLUR - Runengon (Raveille) [Easy] } } }.GetConfig(lookup: [ManiaSkinConfigurationLookup lookup:ColumnSpacing col:0])
[runtime] 2023-09-06 08:28:34 [verbose]: |-RulesetSkinProvidingContainer.GetConfig(lookup: [ManiaSkinConfigurationLookup lookup:ColumnSpacing col:0])
[runtime] 2023-09-06 08:28:34 [verbose]: |-|-SkinProvidingContainer+DisableableSkinSource{ skin: SkinTransformer{ Skin: LegacySkin{ Name: Test Skin [test-skin] } } }.GetConfig(lookup: [ManiaSkinConfigurationLookup lookup:ColumnSpacing col:0])
[runtime] 2023-09-06 08:28:34 [verbose]: |-|-|-SkinTransformer{ Skin: LegacySkin{ Name: Test Skin [test-skin] } }.GetConfig(lookup: [LegacyManiaSkinConfigurationLookup lookup:ColumnSpacing col:0 totalcols:4])
[runtime] 2023-09-06 08:28:34 [verbose]: |-|-|-|-LegacySkin{ Name: Test Skin [test-skin] }.GetConfig(lookup: [LegacyManiaSkinConfigurationLookup lookup:ColumnSpacing col:0 totalcols:4]) 🔴
[runtime] 2023-09-06 08:28:34 [verbose]: |-|-SkinProvidingContainer+DisableableSkinSource{ skin: SkinTransformer{ Skin: DefaultLegacySkin{ Name: osu! "classic" (2013) } } }.GetConfig(lookup: [ManiaSkinConfigurationLookup lookup:ColumnSpacing col:0])
[runtime] 2023-09-06 08:28:34 [verbose]: |-|-|-SkinTransformer{ Skin: DefaultLegacySkin{ Name: osu! "classic" (2013) } }.GetConfig(lookup: [LegacyManiaSkinConfigurationLookup lookup:ColumnSpacing col:0 totalcols:4])
[runtime] 2023-09-06 08:28:34 [verbose]: |-|-|-|-DefaultLegacySkin{ Name: osu! "classic" (2013) }.GetConfig(lookup: [LegacyManiaSkinConfigurationLookup lookup:ColumnSpacing col:0 totalcols:4]) 🟢
[runtime] 2023-09-06 08:28:34 [verbose]:

```
2023-09-06 18:03:40 +09:00
.config Update localisation analyser packages 2023-07-12 16:30:26 +09:00
.github Update config.yml to mention "performance" in the discussion link 2023-06-08 00:22:06 +09:00
.idea Delete and ignore rider's misc.xml 2022-05-19 13:55:19 +09:00
.run Update desktop projects to target .NET 6 2022-02-10 17:42:09 +09:00
.vscode Add C# extension to recommended VS Code extensions 2022-03-22 20:33:27 +11:00
assets Add icon and use licence expression for NuGet. 2019-10-30 23:37:58 +08:00
CodeAnalysis Ban char.ToLower()/char.ToUpper() as well for better safety 2022-10-21 20:56:34 +03:00
osu.Android Declare media permissions in game project for editor usage 2023-08-20 23:37:11 +02:00
osu.Desktop Disable IPC binding in tournament client to allow running concurrently 2023-08-16 16:55:48 +09:00
osu.Game Add debug output for skin configuration lookups 2023-09-06 18:03:40 +09:00
osu.Game.Benchmarks Add benchmarks for carousel beatmap filter 2023-03-04 15:14:22 +01:00
osu.Game.Rulesets.Catch Add performance breakdown chart for osu!catch 2023-07-13 18:48:24 +09:00
osu.Game.Rulesets.Catch.Tests Revert "Revert "Fix TestSceneFruitRandomness"" 2023-08-21 13:02:41 +02:00
osu.Game.Rulesets.Catch.Tests.Android Bump Android target SDK version to 33 2023-08-20 23:36:07 +02:00
osu.Game.Rulesets.Catch.Tests.iOS Fix iOS visual tests having unusual bundle identifiers 2023-07-23 20:32:01 +03:00
osu.Game.Rulesets.Mania Add debug output for skin configuration lookups 2023-09-06 18:03:40 +09:00
osu.Game.Rulesets.Mania.Tests Remove ModNoMod usage 2023-09-04 15:56:32 +09:00
osu.Game.Rulesets.Mania.Tests.Android Bump Android target SDK version to 33 2023-08-20 23:36:07 +02:00
osu.Game.Rulesets.Mania.Tests.iOS Fix iOS visual tests having unusual bundle identifiers 2023-07-23 20:32:01 +03:00
osu.Game.Rulesets.Osu Block input to objects lying under already-hit hitcircles when classic note lock is active 2023-09-05 22:50:27 +02:00
osu.Game.Rulesets.Osu.Tests Fix HitCircleLateFade failures due to hitcircle not being loaded when applying mods 2023-09-05 23:35:03 +02:00
osu.Game.Rulesets.Osu.Tests.Android Bump Android target SDK version to 33 2023-08-20 23:36:07 +02:00
osu.Game.Rulesets.Osu.Tests.iOS Fix iOS visual tests having unusual bundle identifiers 2023-07-23 20:32:01 +03:00
osu.Game.Rulesets.Taiko Remove SV from DrumRoll 2023-08-13 21:47:13 +02:00
osu.Game.Rulesets.Taiko.Tests Add test covering blocking of second hit on same frame 2023-07-25 20:05:37 +02:00
osu.Game.Rulesets.Taiko.Tests.Android Bump Android target SDK version to 33 2023-08-20 23:36:07 +02:00
osu.Game.Rulesets.Taiko.Tests.iOS Fix iOS visual tests having unusual bundle identifiers 2023-07-23 20:32:01 +03:00
osu.Game.Tests Merge pull request #24722 from peppy/beatmap-status-pill-animation 2023-09-06 09:59:21 +02:00
osu.Game.Tests.Android Bump Android target SDK version to 33 2023-08-20 23:36:07 +02:00
osu.Game.Tests.iOS Fix iOS visual tests having unusual bundle identifiers 2023-07-23 20:32:01 +03:00
osu.Game.Tournament Merge pull request #24691 from peppy/file-ipc-race-fix 2023-08-31 21:54:38 +02:00
osu.Game.Tournament.Tests Merge pull request #24691 from peppy/file-ipc-race-fix 2023-08-31 21:54:38 +02:00
osu.iOS Automated pass 2023-06-24 01:00:03 +09:00
Templates Make HitSampleInfo.Bank non-nullable 2023-05-16 18:12:56 +09:00
.editorconfig Add generated code hints in editorconfig / dotsettings 2023-07-07 22:38:07 +09:00
.git-blame-ignore-revs Add automated commit to blame ignore revs 2023-06-24 01:56:38 +09:00
.gitattributes Force crlf for osu.licenseheader 2019-01-25 16:22:20 +09:00
.gitignore More realm analytic disables 2023-07-20 17:51:33 +09:00
.globalconfig Upgrade LocalisationAnalyser and disable warning 2022-08-18 15:08:24 +09:00
app.manifest Remove manifest DPI awareness entires 2023-07-01 19:11:48 +02:00
appveyor_deploy.yml Update appveyor deploy image 2022-12-25 23:40:01 +08:00
appveyor.yml Use maui-android 2022-12-19 16:47:10 +09:00
CONTRIBUTING.md Rewrite contributing guidelines 2023-01-11 23:34:05 +01:00
Directory.Build.props Use lang version 10 2023-03-06 19:31:45 +09:00
FodyWeavers.xml Disable realm analytics submission 2021-06-28 17:37:58 +09:00
global.json Pin builds to .NET 6 2023-05-19 17:49:27 +09:00
InspectCode.ps1 Add caches-home 2022-04-14 12:37:42 +09:00
InspectCode.sh Add caches-home 2022-04-14 12:37:42 +09:00
LICENCE Update various licence years to 2022 2022-04-07 22:05:04 +09:00
osu.Android.props Update framework 2023-09-05 15:40:00 +09:00
osu.Android.slnf Use slnf for filtering platform. 2019-10-30 21:35:58 +08:00
osu.Desktop.slnf Fix invalid array definition in slnf 2021-04-07 15:54:16 +09:00
osu.iOS.props Update framework 2023-09-05 15:40:00 +09:00
osu.iOS.slnf Add missing project to iOS filter. 2019-11-08 21:17:59 +08:00
osu.licenseheader Force crlf for osu.licenseheader 2019-01-25 16:22:20 +09:00
osu.sln Remove rollForward rule for now 2022-12-19 21:54:33 +09:00
osu.sln.DotSettings Disable redundant verbatim string prefix inspections 2023-08-28 12:44:57 +02:00
osu.TestProject.props Normalize .props 2019-10-30 21:54:14 +08:00
README.md Update README.md to include VS Code plugin prerequisites 2023-08-24 13:28:17 -05:00
UseLocalFramework.ps1 Add mobile local framework reference support 2023-02-21 18:59:33 +03:00
UseLocalFramework.sh Add mobile local framework reference support 2023-02-21 18:59:33 +03:00
UseLocalResources.ps1 Add helper scripts for using local resources 2022-11-12 17:22:18 +09:00
UseLocalResources.sh Add helper scripts for using local resources 2022-11-12 17:22:18 +09:00

osu! logo

osu!

Build status GitHub release CodeFactor dev chat Crowdin

A free-to-win rhythm game. Rhythm is just a click away!

The future of osu! and the beginning of an open era! Currently known by and released under the release codename "lazer". As in sharper than cutting-edge.

Status

This project is under constant development, but we aim to keep things in a stable state. Users are encouraged to try it out and keep it installed alongside the stable osu! client. It will continue to evolve to the point of eventually replacing the existing stable client as an update.

IMPORTANT: Gameplay mechanics (and other features which you may have come to know and love) are in a constant state of flux. Game balance and final quality-of-life passes come at the end of development, preceded by experimentation and changes which may potentially reduce playability or usability. This is done in order to allow us to move forward as developers and designers more efficiently. If this offends you, please consider sticking to a stable release of osu!. We are not yet open to heated discussion over game mechanics and will not be using github as a forum for such discussions just yet.

We are accepting bug reports (please report with as much detail as possible and follow the existing issue templates). Feature requests are also welcome, but understand that our focus is on completing the game to feature parity before adding new features. A few resources are available as starting points to getting involved and understanding the project:

Running osu!

If you are looking to install or test osu! without setting up a development environment, you can consume our releases. You can also generally download a version for your current device from the osu! site. Failing that, you may use the links below to download the latest version for your operating system of choice:

Latest release:

Windows 8.1+ (x64) macOS 10.15+ (Intel, Apple Silicon) Linux (x64) iOS 13.4+ Android 5+
  • The iOS testflight link may fill up (Apple has a hard limit of 10,000 users). We reset it occasionally when this happens. Please do not ask about this. Check back regularly for link resets or follow peppy on twitter for announcements of link resets.

If your platform is not listed above, there is still a chance you can manually build it by following the instructions below.

Developing a custom ruleset

osu! is designed to have extensible modular gameplay modes, called "rulesets". Building one of these allows a developer to harness the power of osu! for their own game style. To get started working on a ruleset, we have some templates available here.

You can see some examples of custom rulesets by visiting the custom ruleset directory.

Developing osu!

Please make sure you have the following prerequisites:

When working with the codebase, we recommend using an IDE with intelligent code completion and syntax highlighting, such as the latest version of Visual Studio, JetBrains Rider, or Visual Studio Code with the EditorConfig and C# plugin installed.

Downloading the source code

Clone the repository:

git clone https://github.com/ppy/osu
cd osu

To update the source code to the latest commit, run the following command inside the osu directory:

git pull

Building

Build configurations for the recommended IDEs (listed above) are included. You should use the provided Build/Run functionality of your IDE to get things going. When testing or building new components, it's highly encouraged you use the VisualTests project/configuration. More information on this is provided below.

  • Visual Studio / Rider users should load the project via one of the platform-specific .slnf files, rather than the main .sln. This will allow access to template run configurations.

You can also build and run osu! from the command-line with a single command:

dotnet run --project osu.Desktop

If you are not interested in debugging osu!, you can add -c Release to gain performance. In this case, you must replace Debug with Release in any commands mentioned in this document.

If the build fails, try to restore NuGet packages with dotnet restore.

Due to a historical feature gap between .NET Core and Xamarin, running dotnet CLI from the root directory will not work for most commands. This can be resolved by specifying a target .csproj or the helper project at build/Desktop.proj. Configurations have been provided to work around this issue for all supported IDEs mentioned above.

Testing with resource/framework modifications

Sometimes it may be necessary to cross-test changes in osu-resources or osu-framework. This can be quickly achieved using included commands:

Windows:

UseLocalFramework.ps1
UseLocalResources.ps1

macOS / Linux:

UseLocalFramework.sh
UseLocalResources.sh

Note that these commands assume you have the relevant project(s) checked out in adjacent directories:

|- osu            // this repository
|- osu-framework
|- osu-resources

Code analysis

Before committing your code, please run a code formatter. This can be achieved by running dotnet format in the command line, or using the Format code command in your IDE.

We have adopted some cross-platform, compiler integrated analyzers. They can provide warnings when you are editing, building inside IDE or from command line, as-if they are provided by the compiler itself.

JetBrains ReSharper InspectCode is also used for wider rule sets. You can run it from PowerShell with .\InspectCode.ps1. Alternatively, you can install ReSharper or use Rider to get inline support in your IDE of choice.

Contributing

When it comes to contributing to the project, the two main things you can do to help out are reporting issues and submitting pull requests. Please refer to the contributing guidelines to understand how to help in the most effective way possible.

If you wish to help with localisation efforts, head over to crowdin.

We love to reward quality contributions. If you have made a large contribution, or are a regular contributor, you are welcome to submit an expense via opencollective. If you have any questions, feel free to reach out to peppy before doing so.

Licence

osu!'s code and framework are licensed under the MIT licence. Please see the licence file for more information. tl;dr you can do whatever you want as long as you include the original copyright and license notice in any copy of the software/source.

Please note that this does not cover the usage of the "osu!" or "ppy" branding in any software, resources, advertising or promotion, as this is protected by trademark law.

Please also note that game resources are covered by a separate licence. Please see the ppy/osu-resources repository for clarifications.