65147 Commits

This Branch

This Branch

All Branches

• Fix ConstrainedIconContainer always using masking
  Andrei Zavatski · 2024-01-18 20:13:27 +09:00
  4532a409d2
• Remove test guarantee of audio time not advancing
  Dean Herbert · 2024-01-18 20:06:53 +09:00
  c4e9bcd140
• Remove "pause rate adjust" flow
  Dean Herbert · 2024-01-18 14:21:02 +09:00
  8ab8c90e33
• Simplify gameplay pause sequence
  Dean Herbert · 2024-01-18 14:17:19 +09:00
  799c74cfe5
• Merge pull request #26594 from frenzibyte/fix-storyboard-sprites-1

  Change legacy beatmap skins to not handle `@2x` textures (to match stable)

  Dean Herbert · 2024-01-18 00:40:29 +09:00
  e260e75fac
• Merge pull request #26593 from peppy/rolling-counter-unstick

  Change rolling counters to use quicker easing types

  Bartłomiej Dach · 2024-01-17 14:37:52 +01:00
  b718897b30
• Add extended test coverage
  Salman Ahmed · 2024-01-17 15:58:27 +03:00
  bcc7dd6af5
• Merge pull request #26589 from peppy/key-binding-overlay-ordering

  Change key overlay to use the ordering provided by rulesets

  Bartłomiej Dach · 2024-01-17 13:37:26 +01:00
  d335c01553
• Merge pull request #26578 from bdach/taiko-fail-no-hits

  Fix taiko maps containing only drum rolls / swells not being passable without mods

  Dean Herbert · 2024-01-17 20:41:52 +09:00
  981e959654
• Jiggle ordering a bit further to fix revert-to-default buttons showing up
  Bartłomiej Dach · 2024-01-17 12:24:48 +01:00
  a8970d7642
• Merge pull request #26585 from frenzibyte/fix-editor-ux

  Fix timing point changes not applying after selecting another one

  Dean Herbert · 2024-01-17 19:53:35 +09:00
  6a8a45bb13
• Rename test method slightly
  Dean Herbert · 2024-01-17 19:53:23 +09:00
  1af5d1434c
• Merge pull request #26502 from frenzibyte/prevent-submission-with-invalid-mods

  Add guard against submitting score with invalid mod instances

  Bartłomiej Dach · 2024-01-17 11:39:32 +01:00
  5cb17bcacf
• Merge pull request #26579 from bdach/accuracy-rank-lazer-score-reimport

  Fix incorrect accuracy and rank population when decoding lazer replays

  Dean Herbert · 2024-01-17 19:33:26 +09:00
  0ddd89a5b8
• Merge pull request #26576 from bdach/flashlight-broke

  Fix flashlight not dimming if slider head is hit early

  Dean Herbert · 2024-01-17 19:23:00 +09:00
  c623956b3f
• Disable high resolution texture lookup for legacy beatmap skins to match stable
  Salman Ahmed · 2024-01-17 12:56:29 +03:00
  98c65f36c9
• Allow disabling high resolution texture lookups in LegacySkin
  Salman Ahmed · 2024-01-17 12:56:29 +03:00
  5ad2918a75
• Merge pull request #26549 from bdach/hit-error-meter-pooling-bad

  Fix `ColourHitErrorMeter` not loading pooled drawables ahead of time

  Dean Herbert · 2024-01-17 18:43:47 +09:00
  456a8e6e82
• Change rolling counters to use quicker easing types
  Dean Herbert · 2024-01-17 18:18:53 +09:00
  a66ddc7813
• Change taiko's default key ordering to better match display order

  Fixes the issue originally fixed via
  https://github.com/ppy/osu/pull/10553 in a slightly different way,
  allowing more flexibility.

  Dean Herbert · 2024-01-17 17:37:56 +09:00
  a4c0bfd099
• Change key overlay to use the ordering provided by rulesets

  osu!mania already goes out of its way to order things correctly.
  Arguably, osu!taiko just did it wrong.

  Dean Herbert · 2024-01-17 17:37:38 +09:00
  45e52854ca
• Merge pull request #26340 from stanriders/user-rank-card

  Add user card with global/country ranks to login overlay

  Dean Herbert · 2024-01-17 17:22:33 +09:00
  ee18123fc2
• Merge pull request #26446 from LeNitrous/add/replay-playback-controls

  Add replay playback controls

  Dean Herbert · 2024-01-17 17:06:15 +09:00
  c1c2e61723
• Fix one more incorrect bindable flow and simplify string setters
  Dean Herbert · 2024-01-17 17:00:56 +09:00
  353df2f312
• Add comment about messy methods
  Dean Herbert · 2024-01-17 16:57:22 +09:00
  66c7a29e79
• Fix incorrect bindable usage
  Dean Herbert · 2024-01-17 16:50:48 +09:00
  fe06402951
• Fix test failures
  Dean Herbert · 2024-01-17 16:40:45 +09:00
  e97b31d82e
• Make PlayerSettingsOverlay's api more stringent
  Dean Herbert · 2024-01-17 15:13:59 +09:00
  e7732caaf7
• Add tooltips and localisation
  Dean Herbert · 2024-01-17 15:12:33 +09:00
  2788bd912e
• Merge pull request #26564 from peppy/drag-volume-controls

  Allow adjusting volume controls via a drag

  Salman Ahmed · 2024-01-17 09:09:36 +03:00
  0adfe5f348
• Change replay playback adjustment to skew frequency, not tempo
  Dean Herbert · 2024-01-17 15:02:42 +09:00
  e53989faeb
• Adjust playback speed range to allow slower minimum speed
  Dean Herbert · 2024-01-17 15:02:42 +09:00
  042e852a3e
• Move load procedure to async method and simplify code
  Dean Herbert · 2024-01-17 15:02:42 +09:00
  42f64c2c44
• Fix android build CI failing

  No idea why this is only in android, but okay.

  Salman Ahmed · 2024-01-17 08:53:28 +03:00
  05729706eb
• Merge branch 'master' into drag-volume-controls
  Salman Ahmed · 2024-01-17 08:37:34 +03:00
  23e5167cb5
• Remove redundant value to appease CI
  Salman Ahmed · 2024-01-17 08:29:55 +03:00
  1790a5df03
• Add small volume meter to test feel
  Salman Ahmed · 2024-01-17 08:28:47 +03:00
  a34d2a3424
• Schedule control point switch for settings modifications to apply first
  Salman Ahmed · 2024-01-17 08:15:01 +03:00
  46429c5074
• Add failing test case
  Salman Ahmed · 2024-01-17 08:15:01 +03:00
  f11682d44f
• Change drag adjustments to be linear (and account for partial deltas)
  Dean Herbert · 2024-01-17 14:12:12 +09:00
  9cde04c30c
• Merge pull request #26573 from EVAST9919/leaderboard-glow-remove

  Fix multiple issues with `GlowingSpriteText`

  Dean Herbert · 2024-01-17 13:17:03 +09:00
  68fb1b8663
• Fix incorrect accuracy and rank population when decoding lazer replays

  Closes https://github.com/ppy/osu/issues/24061.
  
  The gist of this change is that if the `LegacyReplaySoloScoreInfo`
  bolt-on is present in the replay, then it can (and is) used to recompute
  the accuracy, and rank is computed based on that.
  
  This was the missing part of
  https://github.com/ppy/osu/issues/24061#issuecomment-1888438151.
  The accuracy would change on import before that because the encode
  process is _lossy_ if the `LegacyReplaySoloScoreInfo` bolt-on is not
  used, as the legacy format only has 6 fields for encoding judgement
  counts, and some judgements that affect accuracy in lazer do not fit
  into that.
  
  Note that this _only_ fixes _relatively_ new lazer scores looking wrong
  after reimport.
  
  - Very old lazer scores, i.e. ones that don't have the
    `LegacyReplaySoloScoreInfo` bolt-on, obviously can't use it
    to repopulate. There's really not much good that can be done there,
    so the stable pathways are used as a fallback that always works.
  
  - For stable replays, `ScoreImporter` recalculates the accuracy of
    the score _again_ in
  
    https://github.com/ppy/osu/blob/15a5fd7e4c8e8e3c38382cfd3d5d676d107d7908/osu.Game/Scoring/ScoreImporter.cs#L106-L110
  
    as `StandardisedScoreMigrationTools.UpdateFromLegacy()` recomputes
    _both_ total score and accuracy.
  
    This makes a _semblance_ of sense as it attempts to make the accuracy
    of stable and lazer replays comparable. In most cases it also won't
    matter, as the only ruleset where accuracy changed between the legacy
    implementation and current lazer accuracy is mania.
  
    But it is also an inaccurate process (as, again, some of the required
    data is not in the replay, namely judgement counts of ticks
    and so on).
  
    For whatever's worth, a similar thing happens server-side in
  
    https://github.com/ppy/osu-queue-score-statistics/blob/106c2948dbe695efcad5972d32cd46f4b36005cc/osu.Server.Queues.ScoreStatisticsProcessor/Commands/Queue/BatchInserter.cs#L319
  
  - However, _ranks_ of stable scores will still use the local stable
    reimplementation of ranks, i.e. a 1-miss stable score in osu! ruleset
    will be an A rather than an S. See importer:
  
    https://github.com/ppy/osu-queue-score-statistics/blob/106c2948dbe695efcad5972d32cd46f4b36005cc/osu.Server.Queues.ScoreStatisticsProcessor/Commands/Queue/BatchInserter.cs#L237
  
    (it's the same method which is renamed
    to `PopulateLegacyAccuracyAndRank()` in this commit).
  
    That is all a bit of a mess honestly, but I'm not sure where to even
    begin there...

  Bartłomiej Dach · 2024-01-16 22:38:53 +01:00
  17b9d842ab
• Add failing test coverage
  Bartłomiej Dach · 2024-01-16 22:38:52 +01:00
  1075b87fb8
• Merge pull request #26575 from bdach/touch-device-multiplayer

  Fix touch device not always activating when it should

  Salman Ahmed · 2024-01-16 22:35:59 +03:00
  15a5fd7e4c
• Fix taiko maps containing only drum rolls / swells not being passable without mods

  Closes https://github.com/ppy/osu/issues/26370.
  
  As was noted in the issue thread stable does not attempt to account for
  such maps, and the maps are impassable in stable without No Fail.
  Nevertheless that seems like a pretty anti-player behaviour and I
  honestly believe that it is fine to change this in lazer.

  Bartłomiej Dach · 2024-01-16 20:18:32 +01:00
  fc37c5e4c2
• Merge branch 'master' into touch-device-multiplayer
  Salman Ahmed · 2024-01-16 22:09:17 +03:00
  e5f67173e5
• Add failing test cases
  Bartłomiej Dach · 2024-01-16 19:46:00 +01:00
  190f30a4b3
• Add basic test coverage of taiko health processor
  Bartłomiej Dach · 2024-01-16 19:44:20 +01:00
  265a56bede
• Add some more test coverage for good measure
  Bartłomiej Dach · 2024-01-16 18:56:58 +01:00
  24741e9615
• Fix flashlight not dimming if slider head is hit early

  Closes https://github.com/ppy/osu/issues/26551
  
  Fix is a bit nuclear (`OnUpdate` should be considered last resort),
  but I don't see many better alternatives here as
  `ApplyCustomUpdateState` does not work...

  Bartłomiej Dach · 2024-01-16 18:56:50 +01:00
  d0e9402761