1
0
mirror of https://github.com/ppy/osu.git synced 2024-09-21 17:27:24 +08:00
Go to file
Bartłomiej Dach 17b9d842ab
Fix incorrect accuracy and rank population when decoding lazer replays
Closes https://github.com/ppy/osu/issues/24061.

The gist of this change is that if the `LegacyReplaySoloScoreInfo`
bolt-on is present in the replay, then it can (and is) used to recompute
the accuracy, and rank is computed based on that.

This was the missing part of
https://github.com/ppy/osu/issues/24061#issuecomment-1888438151.
The accuracy would change on import before that because the encode
process is _lossy_ if the `LegacyReplaySoloScoreInfo` bolt-on is not
used, as the legacy format only has 6 fields for encoding judgement
counts, and some judgements that affect accuracy in lazer do not fit
into that.

Note that this _only_ fixes _relatively_ new lazer scores looking wrong
after reimport.

- Very old lazer scores, i.e. ones that don't have the
  `LegacyReplaySoloScoreInfo` bolt-on, obviously can't use it
  to repopulate. There's really not much good that can be done there,
  so the stable pathways are used as a fallback that always works.

- For stable replays, `ScoreImporter` recalculates the accuracy of
  the score _again_ in

  15a5fd7e4c/osu.Game/Scoring/ScoreImporter.cs (L106-L110)

  as `StandardisedScoreMigrationTools.UpdateFromLegacy()` recomputes
  _both_ total score and accuracy.

  This makes a _semblance_ of sense as it attempts to make the accuracy
  of stable and lazer replays comparable. In most cases it also won't
  matter, as the only ruleset where accuracy changed between the legacy
  implementation and current lazer accuracy is mania.

  But it is also an inaccurate process (as, again, some of the required
  data is not in the replay, namely judgement counts of ticks
  and so on).

  For whatever's worth, a similar thing happens server-side in

  106c2948db/osu.Server.Queues.ScoreStatisticsProcessor/Commands/Queue/BatchInserter.cs (L319)

- However, _ranks_ of stable scores will still use the local stable
  reimplementation of ranks, i.e. a 1-miss stable score in osu! ruleset
  will be an A rather than an S. See importer:

  106c2948db/osu.Server.Queues.ScoreStatisticsProcessor/Commands/Queue/BatchInserter.cs (L237)

  (it's the same method which is renamed
  to `PopulateLegacyAccuracyAndRank()` in this commit).

  That is all a bit of a mess honestly, but I'm not sure where to even
  begin there...
2024-01-16 22:38:53 +01:00
.config Update localisation analyser 2023-11-17 17:07:21 +09:00
.github Remove outdated main menu version reference on issue template 2023-12-30 11:44:11 -08:00
.idea Delete and ignore rider's misc.xml 2022-05-19 13:55:19 +09:00
.run Update desktop projects to target .NET 6 2022-02-10 17:42:09 +09:00
.vscode Add C# extension to recommended VS Code extensions 2022-03-22 20:33:27 +11:00
assets Add icon and use licence expression for NuGet. 2019-10-30 23:37:58 +08:00
CodeAnalysis Ban char.ToLower()/char.ToUpper() as well for better safety 2022-10-21 20:56:34 +03:00
osu.Android Add inline comment matching framework 2023-12-04 12:10:31 +09:00
osu.Desktop Fix broken installer 2024-01-13 22:04:21 +01:00
osu.Game Fix incorrect accuracy and rank population when decoding lazer replays 2024-01-16 22:38:53 +01:00
osu.Game.Benchmarks Update some packages to match osu.Server.Spectator 2023-10-12 18:58:42 +09:00
osu.Game.Rulesets.Catch Fix incorrect score conversion on selected beatmaps due to incorrect difficultyPeppyStars rounding 2024-01-10 19:30:18 +01:00
osu.Game.Rulesets.Catch.Tests Adjust assertion to match new juice stream child ordering 2024-01-02 20:51:22 +01:00
osu.Game.Rulesets.Catch.Tests.Android Bump Android target SDK version to 33 2023-08-20 23:36:07 +02:00
osu.Game.Rulesets.Catch.Tests.iOS Fix iOS visual tests having unusual bundle identifiers 2023-07-23 20:32:01 +03:00
osu.Game.Rulesets.Mania Fix osu!mania judgments not being pooled correctly 2024-01-15 20:50:09 +09:00
osu.Game.Rulesets.Mania.Tests Add mania/osu sudden death mod tests 2023-12-22 16:43:09 +09:00
osu.Game.Rulesets.Mania.Tests.Android Bump Android target SDK version to 33 2023-08-20 23:36:07 +02:00
osu.Game.Rulesets.Mania.Tests.iOS Fix iOS visual tests having unusual bundle identifiers 2023-07-23 20:32:01 +03:00
osu.Game.Rulesets.Osu Merge branch 'master' into spinner-speed-fix 2024-01-17 01:40:53 +11:00
osu.Game.Rulesets.Osu.Tests Use until step instead 2024-01-16 17:54:49 +01:00
osu.Game.Rulesets.Osu.Tests.Android Bump Android target SDK version to 33 2023-08-20 23:36:07 +02:00
osu.Game.Rulesets.Osu.Tests.iOS Fix iOS visual tests having unusual bundle identifiers 2023-07-23 20:32:01 +03:00
osu.Game.Rulesets.Taiko Fix osu!taiko judgments not being pooled correctly 2024-01-15 20:50:09 +09:00
osu.Game.Rulesets.Taiko.Tests Add mania/osu sudden death mod tests 2023-12-22 16:43:09 +09:00
osu.Game.Rulesets.Taiko.Tests.Android Bump Android target SDK version to 33 2023-08-20 23:36:07 +02:00
osu.Game.Rulesets.Taiko.Tests.iOS Fix iOS visual tests having unusual bundle identifiers 2023-07-23 20:32:01 +03:00
osu.Game.Tests Add failing test coverage 2024-01-16 22:38:52 +01:00
osu.Game.Tests.Android Bump Android target SDK version to 33 2023-08-20 23:36:07 +02:00
osu.Game.Tests.iOS Fix iOS visual tests having unusual bundle identifiers 2023-07-23 20:32:01 +03:00
osu.Game.Tournament Move object counts to BeatmapInfo 2023-12-13 17:33:24 +09:00
osu.Game.Tournament.Tests Simplify state reset in test scene 2023-12-06 12:03:54 +09:00
osu.iOS Add application category type to enable game mode on new macOS versions 2023-08-22 12:32:42 +09:00
Templates Small update to README of Templates 2023-10-29 21:25:15 +08:00
.editorconfig Add generated code hints in editorconfig / dotsettings 2023-07-07 22:38:07 +09:00
.git-blame-ignore-revs Add automated commit to blame ignore revs 2023-06-24 01:56:38 +09:00
.gitattributes Force crlf for osu.licenseheader 2019-01-25 16:22:20 +09:00
.gitignore More realm analytic disables 2023-07-20 17:51:33 +09:00
.globalconfig Upgrade LocalisationAnalyser and disable warning 2022-08-18 15:08:24 +09:00
app.manifest Remove manifest DPI awareness entires 2023-07-01 19:11:48 +02:00
appveyor_deploy.yml Update appveyor deploy image 2022-12-25 23:40:01 +08:00
appveyor.yml Use maui-android 2022-12-19 16:47:10 +09:00
CONTRIBUTING.md Update links to figma library 2023-11-24 12:37:25 +09:00
Directory.Build.props Revert "Merge pull request #23570 from huoyaoyuan/inspect-code-cs11" 2023-05-17 14:49:47 +09:00
FodyWeavers.xml Disable realm analytics submission 2021-06-28 17:37:58 +09:00
global.json Pin builds to .NET 6 2023-05-19 17:49:27 +09:00
InspectCode.ps1 Add caches-home 2022-04-14 12:37:42 +09:00
InspectCode.sh Add caches-home 2022-04-14 12:37:42 +09:00
LICENCE Update various licence years to 2022 2022-04-07 22:05:04 +09:00
osu.Android.props Update framework 2024-01-14 22:31:48 +09:00
osu.Android.slnf Use slnf for filtering platform. 2019-10-30 21:35:58 +08:00
osu.Desktop.slnf Fix invalid array definition in slnf 2021-04-07 15:54:16 +09:00
osu.iOS.props Update framework 2024-01-14 22:31:48 +09:00
osu.iOS.slnf Add missing project to iOS filter. 2019-11-08 21:17:59 +08:00
osu.licenseheader Force crlf for osu.licenseheader 2019-01-25 16:22:20 +09:00
osu.sln Remove rollForward rule for now 2022-12-19 21:54:33 +09:00
osu.sln.DotSettings Enforce namespace body style 2023-12-07 15:26:02 +09:00
osu.TestProject.props Normalize .props 2019-10-30 21:54:14 +08:00
README.md Reword release build disclaimer 2023-09-21 14:59:37 +09:00
UseLocalFramework.ps1 Add mobile local framework reference support 2023-02-21 18:59:33 +03:00
UseLocalFramework.sh Add mobile local framework reference support 2023-02-21 18:59:33 +03:00
UseLocalResources.ps1 Add helper scripts for using local resources 2022-11-12 17:22:18 +09:00
UseLocalResources.sh Add helper scripts for using local resources 2022-11-12 17:22:18 +09:00

osu! logo

osu!

Build status GitHub release CodeFactor dev chat Crowdin

A free-to-win rhythm game. Rhythm is just a click away!

This is the future and final iteration of the osu! game client which marks the beginning of an open era! Currently known by and released under the release codename "lazer". As in sharper than cutting-edge.

Status

This project is under constant development, but we do our best to keep things in a stable state. Players are encouraged to install from a release alongside their stable osu! client. This project will continue to evolve until we eventually reach the point where most users prefer it over the previous "osu!stable" release.

A few resources are available as starting points to getting involved and understanding the project:

Running osu!

If you are just looking to give the game a whirl, you can grab the latest release for your platform:

Latest release:

Windows 8.1+ (x64) macOS 10.15+ (Intel, Apple Silicon) Linux (x64) iOS 13.4+ Android 5+

You can also generally download a version for your current device from the osu! site.

If your platform is not listed above, there is still a chance you can manually build it by following the instructions below.

For iOS/iPadOS users: The iOS testflight link fills up very fast (Apple has a hard limit of 10,000 users). We reset it occasionally. Please do not ask about this. Check back regularly for link resets or follow peppy on twitter for announcements. Our goal is to get the game on mobile app stores in early 2024.

Developing a custom ruleset

osu! is designed to allow user-created gameplay variations, called "rulesets". Building one of these allows a developer to harness the power of the osu! beatmap library, game engine, and general UX for a new style of gameplay. To get started working on a ruleset, we have some templates available here.

You can see some examples of custom rulesets by visiting the custom ruleset directory.

Developing osu!

Prerequisites

Please make sure you have the following prerequisites:

When working with the codebase, we recommend using an IDE with intelligent code completion and syntax highlighting, such as the latest version of Visual Studio, JetBrains Rider, or Visual Studio Code with the EditorConfig and C# plugin installed.

Downloading the source code

Clone the repository:

git clone https://github.com/ppy/osu
cd osu

To update the source code to the latest commit, run the following command inside the osu directory:

git pull

Building

From an IDE

You should load the solution via one of the platform-specific .slnf files, rather than the main .sln. This will reduce dependencies and hide platforms that you don't care about. Valid .slnf files are:

  • osu.Desktop.slnf (most common)
  • osu.Android.slnf
  • osu.iOS.slnf

Run configurations for the recommended IDEs (listed above) are included. You should use the provided Build/Run functionality of your IDE to get things going. When testing or building new components, it's highly encouraged you use the osu! (Tests) project/configuration. More information on this is provided below.

To build for mobile platforms, you will likely need to run sudo dotnet workload restore if you haven't done so previously. This will install Android/iOS tooling required to complete the build.

From CLI

You can also build and run osu! from the command-line with a single command:

dotnet run --project osu.Desktop

When running locally to do any kind of performance testing, make sure to add -c Release to the build command, as the overhead of running with the default Debug configuration can be large (especially when testing with local framework modifications as below).

If the build fails, try to restore NuGet packages with dotnet restore.

Testing with resource/framework modifications

Sometimes it may be necessary to cross-test changes in osu-resources or osu-framework. This can be quickly achieved using included commands:

Windows:

UseLocalFramework.ps1
UseLocalResources.ps1

macOS / Linux:

UseLocalFramework.sh
UseLocalResources.sh

Note that these commands assume you have the relevant project(s) checked out in adjacent directories:

|- osu            // this repository
|- osu-framework
|- osu-resources

Code analysis

Before committing your code, please run a code formatter. This can be achieved by running dotnet format in the command line, or using the Format code command in your IDE.

We have adopted some cross-platform, compiler integrated analyzers. They can provide warnings when you are editing, building inside IDE or from command line, as-if they are provided by the compiler itself.

JetBrains ReSharper InspectCode is also used for wider rule sets. You can run it from PowerShell with .\InspectCode.ps1. Alternatively, you can install ReSharper or use Rider to get inline support in your IDE of choice.

Contributing

When it comes to contributing to the project, the two main things you can do to help out are reporting issues and submitting pull requests. Please refer to the contributing guidelines to understand how to help in the most effective way possible.

If you wish to help with localisation efforts, head over to crowdin.

We love to reward quality contributions. If you have made a large contribution, or are a regular contributor, you are welcome to submit an expense via opencollective. If you have any questions, feel free to reach out to peppy before doing so.

Licence

osu!'s code and framework are licensed under the MIT licence. Please see the licence file for more information. tl;dr you can do whatever you want as long as you include the original copyright and license notice in any copy of the software/source.

Please note that this does not cover the usage of the "osu!" or "ppy" branding in any software, resources, advertising or promotion, as this is protected by trademark law.

Please also note that game resources are covered by a separate licence. Please see the ppy/osu-resources repository for clarifications.