Dan Balasescu
6b90e602cc
Merge pull request #12847 from peppy/refactor-selection-mutation-logic
...
Add more correct flip support to skin editor
2021-05-18 20:41:45 +09:00
Dan Balasescu
ef81bdf63f
Merge branch 'master' into always-use-lifetime-entry
2021-05-18 20:10:12 +09:00
ekrctb
ee9fe3c4be
Revert "Add failing test showing lifetime not recomputed with pooled objects"
...
This reverts commit b88e5a31
2021-05-18 19:55:44 +09:00
ekrctb
84a1a86c63
Revert "Use entry to calculate lifetime in ScrollingHOC"
...
This reverts commit 632bb70e
2021-05-18 19:55:31 +09:00
ekrctb
2c65b8fa93
Revert "Fix uninitialized scrollLength value is used"
...
This reverts commit 73dfb04d
2021-05-18 19:55:25 +09:00
smoogipoo
d93ac7ac98
Change class xmldoc a bit
2021-05-18 19:15:46 +09:00
smoogipoo
ab6a79f84c
Simplify
2021-05-18 19:15:46 +09:00
smoogipoo
97f4f7bbd1
Remove Component inheritance
2021-05-18 18:59:45 +09:00
smoogipoo
633f841a0f
Rename to HitObjectUsageEventBuffer
2021-05-18 18:57:02 +09:00
smoogipoo
bfc0205e9b
Fix (began, finished) event
2021-05-18 18:49:11 +09:00
smoogipoo
a31a6947bb
Add test
2021-05-18 18:49:05 +09:00
Salman Ahmed
d1272d5e13
Group all skinnable test scenes to one TestSceneSkinnableHUDComponents
2021-05-18 12:38:06 +03:00
Salman Ahmed
e5b6ad10bd
Remove no longer working combo counter hide code
2021-05-18 12:37:36 +03:00
Salman Ahmed
08ee1e4853
Remove HUD skin component lookup in favour of MainHUDComponents target system
2021-05-18 12:37:23 +03:00
Dean Herbert
d661e98fa6
Move common functionality out of OsuSelectionHandler and implement flip support
2021-05-18 18:34:06 +09:00
Dean Herbert
c80e736712
Change SkinBlueprint to use the origin point as the selection point
...
Not sure how this feels, but it makes using the same point throughout
the editor possible, which I think is the correct way forward for now.
2021-05-18 18:33:06 +09:00
smoogipoo
61a41d97a4
Add some xmldocs + comments
2021-05-18 17:39:45 +09:00
Dean Herbert
ed957df162
Add simple xmldoc to TransferBlueprintFor method
2021-05-18 16:40:56 +09:00
Dean Herbert
55cc533a37
Merge branch 'master' into hoc-event-queue
2021-05-18 16:31:20 +09:00
Dean Herbert
a96603f025
Merge pull request #12782 from smoogipoo/rework-hitobject-blueprints
...
Rename hitobject blueprints and tie them to HitObjects
2021-05-18 16:30:58 +09:00
Salman Ahmed
4e12a2734c
Remove ignore attribute from now fixed test scene
2021-05-18 09:51:58 +03:00
Dean Herbert
10c730b37d
Add new default locations for hit bar error displays
2021-05-18 15:50:50 +09:00
Dean Herbert
5acb708939
Remove customisation of hit error via standard settings
2021-05-18 15:50:50 +09:00
Salman Ahmed
380d004683
Merge branch 'fix-legacy-skin-test' into catch-hide-combo-workaround
2021-05-18 09:45:43 +03:00
Salman Ahmed
265a89e5cc
Fix LegacySkinPlayerTestScene overriden by default beatmap skin
2021-05-18 09:45:32 +03:00
Dean Herbert
c885ad87d5
Update HitErrorDisplay tests
2021-05-18 15:12:29 +09:00
Salman Ahmed
ff419af512
Hide the combo counter content rather than full death
2021-05-18 09:10:15 +03:00
Dean Herbert
829d326e36
Remove alignment logic completely for the time being
...
This was overly complex and does not play well with the new layout
customisation system. We can add it back as required.
2021-05-18 14:55:34 +09:00
smoogipoo
562ac73e96
Merge branch 'hoc-event-queue' into mania-pooling
2021-05-18 14:54:00 +09:00
smoogipoo
75c0d4d972
Merge branch 'rework-hitobject-blueprints' into hoc-event-queue
2021-05-18 14:33:52 +09:00
smoogipoo
882d54a8f8
Remove now unnecessary Apply() method
2021-05-18 14:26:26 +09:00
smoogipoo
72beddaadc
Remove nested blueprints from hold notes
2021-05-18 14:25:07 +09:00
smoogipoo
532c41c82e
Remove nested blueprints from sliders
2021-05-18 14:19:11 +09:00
smoogipoo
e621cfc4ea
Add Apply() method for applying new DHOs
2021-05-18 14:14:10 +09:00
Dean Herbert
0100b88a86
Move private methods down
2021-05-18 14:12:27 +09:00
Dean Herbert
3a5b21c0f5
Update "reset all bindings" button to better match new key binding row widths
2021-05-18 13:47:39 +09:00
Dean Herbert
c71d53a0f9
Fix text and button layout
2021-05-18 13:40:26 +09:00
smoogipoo
f1f3606fd0
Fix unresolved xmldocs
2021-05-18 13:11:58 +09:00
Dean Herbert
06389c08dc
Add basic test to show data how one would expect it to be displayed
2021-05-18 13:11:22 +09:00
Dan Balasescu
9d423245d8
Fix up xmldocs
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2021-05-18 13:02:23 +09:00
Lucas A
79740dd2d8
Merge conditionnal expression.
2021-05-17 22:01:05 +02:00
Bartłomiej Dach
0e91a00a7e
Revert to previous width spec instead of size
2021-05-17 21:18:45 +02:00
Bartłomiej Dach
ef114f2407
Simplify bindable flow in KeyBindingRow
2021-05-17 21:10:05 +02:00
Lucas A
8530b31e39
Use bitshifts for enum values instead of literal values.
2021-05-17 21:02:45 +02:00
Bartłomiej Dach
44b8725458
Merge pull request #12839 from smoogipoo/add-overlay-link-colours
2021-05-17 21:01:44 +02:00
Bartłomiej Dach
30d7768971
Remove now-redundant null check
2021-05-17 20:47:56 +02:00
Bartłomiej Dach
33fe843ba9
Move value change bindings to LoadComplete()
...
Also removes a redundant one from the setter of `Current`. If the set to
current comes with an associated value change, the bind-unbind flow that
`BindableWithCurrent` implements will handle that change anyway.
2021-05-17 20:46:30 +02:00
Salman Ahmed
f667ea3fd0
Replace AllowDefaultHUDComponentsFallback with a temporary override at LegacyBeatmapSkin
2021-05-17 21:34:53 +03:00
Bartłomiej Dach
2bf62b86ea
Merge branch 'master' into add-overlay-link-colours
2021-05-17 20:11:27 +02:00
Lucas A
e2018f81f3
Use equality check for nullable types.
2021-05-17 19:54:21 +02:00
