41778 Commits

This Branch

This Branch

All Branches

• Update tests in line with thread safety check
  Dean Herbert · 2021-07-04 17:59:39 +09:00
  3ec7dc3bb9
• Fix thread safety of realm Refresh operation

  Due to the lack of locking, there was a chance the the update thread
  `context` was retrieved just before the `flushContexts` call, followed
  by `.Refresh()` being run while the blocking behaviour was invoked.
  
  This can be seen in test failures such as
  https://ci.appveyor.com/project/peppy/osu/builds/39859786/tests.
  
  As an aside, I tried multiple different methods to avoid `lock()` on the
  update thread but they felt flaky. The overhead of lock when there's no
  contention is reportedly around 30-50ns, so likely not of concern. We
  can address it at a later point if it becomes one.

  Dean Herbert · 2021-07-04 16:24:43 +09:00
  567e9f33a9
• Merge pull request #7674 from LeNitrous/linkify-metadata

  Linkify metadata in beatmap details and overlay

  Bartłomiej Dach · 2021-07-03 16:43:53 +02:00
  49090a0d1b
• Merge branch 'master' into linkify-metadata
  Bartłomiej Dach · 2021-07-03 15:51:08 +02:00
  fbe3b447e5
• Trim no longer used constant
  Bartłomiej Dach · 2021-07-03 15:47:47 +02:00
  6fb8ed4d07
• Remove unused using directives
  Bartłomiej Dach · 2021-07-03 15:23:26 +02:00
  7dae93ad66
• Remove mention of direct from xmldoc
  Bartłomiej Dach · 2021-07-03 15:22:03 +02:00
  16d08df5e2
• Merge pull request #13727 from peppy/update-disclaimer

  Update disclaimer

  Dan Balasescu · 2021-07-02 21:08:43 +09:00
  2021.703.0 ace57a9ee9
• Merge pull request #13726 from nekodex/notch-tick-sfx

  Add audio feedback for changing volume

  Dan Balasescu · 2021-07-02 21:08:31 +09:00
  5a7706edee
• Merge pull request #13382 from ribbanya/clamp-skin-scale

  Fix skin elements flipping when scaled below zero

  Dean Herbert · 2021-07-02 20:50:47 +09:00
  6e31c781bb
• Merge branch 'master' into notch-tick-sfx
  Dan Balasescu · 2021-07-02 20:38:30 +09:00
  4d85df6bbc
• Merge pull request #13685 from gagahpangeran/wiki-image-block

  Fix image overflow in wiki overlay

  Dean Herbert · 2021-07-02 20:21:20 +09:00
  b0f257fa04
• Update framework
  Dean Herbert · 2021-07-02 18:51:14 +09:00
  8847915c6a
• Merge pull request #13721 from peppy/submit-on-player-exit

  Submit scores on player exit

  Dan Balasescu · 2021-07-02 18:25:26 +09:00
  9eb6ae4d45
• Merge branch 'master' into wiki-image-block
  Dean Herbert · 2021-07-02 18:19:46 +09:00
  4e52aee5a0
• Merge pull request #13742 from aitani9/skin-editor-flipping-reflect

  Make flipping in the skin editor reflect across the axes of the selection box

  Dean Herbert · 2021-07-02 18:19:04 +09:00
  f37e5bdab8
• Merge pull request #13744 from peppy/fix-async-void-calls

  Fix some incorrectly invoked `async` calls

  Dan Balasescu · 2021-07-02 18:10:30 +09:00
  211c248692
• Move to more friendly namespace
  Dean Herbert · 2021-07-02 18:09:16 +09:00
  362816492f
• Merge pull request #13714 from bdach/colour-picker

  Add osu!-styled colour picker control

  Dean Herbert · 2021-07-02 18:05:19 +09:00
  1bbf578dfe
• Move shared types into their own classes
  Dean Herbert · 2021-07-02 18:05:00 +09:00
  eacf867073
• Add missing blank lines
  Dean Herbert · 2021-07-02 17:51:54 +09:00
  ecb4982281
• Add some basic testability of external colour setting
  Dean Herbert · 2021-07-02 17:24:15 +09:00
  d67fc87dcb
• Merge pull request #13745 from Henry-YSLin/fix-incorrect-obsolete-message

  Fix the obsolete message in `Mod.Ranked` property

  Dean Herbert · 2021-07-02 16:57:43 +09:00
  f34c30f788
• Fix obsolete message in Mod.Ranked
  Henry Lin · 2021-07-02 15:55:25 +08:00
  6a0c5b54c3
• Fix ongoing operation being begun in an async context
  Dean Herbert · 2021-07-02 16:09:02 +09:00
  7b0f970e7d
• Merge conditionals in line with other case of same logic
  Dean Herbert · 2021-07-02 15:55:36 +09:00
  35f7966922
• Fix one more instance of incorrect playback/frequency set order
  Dean Herbert · 2021-07-02 15:52:20 +09:00
  63d2ac66d2
• Center pitch randomisation around base pitch
  Jamie Taylor · 2021-07-02 15:51:23 +09:00
  910fe3e9f8
• Add note about intentional downward pitch, against expectations
  Dean Herbert · 2021-07-02 15:48:16 +09:00
  bd6664d541
• Remove usage of bool for initial playback

  Also refactors the whole method to generally clean things up. One more
  important fix is setting the frequency on the channel before starting
  playback, so avoid the frequency potentially being adjusted after the
  playback is already started.

  Dean Herbert · 2021-07-02 15:48:13 +09:00
  13254d51fc
• Tidy up weird bind logic
  Dean Herbert · 2021-07-02 15:29:51 +09:00
  69b1347730
• Merge branch 'master' into notch-tick-sfx
  Dean Herbert · 2021-07-02 15:27:28 +09:00
  9814c24741
• Fix some incorrectly invoked async calls
  Dean Herbert · 2021-07-02 14:43:48 +09:00
  f2d9d78455
• Avoid using game-wide beatmap during score submission
  Dean Herbert · 2021-07-02 14:24:27 +09:00
  f689e788c9
• Remove local handling of NoFail addition
  Dean Herbert · 2021-07-02 14:21:48 +09:00
  30467191b2
• Merge pull request #13743 from peppy/rename-ranked-bakc

  Rename `Mod.Ranked` back to avoid breaking ruleset API

  Dan Balasescu · 2021-07-02 13:15:09 +09:00
  7b4317be9a
• Rename Mod.Ranked back to avoid breaking ruleset API
  Dean Herbert · 2021-07-02 12:50:58 +09:00
  0396a03bbc
• Tidy up font formatting methods
  Dean Herbert · 2021-07-02 12:21:28 +09:00
  62c125d7a2
• Reduce usable width
  Dean Herbert · 2021-07-02 12:18:52 +09:00
  f0727a63be
• Slightly change wording to hopefully read better
  Dean Herbert · 2021-07-02 12:15:16 +09:00
  a1eaf39645
• Use alternative hue slider nub design
  Bartłomiej Dach · 2021-07-02 01:03:02 +02:00
  083e463afd
• Merge branch 'master' into colour-picker
  Bartłomiej Dach · 2021-07-02 01:03:00 +02:00
  434c048d87
• Make flipping reflect across the axes of the selection box
  aitani9 · 2021-07-01 15:38:38 -07:00
  9b0fa6d3fc
• Merge pull request #13741 from bdach/update-dependencies

  Update dependencies

  Dean Herbert · 2021-07-02 06:54:05 +09:00
  c5c1fe00f6
• Merge remote-tracking branch 'upstream/dependabot/nuget/Microsoft.AspNetCore.SignalR.Protocols.MessagePack-5.0.7' into update-dependencies
  Bartłomiej Dach · 2021-07-01 19:17:00 +02:00
  6c07f6fecf
• Merge remote-tracking branch 'upstream/dependabot/nuget/Microsoft.AspNetCore.SignalR.Client-5.0.7' into update-dependencies
  Bartłomiej Dach · 2021-07-01 19:16:23 +02:00
  326a46fa84
• Merge remote-tracking branch 'upstream/dependabot/nuget/ppy.LocalisationAnalyser-2021.614.0' into update-dependencies
  Bartłomiej Dach · 2021-07-01 19:16:16 +02:00
  7f6d6edc46
• Merge remote-tracking branch 'upstream/dependabot/nuget/Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson-5.0.7' into update-dependencies
  Bartłomiej Dach · 2021-07-01 19:16:11 +02:00
  8a581fcf7e
• Merge remote-tracking branch 'upstream/dependabot/nuget/Humanizer-2.11.10' into update-dependencies
  Bartłomiej Dach · 2021-07-01 19:15:58 +02:00
  c34ecc7492
• Merge remote-tracking branch 'upstream/dependabot/nuget/NUnit3TestAdapter-4.0.0' into update-dependencies
  Bartłomiej Dach · 2021-07-01 19:14:32 +02:00
  d39afc807c