781 Commits

Author	SHA1	Message	Date
Bartłomiej Dach	32b3d3d7df	Compile regexes for speed	2024-07-03 15:49:21 +02:00
Bartłomiej Dach	901fec65ef	Address code quality issues	2024-07-03 15:49:17 +02:00
Arthur Araujo	7143ff523f	Make MarkerChecks and MarkerCheck class private	2024-07-02 21:09:49 -03:00
Arthur Araujo	7cdad20119	Fix explicit array type specification in MarkerChecks	2024-07-02 20:55:52 -03:00
Arthur Araujo	7cb3d7445c	Add verify checks for title markers	2024-07-02 17:20:00 -03:00
Dean Herbert	fd6b77ea92	Fix distance snap control being removed	2024-06-27 23:59:38 +09:00
Dean Herbert	14104e57d4	Merge branch 'master' into timeline-drag-selection-crash	2024-06-20 15:16:10 +09:00
Dean Herbert	0eb533f2fd	Merge pull request #28444 from bdach/scrolling-ruleset-editor-reloads ... Reload scrolling hitobject composer on control point changes	2024-06-20 15:15:26 +09:00
Bartłomiej Dach	4022a8b06c	Implement automatic break period generation	2024-06-19 10:22:06 +02:00
Bartłomiej Dach	7cfe8d8df2	Reduce editor opacity of several editor components when hovering over composer ... Addresses https://github.com/ppy/osu/discussions/24384.	2024-06-17 12:14:28 +02:00
Bartłomiej Dach	bdeea37a44	Commit active placement when starting drag selection via timeline ... This was reported in https://github.com/ppy/osu/pull/28474, albeit the code changes proposed there did not fix the issue at all. See 8b6385f7d0 for demonstration of the crash scenario. Basically what is happening there is: - The starting premise is that there is a spinner placement active. - At this time, a drag selection is started via the timeline. - Once the drag selection finds at least one suitable object to select, it mutates `SelectedItems`. - When selection changes for any reason, the `HitObjectComposer` decides to switch to the "select" tool, regardless of why the selection changed. - Changing the active tool causes the current placement - if any - to be committed, which mutates the beatmap. - Back at the drag box selection code, this causes a "collection modified when enumerating" exception. The proposed fix here is to eagerly commit active placement - if any - when drag selection is initiated via the timeline, which avoids this issue. This also appears to vaguely match stable behaviour and is sort of consistent with the logic of committing any outstanding changes upon switching to the selection tool.	2024-06-14 09:32:40 +02:00
Bartłomiej Dach	922837dd3a	Reload scrolling composer on control point changes	2024-06-11 12:01:35 +02:00
Bartłomiej Dach	14658824e7	Adjust distance snap grid momentary toggle logic to not hide it on spacing adjust	2024-05-02 14:11:44 +02:00
Bartłomiej Dach	70a5288a68	Do not attempt to pass files that don't look like audio to BASS	2024-04-22 10:45:09 +02:00
Bartłomiej Dach	ceeb9b0819	Use explicit reference equality check	2024-04-22 10:27:30 +02:00
Bartłomiej Dach	1bcf835d22	Remove redundant array type specification	2024-04-22 10:25:46 +02:00
Arthur Araujo	49563f4e5b	Use bitwise to check hitsound formats	2024-04-22 04:44:38 -03:00
Arthur Araujo	92b85beff6	Remove ChannelType from messages	2024-04-19 08:01:23 -03:00
Arthur Araujo	68e86b5105	Remove unsued import and add a blankline before yield break;	2024-04-19 07:39:31 -03:00
Arthur Araujo	eac9dededf	Use periods instead of semicolons ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2024-04-19 07:20:59 -03:00
Arthur Araujo	ac03856ebd	Fix test methods names	2024-04-17 08:22:05 -03:00
Arthur Araujo	8d94f8d995	Remove BassFlags.Prescan and free the decodeStream	2024-04-17 08:14:19 -03:00
Arthur Araujo	c32d99250f	Deal with corrupt audio files ... This removes the corrupt file check from CheckTooShortAudioFiles and makes the audio formats checks deal with it instead to avoid redundant messages.	2024-04-16 06:53:55 -03:00
Arthur Araujo	9ef27104ce	Add checks for audio formats	2024-04-16 06:15:21 -03:00
Nguyên Minh Hồ	6f782266b5	Fix inspection	2024-03-30 17:28:57 +07:00
Nguyên Minh Hồ	5d497ba4a8	Simplify TooltipText for EditorRadioButton	2024-03-30 16:04:22 +07:00
Nguyên Minh Hồ	113dbcd10f	Merge branch 'master' into fix-rotate-editor-button-disabled	2024-03-30 13:56:31 +07:00
Bartłomiej Dach	b74f8dba41	Merge branch 'master' into verify-abnormal-difficulty-settings	2024-03-26 11:13:16 +01:00
Bartłomiej Dach	1866b4b6b1	Refactor abstract check to reduce duplication	2024-03-26 11:13:03 +01:00
Arthur Araujo	8a05fecad5	Fix formatting issue	2024-03-23 23:28:55 -03:00
Arthur Araujo	6fbe1a5b8d	Add video resolution check	2024-03-23 19:22:47 -03:00
Arthur Araujo	a4822fd615	Make CheckAbnormalDifficultySettings abstract	2024-03-22 01:37:06 -03:00
Arthur Araujo	b132734f9c	Fix codefactor issues	2024-03-20 18:54:38 -03:00
Arthur Araujo	c605e463a4	Add mania keycount check	2024-03-20 15:52:16 -03:00
Arthur Araujo	4904c49c38	Add abnormal difficulty settings checks	2024-03-20 09:31:58 -03:00
Bartłomiej Dach	2b83e6bc4c	Fix check crash on empty beatmap	2024-03-19 19:17:22 +01:00
Arthur Araujo	5241c999c1	Add different warning to maps with storyboard/video	2024-03-18 16:08:41 -03:00
Arthur Araujo	c23212f4ef	Use GetLastObjectTime to calculate mapped length	2024-03-18 14:02:33 -03:00
Arthur Araujo	915a9682b5	Fix issue type and display percentage left	2024-03-18 13:51:36 -03:00
Arthur Araujo	a3f3dcf853	Inline percentage calculation	2024-03-18 13:27:43 -03:00
Arthur Araujo	f7aff76592	Fix codefactor issues	2024-03-16 23:03:06 -03:00
Arthur Araujo	63816adbc0	Add verify checks to unused audio at the end	2024-03-16 21:20:12 -03:00
Bartłomiej Dach	20c760835a	Fix audio in video check crashing on unexpected failures	2024-03-13 13:55:49 +01:00
Dean Herbert	9a46e738bd	Fix inspections	2024-02-26 15:45:29 +08:00
Dean Herbert	4c744ccb69	Fix "Use current" snap not working ... Regressed with https://github.com/ppy/osu/pull/27249. I was suspicious of this specific operation at the time but didn't test properly.	2024-02-26 14:11:54 +08:00
Andrei Zavatski	c758640311	Reduce allocations in ComposerDistanceSnapProvider	2024-02-19 20:49:56 +03:00
Berkan Diler	6adf0ac01e	Use new LINQ Order() instead of OrderBy() when possible	2024-02-08 18:01:00 +01:00
Nguyên Minh Hồ	94ada87cba	Un-hardcode tooltip from EditorRadioButton and add disabled tooltip for rotation popover	2024-01-25 14:32:48 +07:00
Nguyên Minh Hồ	500bed0121	Split editor toolbox radio button disabling logic from EditorRadioButton, then add disabling logic for rotate popover	2024-01-25 14:24:35 +07:00
Bartłomiej Dach	b7d74fda88	Revert "Keep editor in frame stable mode when possible"	2024-01-14 09:10:39 +01:00