Bartłomiej Dach
31e7d7333b
Merge branch 'master' into fix-fail-sample-playing-after-leaving-dialog
2023-01-22 09:35:37 +01:00
Bartłomiej Dach
06aa3f7798
Rename Stop{SampleAndRemoveFilters -> }()
...
Now that just one method for stopping samples is left, let's just
repurpose st as the general "stop global effects" method rather than
have it there with a hyperspecific name. It also has good symmetry, as
there already was a `Start()` method in the class.
2023-01-22 09:29:22 +01:00
Bartłomiej Dach
9e4e85e3e3
Inline StopSample() into StopSampleAndRemoveFilters()
...
The first method no longer has any callers except for the second one.
2023-01-22 09:26:01 +01:00
Bartłomiej Dach
0edfd24410
Remove unnecessary sample stop in Restart()
...
It is unnecessary, as a successful restart will exit the current player
screen, and `OnExiting()` has another `StopSampleAndRemoveFilters()`
call, which means that in the restart flow the sample was actually
getting stopped twice.
Standard exit flow is fine, it only stopped the sample once.
2023-01-22 09:24:12 +01:00
Bartłomiej Dach
88d58e8476
Merge pull request #22337 from Joehuu/fix-comment-editor-sounds
...
Fix comment editor text boxes not having sound feedback
2023-01-22 09:10:20 +01:00
Bartłomiej Dach
b66279c5d7
Merge pull request #22341 from peppy/screen-scaling-keywords
...
Add search keywords for screen scaling sub-settings
2023-01-22 08:56:14 +01:00
Matheus Filipe dos Santos Reinert
db0b69db6b
Merge branch 'master' into fix-fail-sample-playing-after-leaving-dialog
2023-01-22 02:12:07 -03:00
Dean Herbert
27f1afdae1
Merge pull request #22330 from bdach/segmented-graph-bad-accesses
...
Fix `SegmentedGraph` draw node calculating segment colours in unsafe manner
2023-01-22 13:55:48 +09:00
Dean Herbert
7040743249
Add search keywords for screen scaling sub-settings
2023-01-22 13:47:31 +09:00
Matheus Filipe dos Santos Reinert
5b1a23c697
Replace RemoveFilters call with StopSampleAndRemoveFilters
2023-01-22 01:44:16 -03:00
Matheus Filipe dos Santos Reinert
2e1ba6ef49
Create StopSampleAndRemoveFilters method and change RemoveFilters to private
2023-01-22 01:43:40 -03:00
Matheus Filipe dos Santos Reinert
a746cbc6ed
Fix failSample still playing after player left FailOverlay
2023-01-22 01:14:33 -03:00
Joseph Madamba
da03abc812
Fix comment editor text boxes not having sound feedback
2023-01-21 17:32:42 -08:00
Bartłomiej Dach
718cbf9382
Fix SegmentedGraph draw node calculating segment colours in unsafe manner
...
The `SegmentedGraph`'s draw node would call `getSegmentColour()`
on the drawable, which would query the `DrawColourInfo` and
`tierColours` properties of the drawable. This is a cross-thread access
and as such completely unsafe, as due to being cross-thread it can die
on invalidations or out-of-bounds accesses.
Fix by transferring everything to the draw node first before attempting
to draw. `SegmentedGraph.TierColours` setter already correctly
invalidates the draw node via `graphNeedsUpdate`, so no further
intervention was required there.
Closes #22326 .
2023-01-21 23:19:34 +01:00
Salman Ahmed
292fd345bc
Merge pull request #22302 from ekrctb/fix-infinity-spm
...
Fix spinners potentially displaying incorrect SPM numbers
2023-01-21 16:56:34 +03:00
Salman Ahmed
ce64ba471a
Merge branch 'master' into fix-infinity-spm
2023-01-21 15:42:48 +03:00
Dean Herbert
c2e1c91b58
Merge pull request #22315 from frenzibyte/fix-test-browser-broken
...
Fix test browsers on longer working after framework update
2023-01-21 21:34:08 +09:00
Salman Ahmed
c48af79588
Fix test browsers on longer working after framework update
2023-01-21 14:49:47 +03:00
Dean Herbert
2a9b1ea9fc
Merge pull request #22310 from peppy/fix-threading-tournament-save
...
Fix incorrect async continuation causing tournament client to not enable save button
2023-01-21 15:31:56 +09:00
Dean Herbert
0fb12508f0
Fix incorrect async continuation causing tournament client to not enable save button
2023-01-21 11:28:56 +09:00
Dean Herbert
2075583313
Merge pull request #22303 from peppy/update-framework
...
Update framework
2023-01-21 00:30:59 +09:00
Dean Herbert
154c258248
Fix TournamentGameBase calling AddInternal
2023-01-20 23:53:30 +09:00
Dean Herbert
19450bfe12
Update framework
2023-01-20 23:23:25 +09:00
ekrctb
7e466e1eba
Fix SPM calculation division by zero
2023-01-20 21:00:01 +09:00
Dean Herbert
e86748626a
Merge pull request #22296 from frenzibyte/actually-fix-beatmap-options
2023-01-20 10:21:55 +09:00
Dean Herbert
684d05e9aa
Merge pull request #22297 from frenzibyte/fix-playlists-match-test-failure
2023-01-20 10:19:45 +09:00
Salman Ahmed
8174ef06c3
Fix intermittent failure in playlists match loading test
2023-01-20 01:18:41 +03:00
Salman Ahmed
f0464b0340
Actually fix intermittent failure in beatmap options state test
2023-01-19 22:47:35 +03:00
Dean Herbert
5a1940facf
Merge pull request #22290 from mk56-spn/judgement_fix
...
Fix JudgementCounterDisplay.cs max judgement not hiding upon display mode change
2023-01-19 20:00:44 +09:00
Dean Herbert
2ce32e3209
Refactor update logic to be easier to follow
2023-01-19 19:27:05 +09:00
mk56-spn
b22363ed8c
Fix JudgementCounterDisplay.cs max judgement always showing upon changing display mode
2023-01-19 10:31:02 +01:00
Dean Herbert
c6dfbab702
Merge pull request #22283 from Feodor0090/comment-reply
...
Add ability to leave replies to comments
2023-01-19 16:41:05 +09:00
Dean Herbert
4916a742d5
Immediately focus the textbox when clicking to reply to a comment
2023-01-19 16:08:27 +09:00
Dean Herbert
81e6c3792c
Remove unused method
2023-01-19 16:03:46 +09:00
Dean Herbert
56ce8504ae
Merge branch 'master' into comment-reply
2023-01-19 16:01:47 +09:00
Dean Herbert
07af18b8a7
Remove ReplyCommentEditor into its own class
2023-01-19 16:01:37 +09:00
Dean Herbert
db8084570d
Merge pull request #22285 from bdach/segmented-graph-tint
...
Apply draw colour to segmented graph
2023-01-19 13:36:19 +09:00
Dean Herbert
e58abf7d1a
Merge pull request #22284 from bdach/judgement-counter-broken
...
Fix "show max judgement" setting not applying initially on judgement counter display
2023-01-19 09:09:06 +09:00
Bartłomiej Dach
83c38a8960
Merge pull request #22233 from peppy/osu-ruleset-multi-touch-basic
...
Add basic multi-touch support for osu! ruleset
2023-01-19 00:59:45 +01:00
Bartłomiej Dach
2fba80dfd3
Merge branch 'master' into osu-ruleset-multi-touch-basic
2023-01-19 00:26:57 +01:00
Bartłomiej Dach
593f5f6d56
Merge pull request #22144 from ItsShamed/skin/argon-song-progress-cleaner
...
Add "argon" variant of song progress display
2023-01-19 00:25:39 +01:00
Bartłomiej Dach
a0fe71c706
Use alternative segment colour computation method
2023-01-19 00:08:32 +01:00
Bartłomiej Dach
b62ff8d644
Merge branch 'master' into skin/argon-song-progress-cleaner
2023-01-18 23:52:12 +01:00
Bartłomiej Dach
b8b7442eb8
Make SongProgressInfo.ShowProgress init-only (and remove duplicate init)
2023-01-18 23:35:40 +01:00
Bartłomiej Dach
903c37bf32
Apply draw colour to segmented graph segments
2023-01-18 23:17:57 +01:00
Bartłomiej Dach
e09b768a99
Add test steps demonstrating failure
2023-01-18 23:07:40 +01:00
Bartłomiej Dach
769f8c6190
Fix ShowMaxJudgement callback conflicting with JudgementCounter.Pop{In,Out}
...
Both `JudgementCounterDisplay` (via the `ShowMaxJudgement` callback)
and the `JudgementCounter.Pop{In,Out}` methods were operating on the
alpha of the `JudgementCounter`. This meant that if the counter display
was created with max judgement initially hidden, it would be hidden
by the `ShowMaxJudgement` callback first, but then _unhidden_
by `PopIn()`.
2023-01-18 21:46:28 +01:00
Bartłomiej Dach
7299d227d1
Add failing test case
2023-01-18 21:42:22 +01:00
Bartłomiej Dach
06212bca51
Restructure test scene to demonstrate failure
2023-01-18 21:41:00 +01:00
ansel
7f4d8bdcaa
Add test
2023-01-18 21:27:42 +03:00
