58147 Commits

This Branch

This Branch

All Branches

• Merge pull request #21070 from peppy/standardise-visual-settings-ui-components

  Standardise "Visual Settings" components to fix mismatched paddings and labels

  Dan Balasescu · 2022-11-02 14:53:00 +09:00
  22f662a076
• Fix multiple notifications arriving for imports in edge cases
  Dean Herbert · 2022-11-02 14:47:56 +09:00
  e761c0395d
• Merge pull request #20990 from smoogipoo/socket-client

  Generalise `HubClientConnector` into `SocketClientConnector`

  Dean Herbert · 2022-11-02 14:17:36 +09:00
  4dabb1aa9c
• Merge branch 'standardise-visual-settings-ui-components' into combo-colour-brightness-limit
  Dean Herbert · 2022-11-02 14:02:09 +09:00
  71c507d80c
• Standardise "Visual Settings" components to fix mismatched paddings and labels
  Dean Herbert · 2022-11-02 14:01:57 +09:00
  37300ba9e2
• Localise new label
  Dean Herbert · 2022-11-02 14:01:03 +09:00
  50b6fe4acb
• Add setting to visual settings toolbox
  Dean Herbert · 2022-11-02 13:58:34 +09:00
  61fc3c8cc0
• Merge branch 'standardise-visual-settings-ui-components' into combo-colour-brightness-limit
  Dean Herbert · 2022-11-02 13:58:33 +09:00
  5b8699872f
• Standardise "Visual Settings" components to fix mismatched paddings and labels
  Dean Herbert · 2022-11-02 13:55:56 +09:00
  d8aa06ea92
• Change range to 0-100% and rename to "normalisation"
  Dean Herbert · 2022-11-02 13:47:11 +09:00
  99ba7c29dd
• Add/adjust xmldocs
  Dan Balasescu · 2022-11-02 13:16:34 +09:00
  30800c9252
• Remove toggle and change method of application to blend with original colour
  Dean Herbert · 2022-11-02 13:08:29 +09:00
  2f3c80f884
• Merge branch 'master' into combo-colour-brightness-limit
  Dean Herbert · 2022-11-02 12:09:27 +09:00
  a01602e63c
• Merge branch 'socket-client' into websocket-chat-2
  Dan Balasescu · 2022-11-02 11:49:57 +09:00
  3816152c9d
• Use IDisposable instead
  Dan Balasescu · 2022-11-02 11:49:04 +09:00
  e59c8b7d24
• Rename StartAsync -> ConnectAsync
  Dan Balasescu · 2022-11-02 11:44:16 +09:00
  c9108ce41b
• Rename Socket* -> PersistentEndpoint*
  Dan Balasescu · 2022-11-02 11:43:22 +09:00
  46d1713e28
• Rename var
  Dan Balasescu · 2022-11-02 10:14:40 +09:00
  5448c0209e
• Fix possible threading issues

  Not really sure of the best way to handle this in general. It could be
  argued that this should be a `Component` type and the bindable bound in
  `LoadComplete()`...

  Dan Balasescu · 2022-11-02 10:04:25 +09:00
  8ac2075c61
• Don't make Beatmap in OsuGameBase public

  Signed-off-by: C0D3 M4513R <28912031+C0D3-M4513R@users.noreply.github.com>

  C0D3 M4513R · 2022-11-01 21:19:01 +01:00
  975eed964e
• Add a generic text Element

  Signed-off-by: C0D3 M4513R <28912031+C0D3-M4513R@users.noreply.github.com>

  C0D3 M4513R · 2022-11-01 20:54:52 +01:00
  c231a20cbb
• Initial implementation of a Beatmap Information Skinning Element

  Signed-off-by: C0D3 M4513R <28912031+C0D3-M4513R@users.noreply.github.com>

  C0D3 M4513R · 2022-11-01 20:46:32 +01:00
  905ebc3c1f
• Merge pull request #21051 from peppy/fix-directory-selector-breadcrumb

  Fix breadcrumb display in directory selector overlapping new "show hidden" button

  Bartłomiej Dach · 2022-11-01 15:00:21 +01:00
  2022.1101.0 f1138f51f3
• Merge branch 'master' into fix-directory-selector-breadcrumb
  Dean Herbert · 2022-11-01 22:28:13 +09:00
  9f031b55a1
• Update framework
  Dean Herbert · 2022-11-01 22:28:06 +09:00
  e104242864
• Merge pull request #21049 from peppy/fix-slider-sv-snap

  Fix time snap of sliders not matching when SV is not 1.0x

  Bartłomiej Dach · 2022-11-01 13:57:14 +01:00
  3f48aff09b
• Construct notifications client via IAPIProvider
  Dan Balasescu · 2022-11-01 21:34:34 +09:00
  5b25ef5f2f
• Merge branch 'master' into fix-slider-sv-snap
  Bartłomiej Dach · 2022-11-01 13:19:46 +01:00
  ac554c644d
• Merge pull request #21052 from peppy/fix-control-point-info

  Fix control points not being cloned when running beatmap conversion

  Dan Balasescu · 2022-11-01 21:04:49 +09:00
  5621db8a2e
• Merge pull request #21060 from peppy/rename-target-practice

  Rename mod "Target" to "Target Practice"

  Dan Balasescu · 2022-11-01 20:38:15 +09:00
  e4fb9119b3
• Merge pull request #21059 from peppy/fix-combo-colour-application

  Fix `DrawableHitObject.AccentColour` not being updated if object entry is not attached

  Dan Balasescu · 2022-11-01 20:21:17 +09:00
  3fa529c27a
• Merge pull request #21056 from peppy/fix-argon-explosion-size

  Fix argon hit circle outer gradient getting smaller each state application

  Dan Balasescu · 2022-11-01 20:03:22 +09:00
  947e6d41c0
• Merge pull request #21057 from peppy/fix-accent-colour-change-performance-osu-argon

  Fix large transform retention when adjusting accent colour of hitobject during pause

  Dan Balasescu · 2022-11-01 20:00:48 +09:00
  fcf0ad2b99
• Rename "Target" to "Target Practice"
  Dean Herbert · 2022-11-01 19:47:20 +09:00
  cd8dc9b17b
• Fix DrawableHitObject.AccentColour not being updated if object entry is not attached
  Dean Herbert · 2022-11-01 19:34:53 +09:00
  f014acfc8d
• Fix large transform retention when adjusting accent colour of hitobject during pause
  Dean Herbert · 2022-11-01 19:12:59 +09:00
  ff60eebe21
• Fix argon hit circle outer gradient getting smaller each state application
  Dean Herbert · 2022-11-01 18:31:30 +09:00
  c179f0bb52
• Merge pull request #21054 from smoogipoo/adjust-mod-multipliers

  Adjust target and hold off mod multipliers

  Dean Herbert · 2022-11-01 18:12:56 +09:00
  ddb3d8326e
• Adjust target and hold off mod multipliers
  Dan Balasescu · 2022-11-01 17:57:20 +09:00
  37407293aa
• Merge branch 'master' into combo-colour-brightness-limit
  Dean Herbert · 2022-11-01 17:50:26 +09:00
  27af91003b
• Fix control points not being cloned when running beatmap conversion

  Closes #20994.
  
  I haven't considered how this affects performance of difficulty
  calculation or otherwise. Seems like a sane initial fix which we can
  iterate on going forward.
  
  I've tested using the scenario in the linked issue.
  
  I'm not going to add test coverage because
  [BeatmapConversionTest](https://github.com/ppy/osu/blob/master/osu.Game/Tests/Beatmaps/BeatmapConversionTest.cs)
  should correctly cover this scenario once we are serialising control
  points as well.

  Dean Herbert · 2022-11-01 17:42:09 +09:00
  978d15955c
• Merge pull request #21050 from peppy/fix-safe-area-initial-state

  Fix notch toggle not applying correctly after restart

  Dean Herbert · 2022-11-01 17:20:17 +09:00
  17b435db35
• Remove incorrect double multiplication and add missing test coverage
  Dean Herbert · 2022-11-01 17:17:54 +09:00
  29bc653d24
• Fix breadcrumb display in directory selector overlapping new "show hidden" button

  Closes #21034.

  Dean Herbert · 2022-11-01 17:07:59 +09:00
  d15585153d
• Fix notch toggle not applying correctly after restart
  Dean Herbert · 2022-11-01 16:31:09 +09:00
  8280605e92
• Add failing test covering snap calculations with SV applied
  Dean Herbert · 2022-11-01 16:22:48 +09:00
  d807d9d822
• Add test coverage of new parameter
  Dean Herbert · 2022-11-01 15:13:05 +09:00
  e8b7914295
• Fix time snap of sliders not matching when SV is not 1.0x

  This regressed with https://github.com/ppy/osu/pull/20850 because the
  function was used in other places which expect it to factor slider
  velocity into the equation.
  
  Rather than reverting, I've added a new argument, as based on the method
  naming alone it was hard to discern whether SV should actually be
  considered.
  
  The reason for the change in #20850 was to avoid the SV coming in from a
  reference object which may not have a correct SV in the first place. In
  such cases, passing `false` to the function will give the expected
  behaviour.

  Dean Herbert · 2022-11-01 15:12:58 +09:00
  2a88409dfe
• Merge pull request #21045 from peppy/improve-ruleset-load-fail-message

  Improve messaging when ruleset load fails

  Dan Balasescu · 2022-11-01 14:36:40 +09:00
  00bd77ce76
• Improve messaging when ruleset load fails
  Dean Herbert · 2022-11-01 13:57:34 +09:00
  706adfb28c