Dan Balasescu
808818768b
Add TotalScore to replay frame headers
2023-05-18 20:08:49 +09:00
Dan Balasescu
f3591f83a2
Remove ScoreManager.GetTotalScore()
2023-05-18 20:08:49 +09:00
Dan Balasescu
510b8e4c78
Remove ScoreManager.Mode, handle per-use
2023-05-18 20:08:49 +09:00
Dan Balasescu
829e47d30b
Add MaxTotalScore for performance breakdown calculator
2023-05-18 17:47:25 +09:00
Dan Balasescu
f2483a1cf8
Add some helper methods, fix precision differences
...
Introduces some error at all times, but if we're to store scores everywhere as
`long`, then the same precision should be applied to the "during
gameplay" path as well.
2023-05-18 17:44:31 +09:00
Dean Herbert
ee522253cb
Remove a couple of unnecessary volume declarations
2023-05-18 14:12:57 +09:00
Joseph Madamba
caa79704ac
Add test coverage for failing case
2023-05-17 20:23:37 -07:00
Bartłomiej Dach
9ca1c7f7b7
Merge pull request #23580 from peppy/fix-profile-button-depth
...
Ensure scroll-to-top button is displayed above all overlay content
2023-05-17 21:23:46 +02:00
Bartłomiej Dach
fb441b864e
Merge pull request #23576 from peppy/fix-random-button-right-click
...
Fix random button hover state sticking when rewinding using right mouse button
2023-05-17 21:02:39 +02:00
Dimmitsaras
7ac6688a0f
Chat message notifications always play on unfocused window
2023-05-17 18:34:39 +03:00
Dean Herbert
b58ab28765
Make EditorClock non-nullable in PlacementBlueprint
2023-05-17 21:40:52 +09:00
Dean Herbert
214d7e07fa
Add TODO regarding failing stack display code
2023-05-17 17:52:17 +09:00
Dean Herbert
0b25818bd2
Update combo information on placement blueprint
2023-05-17 17:26:19 +09:00
Dean Herbert
9563d4f730
Fix weird purple tint on placement object in timeline
2023-05-17 17:26:19 +09:00
Dean Herbert
8d925c8a8a
Move combo information updating to an interface level helper method
2023-05-17 17:26:19 +09:00
Dean Herbert
e43f2c2c43
Improve previous hitobject lookup efficient and correctness
2023-05-17 17:19:29 +09:00
Dean Herbert
7d7d402d4e
Apply NRT to PlacementBlueprint
2023-05-17 17:19:29 +09:00
Dean Herbert
87ff28b022
Update beat divisor control to show ticks in more visually correct locations
...
As proposed in https://github.com/ppy/osu/discussions/23527 .
2023-05-17 16:34:12 +09:00
Dean Herbert
ec2b9165d5
Adjust BeatDivisorControl test to show control mmuch larger
2023-05-17 16:33:58 +09:00
Dean Herbert
730bc3a961
Apply NRT and simplify some remaining code
2023-05-17 16:18:13 +09:00
Dean Herbert
e97d027230
Make OnlinePlayPill class abstract
2023-05-17 16:13:03 +09:00
Dean Herbert
79e1d978e7
Ensure scroll-to-top button is displayed above all overlay content
2023-05-17 15:42:38 +09:00
Dean Herbert
3054348c73
Add text hints to accuracy heat map to better describe travel direction
2023-05-17 15:22:48 +09:00
Dean Herbert
9fe787acd8
Enable NRT on AccuracyHeatmap
2023-05-17 15:03:59 +09:00
Dean Herbert
764f0323f4
Show "rewind" text on random button when beginning a right mouse press
2023-05-17 14:51:40 +09:00
Dean Herbert
94b184712d
Fix random button hover state not correctly being reset on right click
2023-05-17 14:51:40 +09:00
Dean Herbert
dc421bd2af
Revert "Merge pull request #23570 from huoyaoyuan/inspect-code-cs11"
...
This reverts commit ab2bd123e7267e63320f
2023-05-17 14:49:47 +09:00
Dean Herbert
510ebe1f23
Fix weird optional usage in HitSampleInfo.With
2023-05-17 14:11:52 +09:00
Dean Herbert
dc51d5ecf3
Rename GetSampleInfo to better describe what method does
...
Also add full xmldoc
2023-05-17 14:07:48 +09:00
Dean Herbert
a8bc337006
Change default volume when constructing a HitSampleInfo to non-zero
2023-05-17 14:06:02 +09:00
Susko3
fec47fa690
Merge branch 'master' into use-atomic-ReplaceRange
...
This reverts 0dcf1b540e
2023-05-17 06:56:54 +02:00
Joseph Madamba
d6fa44240d
Fix storyboard video-only check being inverted
2023-05-16 21:51:32 -07:00
Dean Herbert
0d3c64dc32
Merge pull request #23572 from bdach/avoid-display-settings-feedback
...
Work around issues with bindable/event feedback in layout settings
2023-05-17 12:03:45 +09:00
Dean Herbert
ab2bd123e7
Merge pull request #23570 from huoyaoyuan/inspect-code-cs11
...
Update InspectCode to 2022.3.3 and enable C# 11
2023-05-17 11:37:57 +09:00
Bartłomiej Dach
c97b7a077e
Use better issue reference
2023-05-16 23:47:47 +02:00
Bartłomiej Dach
70426a5042
Add reference to youtrack issue to suppression
2023-05-16 22:42:25 +02:00
Susko3
2d7fe68311
Prevent feedback by using atomic .ReplaceRange()
...
`display.NewValue` will never be null, checked on SDL + osuTK/Android.
On Android it's a 0x0 display, importantly not null.
2023-05-16 21:57:31 +02:00
Bartłomiej Dach
0dcf1b540e
Attempt to preserve old resolution when switching displays
2023-05-16 21:14:09 +02:00
Bartłomiej Dach
88ce627c8e
Avoid bindable/event feedback when changing resolution
2023-05-16 21:02:23 +02:00
Huo Yaoyuan
84de463e2e
Turn off inspection of MSBuild unknown property
2023-05-17 00:13:08 +08:00
Huo Yaoyuan
ddfdd712bd
Update InspectCode to 2022.3.3 and enable C# 11
2023-05-17 00:07:06 +08:00
Dean Herbert
ebce39cd1c
Add test coverage of failing sample bank transfer
2023-05-16 18:52:52 +09:00
Dean Herbert
8528fcaedc
Rename editor sample adjustment test scene to increase scope of tests
2023-05-16 18:52:52 +09:00
Dean Herbert
31fff72eb6
Fix bank not correctly being assigned to some taiko hit cases
2023-05-16 18:52:52 +09:00
Dean Herbert
d9ae822966
Fix bank not correctly being assigned when adding sample additions in editor
2023-05-16 18:52:52 +09:00
Dean Herbert
83dcd78826
Make HitSampleInfo.Bank non-nullable
2023-05-16 18:12:56 +09:00
timiimit
cc6e4df93e
Remove wrongly added back namepspace
2023-05-16 10:27:46 +02:00
timiimit
4ef74eb3f9
Fix RoomStatusPill text colour
2023-05-16 10:22:52 +02:00
timiimit
81b7737660
Fix text colour of RoomSpecialCategoryPill
2023-05-16 10:20:16 +02:00
timiimit
a9991d9dd4
Remove another unused namespace
2023-05-16 10:14:14 +02:00
