69412 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Dean Herbert	24d6ea5444	Change failed states to be considered as NotPlaying	2024-10-03 17:11:41 +09:00
Dean Herbert	ecf144f4a5	Add failing test of importing failed replay in OsuGame flow ... We had a test covering this but it wasn't within `OsuGame` so didn't have full import blocking coverage (see cbbe2f9dc0/osu.Game.Tests/Visual/Gameplay/TestScenePlayerLocalScoreImport.cs (L89-L88)).	2024-10-03 17:11:25 +09:00
Dean Herbert	8773c34fdd	Rename enum to non-plural now that it won't conflict	2024-10-01 19:55:46 +09:00
Dean Herbert	8dba4cf760	Passing means NotPlaying	2024-10-01 19:55:31 +09:00
Dean Herbert	7977ce8a0e	Attempt to fix android class	2024-10-01 18:25:45 +09:00
Dean Herbert	8f0fedbd22	Fix local scores never importing due to new conditionals	2024-10-01 18:21:15 +09:00
Dean Herbert	4b1c2c09ee	Avoid updates and update notifications appearing in more gameplay cases	2024-10-01 17:53:59 +09:00
Dean Herbert	3d54f4a5ab	Make states better defined	2024-10-01 17:53:58 +09:00
Dean Herbert	ad3007eaad	Adjust ILocalUserPlayInfo to expose whether gameplay is in a paused/break state	2024-10-01 17:53:46 +09:00
Bartłomiej Dach	a9818854f4	Merge pull request #30024 from peppy/edit-url-decode ... Fix editor timestamp URLs not working when they contain a space	2024-10-01 09:44:18 +02:00
Dean Herbert	87ab953935	Merge pull request #30062 from bdach/distance-snap-weirdness ... Fix various distance snap grid weirdness around unsnapped objects	2024-10-01 16:16:22 +09:00
Dean Herbert	0bff7e8697	Merge pull request #30063 from bdach/snap-sliders-on-path-type-change ... Ensure sliders are snapped when changing path types	2024-10-01 16:03:12 +09:00
Bartłomiej Dach	493dcc7a1c	Fix test being dodgy ... Hitobjects are in an indeterminate state until defaults are applied. Adding the object to the beatmap will do this.	2024-09-30 14:38:21 +02:00
Bartłomiej Dach	48b03a328b	Ensure sliders are snapped when changing path types ... Closes https://github.com/ppy/osu/issues/29915. Uses behaviour suggested in https://github.com/ppy/osu/issues/29915#issuecomment-2361843011.	2024-09-30 14:38:20 +02:00
Bartłomiej Dach	11fc1f9a1c	Fix distance snap grid using wrong colour when reference object is unsnapped	2024-09-30 13:36:51 +02:00
Bartłomiej Dach	75fc57c34b	Fix distance spacing grid displaying incorrectly for unsnapped objects with duration	2024-09-30 13:36:16 +02:00
Bartłomiej Dach	4723efaf41	Add failing test coverage for incorrect distance snapping	2024-09-30 13:36:05 +02:00
Dean Herbert	7d756d0de2	Merge pull request #30056 from bdach/speed-change-hotkeys-lose-pitch ... Fix rate change hotkeys sometimes losing track of adjust pitch setting	2024-09-30 16:38:42 +09:00
Bartłomiej Dach	5e5bb49cd8	Fix rate change hotkeys sometimes losing track of adjust pitch setting ... Fixes https://osu.ppy.sh/community/forums/topics/1983327. The cause of the bug is a bit convoluted, and stems from the fact that the mod select overlay controls all of the game-global mod instances if present. `ModSpeedHotkeyHandler` would store the last spotted instance of a rate adjust mod - which in this case is a problem, because on deselection of a mod, the mod select overlay resets its settings to defaults: a258059d43/osu.Game/Overlays/Mods/ModSelectOverlay.cs (L424-L425) A way to defend against this is a clone, but this reveals another issue, in that the existing code was *relying* on the reference to the mod remaining the same in any other case, to read the latest valid settings of the mod. This basically only mattered in the edge case wherein Double Time would swap places with Half Time and vice versa (think [0.95,1.05] range). Therefore, track mod settings too explicitly to ensure that the stored clone is as up-to-date as possible.	2024-09-30 08:47:02 +02:00
Bartłomiej Dach	23b8354af4	Add more test steps demonstrating another failure case	2024-09-30 08:46:45 +02:00
Bartłomiej Dach	3fac9baa9f	Add test steps demonstrating failure case	2024-09-30 08:46:33 +02:00
Dean Herbert	a258059d43	Merge pull request #29918 from bdach/control-drag ... Add to existing selection when dragging with control pressed	2024-09-30 14:00:36 +09:00
Dean Herbert	71a5cd182a	Merge pull request #30040 from EVAST9919/file-popover-border ... Fix text in `FormFileSelector` bleeding through the border	2024-09-30 11:07:39 +09:00
Andrei Zavatski	f473f4398c	Fix text in FormFileSelector bleeding through the border	2024-09-28 22:37:16 +03:00
Dean Herbert	c46d787f1e	Merge pull request #29949 from minetoblend/feature/scale-around-center ... Support scaling around center when scaling with select box	2024-09-28 21:37:39 +09:00
Dean Herbert	9647a1be7d	Ensure editor timestamp args are URL decoded	2024-09-27 20:08:38 +09:00
Dean Herbert	f6c5f975ee	Add failing test showing url decoding is not being performed	2024-09-27 20:08:26 +09:00
Bartłomiej Dach	c1e51e05df	Merge pull request #29704 from Fabep/ModCustomisationHeaderColor ... Mod customisation header color	2024-09-27 12:40:35 +02:00
Bartłomiej Dach	d607331755	Fix control-drag selection expansion deselecting object if control is released over one of the blueprints	2024-09-27 12:15:08 +02:00
Bartłomiej Dach	eb725ec1fb	Nudge test coverage to also cover discovered fail case	2024-09-27 12:13:11 +02:00
Bartłomiej Dach	b45fedc356	Merge branch 'master' into control-drag	2024-09-27 11:39:50 +02:00
Dean Herbert	a358731af5	Merge pull request #29913 from Joehuu/fix-romanised-searching ... Fix searching by clicking title/artist in beatmap overlay not following original language setting	2024-09-27 18:39:33 +09:00
Dean Herbert	e7c4451206	Reduce brightness of hover effect	2024-09-27 18:20:16 +09:00
Dean Herbert	64c1ced80d	Merge branch 'master' into ModCustomisationHeaderColor	2024-09-27 18:15:30 +09:00
Dean Herbert	d9de2ad97b	Merge pull request #29899 from bdach/mania-selection-dropped ... Ensure selection is preserved when moving selection between columns	2024-09-27 18:11:23 +09:00
Bartłomiej Dach	a00ed8dd77	Merge pull request #29914 from peppy/fix-judgement-counter-sync ... Fix judgement counter not showing correct counts when spectating user mid-play	2024-09-27 10:57:26 +02:00
Bartłomiej Dach	33593280d8	Merge pull request #29938 from OliBomby/selection-center ... Use minimum enclosing circle as selection centre for scale and rotate	2024-09-27 10:46:32 +02:00
Dean Herbert	371cee1617	Consume framework change to avoid weird unbind flow	2024-09-27 17:41:55 +09:00
Dean Herbert	92ee86e3dd	Update framework	2024-09-27 17:40:06 +09:00
Dean Herbert	048e3c2505	Merge branch 'master' into fix-romanised-searching	2024-09-27 17:40:03 +09:00
Bartłomiej Dach	766d2d2ad2	Merge pull request #29950 from minetoblend/feature/freeze-select-box-buttons ... Freeze select box buttons position on press	2024-09-27 10:13:06 +02:00
Dan Balasescu	eb8cc7fbb2	Merge pull request #30019 from smoogipoo/fix-ios-ci-build ... Fix iOS CI build	2024-09-27 16:58:47 +09:00
Dan Balasescu	73a9b03401	Merge pull request #30018 from peppy/add-missing-shader-preload ... Update shader preloader with missing shader usages	2024-09-27 16:58:15 +09:00
Dean Herbert	1dd6082aa9	Rename method to be more appropriate	2024-09-27 16:56:22 +09:00
Dean Herbert	9a39b80a4d	Merge pull request #29970 from bdach/volume-aware-sample-equality-pitfall ... Fix argon volume-aware hitsounds not correctly playing immediately after object placement	2024-09-27 16:38:35 +09:00
Dean Herbert	19a96bcc50	Merge pull request #29967 from bdach/storyboard-full-dim ... Continue displaying storyboard even if fully dimmed in specific circumstances	2024-09-27 16:33:58 +09:00
Bartłomiej Dach	fa90b43233	Merge branch 'master' into selection-center	2024-09-27 09:30:36 +02:00
Dan Balasescu	cb51e12d13	Fix iOS CI build	2024-09-27 16:26:11 +09:00
Bartłomiej Dach	21796900e2	Fix code quality naming issue	2024-09-27 09:26:08 +02:00
Dean Herbert	5be63ee304	Reorganise with ruleset shader separated out	2024-09-27 16:19:24 +09:00