Bartłomiej Dach
6a9c30c47a
Fix some more wrong icon colours
2022-08-06 18:34:00 +02:00
Bartłomiej Dach
2ba127b6fc
Fix wrong icon for approval event
2022-08-06 18:30:49 +02:00
Bartłomiej Dach
f1e0dd2da3
Match approval type-dependent icon appearance with web
2022-08-06 18:29:24 +02:00
Bartłomiej Dach
f3ecd73e0b
Add references to web source in recent activity icon
2022-08-06 18:23:15 +02:00
LukynkaCZE
3000d9b9c6
Inline everything in RecentActivityIcon
2022-08-06 07:16:34 +02:00
LukynkaCZE
bd27995c71
Merge branch 'ppy:master' into add-missing-icons-to-recent-profile-section
2022-08-06 05:55:51 +02:00
Dean Herbert
6823282604
Fix PlayButton potentially not disposing an unused PreviewTrack during load
2022-08-05 14:15:27 +09:00
Bartłomiej Dach
ca1b4689cb
Automatically focus name textbox upon add preset popover open
2022-08-03 21:26:35 +02:00
Bartłomiej Dach
159d3b032c
Rename locals for legibility
2022-08-03 21:23:31 +02:00
Bartłomiej Dach
82d3fbd51b
Split AddPresetPopover to separate file
2022-08-03 21:22:55 +02:00
Bartłomiej Dach
add2971eb4
Implement preset creation flow with test coverage
2022-08-02 22:05:54 +02:00
Bartłomiej Dach
7251389e43
Add localisations for add preset button
2022-08-02 22:05:34 +02:00
Bartłomiej Dach
059a465fe8
Add border to popover for better visual contrast
2022-08-02 22:03:33 +02:00
Bartłomiej Dach
1b3074d098
Implement popover for creating mod presets
2022-08-02 22:03:33 +02:00
Bartłomiej Dach
085080576a
Add button for creating new mod presets
2022-08-02 22:03:32 +02:00
Dean Herbert
34ffc51c51
Avoid clearing chat overlay textbox when pressing "back" key binding
...
Generally this is expected behaviour for usages of focused text boxes
(ie. to clear search content), but not so much here.
Addresses https://github.com/ppy/osu/discussions/19403#discussioncomment-3230395 .
2022-08-02 13:56:03 +09:00
notmyname
6686b09549
Hide F rank from beatmap overlay
2022-08-01 18:54:00 +02:00
Salman Ahmed
2a127c6ef8
Merge branch 'master' into fix-tags-overflow
2022-08-01 12:40:43 +03:00
Gutyina Gergő
c65747d1b8
Use masking instead of scrollable container to prevent tags overflow
2022-08-01 10:36:53 +02:00
Dean Herbert
2f60f91a0e
Fix editor potentially using a track post-disposal
...
This changes the editor to track the current track as it is *loaded* by
`MusicController`, rather than haphazardly following the current global
`WorkingBeatmap` (with a potentially unloaded track) or relying on local
immediate-load behaviour (as implemented in `ResourcesSection`).
2022-08-01 16:53:49 +09:00
Bartłomiej Dach
85f77abee1
Fix code quality inspection about ambiguous equality
2022-07-31 23:53:46 +02:00
Bartłomiej Dach
345f103119
Migrate mod preset column to use realm
2022-07-31 23:53:45 +02:00
Gutyina Gergő
98214beb6c
Prevent overflow on beatmap info using scrollable container
2022-07-31 21:24:41 +02:00
Dan Balasescu
aa03df905f
Merge pull request #19441 from peppy/test-working-beatmap-unfuck
...
Reduce calls to `LoadTrack` by implicitly running on test/dummy classes
2022-07-28 22:05:25 +09:00
Dean Herbert
a21aee4e9c
Reduce calls to LoadTrack by implicitly running on test/dummy classes
2022-07-28 18:11:40 +09:00
Dean Herbert
ca68574473
Make NotificationOverlay dependency optional in CollectionSettings
2022-07-28 14:35:27 +09:00
Dean Herbert
ad482b8afc
Tidy up naming of collection dropdowns
2022-07-28 13:57:21 +09:00
Dean Herbert
438067a18b
Convert realm data propagation to more correctly use Live<T>
...
wip
2022-07-27 19:35:09 +09:00
Dean Herbert
41393616d8
Replace BeatmapCollection with RealmBeatmapCollection
2022-07-27 19:35:09 +09:00
Dean Herbert
9c543fef48
Remove CollectionManager
2022-07-27 18:45:33 +09:00
Dean Herbert
c30e8047ab
Merge pull request #19375 from novialriptide/contextmenu-external-beatmap
...
Add ContextMenu to beatmap external link
2022-07-26 19:06:10 +09:00
Dean Herbert
1539fa704b
Always allow selecting the top-most button using the select binding
2022-07-26 17:46:23 +09:00
Andrew Hong
003aec86ae
Rearrange sizeaxes
2022-07-26 04:27:22 -04:00
Dean Herbert
ee0c67e114
Add ability to make cursor show even during touch input
...
I completely disagree with this from a UX perspective, but it's come up
so often that I figure we should just let users bone themselves.
2022-07-26 14:08:00 +09:00
Andrew Hong
a8e315abf0
Refactor
2022-07-25 17:16:33 -04:00
LukynkaCZE
a7c92fe5d6
Merge branch 'ppy:master' into add-missing-icons-to-recent-profile-section
2022-07-25 14:56:00 +02:00
Andrew Hong
fcf767e28b
Add contextmenu to beatmap external link
2022-07-25 04:07:33 -04:00
Salman Ahmed
4d90e6bbac
Flip method to read better
2022-07-25 10:03:06 +03:00
Salman Ahmed
e402e919ab
Display placeholder for user profile scores
2022-07-25 09:40:20 +03:00
Salman Ahmed
f54cee0270
Display placeholder for leaderboard top scores
2022-07-25 09:18:04 +03:00
Salman Ahmed
91d1c9686c
Separate unprocessed PP placeholder to own class
2022-07-25 09:07:51 +03:00
Salman Ahmed
54eb2b98a9
Display exclamation triangle on scores with unprocessed PP
2022-07-25 07:30:57 +03:00
Salman Ahmed
3beb1da3de
Merge branch 'master' into beatmap-overlay-null-pp
2022-07-25 07:18:03 +03:00
Bartłomiej Dach
446485f804
Move localisation string to common location
2022-07-24 23:30:52 +02:00
Bartłomiej Dach
8af9cfbe40
Add readonly modifier
2022-07-24 23:29:18 +02:00
Bartłomiej Dach
6a67d76d7c
Add basic mod preset column implementation
2022-07-24 16:39:04 +02:00
Bartłomiej Dach
b2f8934117
Extract base mod select column presentation logic
2022-07-24 16:39:03 +02:00
Salman Ahmed
7c477e6f22
Fix beatmap overlay leaderboard not handling null PP scores properly
2022-07-24 04:20:49 +03:00
LukynkaCZE
1aa0d49d81
Code Quality
2022-07-23 12:27:24 +02:00
LukynkaCZE
9db06fafd0
Fix code formatting
2022-07-23 12:16:11 +02:00
LukynkaCZE
33b442d5d0
Add missing icons to UserProfileRecentSection
2022-07-23 12:06:30 +02:00
Salman Ahmed
2829a7e836
Merge branch 'master' into beatmap-overlay-modded-stats
2022-07-23 10:38:13 +03:00
Salman Ahmed
661c79baf6
Add explanatory comment
2022-07-23 10:16:11 +03:00
Adam Baker
06462c13dd
Overwrite IBindable<ReadOnlyList<Mod>> cache in BeatmapSetOverlay
...
Implement fix as suggested
2022-07-22 23:15:24 -05:00
Adam Baker
d451bc8fda
Revert commits
...
This reverts commit 28586c704dd9d35bb847
2022-07-22 22:25:49 -05:00
Bartłomiej Dach
f3ceabc53f
Rename ModSelect{Overlay -> }Panel
2022-07-22 19:17:22 +02:00
Adam Baker
d9d35bb847
Set BeatmapSetHeaderContent details to not show modded values
2022-07-22 05:43:56 -05:00
Bartłomiej Dach
a3090003de
Add tooltip showing contents of mod preset
2022-07-21 23:29:21 +02:00
Bartłomiej Dach
bdff7f1ef4
Implement basic appearance of mod preset panels
2022-07-21 23:29:21 +02:00
Bartłomiej Dach
6cd18fad99
Fix code inspections after base panel class extraction
2022-07-21 23:29:08 +02:00
Bartłomiej Dach
d796b7d53c
Extract base mod select overlay panel presentation logic
2022-07-21 22:37:00 +02:00
Dan Balasescu
7dfc18a0e3
Merge pull request #19208 from frenzibyte/remove-score-multiplier-on-custom-mod-settings
...
Remove score multiplier on difficulty-increasing mods with customised settings
2022-07-20 20:12:59 +09:00
Dean Herbert
62133fa069
Merge pull request #19246 from frenzibyte/fix-wiki-navigation
...
Fix wiki overlay not handling path redirection properly
2022-07-20 20:08:11 +09:00
Salman Ahmed
5e933cb466
Improve comment wording
...
Co-authored-by: Dean Herbert <pe@ppy.sh>
2022-07-20 09:43:32 +03:00
Salman Ahmed
474c1a8a7a
Fix wiki overlay not handling path redirection properly
2022-07-20 09:06:11 +03:00
Salman Ahmed
6ce6f6f7df
Merge branch 'master' into remove-score-multiplier-on-custom-mod-settings
2022-07-20 08:57:43 +03:00
Salman Ahmed
1270abdf42
Highlight perfect slider tick/end values in beatmap info leaderboards
2022-07-20 00:53:10 +03:00
Salman Ahmed
4210ec6502
Merge branch 'master' into remove-score-multiplier-on-custom-mod-settings
2022-07-19 19:21:26 +03:00
Salman Ahmed
89653b74c7
Only add setting tracker when customisation is permitted
2022-07-19 19:21:16 +03:00
Salman Ahmed
b5c7d07ba8
Merge branch 'master' into fix-user-profile-overlay
2022-07-18 10:27:33 +03:00
Dean Herbert
a7f19cc796
Merge pull request #19137 from frenzibyte/country-enum
...
Replace `Country` class with enumeration
2022-07-18 16:12:24 +09:00
Salman Ahmed
e4d11febc5
Remove no longer necessary fallback
2022-07-18 09:47:40 +03:00
Salman Ahmed
84c1c26a7f
Merge branch 'master' into fix-user-profile-overlay
2022-07-18 09:45:25 +03:00
Salman Ahmed
018da74fe8
Replace default with CountryCode.Unknown
2022-07-18 08:54:35 +03:00
Salman Ahmed
100c53f9ef
Country -> CountryCode
2022-07-18 08:40:34 +03:00
Salman Ahmed
eddae7b143
Fix mod overlay and footer not updating multiplayer on settings change
2022-07-18 07:38:56 +03:00
Salman Ahmed
b33f8aa0fc
Fix "Start Chat" on multiplayer/playlist chat not opening overlay
2022-07-18 06:45:00 +03:00
Salman Ahmed
7e4ce89981
Include mod settings in profile score mod icons
2022-07-18 04:03:18 +03:00
tsunyoku
a5d7075ef1
simplify beatmap metadata logic in DrawableProfileScore
2022-07-17 18:10:47 +01:00
Dean Herbert
4e8bf1da52
Don't sent ruleset configuration failures to sentry
2022-07-18 01:23:46 +09:00
tsunyoku
7a6666996f
rename item to model in CreateDrawableItem
2022-07-17 14:50:53 +01:00
tsunyoku
486fbd2531
create instance of BeatmapInfo for use in ScoreBeatmapMetadataContainer
2022-07-17 14:47:04 +01:00
tsunyoku
7135329c8c
remove `PaginatedProfileScoreSubsectio, revert profile score drawables
2022-07-17 14:22:27 +01:00
tsunyoku
3a8b5d48b9
update PaginatedScoreContainer to use new class and format
2022-07-17 14:09:14 +01:00
tsunyoku
ef4237c4ac
create special subsection class for paginated profile scores
2022-07-17 14:08:31 +01:00
tsunyoku
e8d88e29c6
change DrawableProfileScore and DrawableProfileWeightedScore to take SoloScoreInfo and APIBeatmap instead of APIScore
2022-07-17 14:08:04 +01:00
Salman Ahmed
4968859e69
Rename placeholder display flag property to make sense
2022-07-16 06:07:53 +03:00
Salman Ahmed
e62049f4a9
Update various usages of Country inline with new enum
2022-07-16 05:04:24 +03:00
Salman Ahmed
838e9ec12e
Merge branch 'master' into placeholder-fixes
2022-07-15 20:22:25 +03:00
Dean Herbert
cf38b15332
Merge pull request #19124 from frenzibyte/song-select-metadata-search
...
Change clicking source/tags on song select to filter instead of searching online
2022-07-15 19:16:31 +09:00
Dean Herbert
437e01427c
Fix beatmap listing not entering correct search mode when arriving before LoadComplete
2022-07-15 17:53:44 +09:00
Dan Balasescu
c1dd1cfead
Merge pull request #19082 from peppy/api-solo-score-model
...
Add and consume `SoloScoreInfo`
2022-07-15 15:20:18 +09:00
Salman Ahmed
eafa11555a
Allow specifying custom search action to metadata sections
2022-07-15 06:41:03 +03:00
Dean Herbert
cd085cbd97
Merge pull request #19114 from frenzibyte/fix-potential-dialog-test-failure
...
Fix dialog overlay potentially pushing dialog while not loaded
2022-07-15 12:34:19 +09:00
Salman Ahmed
aea786ea0c
Fix minor typo
2022-07-15 05:56:49 +03:00
Dean Herbert
08396ba486
Adjust colouring to avoid weird banding during transition period
2022-07-14 14:47:25 +09:00
Dean Herbert
5dff48a1e0
Fix button selection animation not playing smoothly when new glyphs are loaded
2022-07-14 14:40:25 +09:00
Dean Herbert
5c6b4e498d
Protect against a potential early call to LanguageButton.Selected
2022-07-14 14:31:59 +09:00
Dean Herbert
227871e8df
Refactor hide logic a touch for better readability
2022-07-14 14:00:33 +09:00
Salman Ahmed
dccd81dbc7
Use BindValueChanged to handle changes between push time and schedule execution
2022-07-14 07:07:32 +03:00
